| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c56bd169-4c65-cce8-de7f-d8b186d25e56 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E6E4:CF959:30DEEB4:4076BFD:6B002526 |
| html-safe-nonce | 233afbaef205617c0fb42c4f86f0b0e9cb5a87ffd77149395ff69347caf0aad9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkU0OkNGOTU5OjMwREVFQjQ6NDA3NkJGRDo2QjAwMjUyNiIsInZpc2l0b3JfaWQiOiI3MzEyNDA1MTQ4NjQ5NjYxNzM0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | dbcb0aede97f0bf2b62e861c52986750907ea895b2a4295f968fc16a297ec65a |
| hovercard-subject-tag | pull_request:145337096 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/4073/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b8bee2ba50493b44d496445f24e641ed439681417f337e3fd0aae0f3eba717f4/python/mypy/pull/4073 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b8bee2ba50493b44d496445f24e641ed439681417f337e3fd0aae0f3eba717f4/python/mypy/pull/4073 |
| og:image:alt | Fixes #4069
This pushes the correct enclosing class while deferring a method instead of just the top class.
A related comment: the name active_class is a bit misleading, it returns None from within... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ilevkivskyi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/4073#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4073 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4073 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/4073 |
| Reload | https://github.com/python/mypy/pull/4073 |
| Reload | https://github.com/python/mypy/pull/4073 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| JukkaL | https://github.com/JukkaL |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:getattr-fix | https://github.com/ilevkivskyi/mypy/tree/getattr-fix |
| Conversation | https://github.com/python/mypy/pull/4073 |
| Commits5 (5) | https://github.com/python/mypy/pull/4073/commits |
| Checks | https://github.com/python/mypy/pull/4073/checks |
| Files changed | https://github.com/python/mypy/pull/4073/files |
| Push correct enclosing class while deferring a method | https://github.com/python/mypy/pull/4073#top |
| JukkaL | https://github.com/JukkaL |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:getattr-fix | https://github.com/ilevkivskyi/mypy/tree/getattr-fix |
|
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Oct 8, 2017 | https://github.com/python/mypy/pull/4073#issue-263721564 |
| #4069 | https://github.com/python/mypy/issues/4069 |
| Please reload this page | https://github.com/python/mypy/pull/4073 |
|
| https://github.com/ilevkivskyi |
| Push correct enclosing class while deferring a method | https://github.com/python/mypy/pull/4073/commits/391a7ae3ecc2493cc43fa75940b817f8d521f0bd |
| 391a7ae | https://github.com/python/mypy/pull/4073/commits/391a7ae3ecc2493cc43fa75940b817f8d521f0bd |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Oct 8, 2017
| https://github.com/python/mypy/pull/4073#ref-issue-263543577 |
|
Class level __getattr__ causes error: __getattr__ is not valid at the module level outside a stub file
#4069
| https://github.com/python/mypy/issues/4069 |
| https://github.com/elazarg |
| elazarg | https://github.com/elazarg |
| Oct 8, 2017 | https://github.com/python/mypy/pull/4073#issuecomment-335013498 |
| Please reload this page | https://github.com/python/mypy/pull/4073 |
| Please reload this page | https://github.com/python/mypy/pull/4073 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Oct 8, 2017 | https://github.com/python/mypy/pull/4073#issuecomment-335014952 |
| Please reload this page | https://github.com/python/mypy/pull/4073 |
|
| https://github.com/ilevkivskyi |
| CR | https://github.com/python/mypy/pull/4073/commits/bce70d54d7632e314522d2230b6f74b10858d5b9 |
| bce70d5 | https://github.com/python/mypy/pull/4073/commits/bce70d54d7632e314522d2230b6f74b10858d5b9 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Oct 9, 2017
| https://github.com/python/mypy/pull/4073#ref-issue-263946380 |
|
Release 0.540 planning
#4084
| https://github.com/python/mypy/issues/4084 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| Oct 11, 2017 | https://github.com/python/mypy/pull/4073#event-1288222104 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| Oct 11, 2017 | https://github.com/python/mypy/pull/4073#issuecomment-335812818 |
| Please reload this page | https://github.com/python/mypy/pull/4073 |
|
| https://github.com/ilevkivskyi |
| Merge branch 'master' into getattr-fix | https://github.com/python/mypy/pull/4073/commits/baa5aad0a32c1d293d875a6c57e6c32d01939e53 |
| baa5aad | https://github.com/python/mypy/pull/4073/commits/baa5aad0a32c1d293d875a6c57e6c32d01939e53 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Oct 11, 2017 | https://github.com/python/mypy/pull/4073#issuecomment-335816635 |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/4073 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| Oct 11, 2017 | https://github.com/python/mypy/pull/4073#issuecomment-335827152 |
| Please reload this page | https://github.com/python/mypy/pull/4073 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Oct 11, 2017 | https://github.com/python/mypy/pull/4073#issuecomment-335863081 |
| Please reload this page | https://github.com/python/mypy/pull/4073 |
| Fix regressoin | https://github.com/python/mypy/pull/4073/commits/1e6302f95bd7171f4f3afb8578d6e32f58539dec |
| 1e6302f | https://github.com/python/mypy/pull/4073/commits/1e6302f95bd7171f4f3afb8578d6e32f58539dec |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Oct 11, 2017 | https://github.com/python/mypy/pull/4073#issuecomment-335879334 |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/4073 |
| Add explanatory assert message | https://github.com/python/mypy/pull/4073/commits/02e495c1f9648905864e6330362a387d368d7f24 |
| 02e495c | https://github.com/python/mypy/pull/4073/commits/02e495c1f9648905864e6330362a387d368d7f24 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Oct 12, 2017
| https://github.com/python/mypy/pull/4073#pullrequestreview-68947769 |
|
View reviewed changes
| https://github.com/python/mypy/pull/4073/files/02e495c1f9648905864e6330362a387d368d7f24 |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/4073#pullrequestreview-68947769 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/4073 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| ed5a057 | https://github.com/python/mypy/commit/ed5a057f03d24b6bea3fcd91dbb2bcfba29c22b6 |
| Oct 12, 2017 | https://github.com/python/mypy/pull/4073#event-1290426931 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F4073 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/4073/files/02e495c1f9648905864e6330362a387d368d7f24 |
| Please reload this page | https://github.com/python/mypy/pull/4073 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/4073 |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/elazarg |
|
| https://github.com/JukkaL |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |