René's URL Explorer Experiment


Title: Refactor test discovery by elazarg · Pull Request #3973 · python/mypy · GitHub

Open Graph Title: Refactor test discovery by elazarg · Pull Request #3973 · python/mypy

X Title: Refactor test discovery by elazarg · Pull Request #3973 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Test discovery logic is duplicated over all the different test suites. This PR refactors this logic to the plugin method collect(), leaving only the choice of configuration in the classes. This ref...

X Description: Test discovery logic is duplicated over all the different test suites. This PR refactors this logic to the plugin method collect(), leaving only the choice of configuration in the classes. This ref...

Opengraph URL: https://github.com/python/mypy/pull/3973

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:aa2d9915-d458-7191-146d-ec864d3476ba
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE438:1F52F6:299912:384D81:6B002519
html-safe-noncee04557de0c2f4973674ef672fd8866d2258023123d2e088126c32750d41b973e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDM4OjFGNTJGNjoyOTk5MTI6Mzg0RDgxOjZCMDAyNTE5IiwidmlzaXRvcl9pZCI6IjM1OTE3MDYyMzAzMDY5MDc0MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdd1fbc1e883070bc9ae374a9a8652ba8594a72decac6af66ebfd3e923b9eca2e
hovercard-subject-tagpull_request:141990147
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/mypy/pull/3973
twitter:imagehttps://opengraph.githubassets.com/7f77d3b739b3f67f6335539d5c9c22d803eb2547ef85cf6d08898f42a966929e/python/mypy/pull/3973
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7f77d3b739b3f67f6335539d5c9c22d803eb2547ef85cf6d08898f42a966929e/python/mypy/pull/3973
og:image:altTest discovery logic is duplicated over all the different test suites. This PR refactors this logic to the plugin method collect(), leaving only the choice of configuration in the classes. This ref...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameelazarg
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/3973#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3973
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3973
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/3973
Reloadhttps://github.com/python/mypy/pull/3973
Reloadhttps://github.com/python/mypy/pull/3973
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
elazarg:refactor-test-discoveryhttps://github.com/elazarg/mypy/tree/refactor-test-discovery
Conversationhttps://github.com/python/mypy/pull/3973
Commits17 (17)https://github.com/python/mypy/pull/3973/commits
Checkshttps://github.com/python/mypy/pull/3973/checks
Files changedhttps://github.com/python/mypy/pull/3973/files
Refactor test discoveryhttps://github.com/python/mypy/pull/3973#top
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
elazarg:refactor-test-discoveryhttps://github.com/elazarg/mypy/tree/refactor-test-discovery
https://github.com/elazarg
elazarghttps://github.com/elazarg
Sep 20, 2017https://github.com/python/mypy/pull/3973#issue-259009693
Please reload this pagehttps://github.com/python/mypy/pull/3973
Please reload this pagehttps://github.com/python/mypy/pull/3973
https://github.com/elazarg
elazarghttps://github.com/elazarg
force-pushedhttps://github.com/python/mypy/compare/d75d7ee6197accca475721f73d79f8f3eb36d5d1..a107d0c69f4385c0984cf52018572475ea74aeef
d75d7eehttps://github.com/python/mypy/commit/d75d7ee6197accca475721f73d79f8f3eb36d5d1
a107d0chttps://github.com/python/mypy/commit/a107d0c69f4385c0984cf52018572475ea74aeef
Compare https://github.com/python/mypy/compare/d75d7ee6197accca475721f73d79f8f3eb36d5d1..a107d0c69f4385c0984cf52018572475ea74aeef
September 20, 2017 09:15https://github.com/python/mypy/pull/3973#event-1257044088
https://github.com/elazarg
elazarghttps://github.com/elazarg
Sep 23, 2017 https://github.com/python/mypy/pull/3973#ref-issue-254174990
Appveyor tests are being flaky #3895 https://github.com/python/mypy/issues/3895
https://github.com/elazarg
elazarghttps://github.com/elazarg
Oct 18, 2017 https://github.com/python/mypy/pull/3973#ref-pullrequest-266353170
Add daemon mode -- highly experimental #4130 https://github.com/python/mypy/pull/4130
https://github.com/elazarg
elazarghttps://github.com/elazarg
force-pushedhttps://github.com/python/mypy/compare/e76f9ef0a20f2eec9b93a463e831e74c41ef5654..5df8a6c4c477578ca2b47f519d70daa8de782281
e76f9efhttps://github.com/python/mypy/commit/e76f9ef0a20f2eec9b93a463e831e74c41ef5654
5df8a6chttps://github.com/python/mypy/commit/5df8a6c4c477578ca2b47f519d70daa8de782281
Compare https://github.com/python/mypy/compare/e76f9ef0a20f2eec9b93a463e831e74c41ef5654..5df8a6c4c477578ca2b47f519d70daa8de782281
October 21, 2017 19:13https://github.com/python/mypy/pull/3973#event-1304276409
https://github.com/elazarg
refactor test discoveryhttps://github.com/python/mypy/pull/3973/commits/34120f68c75ed8c87dab051c744c2c7c9902ec30
34120f6https://github.com/python/mypy/pull/3973/commits/34120f68c75ed8c87dab051c744c2c7c9902ec30
https://github.com/elazarg
elazarghttps://github.com/elazarg
force-pushedhttps://github.com/python/mypy/compare/5df8a6c4c477578ca2b47f519d70daa8de782281..34120f68c75ed8c87dab051c744c2c7c9902ec30
5df8a6chttps://github.com/python/mypy/commit/5df8a6c4c477578ca2b47f519d70daa8de782281
34120f6https://github.com/python/mypy/commit/34120f68c75ed8c87dab051c744c2c7c9902ec30
Compare https://github.com/python/mypy/compare/5df8a6c4c477578ca2b47f519d70daa8de782281..34120f68c75ed8c87dab051c744c2c7c9902ec30
October 21, 2017 20:04https://github.com/python/mypy/pull/3973#event-1304292472
elazarghttps://github.com/elazarg
November 12, 2017 18:21https://github.com/python/mypy/pull/3973#commits-pushed-4a738af
https://github.com/elazarg
Merge branch 'master' into refactor-test-discoveryhttps://github.com/python/mypy/pull/3973/commits/4a738af5108617374f2d5a0b9367e64a0c9abcdb
4a738afhttps://github.com/python/mypy/pull/3973/commits/4a738af5108617374f2d5a0b9367e64a0c9abcdb
https://github.com/elazarg
Merge branch 'master' into refactor-test-discoveryhttps://github.com/python/mypy/pull/3973/commits/900c08799b215e91908a62755fca105f24059f4d
900c087https://github.com/python/mypy/pull/3973/commits/900c08799b215e91908a62755fca105f24059f4d
https://github.com/elazarg
import test_temp_dirhttps://github.com/python/mypy/pull/3973/commits/3d89f93e723b75f216721645031ffbabf175e8a6
3d89f93https://github.com/python/mypy/pull/3973/commits/3d89f93e723b75f216721645031ffbabf175e8a6
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Nov 30, 2017 https://github.com/python/mypy/pull/3973#pullrequestreview-80221954
View reviewed changes https://github.com/python/mypy/pull/3973/files/3d89f93e723b75f216721645031ffbabf175e8a6
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/3973#pullrequestreview-80221954
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
mypy/myunit/__init__.pyhttps://github.com/python/mypy/pull/3973/files/3d89f93e723b75f216721645031ffbabf175e8a6#diff-aab4004bb6b4ea58461f84449b351b5b35e6fed8f984505a5d7138f595f29e4c
JukkaLhttps://github.com/JukkaL
Nov 30, 2017https://github.com/python/mypy/pull/3973#discussion_r154109000
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
mypy/myunit/__init__.pyhttps://github.com/python/mypy/pull/3973/files/3d89f93e723b75f216721645031ffbabf175e8a6#diff-aab4004bb6b4ea58461f84449b351b5b35e6fed8f984505a5d7138f595f29e4c
JukkaLhttps://github.com/JukkaL
Nov 30, 2017https://github.com/python/mypy/pull/3973#discussion_r154109796
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
mypy/test/data.pyhttps://github.com/python/mypy/pull/3973/files/3d89f93e723b75f216721645031ffbabf175e8a6#diff-37a6d75aa7e2778959e27eff15466ac487c02c5026524afc6a62476315199051
JukkaLhttps://github.com/JukkaL
Nov 30, 2017https://github.com/python/mypy/pull/3973#discussion_r154110433
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
mypy/test/data.pyhttps://github.com/python/mypy/pull/3973/files/3d89f93e723b75f216721645031ffbabf175e8a6#diff-37a6d75aa7e2778959e27eff15466ac487c02c5026524afc6a62476315199051
JukkaLhttps://github.com/JukkaL
Nov 30, 2017https://github.com/python/mypy/pull/3973#discussion_r154111065
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
mypy/test/data.pyhttps://github.com/python/mypy/pull/3973/files/3d89f93e723b75f216721645031ffbabf175e8a6#diff-37a6d75aa7e2778959e27eff15466ac487c02c5026524afc6a62476315199051
JukkaLhttps://github.com/JukkaL
Nov 30, 2017https://github.com/python/mypy/pull/3973#discussion_r154111421
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
mypy/test/data.pyhttps://github.com/python/mypy/pull/3973/files/3d89f93e723b75f216721645031ffbabf175e8a6#diff-37a6d75aa7e2778959e27eff15466ac487c02c5026524afc6a62476315199051
JukkaLhttps://github.com/JukkaL
Nov 30, 2017https://github.com/python/mypy/pull/3973#discussion_r154111537
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
mypy/test/data.pyhttps://github.com/python/mypy/pull/3973/files/3d89f93e723b75f216721645031ffbabf175e8a6#diff-37a6d75aa7e2778959e27eff15466ac487c02c5026524afc6a62476315199051
JukkaLhttps://github.com/JukkaL
Nov 30, 2017https://github.com/python/mypy/pull/3973#discussion_r154112417
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
mypy/test/data.pyhttps://github.com/python/mypy/pull/3973/files/3d89f93e723b75f216721645031ffbabf175e8a6#diff-37a6d75aa7e2778959e27eff15466ac487c02c5026524afc6a62476315199051
JukkaLhttps://github.com/JukkaL
Nov 30, 2017https://github.com/python/mypy/pull/3973#discussion_r154114009
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
elazarghttps://github.com/elazarg
Dec 2, 2017https://github.com/python/mypy/pull/3973#discussion_r154503728
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
mypy/test/testpythoneval.pyhttps://github.com/python/mypy/pull/3973/files/3d89f93e723b75f216721645031ffbabf175e8a6#diff-9dd59f20d6574f9d5af7175a749448ba3cb625420b97bbf59513fc4ebbb359e2
JukkaLhttps://github.com/JukkaL
Nov 30, 2017https://github.com/python/mypy/pull/3973#discussion_r154114798
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
elazarghttps://github.com/elazarg
December 1, 2017 15:39https://github.com/python/mypy/pull/3973#commits-pushed-0ce79ab
https://github.com/elazarg
remove python3.3 related checkhttps://github.com/python/mypy/pull/3973/commits/0ce79aba664a5a219004beb8cd95dfc5e24f3769
0ce79abhttps://github.com/python/mypy/pull/3973/commits/0ce79aba664a5a219004beb8cd95dfc5e24f3769
https://github.com/elazarg
rename ProtoTestCase to BaseTestCasehttps://github.com/python/mypy/pull/3973/commits/cdbfe1b5043bc9affbce2119e92210f15a0a3778
cdbfe1bhttps://github.com/python/mypy/pull/3973/commits/cdbfe1b5043bc9affbce2119e92210f15a0a3778
https://github.com/elazarg
cleanup and document myunit classeshttps://github.com/python/mypy/pull/3973/commits/73b56a6f5769ddc7a2d99823a42990a4fc593a20
73b56a6https://github.com/python/mypy/pull/3973/commits/73b56a6f5769ddc7a2d99823a42990a4fc593a20
https://github.com/elazarg
document pytest magichttps://github.com/python/mypy/pull/3973/commits/f255c4b0b867c7fec085a35008d3d57c39eb6e5e
f255c4bhttps://github.com/python/mypy/pull/3973/commits/f255c4b0b867c7fec085a35008d3d57c39eb6e5e
https://github.com/elazarg
Merge remote-tracking branch 'upstream/master' into refactor-test-dis…https://github.com/python/mypy/pull/3973/commits/61d4e7ed976874d8d5a4fa777f29c32f1710350d
61d4e7ehttps://github.com/python/mypy/pull/3973/commits/61d4e7ed976874d8d5a4fa777f29c32f1710350d
https://github.com/elazarg
uniform naming (setup/teardown); document DataDrivenTestCasehttps://github.com/python/mypy/pull/3973/commits/a5c6939dd35230833b87b4f84735379b118e818c
a5c6939https://github.com/python/mypy/pull/3973/commits/a5c6939dd35230833b87b4f84735379b118e818c
https://github.com/elazarg
elazarghttps://github.com/elazarg
Dec 1, 2017https://github.com/python/mypy/pull/3973#issuecomment-348506978
Please reload this pagehttps://github.com/python/mypy/pull/3973
elazarghttps://github.com/elazarg
December 2, 2017 20:29https://github.com/python/mypy/pull/3973#commits-pushed-b5c1067
https://github.com/elazarg
assert is_incremental and has_stable_flagshttps://github.com/python/mypy/pull/3973/commits/b5c1067e4ff46a1498891e79177c111ca16bd12e
b5c1067https://github.com/python/mypy/pull/3973/commits/b5c1067e4ff46a1498891e79177c111ca16bd12e
https://github.com/elazarg
avoid using ClassVarhttps://github.com/python/mypy/pull/3973/commits/9e12fec05539b731f64d067cec1ef62965eb4f44
9e12fechttps://github.com/python/mypy/pull/3973/commits/9e12fec05539b731f64d067cec1ef62965eb4f44
https://github.com/elazarg
add filter method to DataSuite for dmypyhttps://github.com/python/mypy/pull/3973/commits/a8c61ba7859d2903610c63b28537eae86ae98fec
a8c61bahttps://github.com/python/mypy/pull/3973/commits/a8c61ba7859d2903610c63b28537eae86ae98fec
https://github.com/elazarg
elazarghttps://github.com/elazarg
Dec 2, 2017https://github.com/python/mypy/pull/3973#issuecomment-348713282
@JukkaLhttps://github.com/JukkaL
Please reload this pagehttps://github.com/python/mypy/pull/3973
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Dec 12, 2017 https://github.com/python/mypy/pull/3973#pullrequestreview-82848043
View reviewed changes https://github.com/python/mypy/pull/3973/files/a8c61ba7859d2903610c63b28537eae86ae98fec
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/3973#pullrequestreview-82848043
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
mypy/myunit/__init__.pyhttps://github.com/python/mypy/pull/3973/files/a8c61ba7859d2903610c63b28537eae86ae98fec#diff-aab4004bb6b4ea58461f84449b351b5b35e6fed8f984505a5d7138f595f29e4c
JukkaLhttps://github.com/JukkaL
Dec 12, 2017https://github.com/python/mypy/pull/3973#discussion_r156381048
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
mypy/myunit/__init__.pyhttps://github.com/python/mypy/pull/3973/files/a8c61ba7859d2903610c63b28537eae86ae98fec#diff-aab4004bb6b4ea58461f84449b351b5b35e6fed8f984505a5d7138f595f29e4c
JukkaLhttps://github.com/JukkaL
Dec 12, 2017https://github.com/python/mypy/pull/3973#discussion_r156381284
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
mypy/test/data.pyhttps://github.com/python/mypy/pull/3973/files/a8c61ba7859d2903610c63b28537eae86ae98fec#diff-37a6d75aa7e2778959e27eff15466ac487c02c5026524afc6a62476315199051
JukkaLhttps://github.com/JukkaL
Dec 12, 2017https://github.com/python/mypy/pull/3973#discussion_r156382215
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
mypy/test/data.pyhttps://github.com/python/mypy/pull/3973/files/a8c61ba7859d2903610c63b28537eae86ae98fec#diff-37a6d75aa7e2778959e27eff15466ac487c02c5026524afc6a62476315199051
JukkaLhttps://github.com/JukkaL
Dec 12, 2017https://github.com/python/mypy/pull/3973#discussion_r156382768
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
mypy/test/testcheck.pyhttps://github.com/python/mypy/pull/3973/files/a8c61ba7859d2903610c63b28537eae86ae98fec#diff-a1728e8ba6e78bdc975a04007a7765fc56c65959bef3a8ca87b94fbf85370572
JukkaLhttps://github.com/JukkaL
Dec 12, 2017https://github.com/python/mypy/pull/3973#discussion_r156383500
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
mypy/test/testdmypy.pyhttps://github.com/python/mypy/pull/3973/files/a8c61ba7859d2903610c63b28537eae86ae98fec#diff-aa119bb4ab613726ef3360c1dfba13ffd94bf2645431829e2e8b165689c027a5
JukkaLhttps://github.com/JukkaL
Dec 12, 2017https://github.com/python/mypy/pull/3973#discussion_r156384073
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
mypy/test/testdmypy.pyhttps://github.com/python/mypy/pull/3973/files/a8c61ba7859d2903610c63b28537eae86ae98fec#diff-aa119bb4ab613726ef3360c1dfba13ffd94bf2645431829e2e8b165689c027a5
JukkaLhttps://github.com/JukkaL
Dec 12, 2017https://github.com/python/mypy/pull/3973#discussion_r156384155
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3973
elazarghttps://github.com/elazarg
December 12, 2017 16:59https://github.com/python/mypy/pull/3973#commits-pushed-8eb0fed
https://github.com/elazarg
consistent setup/teardown; multiline docstringshttps://github.com/python/mypy/pull/3973/commits/8eb0fede2e2b579a4626a66e333cdbfb7d178579
8eb0fedhttps://github.com/python/mypy/pull/3973/commits/8eb0fede2e2b579a4626a66e333cdbfb7d178579
https://github.com/elazarg
fix switched messageshttps://github.com/python/mypy/pull/3973/commits/c26671bbcfd683632f73d94a5f07bb2fc681af11
c26671bhttps://github.com/python/mypy/pull/3973/commits/c26671bbcfd683632f73d94a5f07bb2fc681af11
elazarghttps://github.com/elazarg
December 12, 2017 17:07https://github.com/python/mypy/pull/3973#commits-pushed-5600859
https://github.com/elazarg
remove annotations from DataSuite subclasseshttps://github.com/python/mypy/pull/3973/commits/5600859d2c2736364c9ba69062df59b1512a47e7
5600859https://github.com/python/mypy/pull/3973/commits/5600859d2c2736364c9ba69062df59b1512a47e7
https://github.com/elazarg
remove missed annotationhttps://github.com/python/mypy/pull/3973/commits/a1d0c183e338253e6c752f0720d268368d214a2f
a1d0c18https://github.com/python/mypy/pull/3973/commits/a1d0c183e338253e6c752f0720d268368d214a2f
https://github.com/elazarg
elazarghttps://github.com/elazarg
Dec 12, 2017https://github.com/python/mypy/pull/3973#issuecomment-351085508
Please reload this pagehttps://github.com/python/mypy/pull/3973
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Dec 12, 2017 https://github.com/python/mypy/pull/3973#pullrequestreview-82904254
View reviewed changes https://github.com/python/mypy/pull/3973/files/a1d0c183e338253e6c752f0720d268368d214a2f
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
dc52e86https://github.com/python/mypy/commit/dc52e8668d287d63409da46f346820726c58ecc5
Dec 12, 2017https://github.com/python/mypy/pull/3973#event-1383976004
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3973
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/3973/files/a1d0c183e338253e6c752f0720d268368d214a2f
Please reload this pagehttps://github.com/python/mypy/pull/3973
Please reload this pagehttps://github.com/python/mypy/pull/3973
https://github.com/elazarg
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.