René's URL Explorer Experiment


Title: Fix type checking decorated method overrides by JukkaL · Pull Request #3918 · python/mypy · GitHub

Open Graph Title: Fix type checking decorated method overrides by JukkaL · Pull Request #3918 · python/mypy

X Title: Fix type checking decorated method overrides by JukkaL · Pull Request #3918 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: The fix turned out to be pretty complicated, as there were a bunch of untested method overriding scenarios which weren't quite right. I fixed any related issues that I encountered, though I'...

X Description: The fix turned out to be pretty complicated, as there were a bunch of untested method overriding scenarios which weren't quite right. I fixed any related issues that I encountered, though I...

Opengraph URL: https://github.com/python/mypy/pull/3918

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a4303c3d-5944-4d4c-1ab2-4df2e6b8379d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id984E:37308E:21DCA85:2C121FA:6AFFE8FE
html-safe-nonce4cf350288445ddc22b1205be771c2f82b4016baa9f2009f2ab5403993b5d8b0e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODRFOjM3MzA4RToyMURDQTg1OjJDMTIxRkE6NkFGRkU4RkUiLCJ2aXNpdG9yX2lkIjoiMjI4MTU2NDUxMDA3MjMzNDU5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7577395ccd57b453459050c6bf3ed71b5dfff648c7ebf41bb0c1c32fda0a535d
hovercard-subject-tagpull_request:139310132
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/3918/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/13ac9052adce807e42d186318f8f6f4220a75fb1cb9af4e7f5f6044be476a1ba/python/mypy/pull/3918
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/13ac9052adce807e42d186318f8f6f4220a75fb1cb9af4e7f5f6044be476a1ba/python/mypy/pull/3918
og:image:altThe fix turned out to be pretty complicated, as there were a bunch of untested method overriding scenarios which weren't quite right. I fixed any related issues that I encountered, though I'...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJukkaL
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/3918#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3918
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3918
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/3918
Reloadhttps://github.com/python/mypy/pull/3918
Reloadhttps://github.com/python/mypy/pull/3918
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
JukkaLhttps://github.com/JukkaL
masterhttps://github.com/python/mypy/tree/master
decorator-overridehttps://github.com/python/mypy/tree/decorator-override
Conversationhttps://github.com/python/mypy/pull/3918
Commits4 (4)https://github.com/python/mypy/pull/3918/commits
Checkshttps://github.com/python/mypy/pull/3918/checks
Files changedhttps://github.com/python/mypy/pull/3918/files
Fix type checking decorated method overrideshttps://github.com/python/mypy/pull/3918#top
JukkaLhttps://github.com/JukkaL
masterhttps://github.com/python/mypy/tree/master
decorator-overridehttps://github.com/python/mypy/tree/decorator-override
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Sep 5, 2017https://github.com/python/mypy/pull/3918#issue-255259137
#1441https://github.com/python/mypy/issues/1441
Please reload this pagehttps://github.com/python/mypy/pull/3918
https://github.com/JukkaL
Fix type checking decorated method overrideshttps://github.com/python/mypy/pull/3918/commits/3c4f624c3d7ba9922e067222e76d421e34dd3f9d
3c4f624https://github.com/python/mypy/pull/3918/commits/3c4f624c3d7ba9922e067222e76d421e34dd3f9d
#1441https://github.com/python/mypy/issues/1441
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Sep 5, 2017https://github.com/python/mypy/pull/3918#issuecomment-327159760
Please reload this pagehttps://github.com/python/mypy/pull/3918
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 5, 2017https://github.com/python/mypy/pull/3918#issuecomment-327211324
Please reload this pagehttps://github.com/python/mypy/pull/3918
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Sep 5, 2017 https://github.com/python/mypy/pull/3918#pullrequestreview-60639755
View reviewed changes https://github.com/python/mypy/pull/3918/files/3c4f624c3d7ba9922e067222e76d421e34dd3f9d
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/3918#pullrequestreview-60639755
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#3263https://github.com/python/mypy/pull/3263
@kirbyfan64https://github.com/kirbyfan64
Please reload this pagehttps://github.com/python/mypy/pull/3918
mypy/checker.pyhttps://github.com/python/mypy/pull/3918/files/3c4f624c3d7ba9922e067222e76d421e34dd3f9d#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
ilevkivskyihttps://github.com/ilevkivskyi
Sep 5, 2017https://github.com/python/mypy/pull/3918#discussion_r137023763
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#3208https://github.com/python/mypy/issues/3208
Please reload this pagehttps://github.com/python/mypy/pull/3918
JukkaLhttps://github.com/JukkaL
Sep 6, 2017https://github.com/python/mypy/pull/3918#discussion_r137241884
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3918
mypy/checker.pyhttps://github.com/python/mypy/pull/3918/files/3c4f624c3d7ba9922e067222e76d421e34dd3f9d#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
ilevkivskyihttps://github.com/ilevkivskyi
Sep 5, 2017https://github.com/python/mypy/pull/3918#discussion_r137024184
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3918
JukkaLhttps://github.com/JukkaL
Sep 6, 2017https://github.com/python/mypy/pull/3918#discussion_r137242026
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3918
gvanrossumhttps://github.com/gvanrossum
Sep 12, 2017https://github.com/python/mypy/pull/3918#discussion_r138396140
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3918
JukkaLhttps://github.com/JukkaL
September 6, 2017 12:10https://github.com/python/mypy/pull/3918#commits-pushed-4e40dfc
https://github.com/JukkaL
Merge branch 'master' into decorator-overridehttps://github.com/python/mypy/pull/3918/commits/4e40dfca003dbc30efb23d15b2aa9d2ddc33b5f9
4e40dfchttps://github.com/python/mypy/pull/3918/commits/4e40dfca003dbc30efb23d15b2aa9d2ddc33b5f9
https://github.com/JukkaL
Fix test casehttps://github.com/python/mypy/pull/3918/commits/b5a749f07001085ad65b79b87b006715f097ecb0
b5a749fhttps://github.com/python/mypy/pull/3918/commits/b5a749f07001085ad65b79b87b006715f097ecb0
https://github.com/JukkaL
Update commenthttps://github.com/python/mypy/pull/3918/commits/d48b6f06e18e6d66720b8157bb79cb4ac63f9374
d48b6f0https://github.com/python/mypy/pull/3918/commits/d48b6f06e18e6d66720b8157bb79cb4ac63f9374
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
September 11, 2017 18:00https://github.com/python/mypy/pull/3918#event-1243810508
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Sep 12, 2017 https://github.com/python/mypy/pull/3918#pullrequestreview-62185059
View reviewed changes https://github.com/python/mypy/pull/3918/files/3c4f624c3d7ba9922e067222e76d421e34dd3f9d
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/mypy/pull/3918#pullrequestreview-62185059
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3918
mypy/checker.pyhttps://github.com/python/mypy/pull/3918/files/3c4f624c3d7ba9922e067222e76d421e34dd3f9d#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
gvanrossumhttps://github.com/gvanrossum
Sep 12, 2017https://github.com/python/mypy/pull/3918#discussion_r138396140
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3918
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
a771113https://github.com/python/mypy/commit/a77111303aef5ee9e56e23aa61b68e20f930c86c
Sep 13, 2017https://github.com/python/mypy/pull/3918#event-1247329452
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Sep 13, 2017https://github.com/python/mypy/pull/3918#issuecomment-329179951
Please reload this pagehttps://github.com/python/mypy/pull/3918
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Sep 24, 2017 https://github.com/python/mypy/pull/3918#ref-issue-160190303
Adding @abstractmethod __init__ to ABC breaks staticmethods #1706 https://github.com/python/mypy/issues/1706
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
September 29, 2017 21:32https://github.com/python/mypy/pull/3918#event-1272418750
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3918
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/3918/files/3c4f624c3d7ba9922e067222e76d421e34dd3f9d
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/mypy/pull/3918/files/3c4f624c3d7ba9922e067222e76d421e34dd3f9d
Please reload this pagehttps://github.com/python/mypy/pull/3918
Decorator on method in derived class https://github.com/python/mypy/issues/1441
Please reload this pagehttps://github.com/python/mypy/pull/3918
https://github.com/JukkaL
https://github.com/ilevkivskyi
https://github.com/gvanrossum
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.