| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fcb4c145-30f4-5795-ef77-2729ca57a52d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DAC4:22E601:144995:1B5718:6B001ED3 |
| html-safe-nonce | a86b1ed337d3eb69c9bc9557813ae000b2a672293b040c6033f28d7eb9c739f4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUM0OjIyRTYwMToxNDQ5OTU6MUI1NzE4OjZCMDAxRUQzIiwidmlzaXRvcl9pZCI6IjI0OTYzNzk4NzIwNjcxOTg2NzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | bab18ef4afa14ba14291246c1ae24c09068cb965c1bf3b0ed833b2b8a0883fcf |
| hovercard-subject-tag | pull_request:136450100 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/3842/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b0fdb233b41fcd9e3209b86a80ba4a8f28e6b6488bb1e35430a0db2b01177d46/python/mypy/pull/3842 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b0fdb233b41fcd9e3209b86a80ba4a8f28e6b6488bb1e35430a0db2b01177d46/python/mypy/pull/3842 |
| og:image:alt | Fix #3365
There are no special checks for improper use (similar to with_metaclass).
Consistency checks are handled like in any other metaclass. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | elazarg |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/3842#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3842 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3842 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/3842 |
| Reload | https://github.com/python/mypy/pull/3842 |
| Reload | https://github.com/python/mypy/pull/3842 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| elazarg:metaclass-getattr | https://github.com/elazarg/mypy/tree/metaclass-getattr |
| Conversation | https://github.com/python/mypy/pull/3842 |
| Commits8 (8) | https://github.com/python/mypy/pull/3842/commits |
| Checks | https://github.com/python/mypy/pull/3842/checks |
| Files changed | https://github.com/python/mypy/pull/3842/files |
| Support six.add_metaclass | https://github.com/python/mypy/pull/3842#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| elazarg:metaclass-getattr | https://github.com/elazarg/mypy/tree/metaclass-getattr |
|
| https://github.com/elazarg |
| elazarg | https://github.com/elazarg |
| Aug 18, 2017 | https://github.com/python/mypy/pull/3842#issue-251206755 |
| #3365 | https://github.com/python/mypy/issues/3365 |
| Please reload this page | https://github.com/python/mypy/pull/3842 |
|
| https://github.com/elazarg |
| support six.add_metaclass | https://github.com/python/mypy/pull/3842/commits/412fe8f80858804cd9125cfa770a660d253c7c62 |
| 412fe8f | https://github.com/python/mypy/pull/3842/commits/412fe8f80858804cd9125cfa770a660d253c7c62 |
| https://github.com/elazarg |
| elazarg | https://github.com/elazarg |
|
Aug 18, 2017
| https://github.com/python/mypy/pull/3842#ref-issue-251111138 |
|
__getattr__ support for metaclass
#3840
| https://github.com/python/mypy/issues/3840 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Aug 18, 2017
| https://github.com/python/mypy/pull/3842#pullrequestreview-57169590 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3842/files/412fe8f80858804cd9125cfa770a660d253c7c62 |
| test-data/unit/check-classes.test | https://github.com/python/mypy/pull/3842/files/412fe8f80858804cd9125cfa770a660d253c7c62#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 18, 2017 | https://github.com/python/mypy/pull/3842#discussion_r133931583 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3842 |
| elazarg | https://github.com/elazarg |
| Aug 18, 2017 | https://github.com/python/mypy/pull/3842#discussion_r133931997 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3842 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 18, 2017 | https://github.com/python/mypy/pull/3842#discussion_r133932982 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3842 |
| elazarg | https://github.com/elazarg |
| August 18, 2017 17:12 | https://github.com/python/mypy/pull/3842#commits-pushed-a799677 |
|
| https://github.com/elazarg |
| duplicate tests for with_metaclass | https://github.com/python/mypy/pull/3842/commits/a799677cde6cfed7f03a515e1458e699281fac38 |
| a799677 | https://github.com/python/mypy/pull/3842/commits/a799677cde6cfed7f03a515e1458e699281fac38 |
|
| https://github.com/elazarg |
| refactor and add checks for multiple definitions | https://github.com/python/mypy/pull/3842/commits/13be183056f53557c174ffa3bbc996ef2475ae7c |
| 13be183 | https://github.com/python/mypy/pull/3842/commits/13be183056f53557c174ffa3bbc996ef2475ae7c |
|
| https://github.com/elazarg |
| make metaclass an Expression | https://github.com/python/mypy/pull/3842/commits/810a48115b373b436c2878a3928d9a6fa2b1ad5e |
| 810a481 | https://github.com/python/mypy/pull/3842/commits/810a48115b373b436c2878a3928d9a6fa2b1ad5e |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Aug 19, 2017
| https://github.com/python/mypy/pull/3842#ref-pullrequest-251452046 |
|
Make ClassDef.metaclass an Expression
#3848
| https://github.com/python/mypy/pull/3848 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 22, 2017 | https://github.com/python/mypy/pull/3842#event-1216477330 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 30, 2017 | https://github.com/python/mypy/pull/3842#issuecomment-326112662 |
| #3848 | https://github.com/python/mypy/pull/3848 |
| Please reload this page | https://github.com/python/mypy/pull/3842 |
|
| https://github.com/elazarg |
| Merge remote-tracking branch 'upstream/master' into metaclass-getattr | https://github.com/python/mypy/pull/3842/commits/ed7171d21935f9bd6ae643b59d71d193da48fc6f |
| ed7171d | https://github.com/python/mypy/pull/3842/commits/ed7171d21935f9bd6ae643b59d71d193da48fc6f |
| https://github.com/elazarg |
| elazarg | https://github.com/elazarg |
| force-pushed | https://github.com/python/mypy/compare/7187423337cc83bfb0fc78a31ec5cc6fb46b22be..85fd3f6f65e96376db823b702386656e70297283 |
| 7187423 | https://github.com/python/mypy/commit/7187423337cc83bfb0fc78a31ec5cc6fb46b22be |
| 85fd3f6 | https://github.com/python/mypy/commit/85fd3f6f65e96376db823b702386656e70297283 |
|
Compare
| https://github.com/python/mypy/compare/7187423337cc83bfb0fc78a31ec5cc6fb46b22be..85fd3f6f65e96376db823b702386656e70297283 |
| August 30, 2017 22:23 | https://github.com/python/mypy/pull/3842#event-1228534344 |
|
| https://github.com/elazarg |
| more tests | https://github.com/python/mypy/pull/3842/commits/4ae1dea3ed0d8d4de153a101a621e6a1518a7f33 |
| 4ae1dea | https://github.com/python/mypy/pull/3842/commits/4ae1dea3ed0d8d4de153a101a621e6a1518a7f33 |
| https://github.com/elazarg |
| elazarg | https://github.com/elazarg |
| force-pushed | https://github.com/python/mypy/compare/85fd3f6f65e96376db823b702386656e70297283..4ae1dea3ed0d8d4de153a101a621e6a1518a7f33 |
| 85fd3f6 | https://github.com/python/mypy/commit/85fd3f6f65e96376db823b702386656e70297283 |
| 4ae1dea | https://github.com/python/mypy/commit/4ae1dea3ed0d8d4de153a101a621e6a1518a7f33 |
|
Compare
| https://github.com/python/mypy/compare/85fd3f6f65e96376db823b702386656e70297283..4ae1dea3ed0d8d4de153a101a621e6a1518a7f33 |
| August 30, 2017 22:27 | https://github.com/python/mypy/pull/3842#event-1228537555 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Aug 30, 2017
| https://github.com/python/mypy/pull/3842#pullrequestreview-59714172 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3842/files/4ae1dea3ed0d8d4de153a101a621e6a1518a7f33 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/3842#pullrequestreview-59714172 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3842 |
| test-data/unit/check-classes.test | https://github.com/python/mypy/pull/3842/files/4ae1dea3ed0d8d4de153a101a621e6a1518a7f33#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 30, 2017 | https://github.com/python/mypy/pull/3842#discussion_r136207273 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3842 |
| elazarg | https://github.com/elazarg |
| Aug 30, 2017 | https://github.com/python/mypy/pull/3842#discussion_r136213855 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3842 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 31, 2017 | https://github.com/python/mypy/pull/3842#discussion_r136259622 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3842 |
| test-data/unit/check-classes.test | https://github.com/python/mypy/pull/3842/files/4ae1dea3ed0d8d4de153a101a621e6a1518a7f33#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 30, 2017 | https://github.com/python/mypy/pull/3842#discussion_r136207678 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3842 |
| elazarg | https://github.com/elazarg |
| August 31, 2017 00:02 | https://github.com/python/mypy/pull/3842#commits-pushed-cbfb40d |
|
| https://github.com/elazarg |
| fix Any test | https://github.com/python/mypy/pull/3842/commits/cbfb40dd6f40819d5d9052547e2a8f931898d539 |
| cbfb40d | https://github.com/python/mypy/pull/3842/commits/cbfb40dd6f40819d5d9052547e2a8f931898d539 |
|
| https://github.com/elazarg |
| fix doc | https://github.com/python/mypy/pull/3842/commits/1d2b32c19bf9b298ca6abc21871189bae4754872 |
| 1d2b32c | https://github.com/python/mypy/pull/3842/commits/1d2b32c19bf9b298ca6abc21871189bae4754872 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Aug 31, 2017
| https://github.com/python/mypy/pull/3842#pullrequestreview-59770911 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3842/files/1d2b32c19bf9b298ca6abc21871189bae4754872 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/3842#pullrequestreview-59770911 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3842 |
| test-data/unit/check-classes.test | https://github.com/python/mypy/pull/3842/files/4ae1dea3ed0d8d4de153a101a621e6a1518a7f33#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Aug 31, 2017 | https://github.com/python/mypy/pull/3842#discussion_r136259622 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3842 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| 3ef1e18 | https://github.com/python/mypy/commit/3ef1e18bfae167ce8489ebe3c563c3af2edff3e7 |
| Aug 31, 2017 | https://github.com/python/mypy/pull/3842#event-1228969333 |
| https://github.com/elazarg |
| elazarg | https://github.com/elazarg |
|
Sep 24, 2017
| https://github.com/python/mypy/pull/3842#ref-issue-164508041 |
|
Binding an abc to TypeVar loses abstract class check
#1830
| https://github.com/python/mypy/issues/1830 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3842 |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
|
| https://github.com/python/mypy/pull/3842/files/1d2b32c19bf9b298ca6abc21871189bae4754872 |
| Please reload this page | https://github.com/python/mypy/pull/3842 |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
| Please reload this page | https://github.com/python/mypy/pull/3842 |
|
| https://github.com/elazarg |
|
| https://github.com/ilevkivskyi |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |