| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c2158db4-6cdb-e7f0-d428-99e57d0b5e33 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C042:1833B7:1972E62:222C32A:6AFFF6F1 |
| html-safe-nonce | 49cc3cb194f4ff495f89da345c2bab3a8732c907b55829218878484b93ce3934 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDQyOjE4MzNCNzoxOTcyRTYyOjIyMkMzMkE6NkFGRkY2RjEiLCJ2aXNpdG9yX2lkIjoiMjI2ODk4NDMyMzIyOTA4NzQ3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4286b28245e87b3a31d079bb1e88f54fd453cf29061670563533038f6d9449d6 |
| hovercard-subject-tag | pull_request:122172680 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/3435/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bd6c6c50e4be5b720047c0afa819f1f9390cb471d493bda6a08641afebf90264/python/mypy/pull/3435 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bd6c6c50e4be5b720047c0afa819f1f9390cb471d493bda6a08641afebf90264/python/mypy/pull/3435 |
| og:image:alt | In semantic analysis, if we find a simple assignment statement where the rvalue
is a module, make the lvalue a direct alias to that same module.
Fixes #1778.
This PR is very much a trial balloon to... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | carljm |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/3435#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3435 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3435 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/3435 |
| Reload | https://github.com/python/mypy/pull/3435 |
| Reload | https://github.com/python/mypy/pull/3435 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests547 (547) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| carljm:module-alias | https://github.com/carljm/mypy/tree/module-alias |
| Conversation | https://github.com/python/mypy/pull/3435 |
| Commits25 (25) | https://github.com/python/mypy/pull/3435/commits |
| Checks | https://github.com/python/mypy/pull/3435/checks |
| Files changed | https://github.com/python/mypy/pull/3435/files |
| Detect and support module aliasing via assignment. | https://github.com/python/mypy/pull/3435#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| carljm:module-alias | https://github.com/carljm/mypy/tree/module-alias |
|
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| May 24, 2017 | https://github.com/python/mypy/pull/3435#issue-230961131 |
| #1778 | https://github.com/python/mypy/issues/1778 |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
|
| https://github.com/carljm |
| Detect and support module aliasing via assignment. | https://github.com/python/mypy/pull/3435/commits/ad646b9266ecd8b58ec7d4b7d05c386a9f6c2d3e |
| ad646b9 | https://github.com/python/mypy/pull/3435/commits/ad646b9266ecd8b58ec7d4b7d05c386a9f6c2d3e |
| python#1778 | https://github.com/python/mypy/issues/1778 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
May 24, 2017
| https://github.com/python/mypy/pull/3435#pullrequestreview-40023018 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3435/files/ad646b9266ecd8b58ec7d4b7d05c386a9f6c2d3e |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/3435#pullrequestreview-40023018 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| May 24, 2017 | https://github.com/python/mypy/pull/3435#issuecomment-303786254 |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
|
| https://github.com/carljm |
| Handle chained assignment and iterable unpacking assignment. | https://github.com/python/mypy/pull/3435/commits/c498e2a8108aa9f6ab11e1860aa53f74419c2f65 |
| c498e2a | https://github.com/python/mypy/pull/3435/commits/c498e2a8108aa9f6ab11e1860aa53f74419c2f65 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| force-pushed | https://github.com/python/mypy/compare/8661ea26515de067e5fab5584cba44a123176bd0..c498e2a8108aa9f6ab11e1860aa53f74419c2f65 |
| 8661ea2 | https://github.com/python/mypy/commit/8661ea26515de067e5fab5584cba44a123176bd0 |
| c498e2a | https://github.com/python/mypy/commit/c498e2a8108aa9f6ab11e1860aa53f74419c2f65 |
|
Compare
| https://github.com/python/mypy/compare/8661ea26515de067e5fab5584cba44a123176bd0..c498e2a8108aa9f6ab11e1860aa53f74419c2f65 |
| May 24, 2017 18:16 | https://github.com/python/mypy/pull/3435#event-1096097958 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
|
May 24, 2017
| https://github.com/python/mypy/pull/3435#ref-issue-231131870 |
|
SymbolTableNode.kind conflates orthogonal characteristics
#3440
| https://github.com/python/mypy/issues/3440 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| May 24, 2017 | https://github.com/python/mypy/pull/3435#issuecomment-303813488 |
| @ilevkivskyi | https://github.com/ilevkivskyi |
| #3440 | https://github.com/python/mypy/issues/3440 |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| May 24, 2017 | https://github.com/python/mypy/pull/3435#issuecomment-303821257 |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| May 24, 2017 | https://github.com/python/mypy/pull/3435#issuecomment-303822123 |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| May 24, 2017 | https://github.com/python/mypy/pull/3435#issuecomment-303826220 |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
|
May 25, 2017
| https://github.com/python/mypy/pull/3435#ref-pullrequest-231233712 |
|
Support accessing modules imported in class bodies within methods.
#3450
| https://github.com/python/mypy/pull/3450 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| May 25, 2017 | https://github.com/python/mypy/pull/3435#issuecomment-303915923 |
| #3450 | https://github.com/python/mypy/pull/3450 |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
|
| https://github.com/carljm |
| Remove test case that was only for exploration, not intended for incl… | https://github.com/python/mypy/pull/3435/commits/fdb3af1906d3fe7433cb9dd819f363700c0eb96b |
| fdb3af1 | https://github.com/python/mypy/pull/3435/commits/fdb3af1906d3fe7433cb9dd819f363700c0eb96b |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
May 30, 2017
| https://github.com/python/mypy/pull/3435#pullrequestreview-41001817 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3435/files/fdb3af1906d3fe7433cb9dd819f363700c0eb96b |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/3435#pullrequestreview-41001817 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| mypy/semanal.py | https://github.com/python/mypy/pull/3435/files/fdb3af1906d3fe7433cb9dd819f363700c0eb96b#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| May 30, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119148182 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| carljm | https://github.com/carljm |
| May 30, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119224184 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| gvanrossum | https://github.com/gvanrossum |
| May 30, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119228531 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| carljm | https://github.com/carljm |
| May 30, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119240820 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| test-data/unit/check-modules.test | https://github.com/python/mypy/pull/3435/files/fdb3af1906d3fe7433cb9dd819f363700c0eb96b#diff-841b50838a13f5f73aa1699d00dbae63f0e4144cb0be0b8345af10acdb42e55f |
| ilevkivskyi | https://github.com/ilevkivskyi |
| May 30, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119148611 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| carljm | https://github.com/carljm |
| May 30, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119210760 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| ilevkivskyi | https://github.com/ilevkivskyi |
| May 30, 2017 | https://github.com/python/mypy/pull/3435#event-1102754430 |
| carljm | https://github.com/carljm |
| May 30, 2017 13:54 | https://github.com/python/mypy/pull/3435#commits-pushed-14d7d0f |
|
| https://github.com/carljm |
| Merge branch 'master' into module-alias | https://github.com/python/mypy/pull/3435/commits/14d7d0f293041060a2b7108ce1c621950bfc4ecd |
| 14d7d0f | https://github.com/python/mypy/pull/3435/commits/14d7d0f293041060a2b7108ce1c621950bfc4ecd |
| python#3477 | https://github.com/python/mypy/pull/3477 |
| python#3461 | https://github.com/python/mypy/pull/3461 |
| python#3390 | https://github.com/python/mypy/pull/3390 |
| python#3473 | https://github.com/python/mypy/pull/3473 |
| python#3451 | https://github.com/python/mypy/pull/3451 |
| python#3337 | https://github.com/python/mypy/pull/3337 |
| python#3348 | https://github.com/python/mypy/pull/3348 |
| python#3445 | https://github.com/python/mypy/pull/3445 |
| python#3465 | https://github.com/python/mypy/pull/3465 |
| python#3074 | https://github.com/python/mypy/pull/3074 |
| python#3429 | https://github.com/python/mypy/pull/3429 |
| python#3447 | https://github.com/python/mypy/pull/3447 |
| python#3466 | https://github.com/python/mypy/pull/3466 |
| python#3463 | https://github.com/python/mypy/pull/3463 |
| python#3460 | https://github.com/python/mypy/pull/3460 |
| python#3248 | https://github.com/python/mypy/pull/3248 |
| python#3299 | https://github.com/python/mypy/pull/3299 |
| python#3428 | https://github.com/python/mypy/pull/3428 |
| python#3449 | https://github.com/python/mypy/pull/3449 |
|
| https://github.com/carljm |
| Add some more tests for module assignment. | https://github.com/python/mypy/pull/3435/commits/ee8bd80d4c717ef407935f9ee12cfea96a80cce9 |
| ee8bd80 | https://github.com/python/mypy/pull/3435/commits/ee8bd80d4c717ef407935f9ee12cfea96a80cce9 |
|
| https://github.com/carljm |
| Also add tests for access/assignment of nonexistent module attribute. | https://github.com/python/mypy/pull/3435/commits/7efbdb798616e031607543b7a0b394d286dfcffa |
| 7efbdb7 | https://github.com/python/mypy/pull/3435/commits/7efbdb798616e031607543b7a0b394d286dfcffa |
|
| https://github.com/carljm |
| Break down code and add comments for clarity; add test for mismatch l… | https://github.com/python/mypy/pull/3435/commits/fd3eb848346e97ece5b02dbda72fd1676cb7bc45 |
| fd3eb84 | https://github.com/python/mypy/pull/3435/commits/fd3eb848346e97ece5b02dbda72fd1676cb7bc45 |
|
| https://github.com/carljm |
| Naming improvements. | https://github.com/python/mypy/pull/3435/commits/4006d0a959e1831ff0cd5dd8a97e81c4d1d9ddf3 |
| 4006d0a | https://github.com/python/mypy/pull/3435/commits/4006d0a959e1831ff0cd5dd8a97e81c4d1d9ddf3 |
|
| https://github.com/carljm |
| Merge branch 'master' into module-alias | https://github.com/python/mypy/pull/3435/commits/7aeb65ffcaa066614c92d81c317ead88e1e0cf07 |
| 7aeb65f | https://github.com/python/mypy/pull/3435/commits/7aeb65ffcaa066614c92d81c317ead88e1e0cf07 |
| python#3450 | https://github.com/python/mypy/pull/3450 |
| python#3346 | https://github.com/python/mypy/pull/3346 |
| python#3479 | https://github.com/python/mypy/pull/3479 |
| python#3467 | https://github.com/python/mypy/pull/3467 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
May 31, 2017
| https://github.com/python/mypy/pull/3435#pullrequestreview-41333264 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3435/files/4006d0a959e1831ff0cd5dd8a97e81c4d1d9ddf3 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/3435#pullrequestreview-41333264 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| mypy/semanal.py | https://github.com/python/mypy/pull/3435/files/4006d0a959e1831ff0cd5dd8a97e81c4d1d9ddf3#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| May 31, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119452127 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #3450 | https://github.com/python/mypy/pull/3450 |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| mypy/semanal.py | https://github.com/python/mypy/pull/3435/files/4006d0a959e1831ff0cd5dd8a97e81c4d1d9ddf3#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| May 31, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119452990 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| carljm | https://github.com/carljm |
| May 31, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119456039 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| May 31, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119456398 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| mypy/semanal.py | https://github.com/python/mypy/pull/3435/files/4006d0a959e1831ff0cd5dd8a97e81c4d1d9ddf3#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| May 31, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119453266 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| May 31, 2017 | https://github.com/python/mypy/pull/3435#issuecomment-305295625 |
| @carljm | https://github.com/carljm |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| carljm | https://github.com/carljm |
| May 31, 2017 12:45 | https://github.com/python/mypy/pull/3435#commits-pushed-6dc0757 |
|
| https://github.com/carljm |
| Support tracking module assignment in non-global scope. | https://github.com/python/mypy/pull/3435/commits/6dc0757dc79867ca4c6eedb7476c1658135fd7cb |
| 6dc0757 | https://github.com/python/mypy/pull/3435/commits/6dc0757dc79867ca4c6eedb7476c1658135fd7cb |
|
| https://github.com/carljm |
| Add more tests for unpacking mismatch cases. | https://github.com/python/mypy/pull/3435/commits/9aa8169c7d8e59791cb8bad34ba78786140f3569 |
| 9aa8169 | https://github.com/python/mypy/pull/3435/commits/9aa8169c7d8e59791cb8bad34ba78786140f3569 |
|
| https://github.com/carljm |
| Keep rvals always on the right. | https://github.com/python/mypy/pull/3435/commits/6e7cd24f243d44ea1e8b23df91c2fb16622fe606 |
| 6e7cd24 | https://github.com/python/mypy/pull/3435/commits/6e7cd24f243d44ea1e8b23df91c2fb16622fe606 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| May 31, 2017 | https://github.com/python/mypy/pull/3435#issuecomment-305302506 |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| carljm | https://github.com/carljm |
| May 31, 2017 13:47 | https://github.com/python/mypy/pull/3435#commits-pushed-d3d8f9f |
|
| https://github.com/carljm |
| Don't use a form of unpacking that is Py35+ only. | https://github.com/python/mypy/pull/3435/commits/d3d8f9fdb6a8eec6bb95541036b2e4a274df8e04 |
| d3d8f9f | https://github.com/python/mypy/pull/3435/commits/d3d8f9fdb6a8eec6bb95541036b2e4a274df8e04 |
|
| https://github.com/carljm |
| It's the zip that is problematic, not just the unpacking. | https://github.com/python/mypy/pull/3435/commits/1cbe94cfdaa6eb0c040be06484180025d7fd295e |
| 1cbe94c | https://github.com/python/mypy/pull/3435/commits/1cbe94cfdaa6eb0c040be06484180025d7fd295e |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| May 31, 2017 | https://github.com/python/mypy/pull/3435#issuecomment-305313873 |
| @ilevkivskyi | https://github.com/ilevkivskyi |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
|
| https://github.com/carljm |
| Add tests for module assignment in class and local scopes. | https://github.com/python/mypy/pull/3435/commits/325ae9420ea7c0001b89b42c3e13a7bf849a0e60 |
| 325ae94 | https://github.com/python/mypy/pull/3435/commits/325ae9420ea7c0001b89b42c3e13a7bf849a0e60 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| Jun 2, 2017 | https://github.com/python/mypy/pull/3435#issuecomment-305904020 |
| @ilevkivskyi | https://github.com/ilevkivskyi |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Jun 2, 2017
| https://github.com/python/mypy/pull/3435#pullrequestreview-41885848 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3435/files/325ae9420ea7c0001b89b42c3e13a7bf849a0e60 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/3435#pullrequestreview-41885848 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| mypy/semanal.py | https://github.com/python/mypy/pull/3435/files/325ae9420ea7c0001b89b42c3e13a7bf849a0e60#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jun 2, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119953697 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| carljm | https://github.com/carljm |
| Jun 3, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119973546 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| test-data/stdlib-samples/3.2/test/test_genericpath.py | https://github.com/python/mypy/pull/3435/files/325ae9420ea7c0001b89b42c3e13a7bf849a0e60#diff-3f4f4dd330636a77831a5287ff228c544d8a47fe25cb75993891ba91cfff7208 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jun 2, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119957122 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| carljm | https://github.com/carljm |
| Jun 3, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119973904 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| carljm | https://github.com/carljm |
| Jun 3, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119975130 |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| carljm | https://github.com/carljm |
| June 2, 2017 17:06 | https://github.com/python/mypy/pull/3435#commits-pushed-2326425 |
|
| https://github.com/carljm |
| Merge branch 'master' into module-alias | https://github.com/python/mypy/pull/3435/commits/23264252ca6b0831cdc8cdd12f997dca71eb60df |
| 2326425 | https://github.com/python/mypy/pull/3435/commits/23264252ca6b0831cdc8cdd12f997dca71eb60df |
| python#3488 | https://github.com/python/mypy/pull/3488 |
| python#3486 | https://github.com/python/mypy/pull/3486 |
| python#3485 | https://github.com/python/mypy/pull/3485 |
| python#3480 | https://github.com/python/mypy/pull/3480 |
| python#3478 | https://github.com/python/mypy/pull/3478 |
| python#3481 | https://github.com/python/mypy/pull/3481 |
|
| https://github.com/carljm |
| Simplify to single method. | https://github.com/python/mypy/pull/3435/commits/9592ce947378eb0a9180626bac4d96501dcba16e |
| 9592ce9 | https://github.com/python/mypy/pull/3435/commits/9592ce947378eb0a9180626bac4d96501dcba16e |
|
| https://github.com/carljm |
| Go back to annotating genericpath as Any in stdlib-sample. | https://github.com/python/mypy/pull/3435/commits/f438f9c3d0c581b9ebc5803d91e2e21dd72f7ec6 |
| f438f9c | https://github.com/python/mypy/pull/3435/commits/f438f9c3d0c581b9ebc5803d91e2e21dd72f7ec6 |
|
| https://github.com/carljm |
| Respect explicit type annotation and don't propagate module reference. | https://github.com/python/mypy/pull/3435/commits/e1ce5b8a80f42522de0ffa7b4da88cb0885c031e |
| e1ce5b8 | https://github.com/python/mypy/pull/3435/commits/e1ce5b8a80f42522de0ffa7b4da88cb0885c031e |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Jun 3, 2017
| https://github.com/python/mypy/pull/3435#pullrequestreview-41915968 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3435/files/e1ce5b8a80f42522de0ffa7b4da88cb0885c031e |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/3435#pullrequestreview-41915968 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| test-data/stdlib-samples/3.2/test/test_genericpath.py | https://github.com/python/mypy/pull/3435/files/e1ce5b8a80f42522de0ffa7b4da88cb0885c031e#diff-3f4f4dd330636a77831a5287ff228c544d8a47fe25cb75993891ba91cfff7208 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jun 3, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119982213 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| mypy/semanal.py | https://github.com/python/mypy/pull/3435/files/e1ce5b8a80f42522de0ffa7b4da88cb0885c031e#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jun 3, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119982257 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| mypy/semanal.py | https://github.com/python/mypy/pull/3435/files/e1ce5b8a80f42522de0ffa7b4da88cb0885c031e#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jun 3, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119982744 |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| carljm | https://github.com/carljm |
| June 3, 2017 04:43 | https://github.com/python/mypy/pull/3435#commits-pushed-c51a916 |
|
| https://github.com/carljm |
| Merge branch 'master' into module-alias | https://github.com/python/mypy/pull/3435/commits/c51a9163a68204821a68096373c7ea724b3dea75 |
| c51a916 | https://github.com/python/mypy/pull/3435/commits/c51a9163a68204821a68096373c7ea724b3dea75 |
| python#3493 | https://github.com/python/mypy/pull/3493 |
|
| https://github.com/carljm |
| Backtrack to simple ModuleType var in case of incompatible module ali… | https://github.com/python/mypy/pull/3435/commits/4d402073663acd638e015e574b85a56620b72b56 |
| 4d40207 | https://github.com/python/mypy/pull/3435/commits/4d402073663acd638e015e574b85a56620b72b56 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| Jun 3, 2017 | https://github.com/python/mypy/pull/3435#issuecomment-305975132 |
| @ilevkivskyi | https://github.com/ilevkivskyi |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Jun 3, 2017
| https://github.com/python/mypy/pull/3435#pullrequestreview-41920239 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3435/files/4d402073663acd638e015e574b85a56620b72b56 |
| mypy/semanal.py | https://github.com/python/mypy/pull/3435/files/4d402073663acd638e015e574b85a56620b72b56#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jun 3, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119986651 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
|
| https://github.com/carljm |
| Remove stray pdb comment. | https://github.com/python/mypy/pull/3435/commits/a8a4f4473af66cdc77d5c7be9af1bc6000d8ffab |
| a8a4f44 | https://github.com/python/mypy/pull/3435/commits/a8a4f4473af66cdc77d5c7be9af1bc6000d8ffab |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
|
Jun 3, 2017
| https://github.com/python/mypy/pull/3435#ref-issue-233368173 |
|
Clarify aliases vs variables
#3494
| https://github.com/python/mypy/issues/3494 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| Jun 3, 2017 | https://github.com/python/mypy/pull/3435#issuecomment-305975651 |
| #3494 | https://github.com/python/mypy/issues/3494 |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
|
| https://github.com/carljm |
| Also handle reassignment of an original (non-alias) module reference. | https://github.com/python/mypy/pull/3435/commits/6584b0b6ece4baf9f41efd503a5c2bc626aa5c5d |
| 6584b0b | https://github.com/python/mypy/pull/3435/commits/6584b0b6ece4baf9f41efd503a5c2bc626aa5c5d |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| Jun 3, 2017 | https://github.com/python/mypy/pull/3435#issuecomment-305990767 |
| #3494 | https://github.com/python/mypy/issues/3494 |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jun 3, 2017 | https://github.com/python/mypy/pull/3435#issuecomment-305990993 |
| #3494 | https://github.com/python/mypy/issues/3494 |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| Jun 3, 2017 | https://github.com/python/mypy/pull/3435#issuecomment-305991161 |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
|
| https://github.com/carljm |
| Simplify: fail on assignment of different modules to same variable wi… | https://github.com/python/mypy/pull/3435/commits/b292673cadbdc971966adbc67debdb20b0405e5c |
| b292673 | https://github.com/python/mypy/pull/3435/commits/b292673cadbdc971966adbc67debdb20b0405e5c |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| Jun 3, 2017 | https://github.com/python/mypy/pull/3435#issuecomment-305997116 |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Jun 3, 2017
| https://github.com/python/mypy/pull/3435#pullrequestreview-41926959 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3435/files/b292673cadbdc971966adbc67debdb20b0405e5c |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/3435#pullrequestreview-41926959 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| mypy/semanal.py | https://github.com/python/mypy/pull/3435/files/b292673cadbdc971966adbc67debdb20b0405e5c#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jun 3, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119993880 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| mypy/semanal.py | https://github.com/python/mypy/pull/3435/files/b292673cadbdc971966adbc67debdb20b0405e5c#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jun 3, 2017 | https://github.com/python/mypy/pull/3435#discussion_r119993946 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
|
| https://github.com/carljm |
| Style and working tweaks. | https://github.com/python/mypy/pull/3435/commits/f62d58efda070187e437637c64713e1e04e39ccc |
| f62d58e | https://github.com/python/mypy/pull/3435/commits/f62d58efda070187e437637c64713e1e04e39ccc |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| Jun 3, 2017 | https://github.com/python/mypy/pull/3435#issuecomment-306007605 |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| 7b7c7ad | https://github.com/python/mypy/commit/7b7c7adf31e465636042101dca7d583672be8c6a |
| Jun 3, 2017 | https://github.com/python/mypy/pull/3435#event-1108982005 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Jul 7, 2017
| https://github.com/python/mypy/pull/3435#ref-issue-241307478 |
|
Alias to qualified module does not work
#3669
| https://github.com/python/mypy/issues/3669 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Nov 30, 2017
| https://github.com/python/mypy/pull/3435#ref-issue-277732604 |
|
Module alias as instance attribute does not work
#4291
| https://github.com/python/mypy/issues/4291 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3435 |
|
| https://github.com/gvanrossum |
|
gvanrossum
| https://github.com/gvanrossum |
|
| https://github.com/python/mypy/pull/3435/files/fdb3af1906d3fe7433cb9dd819f363700c0eb96b |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
|
| https://github.com/python/mypy/pull/3435/files/b292673cadbdc971966adbc67debdb20b0405e5c |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
| Please reload this page | https://github.com/python/mypy/pull/3435 |
|
| https://github.com/carljm |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/gvanrossum |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |