René's URL Explorer Experiment


Title: Parse each format-string component separately by lincolnq · Pull Request #3390 · python/mypy · GitHub

Open Graph Title: Parse each format-string component separately by lincolnq · Pull Request #3390 · python/mypy

X Title: Parse each format-string component separately by lincolnq · Pull Request #3390 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #3385. The old code evaluated each FormattedValue as an expression potentially returning the type of the value, rather than a string. But that's wrong, because a FormattedValue can exist ...

X Description: Fixes #3385. The old code evaluated each FormattedValue as an expression potentially returning the type of the value, rather than a string. But that's wrong, because a FormattedValue can ex...

Opengraph URL: https://github.com/python/mypy/pull/3390

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:be0d104e-a8a4-ce18-280e-1d3a7a9d43a6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD298:DB416:10EF2AB:1609EA2:6AFFFAF3
html-safe-noncee505547e724609475c03e48b0e50f493eb23a64b110d361138d7a2629249f6ff
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjk4OkRCNDE2OjEwRUYyQUI6MTYwOUVBMjo2QUZGRkFGMyIsInZpc2l0b3JfaWQiOiIzMjQ3MjMwNTcyMDM2MDgzMDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6d23ba1e6b135a8aeadae6c5ead47f442ceb9c4266a6ab95a449eb60e70b48f0
hovercard-subject-tagpull_request:121659197
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/3390/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a073a5fe4641823f8af86730de6623784a75a23d1a145575eee8d2b8a7062a52/python/mypy/pull/3390
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a073a5fe4641823f8af86730de6623784a75a23d1a145575eee8d2b8a7062a52/python/mypy/pull/3390
og:image:altFixes #3385. The old code evaluated each FormattedValue as an expression potentially returning the type of the value, rather than a string. But that's wrong, because a FormattedValue can exist ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelincolnq
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/3390#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3390
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3390
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/3390
Reloadhttps://github.com/python/mypy/pull/3390
Reloadhttps://github.com/python/mypy/pull/3390
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
gvanrossumhttps://github.com/gvanrossum
python:masterhttps://github.com/python/mypy/tree/master
lincolnq:lincoln/fix-fstring-single-formatting-fieldhttps://github.com/lincolnq/mypy/tree/lincoln/fix-fstring-single-formatting-field
Conversationhttps://github.com/python/mypy/pull/3390
Commits5 (5)https://github.com/python/mypy/pull/3390/commits
Checkshttps://github.com/python/mypy/pull/3390/checks
Files changedhttps://github.com/python/mypy/pull/3390/files
Parse each format-string component separatelyhttps://github.com/python/mypy/pull/3390#top
gvanrossumhttps://github.com/gvanrossum
python:masterhttps://github.com/python/mypy/tree/master
lincolnq:lincoln/fix-fstring-single-formatting-fieldhttps://github.com/lincolnq/mypy/tree/lincoln/fix-fstring-single-formatting-field
https://github.com/lincolnq
lincolnqhttps://github.com/lincolnq
May 21, 2017https://github.com/python/mypy/pull/3390#issue-230217929
Please reload this pagehttps://github.com/python/mypy/pull/3390
#3385https://github.com/python/mypy/issues/3385
Please reload this pagehttps://github.com/python/mypy/pull/3390
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 21, 2017 https://github.com/python/mypy/pull/3390#pullrequestreview-39358290
View reviewed changes https://github.com/python/mypy/pull/3390/files
test-data/unit/check-newsyntax.testhttps://github.com/python/mypy/pull/3390/files#diff-314732b76656fe7166ba92434f2a67d15b2878d7c4050df50a7d7927e5bc4296
JelleZijlstrahttps://github.com/JelleZijlstra
May 21, 2017https://github.com/python/mypy/pull/3390#discussion_r117634876
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3390
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 21, 2017 https://github.com/python/mypy/pull/3390#pullrequestreview-39358330
View reviewed changes https://github.com/python/mypy/pull/3390/files
test-data/unit/fixtures/f_string.pyihttps://github.com/python/mypy/pull/3390/files#diff-e5844ce8ed9f79a8dfb26bcc4827e52f284837680b29ac573c4d09d724083302
JelleZijlstrahttps://github.com/JelleZijlstra
May 21, 2017https://github.com/python/mypy/pull/3390#discussion_r117634920
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3390
lincolnqhttps://github.com/lincolnq
May 22, 2017https://github.com/python/mypy/pull/3390#discussion_r117663295
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3390
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 26, 2017 https://github.com/python/mypy/pull/3390#pullrequestreview-40628024
View reviewed changes https://github.com/python/mypy/pull/3390/files
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/mypy/pull/3390#pullrequestreview-40628024
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3390
mypy/fastparse.pyhttps://github.com/python/mypy/pull/3390/files#diff-a7d2c40f4be6322cee498432ca9dbbc3a356c3cbcb61029231452f6638bb11b5
gvanrossumhttps://github.com/gvanrossum
May 26, 2017https://github.com/python/mypy/pull/3390#discussion_r118797298
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3390
test-data/unit/fixtures/f_string.pyihttps://github.com/python/mypy/pull/3390/files#diff-e5844ce8ed9f79a8dfb26bcc4827e52f284837680b29ac573c4d09d724083302
gvanrossumhttps://github.com/gvanrossum
May 26, 2017https://github.com/python/mypy/pull/3390#discussion_r118798313
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3390
lincolnqhttps://github.com/lincolnq
May 27, 2017 11:43https://github.com/python/mypy/pull/3390#commits-pushed-9e22c0c
https://github.com/lincolnq
Parse each format-string component separatelyhttps://github.com/python/mypy/pull/3390/commits/9e22c0cf691f613712d0c15861e6aba41db14912
9e22c0chttps://github.com/python/mypy/pull/3390/commits/9e22c0cf691f613712d0c15861e6aba41db14912
python#3385https://github.com/python/mypy/issues/3385
https://github.com/lincolnq
test f-string type using reveal_typehttps://github.com/python/mypy/pull/3390/commits/dada4e4f87ab397b8fbfe0247c9175e5a401fed1
dada4e4https://github.com/python/mypy/pull/3390/commits/dada4e4f87ab397b8fbfe0247c9175e5a401fed1
https://github.com/lincolnq
remove unnecessary @builtinclass decoratorhttps://github.com/python/mypy/pull/3390/commits/06321c1e39dc004b14944d8f5ff3f0e618a6428d
06321c1https://github.com/python/mypy/pull/3390/commits/06321c1e39dc004b14944d8f5ff3f0e618a6428d
https://github.com/lincolnq
lincolnqhttps://github.com/lincolnq
force-pushedhttps://github.com/python/mypy/compare/d4fba25792f0d8a06064b9ae4ac48060dcefbeeb..a564e4be0a67fbfa5f128229446b06f2f45e6593
d4fba25https://github.com/python/mypy/commit/d4fba25792f0d8a06064b9ae4ac48060dcefbeeb
a564e4bhttps://github.com/python/mypy/commit/a564e4be0a67fbfa5f128229446b06f2f45e6593
Compare https://github.com/python/mypy/compare/d4fba25792f0d8a06064b9ae4ac48060dcefbeeb..a564e4be0a67fbfa5f128229446b06f2f45e6593
May 27, 2017 08:46https://github.com/python/mypy/pull/3390#event-1099830771
lincolnqhttps://github.com/lincolnq
May 27, 2017 11:50https://github.com/python/mypy/pull/3390#commits-pushed-4822afd
https://github.com/lincolnq
change docstrings to commentshttps://github.com/python/mypy/pull/3390/commits/4822afd648518ce004247cbd20b7d75ba090108f
4822afdhttps://github.com/python/mypy/pull/3390/commits/4822afd648518ce004247cbd20b7d75ba090108f
https://github.com/lincolnq
remove unneeded functions from list class in fixturehttps://github.com/python/mypy/pull/3390/commits/f586e2d72afb1a862c1f64d361eeeab3bbb60d7f
f586e2dhttps://github.com/python/mypy/pull/3390/commits/f586e2d72afb1a862c1f64d361eeeab3bbb60d7f
https://github.com/lincolnq
lincolnqhttps://github.com/lincolnq
force-pushedhttps://github.com/python/mypy/compare/a564e4be0a67fbfa5f128229446b06f2f45e6593..f586e2d72afb1a862c1f64d361eeeab3bbb60d7f
a564e4bhttps://github.com/python/mypy/commit/a564e4be0a67fbfa5f128229446b06f2f45e6593
f586e2dhttps://github.com/python/mypy/commit/f586e2d72afb1a862c1f64d361eeeab3bbb60d7f
Compare https://github.com/python/mypy/compare/a564e4be0a67fbfa5f128229446b06f2f45e6593..f586e2d72afb1a862c1f64d361eeeab3bbb60d7f
May 27, 2017 08:51https://github.com/python/mypy/pull/3390#event-1099832659
https://github.com/lincolnq
lincolnqhttps://github.com/lincolnq
May 30, 2017https://github.com/python/mypy/pull/3390#issuecomment-304784957
Please reload this pagehttps://github.com/python/mypy/pull/3390
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 30, 2017 https://github.com/python/mypy/pull/3390#pullrequestreview-40988085
View reviewed changes https://github.com/python/mypy/pull/3390/files/f586e2d72afb1a862c1f64d361eeeab3bbb60d7f
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
d4864a9https://github.com/python/mypy/commit/d4864a962b20a16684a6fa15859f97f1935c4e60
May 30, 2017https://github.com/python/mypy/pull/3390#event-1102570573
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 30, 2017https://github.com/python/mypy/pull/3390#issuecomment-304918587
Please reload this pagehttps://github.com/python/mypy/pull/3390
carljmhttps://github.com/carljm
May 30, 2017 https://github.com/python/mypy/pull/3390#ref-commit-14d7d0f
https://github.com/carljm
Merge branch 'master' into module-aliashttps://github.com/carljm/mypy/commit/14d7d0f293041060a2b7108ce1c621950bfc4ecd
14d7d0fhttps://github.com/carljm/mypy/commit/14d7d0f293041060a2b7108ce1c621950bfc4ecd
python#3477https://github.com/python/mypy/pull/3477
python#3461https://github.com/python/mypy/pull/3461
python#3390https://github.com/python/mypy/pull/3390
python#3473https://github.com/python/mypy/pull/3473
python#3451https://github.com/python/mypy/pull/3451
python#3337https://github.com/python/mypy/pull/3337
python#3348https://github.com/python/mypy/pull/3348
python#3445https://github.com/python/mypy/pull/3445
python#3465https://github.com/python/mypy/pull/3465
python#3074https://github.com/python/mypy/pull/3074
python#3429https://github.com/python/mypy/pull/3429
python#3447https://github.com/python/mypy/pull/3447
python#3466https://github.com/python/mypy/pull/3466
python#3463https://github.com/python/mypy/pull/3463
python#3460https://github.com/python/mypy/pull/3460
python#3248https://github.com/python/mypy/pull/3248
python#3299https://github.com/python/mypy/pull/3299
python#3428https://github.com/python/mypy/pull/3428
python#3449https://github.com/python/mypy/pull/3449
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3390
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/python/mypy/pull/3390/files/3a37e1833dd2a9c640fd3b4dd9890a73b0deb9c0
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/mypy/pull/3390/files/f586e2d72afb1a862c1f64d361eeeab3bbb60d7f
Please reload this pagehttps://github.com/python/mypy/pull/3390
Incorrect errors for fstrings + generators https://github.com/python/mypy/issues/3385
Please reload this pagehttps://github.com/python/mypy/pull/3390
https://github.com/lincolnq
https://github.com/gvanrossum
https://github.com/JelleZijlstra
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.