| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:947928f3-963a-a267-23d5-22fca381b56b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8238:3A13A0:1F4A854:2A58036:6B001739 |
| html-safe-nonce | d7f915a90de2c46245cb63fd37a62cbb91b497f1b6100533517b69fa9fce4f94 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjM4OjNBMTNBMDoxRjRBODU0OjJBNTgwMzY6NkIwMDE3MzkiLCJ2aXNpdG9yX2lkIjoiOTQ5OTE5OTUwMTcxMDE5MDY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9289cf0d0875e03427c80d1a47a404291767d7906953c009666d1c3d2b1be941 |
| hovercard-subject-tag | pull_request:120682068 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/3364/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e5418c173acbca1ec906d42207126d2b4263076e9752531c0799b8ca8c2a59aa/python/mypy/pull/3364 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e5418c173acbca1ec906d42207126d2b4263076e9752531c0799b8ca8c2a59aa/python/mypy/pull/3364 |
| og:image:alt | Fixes #1764
This doesn't add support for @six.add_metaclass(M) -- if that's required we'll add it later (we should open a separate issue for that). |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gvanrossum |
| hostname | github.com |
| expected-hostname | github.com |
| None | a2dd2291b1b13cc9c06f27ec92fa3dbaf34116fc24c9347b8539db61884c59f4 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 70121d4e855ee0bb7b75cf15d061d91f8863c0f8 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/3364#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3364 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3364 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/3364 |
| Reload | https://github.com/python/mypy/pull/3364 |
| Reload | https://github.com/python/mypy/pull/3364 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| gvanrossum | https://github.com/gvanrossum |
| master | https://github.com/python/mypy/tree/master |
| six-metaclass | https://github.com/python/mypy/tree/six-metaclass |
| Conversation | https://github.com/python/mypy/pull/3364 |
| Commits7 (7) | https://github.com/python/mypy/pull/3364/commits |
| Checks | https://github.com/python/mypy/pull/3364/checks |
| Files changed | https://github.com/python/mypy/pull/3364/files |
| Support six.with_metaclass | https://github.com/python/mypy/pull/3364#top |
| gvanrossum | https://github.com/gvanrossum |
| master | https://github.com/python/mypy/tree/master |
| six-metaclass | https://github.com/python/mypy/tree/six-metaclass |
|
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| May 15, 2017 | https://github.com/python/mypy/pull/3364#issue-228827813 |
| Please reload this page | https://github.com/python/mypy/pull/3364 |
| #1764 | https://github.com/python/mypy/issues/1764 |
| Please reload this page | https://github.com/python/mypy/pull/3364 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
May 15, 2017
| https://github.com/python/mypy/pull/3364#ref-issue-228840809 |
|
Support GenericMeta
#3366
| https://github.com/python/mypy/issues/3366 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
May 16, 2017
| https://github.com/python/mypy/pull/3364#pullrequestreview-38265988 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3364/files |
| mypy/semanal.py | https://github.com/python/mypy/pull/3364/files#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| JukkaL | https://github.com/JukkaL |
| May 16, 2017 | https://github.com/python/mypy/pull/3364#discussion_r116630551 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3364 |
| mypy/semanal.py | https://github.com/python/mypy/pull/3364/files#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| JukkaL | https://github.com/JukkaL |
| May 16, 2017 | https://github.com/python/mypy/pull/3364#discussion_r116630761 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3364 |
| gvanrossum | https://github.com/gvanrossum |
| May 16, 2017 | https://github.com/python/mypy/pull/3364#discussion_r116637067 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3364 |
| test-data/unit/check-classes.test | https://github.com/python/mypy/pull/3364/files#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf |
| JukkaL | https://github.com/JukkaL |
| May 16, 2017 | https://github.com/python/mypy/pull/3364#discussion_r116630942 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3364 |
| gvanrossum | https://github.com/gvanrossum |
| May 16, 2017 | https://github.com/python/mypy/pull/3364#discussion_r116637336 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3364 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| May 16, 2017 | https://github.com/python/mypy/pull/3364#issuecomment-301649722 |
| Please reload this page | https://github.com/python/mypy/pull/3364 |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/3364 |
| May 15, 2017 19:43 | https://github.com/python/mypy/pull/3364#commits-pushed-00ed2b3 |
| Basic support for six.with_metaclass | https://github.com/python/mypy/pull/3364/commits/00ed2b3fb9b74562fb6817c99a780ad137f09186 |
| 00ed2b3 | https://github.com/python/mypy/pull/3364/commits/00ed2b3fb9b74562fb6817c99a780ad137f09186 |
| Add tests | https://github.com/python/mypy/pull/3364/commits/b73ba507ccb959e6c45f7e1781b3724d8d08681a |
| b73ba50 | https://github.com/python/mypy/pull/3364/commits/b73ba507ccb959e6c45f7e1781b3724d8d08681a |
| Refactor ugliness into a method | https://github.com/python/mypy/pull/3364/commits/b44cbf5c38b2f1a1c207d637e284faed312f2e3f |
| b44cbf5 | https://github.com/python/mypy/pull/3364/commits/b44cbf5c38b2f1a1c207d637e284faed312f2e3f |
| Add more test cases | https://github.com/python/mypy/pull/3364/commits/defd5403fe99bfa1f33a22478b04f0caa2ea9937 |
| defd540 | https://github.com/python/mypy/pull/3364/commits/defd5403fe99bfa1f33a22478b04f0caa2ea9937 |
| Address code review | https://github.com/python/mypy/pull/3364/commits/53d32b68273521bae469248b0b7a3814c9355d12 |
| 53d32b6 | https://github.com/python/mypy/pull/3364/commits/53d32b68273521bae469248b0b7a3814c9355d12 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
May 16, 2017
| https://github.com/python/mypy/pull/3364#pullrequestreview-38318869 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3364/files |
| mypy/semanal.py | https://github.com/python/mypy/pull/3364/files#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| May 16, 2017 | https://github.com/python/mypy/pull/3364#discussion_r116680402 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #3366 | https://github.com/python/mypy/issues/3366 |
| Please reload this page | https://github.com/python/mypy/pull/3364 |
| gvanrossum | https://github.com/gvanrossum |
| May 17, 2017 | https://github.com/python/mypy/pull/3364#discussion_r116896626 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3364 |
| May 16, 2017 17:13 | https://github.com/python/mypy/pull/3364#commits-pushed-24fd09a |
| Move check for six.with_metaclass to clean_up_bases_and_infer_type_va… | https://github.com/python/mypy/pull/3364/commits/24fd09ae5e35d6e1d584065624919d33767c896b |
| 24fd09a | https://github.com/python/mypy/pull/3364/commits/24fd09ae5e35d6e1d584065624919d33767c896b |
| Add test showing that generics work (this was previously broken) | https://github.com/python/mypy/pull/3364/commits/8acfc9d254cd575af3d44be68804774feb6875b2 |
| 8acfc9d | https://github.com/python/mypy/pull/3364/commits/8acfc9d254cd575af3d44be68804774feb6875b2 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| force-pushed | https://github.com/python/mypy/compare/6cad6f9f3eaf99faae4cab271216e56a8f6b5420..8acfc9d254cd575af3d44be68804774feb6875b2 |
| 6cad6f9 | https://github.com/python/mypy/commit/6cad6f9f3eaf99faae4cab271216e56a8f6b5420 |
| 8acfc9d | https://github.com/python/mypy/commit/8acfc9d254cd575af3d44be68804774feb6875b2 |
|
Compare
| https://github.com/python/mypy/compare/6cad6f9f3eaf99faae4cab271216e56a8f6b5420..8acfc9d254cd575af3d44be68804774feb6875b2 |
| May 17, 2017 02:05 | https://github.com/python/mypy/pull/3364#event-1085203079 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
May 17, 2017
| https://github.com/python/mypy/pull/3364#pullrequestreview-38794957 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3364/files/8acfc9d254cd575af3d44be68804774feb6875b2 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/3364#pullrequestreview-38794957 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3364 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| 3f2668d | https://github.com/python/mypy/commit/3f2668d95ad96a0846ec23e23dd3db73c0aa370e |
| May 17, 2017 | https://github.com/python/mypy/pull/3364#event-1086831353 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| May 17, 2017 21:59 | https://github.com/python/mypy/pull/3364#event-1086831429 |
| PiDelport | https://github.com/PiDelport |
|
Dec 5, 2017
| https://github.com/python/mypy/pull/3364#ref-commit-02f8f0d |
|
| https://github.com/PiDelport |
| Use the six package, rather than Django's vendored version | https://github.com/PiDelport/django-payfast/commit/02f8f0d6db645ea8de18e07e67a39282ac6c7457 |
| 02f8f0d | https://github.com/PiDelport/django-payfast/commit/02f8f0d6db645ea8de18e07e67a39282ac6c7457 |
| python/mypy#3364 | https://github.com/python/mypy/pull/3364 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3364 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/3364/files/07123b388139f2515b63504d8f70186bf96b65a7 |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
|
| https://github.com/python/mypy/pull/3364/files/8acfc9d254cd575af3d44be68804774feb6875b2 |
| Please reload this page | https://github.com/python/mypy/pull/3364 |
| Please reload this page | https://github.com/python/mypy/pull/3364 |
|
| https://github.com/gvanrossum |
|
| https://github.com/JukkaL |
|
| https://github.com/ilevkivskyi |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |