René's URL Explorer Experiment


Title: Make Type[X] compatible with metaclass of X by elazarg · Pull Request #3346 · python/mypy · GitHub

Open Graph Title: Make Type[X] compatible with metaclass of X by elazarg · Pull Request #3346 · python/mypy

X Title: Make Type[X] compatible with metaclass of X by elazarg · Pull Request #3346 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fix #3326. PR #2837 seems completely broken; the checks were all backwards, so this PR reverses them. I had to special-case EnumMeta since the bound for the self argument can't be lower than th...

X Description: Fix #3326. PR #2837 seems completely broken; the checks were all backwards, so this PR reverses them. I had to special-case EnumMeta since the bound for the self argument can't be lower tha...

Opengraph URL: https://github.com/python/mypy/pull/3346

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b47dd018-939e-e558-8ce1-5ff430ae821f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF0A:3EE8F1:D9CB9B:11BF7B3:6AFFEDEE
html-safe-nonce7110c739337b0bfe65ba2e999876672cc7e3a745f3a556bd8c9fe1b331f1e2ad
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjBBOjNFRThGMTpEOUNCOUI6MTFCRjdCMzo2QUZGRURFRSIsInZpc2l0b3JfaWQiOiIzMjA0MTkzNDMzMDkwNTE4NTEwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5a6454e49d15b6210221147a1cc52dd9facfdb80388cc182774f719cd3ff9d02
hovercard-subject-tagpull_request:119744538
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/3346/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d8f30bd27f2a6fca6722d7b1666ae5640318553f323977951bb5d8f97a83d67e/python/mypy/pull/3346
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d8f30bd27f2a6fca6722d7b1666ae5640318553f323977951bb5d8f97a83d67e/python/mypy/pull/3346
og:image:altFix #3326. PR #2837 seems completely broken; the checks were all backwards, so this PR reverses them. I had to special-case EnumMeta since the bound for the self argument can't be lower than th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameelazarg
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/3346#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3346
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3346
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/3346
Reloadhttps://github.com/python/mypy/pull/3346
Reloadhttps://github.com/python/mypy/pull/3346
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
elazarg:type-compat-metahttps://github.com/elazarg/mypy/tree/type-compat-meta
Conversationhttps://github.com/python/mypy/pull/3346
Commits6 (6)https://github.com/python/mypy/pull/3346/commits
Checkshttps://github.com/python/mypy/pull/3346/checks
Files changedhttps://github.com/python/mypy/pull/3346/files
Make Type[X] compatible with metaclass of Xhttps://github.com/python/mypy/pull/3346#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
elazarg:type-compat-metahttps://github.com/elazarg/mypy/tree/type-compat-meta
https://github.com/elazarg
elazarghttps://github.com/elazarg
May 9, 2017https://github.com/python/mypy/pull/3346#issue-227485466
#3326https://github.com/python/mypy/issues/3326
#2837https://github.com/python/mypy/pull/2837
Please reload this pagehttps://github.com/python/mypy/pull/3346
elazarghttps://github.com/elazarg
May 9, 2017 10:48https://github.com/python/mypy/pull/3346#commits-pushed-907f07b
https://github.com/elazarg
Reverse subtype check, add checks for typevarhttps://github.com/python/mypy/pull/3346/commits/907f07b7ed199dca899265bd7e1cfaa38bd9378d
907f07bhttps://github.com/python/mypy/pull/3346/commits/907f07b7ed199dca899265bd7e1cfaa38bd9378d
https://github.com/elazarg
Don't do M <: Type[X]https://github.com/python/mypy/pull/3346/commits/75d80738b1b2abc8b64225594b28602cbfb03b31
75d8073https://github.com/python/mypy/pull/3346/commits/75d80738b1b2abc8b64225594b28602cbfb03b31
https://github.com/elazarg
elazarghttps://github.com/elazarg
force-pushedhttps://github.com/python/mypy/compare/3766205d4309eddbb00b2b00b321abc805052075..75d80738b1b2abc8b64225594b28602cbfb03b31
3766205https://github.com/python/mypy/commit/3766205d4309eddbb00b2b00b321abc805052075
75d8073https://github.com/python/mypy/commit/75d80738b1b2abc8b64225594b28602cbfb03b31
Compare https://github.com/python/mypy/compare/3766205d4309eddbb00b2b00b321abc805052075..75d80738b1b2abc8b64225594b28602cbfb03b31
May 9, 2017 20:22https://github.com/python/mypy/pull/3346#event-1075301668
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
May 13, 2017 https://github.com/python/mypy/pull/3346#pullrequestreview-37974144
View reviewed changes https://github.com/python/mypy/pull/3346/files/75d80738b1b2abc8b64225594b28602cbfb03b31
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/3346#pullrequestreview-37974144
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3346
mypy/subtypes.pyhttps://github.com/python/mypy/pull/3346/files/75d80738b1b2abc8b64225594b28602cbfb03b31#diff-3641fc675bdf772ec816dbb1b8ef258e9f07c15f604d83d7549bf7b873757a54
ilevkivskyihttps://github.com/ilevkivskyi
May 13, 2017https://github.com/python/mypy/pull/3346#discussion_r116352743
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3346
mypy/subtypes.pyhttps://github.com/python/mypy/pull/3346/files/75d80738b1b2abc8b64225594b28602cbfb03b31#diff-3641fc675bdf772ec816dbb1b8ef258e9f07c15f604d83d7549bf7b873757a54
ilevkivskyihttps://github.com/ilevkivskyi
May 13, 2017https://github.com/python/mypy/pull/3346#discussion_r116352771
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3346
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/3346/files/75d80738b1b2abc8b64225594b28602cbfb03b31#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
ilevkivskyihttps://github.com/ilevkivskyi
May 13, 2017https://github.com/python/mypy/pull/3346#discussion_r116352895
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3346
elazarghttps://github.com/elazarg
May 13, 2017https://github.com/python/mypy/pull/3346#discussion_r116363189
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3346
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/3346/files/75d80738b1b2abc8b64225594b28602cbfb03b31#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
ilevkivskyihttps://github.com/ilevkivskyi
May 13, 2017https://github.com/python/mypy/pull/3346#discussion_r116353115
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3346
elazarghttps://github.com/elazarg
May 13, 2017https://github.com/python/mypy/pull/3346#discussion_r116363355
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3346
elazarghttps://github.com/elazarg
May 13, 2017https://github.com/python/mypy/pull/3346#discussion_r116363913
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3346
ilevkivskyihttps://github.com/ilevkivskyi
May 14, 2017https://github.com/python/mypy/pull/3346#discussion_r116376538
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3346
elazarghttps://github.com/elazarg
May 16, 2017https://github.com/python/mypy/pull/3346#discussion_r116852290
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3346
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/3346/files/75d80738b1b2abc8b64225594b28602cbfb03b31#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
ilevkivskyihttps://github.com/ilevkivskyi
May 13, 2017https://github.com/python/mypy/pull/3346#discussion_r116353134
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3346
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/3346/files/75d80738b1b2abc8b64225594b28602cbfb03b31#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
ilevkivskyihttps://github.com/ilevkivskyi
May 13, 2017https://github.com/python/mypy/pull/3346#discussion_r116353224
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3346
elazarghttps://github.com/elazarg
May 13, 2017https://github.com/python/mypy/pull/3346#discussion_r116366538
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3346
ilevkivskyihttps://github.com/ilevkivskyi
May 14, 2017https://github.com/python/mypy/pull/3346#discussion_r116376446
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3346
ilevkivskyihttps://github.com/ilevkivskyi
May 30, 2017https://github.com/python/mypy/pull/3346#discussion_r119142288
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@elazarghttps://github.com/elazarg
@JukkaLhttps://github.com/JukkaL
Please reload this pagehttps://github.com/python/mypy/pull/3346
elazarghttps://github.com/elazarg
May 30, 2017https://github.com/python/mypy/pull/3346#discussion_r119143524
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3346
elazarghttps://github.com/elazarg
May 30, 2017https://github.com/python/mypy/pull/3346#discussion_r119151543
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3346
JukkaLhttps://github.com/JukkaL
May 30, 2017https://github.com/python/mypy/pull/3346#discussion_r119190221
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@ilevkivskyihttps://github.com/ilevkivskyi
Please reload this pagehttps://github.com/python/mypy/pull/3346
gvanrossumhttps://github.com/gvanrossum
May 30, 2017https://github.com/python/mypy/pull/3346#discussion_r119223958
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3346
elazarghttps://github.com/elazarg
May 13, 2017 20:56https://github.com/python/mypy/pull/3346#commits-pushed-2209639
https://github.com/elazarg
fix some errors, extend test, don't remove commenthttps://github.com/python/mypy/pull/3346/commits/2209639f5c785eabc0e2ad077baeedb51cf3f84c
2209639https://github.com/python/mypy/pull/3346/commits/2209639f5c785eabc0e2ad077baeedb51cf3f84c
https://github.com/elazarg
Merge branch 'master' into type-compat-metahttps://github.com/python/mypy/pull/3346/commits/18edb2d11c6ee9b06fd8da97a9a9af48d28f7280
18edb2dhttps://github.com/python/mypy/pull/3346/commits/18edb2d11c6ee9b06fd8da97a9a9af48d28f7280
https://github.com/elazarg
Merge branch 'master' into type-compat-metahttps://github.com/python/mypy/pull/3346/commits/ae0c77b3568a5c062f138c888e45ab9673dc6e34
ae0c77bhttps://github.com/python/mypy/pull/3346/commits/ae0c77b3568a5c062f138c888e45ab9673dc6e34
https://github.com/elazarg
add tests, and prepare tests for checking-on-accesshttps://github.com/python/mypy/pull/3346/commits/34b5817acd2516a94a21a785e4c59f537de0ec09
34b5817https://github.com/python/mypy/pull/3346/commits/34b5817acd2516a94a21a785e4c59f537de0ec09
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
ilevkivskyihttps://github.com/ilevkivskyi
May 30, 2017https://github.com/python/mypy/pull/3346#event-1102751356
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
May 31, 2017 https://github.com/python/mypy/pull/3346#pullrequestreview-41149146
View reviewed changes https://github.com/python/mypy/pull/3346/files/34b5817acd2516a94a21a785e4c59f537de0ec09
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/3346#pullrequestreview-41149146
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3346
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
f60d874https://github.com/python/mypy/commit/f60d874172cfcd51a026665577430680b828263b
May 31, 2017https://github.com/python/mypy/pull/3346#event-1103651298
carljmhttps://github.com/carljm
May 31, 2017 https://github.com/python/mypy/pull/3346#ref-commit-7aeb65f
https://github.com/carljm
Merge branch 'master' into module-aliashttps://github.com/carljm/mypy/commit/7aeb65ffcaa066614c92d81c317ead88e1e0cf07
7aeb65fhttps://github.com/carljm/mypy/commit/7aeb65ffcaa066614c92d81c317ead88e1e0cf07
python#3450https://github.com/python/mypy/pull/3450
python#3346https://github.com/python/mypy/pull/3346
python#3479https://github.com/python/mypy/pull/3479
python#3467https://github.com/python/mypy/pull/3467
https://github.com/elazarg
elazarghttps://github.com/elazarg
Jun 28, 2017 https://github.com/python/mypy/pull/3346#ref-issue-239037734
Metaclass type/instance difficulties #3625 https://github.com/python/mypy/issues/3625
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3346
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/3346/files/75d80738b1b2abc8b64225594b28602cbfb03b31
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/mypy/pull/3346/files/75d80738b1b2abc8b64225594b28602cbfb03b31
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/3346/files/34b5817acd2516a94a21a785e4c59f537de0ec09
Please reload this pagehttps://github.com/python/mypy/pull/3346
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
Please reload this pagehttps://github.com/python/mypy/pull/3346
https://github.com/elazarg
https://github.com/JukkaL
https://github.com/gvanrossum
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.