René's URL Explorer Experiment


Title: Fix crashes in synthetic types by ilevkivskyi · Pull Request #3322 · python/mypy · GitHub

Open Graph Title: Fix crashes in synthetic types by ilevkivskyi · Pull Request #3322 · python/mypy

X Title: Fix crashes in synthetic types by ilevkivskyi · Pull Request #3322 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: UPDATE: see #3322 (comment) below. Fixes #3308 This PR adds better processing of "synthetic" types (NewType, NamedTuple, TypedDict) to the third pass and moves some processing from the se...

X Description: UPDATE: see #3322 (comment) below. Fixes #3308 This PR adds better processing of "synthetic" types (NewType, NamedTuple, TypedDict) to the third pass and moves some processing fro...

Opengraph URL: https://github.com/python/mypy/pull/3322

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:855b1835-8975-3fda-2cce-edcb3c785d55
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C10:5875E:2796C98:35E8CF5:6B0042E7
html-safe-nonce89249bb20e2402f37056ab642de4c4128ce6834d875607726a285a6810d0db16
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzEwOjU4NzVFOjI3OTZDOTg6MzVFOENGNTo2QjAwNDJFNyIsInZpc2l0b3JfaWQiOiIxOTUyMjYxMTEyNTYwODk0Njk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac235d785e190bfab8d5b8bb776525b1145441eacf28e1976079458c5ecc884ba7
hovercard-subject-tagpull_request:119011546
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/3322/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c00202bf9c5ef57688ea53431ea153cad67bc7cbd7c302901da29f04322638d9/python/mypy/pull/3322
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c00202bf9c5ef57688ea53431ea153cad67bc7cbd7c302901da29f04322638d9/python/mypy/pull/3322
og:image:altUPDATE: see #3322 (comment) below. Fixes #3308 This PR adds better processing of "synthetic" types (NewType, NamedTuple, TypedDict) to the third pass and moves some processing from the se...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/3322#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3322
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3322
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/3322
Reloadhttps://github.com/python/mypy/pull/3322
Reloadhttps://github.com/python/mypy/pull/3322
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
gvanrossumhttps://github.com/gvanrossum
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:fix-forward-crashhttps://github.com/ilevkivskyi/mypy/tree/fix-forward-crash
Conversationhttps://github.com/python/mypy/pull/3322
Commits14 (14)https://github.com/python/mypy/pull/3322/commits
Checkshttps://github.com/python/mypy/pull/3322/checks
Files changedhttps://github.com/python/mypy/pull/3322/files
Fix crashes in synthetic typeshttps://github.com/python/mypy/pull/3322#top
gvanrossumhttps://github.com/gvanrossum
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:fix-forward-crashhttps://github.com/ilevkivskyi/mypy/tree/fix-forward-crash
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
May 4, 2017https://github.com/python/mypy/pull/3322#issue-226333506
Please reload this pagehttps://github.com/python/mypy/pull/3322
#3322 (comment)https://github.com/python/mypy/pull/3322#issuecomment-300134170
#3308https://github.com/python/mypy/issues/3308
@JukkaLhttps://github.com/JukkaL
@JukkaLhttps://github.com/JukkaL
#1701 (comment)https://github.com/python/mypy/issues/1701#issuecomment-255347282
Please reload this pagehttps://github.com/python/mypy/pull/3322
May 4, 2017 11:04https://github.com/python/mypy/pull/3322#commits-pushed-e52f9c5
Fix NewType crashhttps://github.com/python/mypy/pull/3322/commits/e52f9c5f850ebec3e730c411c9bb5c820424876d
e52f9c5https://github.com/python/mypy/pull/3322/commits/e52f9c5f850ebec3e730c411c9bb5c820424876d
Fix first kind of crashes in TypedDict and NamedTuplehttps://github.com/python/mypy/pull/3322/commits/554c6faa5a6e8d60fa305787043e2f9aa7ac3097
554c6fahttps://github.com/python/mypy/pull/3322/commits/554c6faa5a6e8d60fa305787043e2f9aa7ac3097
Fix second kind of crashes with TypedDict and NamedTuplehttps://github.com/python/mypy/pull/3322/commits/590d1da36a57cb893e98b13662ad27394a4ca501
590d1dahttps://github.com/python/mypy/pull/3322/commits/590d1da36a57cb893e98b13662ad27394a4ca501
Fix tuple fallback expansionhttps://github.com/python/mypy/pull/3322/commits/ff786ca4760420c303c4847b379ec4e15d3781f5
ff786cahttps://github.com/python/mypy/pull/3322/commits/ff786ca4760420c303c4847b379ec4e15d3781f5
Fix tuple fallback expansion also for generic aliaseshttps://github.com/python/mypy/pull/3322/commits/e2f42373128fa21a13b2de910a199d74b8f269d9
e2f4237https://github.com/python/mypy/pull/3322/commits/e2f42373128fa21a13b2de910a199d74b8f269d9
Fix linthttps://github.com/python/mypy/pull/3322/commits/3e0ef985af7be4bc4eb27a7255ae0674a6c234d5
3e0ef98https://github.com/python/mypy/pull/3322/commits/3e0ef985af7be4bc4eb27a7255ae0674a6c234d5
Add testshttps://github.com/python/mypy/pull/3322/commits/310efe4e217cb31f99da9ac221ac21b3fd74691f
310efe4https://github.com/python/mypy/pull/3322/commits/310efe4e217cb31f99da9ac221ac21b3fd74691f
https://github.com/ilevkivskyi
Merge branch 'master' into fix-forward-crashhttps://github.com/python/mypy/pull/3322/commits/66c0c696843caa1c35bba501bbac4ab4044dfdc2
66c0c69https://github.com/python/mypy/pull/3322/commits/66c0c696843caa1c35bba501bbac4ab4044dfdc2
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
May 4, 2017https://github.com/python/mypy/pull/3322#issuecomment-299240435
Please reload this pagehttps://github.com/python/mypy/pull/3322
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
May 4, 2017https://github.com/python/mypy/pull/3322#event-1069787487
https://github.com/ilevkivskyi
Merge branch 'master' into fix-forward-crashhttps://github.com/python/mypy/pull/3322/commits/ce514d121fc8af7b195fe47c3d94644870783164
ce514d1https://github.com/python/mypy/pull/3322/commits/ce514d121fc8af7b195fe47c3d94644870783164
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
May 4, 2017https://github.com/python/mypy/pull/3322#issuecomment-299328397
Please reload this pagehttps://github.com/python/mypy/pull/3322
Please reload this pagehttps://github.com/python/mypy/pull/3322
join is not associative in the presence of unions #3339 https://github.com/python/mypy/issues/3339
Two crashes on recursive named tuples #3340 https://github.com/python/mypy/issues/3340
May 9, 2017 13:12https://github.com/python/mypy/pull/3322#commits-pushed-3a14a53
Revert some controversial changeshttps://github.com/python/mypy/pull/3322/commits/3a14a5365118b240d4f45973cf4d34d0d530da39
3a14a53https://github.com/python/mypy/pull/3322/commits/3a14a5365118b240d4f45973cf4d34d0d530da39
Add accidentally removed importhttps://github.com/python/mypy/pull/3322/commits/e30e994a45d4dcf9992644abe753a589379884c5
e30e994https://github.com/python/mypy/pull/3322/commits/e30e994a45d4dcf9992644abe753a589379884c5
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
May 9, 2017https://github.com/python/mypy/pull/3322#issuecomment-300134170
@JukkaLhttps://github.com/JukkaL
#3308https://github.com/python/mypy/issues/3308
Please reload this pagehttps://github.com/python/mypy/pull/3322
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
May 9, 2017https://github.com/python/mypy/pull/3322#event-1074628824
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
May 23, 2017 https://github.com/python/mypy/pull/3322#ref-issue-230608420
Crashes related to calling isinstance() on a NamedTuple #3419 https://github.com/python/mypy/issues/3419
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 23, 2017https://github.com/python/mypy/pull/3322#issuecomment-303468003
Please reload this pagehttps://github.com/python/mypy/pull/3322
https://github.com/ilevkivskyi
Merge branch 'master' into fix-forward-crashhttps://github.com/python/mypy/pull/3322/commits/57ca8f1db55140dd204fd06543e45f4ee2e0f627
57ca8f1https://github.com/python/mypy/pull/3322/commits/57ca8f1db55140dd204fd06543e45f4ee2e0f627
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
May 23, 2017https://github.com/python/mypy/pull/3322#issuecomment-303476969
Please reload this pagehttps://github.com/python/mypy/pull/3322
Fix typo in a test commenthttps://github.com/python/mypy/pull/3322/commits/32159cc07451b1a0ba797dab8823a4307a2c48ce
32159cchttps://github.com/python/mypy/pull/3322/commits/32159cc07451b1a0ba797dab8823a4307a2c48ce
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
May 24, 2017https://github.com/python/mypy/pull/3322#issuecomment-303757507
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/mypy/pull/3322
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 24, 2017 https://github.com/python/mypy/pull/3322#pullrequestreview-40116528
View reviewed changes https://github.com/python/mypy/pull/3322/files/32159cc07451b1a0ba797dab8823a4307a2c48ce
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/mypy/pull/3322#pullrequestreview-40116528
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3322
mypy/nodes.pyhttps://github.com/python/mypy/pull/3322/files/32159cc07451b1a0ba797dab8823a4307a2c48ce#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68
gvanrossumhttps://github.com/gvanrossum
May 24, 2017https://github.com/python/mypy/pull/3322#discussion_r118334534
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3322
ilevkivskyihttps://github.com/ilevkivskyi
May 24, 2017https://github.com/python/mypy/pull/3322#discussion_r118346774
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3322
mypy/semanal.pyhttps://github.com/python/mypy/pull/3322/files/32159cc07451b1a0ba797dab8823a4307a2c48ce#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
gvanrossumhttps://github.com/gvanrossum
May 24, 2017https://github.com/python/mypy/pull/3322#discussion_r118336954
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3322
mypy/semanal.pyhttps://github.com/python/mypy/pull/3322/files/32159cc07451b1a0ba797dab8823a4307a2c48ce#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
gvanrossumhttps://github.com/gvanrossum
May 24, 2017https://github.com/python/mypy/pull/3322#discussion_r118337368
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3322
ilevkivskyihttps://github.com/ilevkivskyi
May 24, 2017https://github.com/python/mypy/pull/3322#discussion_r118347898
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3322
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/3322/files/32159cc07451b1a0ba797dab8823a4307a2c48ce#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
gvanrossumhttps://github.com/gvanrossum
May 24, 2017https://github.com/python/mypy/pull/3322#discussion_r118338971
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3322
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/3322/files/32159cc07451b1a0ba797dab8823a4307a2c48ce#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
gvanrossumhttps://github.com/gvanrossum
May 24, 2017https://github.com/python/mypy/pull/3322#discussion_r118339353
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3322
ilevkivskyihttps://github.com/ilevkivskyi
May 24, 2017https://github.com/python/mypy/pull/3322#discussion_r118348371
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3322
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/3322/files/32159cc07451b1a0ba797dab8823a4307a2c48ce#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
gvanrossumhttps://github.com/gvanrossum
May 24, 2017https://github.com/python/mypy/pull/3322#discussion_r118339631
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3322
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/3322/files/32159cc07451b1a0ba797dab8823a4307a2c48ce#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
gvanrossumhttps://github.com/gvanrossum
May 24, 2017https://github.com/python/mypy/pull/3322#discussion_r118339887
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3322
https://github.com/ilevkivskyi
Address review commentshttps://github.com/python/mypy/pull/3322/commits/70e3f636eeda0f32b416eaedbe680fad3a93dc87
70e3f63https://github.com/python/mypy/pull/3322/commits/70e3f636eeda0f32b416eaedbe680fad3a93dc87
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
May 24, 2017https://github.com/python/mypy/pull/3322#issuecomment-303833481
Please reload this pagehttps://github.com/python/mypy/pull/3322
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/mypy/pull/3322
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 24, 2017https://github.com/python/mypy/pull/3322#issuecomment-303842124
Please reload this pagehttps://github.com/python/mypy/pull/3322
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
ccd95e6https://github.com/python/mypy/commit/ccd95e6adea3fcf8058a4bc1e99e0cea0623e9ee
May 24, 2017https://github.com/python/mypy/pull/3322#event-1096420729
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3322
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/mypy/pull/3322/files/32159cc07451b1a0ba797dab8823a4307a2c48ce
Please reload this pagehttps://github.com/python/mypy/pull/3322
Synthetic types are not processed in third pass https://github.com/python/mypy/issues/3308
Please reload this pagehttps://github.com/python/mypy/pull/3322
https://github.com/ilevkivskyi
https://github.com/JukkaL
https://github.com/gvanrossum
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.