René's URL Explorer Experiment


Title: Fixes to union simplification, isinstance and more (try 2) by JukkaL · Pull Request #3086 · python/mypy · GitHub

Open Graph Title: Fixes to union simplification, isinstance and more (try 2) by JukkaL · Pull Request #3086 · python/mypy

X Title: Fixes to union simplification, isinstance and more (try 2) by JukkaL · Pull Request #3086 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This is an updated version of #3025 with an extra fix for strict-optional mode.

X Description: This is an updated version of #3025 with an extra fix for strict-optional mode.

Opengraph URL: https://github.com/python/mypy/pull/3086

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6f647974-98a1-e24b-d98b-72e3e4602f48
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA546:7B498:1324B7F:18F8459:6B0005DD
html-safe-noncec234f56a65be7f9cb61dad2a7611709400011142955ae16689e9f6f32b711653
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTQ2OjdCNDk4OjEzMjRCN0Y6MThGODQ1OTo2QjAwMDVERCIsInZpc2l0b3JfaWQiOiIxNzA0MzY4MzE3NjMzOTIyNTI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4b0838b7a765e8d3d29fa5fd5c6d6c00eccff4803f3beec51dd303c182da8515
hovercard-subject-tagpull_request:113476899
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/3086/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2146ffee83742e1589013749815bfeba4dc8ec873b5d0b805a80ee2a7e9dcd3a/python/mypy/pull/3086
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2146ffee83742e1589013749815bfeba4dc8ec873b5d0b805a80ee2a7e9dcd3a/python/mypy/pull/3086
og:image:altThis is an updated version of #3025 with an extra fix for strict-optional mode.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJukkaL
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/3086#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3086
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3086
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/3086
Reloadhttps://github.com/python/mypy/pull/3086
Reloadhttps://github.com/python/mypy/pull/3086
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
masterhttps://github.com/python/mypy/tree/master
proper-subtype-2https://github.com/python/mypy/tree/proper-subtype-2
Conversationhttps://github.com/python/mypy/pull/3086
Commits11 (11)https://github.com/python/mypy/pull/3086/commits
Checkshttps://github.com/python/mypy/pull/3086/checks
Files changedhttps://github.com/python/mypy/pull/3086/files
Fixes to union simplification, isinstance and more (try 2)https://github.com/python/mypy/pull/3086#top
ilevkivskyihttps://github.com/ilevkivskyi
masterhttps://github.com/python/mypy/tree/master
proper-subtype-2https://github.com/python/mypy/tree/proper-subtype-2
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Mar 30, 2017https://github.com/python/mypy/pull/3086#issue-218262699
#3025https://github.com/python/mypy/pull/3025
Please reload this pagehttps://github.com/python/mypy/pull/3086
JukkaLhttps://github.com/JukkaL
March 30, 2017 10:58https://github.com/python/mypy/pull/3086#commits-pushed-bf20f49
https://github.com/JukkaL
Fixes to union simplification, isinstance and more (https://github.com/python/mypy/pull/3086/commits/bf20f4988250b5bd03f2b6afd159264ad27677f3
#3025https://github.com/python/mypy/pull/3025
)https://github.com/python/mypy/pull/3086/commits/bf20f4988250b5bd03f2b6afd159264ad27677f3
bf20f49https://github.com/python/mypy/pull/3086/commits/bf20f4988250b5bd03f2b6afd159264ad27677f3
#2978https://github.com/python/mypy/issues/2978
#1914https://github.com/python/mypy/issues/1914
https://github.com/JukkaL
Fix strict optional and partial type special case and fix testhttps://github.com/python/mypy/pull/3086/commits/603d371558f6cd083e8df7ce3bd5fa5b2d39b2db
603d371https://github.com/python/mypy/pull/3086/commits/603d371558f6cd083e8df7ce3bd5fa5b2d39b2db
https://github.com/JukkaL
Fix linthttps://github.com/python/mypy/pull/3086/commits/29a74f35a3d5a16299d771be9c1473306122b8a2
29a74f3https://github.com/python/mypy/pull/3086/commits/29a74f35a3d5a16299d771be9c1473306122b8a2
https://github.com/pkch
pkchhttps://github.com/pkch
Mar 31, 2017https://github.com/python/mypy/pull/3086#issuecomment-290670692
#3085https://github.com/python/mypy/issues/3085
#1850https://github.com/python/mypy/issues/1850
Please reload this pagehttps://github.com/python/mypy/pull/3086
https://github.com/JukkaL
Make is_subtype and is_proper_subtype do promotion the same wayhttps://github.com/python/mypy/pull/3086/commits/6f9ff36af05142ec48ec263d3ad828a874652803
6f9ff36https://github.com/python/mypy/pull/3086/commits/6f9ff36af05142ec48ec263d3ad828a874652803
#1850https://github.com/python/mypy/issues/1850
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Mar 31, 2017https://github.com/python/mypy/pull/3086#issuecomment-290698134
#1850https://github.com/python/mypy/issues/1850
Please reload this pagehttps://github.com/python/mypy/pull/3086
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Mar 31, 2017https://github.com/python/mypy/pull/3086#issuecomment-290844493
@ilevkivskyihttps://github.com/ilevkivskyi
#3025https://github.com/python/mypy/pull/3025
Please reload this pagehttps://github.com/python/mypy/pull/3086
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Mar 31, 2017https://github.com/python/mypy/pull/3086#issuecomment-290844850
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/mypy/pull/3086
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
March 31, 2017 22:16https://github.com/python/mypy/pull/3086#event-1024854172
gvanrossumhttps://github.com/gvanrossum
April 3, 2017 12:17https://github.com/python/mypy/pull/3086#commits-pushed-0951fdd
https://github.com/gvanrossum
Merge branch 'master' into proper-subtype-2https://github.com/python/mypy/pull/3086/commits/0951fdd5a46381c874e75ce97a8b45707b76e8c4
0951fddhttps://github.com/python/mypy/pull/3086/commits/0951fdd5a46381c874e75ce97a8b45707b76e8c4
https://github.com/gvanrossum
Drop reference to ErrorType (recently expunged)https://github.com/python/mypy/pull/3086/commits/d9b6e8192c10b3b8c3e1e175ee513420574a9d95
d9b6e81https://github.com/python/mypy/pull/3086/commits/d9b6e8192c10b3b8c3e1e175ee513420574a9d95
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Apr 3, 2017 https://github.com/python/mypy/pull/3086#pullrequestreview-30613194
View reviewed changes https://github.com/python/mypy/pull/3086/files/0951fdd5a46381c874e75ce97a8b45707b76e8c4
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/3086#pullrequestreview-30613194
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3086
test-data/unit/check-unions.testhttps://github.com/python/mypy/pull/3086/files/0951fdd5a46381c874e75ce97a8b45707b76e8c4#diff-b360c5af2e15a4304fb90f6686340f2303b5b960a7e30f6961d038d71fa75788
ilevkivskyihttps://github.com/ilevkivskyi
Apr 3, 2017https://github.com/python/mypy/pull/3086#discussion_r109506379
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#2861https://github.com/python/mypy/issues/2861
Please reload this pagehttps://github.com/python/mypy/pull/3086
JukkaLhttps://github.com/JukkaL
Apr 4, 2017https://github.com/python/mypy/pull/3086#discussion_r109679982
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3086
mypy/binder.pyhttps://github.com/python/mypy/pull/3086/files/0951fdd5a46381c874e75ce97a8b45707b76e8c4#diff-cec7c57fef20b803fc1c4e988ad3971b3597f1fd1b12db07b47f825046f264f5
ilevkivskyihttps://github.com/ilevkivskyi
Apr 3, 2017https://github.com/python/mypy/pull/3086#discussion_r109508267
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3086
JukkaLhttps://github.com/JukkaL
Apr 4, 2017https://github.com/python/mypy/pull/3086#discussion_r109680106
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3086
test-data/unit/check-optional.testhttps://github.com/python/mypy/pull/3086/files/0951fdd5a46381c874e75ce97a8b45707b76e8c4#diff-a6528e88debcf57f7c356e9877b88fb63e975a876e134eb2c6fa2e733a4f27bc
ilevkivskyihttps://github.com/ilevkivskyi
Apr 3, 2017https://github.com/python/mypy/pull/3086#discussion_r109508889
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3086
JukkaLhttps://github.com/JukkaL
Apr 4, 2017https://github.com/python/mypy/pull/3086#discussion_r109680726
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3086
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Apr 3, 2017https://github.com/python/mypy/pull/3086#issuecomment-291256808
Please reload this pagehttps://github.com/python/mypy/pull/3086
gvanrossumhttps://github.com/gvanrossum
April 3, 2017 13:15https://github.com/python/mypy/pull/3086#commits-pushed-f4aebad
https://github.com/gvanrossum
Fix merge mistakehttps://github.com/python/mypy/pull/3086/commits/f4aebadb52f0f4fbc6980914ed328ee24bde7ffd
f4aebadhttps://github.com/python/mypy/pull/3086/commits/f4aebadb52f0f4fbc6980914ed328ee24bde7ffd
https://github.com/gvanrossum
Fix another merge mistakehttps://github.com/python/mypy/pull/3086/commits/69990cebe69357223b78f29c58e128d23e6811ee
69990cehttps://github.com/python/mypy/pull/3086/commits/69990cebe69357223b78f29c58e128d23e6811ee
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Apr 3, 2017https://github.com/python/mypy/pull/3086#issuecomment-291322641
Please reload this pagehttps://github.com/python/mypy/pull/3086
JukkaLhttps://github.com/JukkaL
April 4, 2017 15:34https://github.com/python/mypy/pull/3086#commits-pushed-d372618
https://github.com/JukkaL
Update based on reviewhttps://github.com/python/mypy/pull/3086/commits/d3726187faeb40015b5df61a48654a7f42731487
d372618https://github.com/python/mypy/pull/3086/commits/d3726187faeb40015b5df61a48654a7f42731487
https://github.com/JukkaL
Add test casehttps://github.com/python/mypy/pull/3086/commits/2f348d2c75355d819218bc6b3319b3f296fb3e2f
2f348d2https://github.com/python/mypy/pull/3086/commits/2f348d2c75355d819218bc6b3319b3f296fb3e2f
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Apr 4, 2017 https://github.com/python/mypy/pull/3086#pullrequestreview-30800810
View reviewed changes https://github.com/python/mypy/pull/3086/files/2f348d2c75355d819218bc6b3319b3f296fb3e2f
test-data/unit/check-unions.testhttps://github.com/python/mypy/pull/3086/files/d3726187faeb40015b5df61a48654a7f42731487..2f348d2c75355d819218bc6b3319b3f296fb3e2f#diff-b360c5af2e15a4304fb90f6686340f2303b5b960a7e30f6961d038d71fa75788
ilevkivskyihttps://github.com/ilevkivskyi
Apr 4, 2017https://github.com/python/mypy/pull/3086#discussion_r109682923
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3086
JukkaLhttps://github.com/JukkaL
Apr 4, 2017https://github.com/python/mypy/pull/3086#discussion_r109686973
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3086
https://github.com/JukkaL
Fix redundant TODO due to copy pastehttps://github.com/python/mypy/pull/3086/commits/e1d97a2ecaa6cec670e8361d500462f70c4d7778
e1d97a2https://github.com/python/mypy/pull/3086/commits/e1d97a2ecaa6cec670e8361d500462f70c4d7778
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Apr 4, 2017https://github.com/python/mypy/pull/3086#issuecomment-291545558
Please reload this pagehttps://github.com/python/mypy/pull/3086
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Apr 4, 2017https://github.com/python/mypy/pull/3086#issuecomment-291547565
Please reload this pagehttps://github.com/python/mypy/pull/3086
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
4141d20https://github.com/python/mypy/commit/4141d2039c709f3a8e591fa35a560e54c4e203d2
Apr 4, 2017https://github.com/python/mypy/pull/3086#event-1028699430
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
April 4, 2017 16:05https://github.com/python/mypy/pull/3086#event-1028699676
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Apr 4, 2017 https://github.com/python/mypy/pull/3086#ref-issue-207322200
Discrepancy between context and inferred type for list display in context containing complicated unions #2861 https://github.com/python/mypy/issues/2861
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
May 2, 2017 https://github.com/python/mypy/pull/3086#ref-issue-171548775
Processing of Callables in make_simplified_union is order dependent #2031 https://github.com/python/mypy/issues/2031
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 30, 2017 https://github.com/python/mypy/pull/3086#ref-issue-232061587
Any apparently not considered part of Union[Any, builtins.None] #3472 https://github.com/python/mypy/issues/3472
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
Jun 15, 2018 https://github.com/python/mypy/pull/3086#ref-issue-176833190
Inconsistency with unions and overloads in when checking overlapping op methods #2129 https://github.com/python/mypy/issues/2129
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3086
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/3086/files/2f348d2c75355d819218bc6b3319b3f296fb3e2f
Please reload this pagehttps://github.com/python/mypy/pull/3086
Please reload this pagehttps://github.com/python/mypy/pull/3086
https://github.com/JukkaL
https://github.com/pkch
https://github.com/gvanrossum
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.