René's URL Explorer Experiment


Title: [Reverted] Fixes to union simplification, isinstance and more by JukkaL · Pull Request #3025 · python/mypy · GitHub

Open Graph Title: [Reverted] Fixes to union simplification, isinstance and more by JukkaL · Pull Request #3025 · python/mypy

X Title: [Reverted] Fixes to union simplification, isinstance and more by JukkaL · Pull Request #3025 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: The main change is that unions containing Any are no longer simplified to just Any. Use proper subtype check for union simplification and implement proper subtype checks more fully. This required c...

X Description: The main change is that unions containing Any are no longer simplified to just Any. Use proper subtype check for union simplification and implement proper subtype checks more fully. This required c...

Opengraph URL: https://github.com/python/mypy/pull/3025

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8af64595-1812-b133-c304-c579d2817f31
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id896C:CEC0A:2769F77:33A87D3:6B000372
html-safe-nonce3242c8f9e329884616f6bda1b0bd480128b4cd476a5898aa186c1557f3608d06
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTZDOkNFQzBBOjI3NjlGNzc6MzNBODdEMzo2QjAwMDM3MiIsInZpc2l0b3JfaWQiOiI0MTczOTUxNDgzMjE5MjgwNzU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaceb4600be49337a1d07dd362afd9e65b63da11e5aaf76e25996f478fccb28c42a
hovercard-subject-tagpull_request:111432086
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/3025/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bb76b0d67d8abf8e99e8915a00fcc713853ba9e0a75b0b3c4370189171084e85/python/mypy/pull/3025
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bb76b0d67d8abf8e99e8915a00fcc713853ba9e0a75b0b3c4370189171084e85/python/mypy/pull/3025
og:image:altThe main change is that unions containing Any are no longer simplified to just Any. Use proper subtype check for union simplification and implement proper subtype checks more fully. This required c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJukkaL
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/3025#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3025
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3025
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/3025
Reloadhttps://github.com/python/mypy/pull/3025
Reloadhttps://github.com/python/mypy/pull/3025
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
JukkaLhttps://github.com/JukkaL
masterhttps://github.com/python/mypy/tree/master
proper-subtypehttps://github.com/python/mypy/tree/proper-subtype
Conversationhttps://github.com/python/mypy/pull/3025
Commits19 (19)https://github.com/python/mypy/pull/3025/commits
Checkshttps://github.com/python/mypy/pull/3025/checks
Files changedhttps://github.com/python/mypy/pull/3025/files
[Reverted] Fixes to union simplification, isinstance and morehttps://github.com/python/mypy/pull/3025#top
JukkaLhttps://github.com/JukkaL
masterhttps://github.com/python/mypy/tree/master
proper-subtypehttps://github.com/python/mypy/tree/proper-subtype
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Mar 19, 2017https://github.com/python/mypy/pull/3025#issue-215232675
#1914https://github.com/python/mypy/issues/1914
#2978https://github.com/python/mypy/issues/2978
Please reload this pagehttps://github.com/python/mypy/pull/3025
JukkaLhttps://github.com/JukkaL
March 20, 2017 10:44https://github.com/python/mypy/pull/3025#commits-pushed-c53e0ca
https://github.com/JukkaL
Fixes to union simplification and isinstancehttps://github.com/python/mypy/pull/3025/commits/c53e0ca4b6baecead00365911ffe6a412fcef795
c53e0cahttps://github.com/python/mypy/pull/3025/commits/c53e0ca4b6baecead00365911ffe6a412fcef795
https://github.com/JukkaL
Fixhttps://github.com/python/mypy/pull/3025/commits/dc62a998f20d38351c1c806f09c2a13b32f09ba7
#2978https://github.com/python/mypy/issues/2978
.https://github.com/python/mypy/pull/3025/commits/dc62a998f20d38351c1c806f09c2a13b32f09ba7
dc62a99https://github.com/python/mypy/pull/3025/commits/dc62a998f20d38351c1c806f09c2a13b32f09ba7
https://github.com/JukkaL
Add test casehttps://github.com/python/mypy/pull/3025/commits/07d64f5c9cb98e89754bd5e5104e76fd71c280f3
07d64f5https://github.com/python/mypy/pull/3025/commits/07d64f5c9cb98e89754bd5e5104e76fd71c280f3
#1914https://github.com/python/mypy/issues/1914
https://github.com/JukkaL
Fix test failureshttps://github.com/python/mypy/pull/3025/commits/0beffeef1f258366da3ce3e560fd194334c62934
0beffeehttps://github.com/python/mypy/pull/3025/commits/0beffeef1f258366da3ce3e560fd194334c62934
https://github.com/JukkaL
Fix meet of a broken named tuple and a good named tuplehttps://github.com/python/mypy/pull/3025/commits/e3ff2c7864b63cfe6f415b7396ca535d8813cb75
e3ff2c7https://github.com/python/mypy/pull/3025/commits/e3ff2c7864b63cfe6f415b7396ca535d8813cb75
https://github.com/JukkaL
Fix erasing union typeshttps://github.com/python/mypy/pull/3025/commits/4cb86738d814b01b75666f902a08eaa443f361f8
4cb8673https://github.com/python/mypy/pull/3025/commits/4cb86738d814b01b75666f902a08eaa443f361f8
https://github.com/JukkaL
Remove references to Voidhttps://github.com/python/mypy/pull/3025/commits/fc57a76ec1c3a8b50e100c429dc6ba9c1c9e07bb
fc57a76https://github.com/python/mypy/pull/3025/commits/fc57a76ec1c3a8b50e100c429dc6ba9c1c9e07bb
https://github.com/JukkaL
Proper subtype checks use type promotionshttps://github.com/python/mypy/pull/3025/commits/9cf911466a6016c66de080672b03fb0f346e97b1
9cf9114https://github.com/python/mypy/pull/3025/commits/9cf911466a6016c66de080672b03fb0f346e97b1
https://github.com/JukkaL
Don't call union simplification during semantic analysishttps://github.com/python/mypy/pull/3025/commits/d406157f649aad993e256941cb3119b61bf52c28
d406157https://github.com/python/mypy/pull/3025/commits/d406157f649aad993e256941cb3119b61bf52c28
https://github.com/JukkaL
Add union simplification test caseshttps://github.com/python/mypy/pull/3025/commits/d745a50e7283eaadbc6e91e1e6939efee8769c3d
d745a50https://github.com/python/mypy/pull/3025/commits/d745a50e7283eaadbc6e91e1e6939efee8769c3d
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
force-pushedhttps://github.com/python/mypy/compare/a6c0ff470d831edfeb60ae0296187e94603868e0..d745a50e7283eaadbc6e91e1e6939efee8769c3d
a6c0ff4https://github.com/python/mypy/commit/a6c0ff470d831edfeb60ae0296187e94603868e0
d745a50https://github.com/python/mypy/commit/d745a50e7283eaadbc6e91e1e6939efee8769c3d
Compare https://github.com/python/mypy/compare/a6c0ff470d831edfeb60ae0296187e94603868e0..d745a50e7283eaadbc6e91e1e6939efee8769c3d
March 21, 2017 22:25https://github.com/python/mypy/pull/3025#event-1009505984
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Mar 21, 2017 https://github.com/python/mypy/pull/3025#pullrequestreview-28255467
View reviewed changes https://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d
mypy/subtypes.pyhttps://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d#diff-3641fc675bdf772ec816dbb1b8ef258e9f07c15f604d83d7549bf7b873757a54
ilevkivskyihttps://github.com/ilevkivskyi
Mar 21, 2017https://github.com/python/mypy/pull/3025#discussion_r107291806
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Mar 21, 2017 https://github.com/python/mypy/pull/3025#ref-pullrequest-201901753
Fix make_simplified_union interaction with Any #2714 https://github.com/python/mypy/pull/2714
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Mar 21, 2017 https://github.com/python/mypy/pull/3025#pullrequestreview-28257948
View reviewed changes https://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d
test-data/unit/check-unions.testhttps://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d#diff-b360c5af2e15a4304fb90f6686340f2303b5b960a7e30f6961d038d71fa75788
ilevkivskyihttps://github.com/ilevkivskyi
Mar 21, 2017https://github.com/python/mypy/pull/3025#discussion_r107294246
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#3012https://github.com/python/mypy/pull/3012
Please reload this pagehttps://github.com/python/mypy/pull/3025
JukkaLhttps://github.com/JukkaL
Mar 29, 2017https://github.com/python/mypy/pull/3025#discussion_r108750635
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Mar 21, 2017 https://github.com/python/mypy/pull/3025#pullrequestreview-28258742
View reviewed changes https://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d
test-data/unit/check-optional.testhttps://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d#diff-a6528e88debcf57f7c356e9877b88fb63e975a876e134eb2c6fa2e733a4f27bc
ilevkivskyihttps://github.com/ilevkivskyi
Mar 21, 2017https://github.com/python/mypy/pull/3025#discussion_r107295091
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
ilevkivskyihttps://github.com/ilevkivskyi
Mar 21, 2017https://github.com/python/mypy/pull/3025#discussion_r107295697
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Mar 21, 2017 https://github.com/python/mypy/pull/3025#pullrequestreview-28260812
View reviewed changes https://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d
mypy/subtypes.pyhttps://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d#diff-3641fc675bdf772ec816dbb1b8ef258e9f07c15f604d83d7549bf7b873757a54
ilevkivskyihttps://github.com/ilevkivskyi
Mar 21, 2017https://github.com/python/mypy/pull/3025#discussion_r107297168
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
gvanrossumhttps://github.com/gvanrossum
Mar 22, 2017https://github.com/python/mypy/pull/3025#discussion_r107479909
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Mar 22, 2017 https://github.com/python/mypy/pull/3025#pullrequestreview-28423748
View reviewed changes https://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d
mypy/subtypes.pyhttps://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d#diff-3641fc675bdf772ec816dbb1b8ef258e9f07c15f604d83d7549bf7b873757a54
gvanrossumhttps://github.com/gvanrossum
Mar 22, 2017https://github.com/python/mypy/pull/3025#discussion_r107450616
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
mypy/subtypes.pyhttps://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d#diff-3641fc675bdf772ec816dbb1b8ef258e9f07c15f604d83d7549bf7b873757a54
gvanrossumhttps://github.com/gvanrossum
Mar 22, 2017https://github.com/python/mypy/pull/3025#discussion_r107451644
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
mypy/typeanal.pyhttps://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d#diff-cb65de0aabb09922bb9dca4a4221ac0ca58f6fa26b6fa2a74ac4a9e6fd3d8136
gvanrossumhttps://github.com/gvanrossum
Mar 22, 2017https://github.com/python/mypy/pull/3025#discussion_r107462045
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
mypy/subtypes.pyhttps://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d#diff-3641fc675bdf772ec816dbb1b8ef258e9f07c15f604d83d7549bf7b873757a54
gvanrossumhttps://github.com/gvanrossum
Mar 22, 2017https://github.com/python/mypy/pull/3025#discussion_r107474410
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
mypy/subtypes.pyhttps://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d#diff-3641fc675bdf772ec816dbb1b8ef258e9f07c15f604d83d7549bf7b873757a54
gvanrossumhttps://github.com/gvanrossum
Mar 22, 2017https://github.com/python/mypy/pull/3025#discussion_r107474497
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
test-data/unit/check-namedtuple.testhttps://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d#diff-1e9c665830a34676d60b21b5d56768c9d545fbc3b67ba76c9e3b79a87281dd5c
gvanrossumhttps://github.com/gvanrossum
Mar 22, 2017https://github.com/python/mypy/pull/3025#discussion_r107487601
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
JukkaLhttps://github.com/JukkaL
Mar 24, 2017https://github.com/python/mypy/pull/3025#discussion_r107913663
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#3054https://github.com/python/mypy/issues/3054
Please reload this pagehttps://github.com/python/mypy/pull/3025
test-data/unit/check-optional.testhttps://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d#diff-a6528e88debcf57f7c356e9877b88fb63e975a876e134eb2c6fa2e733a4f27bc
gvanrossumhttps://github.com/gvanrossum
Mar 22, 2017https://github.com/python/mypy/pull/3025#discussion_r107488243
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
test-data/unit/check-optional.testhttps://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d#diff-a6528e88debcf57f7c356e9877b88fb63e975a876e134eb2c6fa2e733a4f27bc
gvanrossumhttps://github.com/gvanrossum
Mar 22, 2017https://github.com/python/mypy/pull/3025#discussion_r107488385
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
test-data/unit/check-optional.testhttps://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d#diff-a6528e88debcf57f7c356e9877b88fb63e975a876e134eb2c6fa2e733a4f27bc
gvanrossumhttps://github.com/gvanrossum
Mar 22, 2017https://github.com/python/mypy/pull/3025#discussion_r107488750
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
test-data/unit/check-optional.testhttps://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d#diff-a6528e88debcf57f7c356e9877b88fb63e975a876e134eb2c6fa2e733a4f27bc
gvanrossumhttps://github.com/gvanrossum
Mar 22, 2017https://github.com/python/mypy/pull/3025#discussion_r107489199
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
JukkaLhttps://github.com/JukkaL
March 24, 2017 16:57https://github.com/python/mypy/pull/3025#commits-pushed-a638e72
https://github.com/JukkaL
Address review feedbackhttps://github.com/python/mypy/pull/3025/commits/a638e72c81bd9c0359a8d4bf1d622e49b16b1281
a638e72https://github.com/python/mypy/pull/3025/commits/a638e72c81bd9c0359a8d4bf1d622e49b16b1281
https://github.com/JukkaL
Fix test case failureshttps://github.com/python/mypy/pull/3025/commits/ca511d8632e8652336109e66056e6b004758e982
ca511d8https://github.com/python/mypy/pull/3025/commits/ca511d8632e8652336109e66056e6b004758e982
https://github.com/JukkaL
Flatten Optional[Union[...]] typeshttps://github.com/python/mypy/pull/3025/commits/807924cb7d2a0a0dc14a2f75d23cde9617a2fa32
807924chttps://github.com/python/mypy/pull/3025/commits/807924cb7d2a0a0dc14a2f75d23cde9617a2fa32
https://github.com/JukkaL
Add TODO comment about make_simplified_unionhttps://github.com/python/mypy/pull/3025/commits/ef46cfadad687ccd7ffc78f6324fe61263c98924
ef46cfahttps://github.com/python/mypy/pull/3025/commits/ef46cfadad687ccd7ffc78f6324fe61263c98924
https://github.com/JukkaL
Add test casehttps://github.com/python/mypy/pull/3025/commits/6cd09f1f0873c3d40da15e4cabbc534fbbf072db
6cd09f1https://github.com/python/mypy/pull/3025/commits/6cd09f1f0873c3d40da15e4cabbc534fbbf072db
https://github.com/JukkaL
Partially address comments about type object typeshttps://github.com/python/mypy/pull/3025/commits/39f94a17bcfe4d08667c9fc3a4707486e8dafe52
39f94a1https://github.com/python/mypy/pull/3025/commits/39f94a17bcfe4d08667c9fc3a4707486e8dafe52
https://github.com/JukkaL
Fixes to TypedDict proper subtype checks + add testshttps://github.com/python/mypy/pull/3025/commits/0826cc3c4ab708771716e1170376f3f3531cbb84
0826cc3https://github.com/python/mypy/pull/3025/commits/0826cc3c4ab708771716e1170376f3f3531cbb84
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Mar 27, 2017 https://github.com/python/mypy/pull/3025#ref-issue-217334841
We lose information on assigning a type object to a variable #3067 https://github.com/python/mypy/issues/3067
https://github.com/JukkaL
Merge branch 'master' into proper-subtypehttps://github.com/python/mypy/pull/3025/commits/baafcd1b8ad77eeb7875c236356030d5d7b90455
baafcd1https://github.com/python/mypy/pull/3025/commits/baafcd1b8ad77eeb7875c236356030d5d7b90455
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Mar 28, 2017 https://github.com/python/mypy/pull/3025#pullrequestreview-29217478
View reviewed changes https://github.com/python/mypy/pull/3025/files/0826cc3c4ab708771716e1170376f3f3531cbb84
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/mypy/pull/3025#pullrequestreview-29217478
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
test-data/unit/check-isinstance.testhttps://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d..0826cc3c4ab708771716e1170376f3f3531cbb84#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb
gvanrossumhttps://github.com/gvanrossum
Mar 27, 2017https://github.com/python/mypy/pull/3025#discussion_r108200839
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
JukkaLhttps://github.com/JukkaL
Mar 29, 2017https://github.com/python/mypy/pull/3025#discussion_r108747184
Please reload this pagehttps://github.com/python/mypy/pull/3025
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
test-data/unit/check-isinstance.testhttps://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d..0826cc3c4ab708771716e1170376f3f3531cbb84#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb
gvanrossumhttps://github.com/gvanrossum
Mar 27, 2017https://github.com/python/mypy/pull/3025#discussion_r108202891
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
JukkaLhttps://github.com/JukkaL
Mar 29, 2017https://github.com/python/mypy/pull/3025#discussion_r108747497
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/3025
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Mar 28, 2017 https://github.com/python/mypy/pull/3025#ref-issue-217629452
Union doesn't simplify arguments in isinstance #3073 https://github.com/python/mypy/issues/3073
https://github.com/pkch
pkchhttps://github.com/pkch
Mar 28, 2017 https://github.com/python/mypy/pull/3025#pullrequestreview-29521643
View reviewed changes https://github.com/python/mypy/pull/3025/files/0826cc3c4ab708771716e1170376f3f3531cbb84
mypy/subtypes.pyhttps://github.com/python/mypy/pull/3025/files/0826cc3c4ab708771716e1170376f3f3531cbb84#diff-3641fc675bdf772ec816dbb1b8ef258e9f07c15f604d83d7549bf7b873757a54
pkchhttps://github.com/pkch
Mar 28, 2017https://github.com/python/mypy/pull/3025#discussion_r108487440
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#3069https://github.com/python/mypy/issues/3069
Please reload this pagehttps://github.com/python/mypy/pull/3025
JukkaLhttps://github.com/JukkaL
Mar 29, 2017https://github.com/python/mypy/pull/3025#discussion_r108748474
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#3054https://github.com/python/mypy/issues/3054
Please reload this pagehttps://github.com/python/mypy/pull/3025
https://github.com/pkch
pkchhttps://github.com/pkch
Mar 28, 2017 https://github.com/python/mypy/pull/3025#ref-issue-217423181
Foo and Union[Foo, bool] fail to unify, when working with NamedTuple and recursively typed values #3069 https://github.com/python/mypy/issues/3069
https://github.com/JukkaL
Merge branch 'master' into proper-subtypehttps://github.com/python/mypy/pull/3025/commits/a06b41c309ff3ac06d0d3a1f670045203e69e232
a06b41chttps://github.com/python/mypy/pull/3025/commits/a06b41c309ff3ac06d0d3a1f670045203e69e232
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
67cda6ehttps://github.com/python/mypy/commit/67cda6e5ea5bb79b536f47946c90cf9f59faac87
Mar 29, 2017https://github.com/python/mypy/pull/3025#event-1020968249
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
March 29, 2017 18:28https://github.com/python/mypy/pull/3025#event-1020969389
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Mar 29, 2017https://github.com/python/mypy/pull/3025#issuecomment-290182008
Please reload this pagehttps://github.com/python/mypy/pull/3025
JukkaLhttps://github.com/JukkaL
Mar 29, 2017 https://github.com/python/mypy/pull/3025#ref-commit-f24089b
https://github.com/JukkaL
Revert "Fixes to union simplification, isinstance and more (https://github.com/python/mypy/commit/f24089b45e253de6545214853d68e57f76074876
#3025https://github.com/python/mypy/pull/3025
)"https://github.com/python/mypy/commit/f24089b45e253de6545214853d68e57f76074876
f24089bhttps://github.com/python/mypy/commit/f24089b45e253de6545214853d68e57f76074876
67cda6ehttps://github.com/python/mypy/commit/67cda6e5ea5bb79b536f47946c90cf9f59faac87
gvanrossumhttps://github.com/gvanrossum
Mar 29, 2017 https://github.com/python/mypy/pull/3025#ref-commit-7f3f67c
https://github.com/JukkaL
https://github.com/gvanrossum
Revert "Fixes to union simplification, isinstance and more (https://github.com/python/mypy/commit/7f3f67cd3b795f9d7ba4a153c906d36a79af0edc
#3025https://github.com/python/mypy/pull/3025
)" (https://github.com/python/mypy/commit/7f3f67cd3b795f9d7ba4a153c906d36a79af0edc
#…https://github.com/python/mypy/pull/3080
7f3f67chttps://github.com/python/mypy/commit/7f3f67cd3b795f9d7ba4a153c906d36a79af0edc
…3080https://github.com/python/mypy/pull/3080
67cda6ehttps://github.com/python/mypy/commit/67cda6e5ea5bb79b536f47946c90cf9f59faac87
Strip type objects when constructing TypeType #2832 https://github.com/python/mypy/pull/2832
Certain order of union members causes Incompatible types error #3085 https://github.com/python/mypy/issues/3085
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Mar 30, 2017https://github.com/python/mypy/pull/3025#event-1021566965
JukkaLhttps://github.com/JukkaL
Mar 30, 2017 https://github.com/python/mypy/pull/3025#ref-commit-bf20f49
https://github.com/JukkaL
Fixes to union simplification, isinstance and more (https://github.com/python/mypy/commit/bf20f4988250b5bd03f2b6afd159264ad27677f3
#3025https://github.com/python/mypy/pull/3025
)https://github.com/python/mypy/commit/bf20f4988250b5bd03f2b6afd159264ad27677f3
bf20f49https://github.com/python/mypy/commit/bf20f4988250b5bd03f2b6afd159264ad27677f3
#2978https://github.com/python/mypy/issues/2978
#1914https://github.com/python/mypy/issues/1914
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Mar 30, 2017 https://github.com/python/mypy/pull/3025#ref-pullrequest-218262699
Fixes to union simplification, isinstance and more (try 2) #3086 https://github.com/python/mypy/pull/3086
ilevkivskyihttps://github.com/ilevkivskyi
Apr 4, 2017 https://github.com/python/mypy/pull/3025#ref-commit-4141d20
https://github.com/JukkaL
https://github.com/ilevkivskyi
Fixes to union simplification, isinstance and more (try 2) (https://github.com/python/mypy/commit/4141d2039c709f3a8e591fa35a560e54c4e203d2
#3086https://github.com/python/mypy/pull/3086
)https://github.com/python/mypy/commit/4141d2039c709f3a8e591fa35a560e54c4e203d2
4141d20https://github.com/python/mypy/commit/4141d2039c709f3a8e591fa35a560e54c4e203d2
#3025https://github.com/python/mypy/pull/3025
#2978https://github.com/python/mypy/issues/2978
#1914https://github.com/python/mypy/issues/1914
#1850https://github.com/python/mypy/issues/1850
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3025
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/mypy/pull/3025/files/0826cc3c4ab708771716e1170376f3f3531cbb84
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/3025/files/d745a50e7283eaadbc6e91e1e6939efee8769c3d
https://github.com/pkch
pkch https://github.com/pkch
https://github.com/python/mypy/pull/3025/files/0826cc3c4ab708771716e1170376f3f3531cbb84
Please reload this pagehttps://github.com/python/mypy/pull/3025
Please reload this pagehttps://github.com/python/mypy/pull/3025
https://github.com/JukkaL
https://github.com/gvanrossum
https://github.com/pkch
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.