| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:62e36417-2114-f4ae-bfee-2e0a091db405 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9E5C:5314B:2AC5C57:383B078:6B001535 |
| html-safe-nonce | 33be148bb48b9f4ae7f825264331c2bf1e9f6437eafffcb4bb7229afba3acd90 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTVDOjUzMTRCOjJBQzVDNTc6MzgzQjA3ODo2QjAwMTUzNSIsInZpc2l0b3JfaWQiOiI0NzI4MTg4NTUwMDE5ODE0NzA5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 50e08a7bacfe4ebd86e5389a8a0995838f5e788203e5743b2d7cc29d5b03f7cd |
| hovercard-subject-tag | pull_request:110771259 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/3005/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/235111dac545d49511b57040884b1d70c3c748a04558470d417e4addd569860f/python/mypy/pull/3005 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/235111dac545d49511b57040884b1d70c3c748a04558470d417e4addd569860f/python/mypy/pull/3005 |
| og:image:alt | Fixes #2909
This PR includes a few commits from other PRs that haven't been merged in yet; I'll squash and fix any merge conflicts after the other PRs are merged in.
The only commits that a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | pkch |
| hostname | github.com |
| expected-hostname | github.com |
| None | a2dd2291b1b13cc9c06f27ec92fa3dbaf34116fc24c9347b8539db61884c59f4 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 70121d4e855ee0bb7b75cf15d061d91f8863c0f8 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/3005#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3005 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3005 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/3005 |
| Reload | https://github.com/python/mypy/pull/3005 |
| Reload | https://github.com/python/mypy/pull/3005 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| pkch:issubclass | https://github.com/pkch/mypy/tree/issubclass |
| Conversation | https://github.com/python/mypy/pull/3005 |
| Commits16 (16) | https://github.com/python/mypy/pull/3005/commits |
| Checks | https://github.com/python/mypy/pull/3005/checks |
| Files changed | https://github.com/python/mypy/pull/3005/files |
| Infer types from issubclass() calls | https://github.com/python/mypy/pull/3005#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| pkch:issubclass | https://github.com/pkch/mypy/tree/issubclass |
|
| https://github.com/pkch |
| pkch | https://github.com/pkch |
| Mar 15, 2017 | https://github.com/python/mypy/pull/3005#issue-214284773 |
| #2909 | https://github.com/python/mypy/issues/2909 |
| a4db99e | https://github.com/python/mypy/commit/a4db99eb17332470f933f68db262f6a95d9629fb |
| fe27fda | https://github.com/python/mypy/commit/fe27fdaf86bae719903a67dc6253fa3beab9e2fb |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Mar 18, 2017
| https://github.com/python/mypy/pull/3005#pullrequestreview-27722404 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3005/files |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/3005#pullrequestreview-27722404 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| mypy/checker.py | https://github.com/python/mypy/pull/3005/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 18, 2017 | https://github.com/python/mypy/pull/3005#discussion_r106778952 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| mypy/checker.py | https://github.com/python/mypy/pull/3005/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 18, 2017 | https://github.com/python/mypy/pull/3005#discussion_r106778972 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| mypy/checker.py | https://github.com/python/mypy/pull/3005/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 18, 2017 | https://github.com/python/mypy/pull/3005#discussion_r106778998 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| pkch | https://github.com/pkch |
| Mar 20, 2017 | https://github.com/python/mypy/pull/3005#discussion_r106847277 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| mypy/checker.py | https://github.com/python/mypy/pull/3005/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 18, 2017 | https://github.com/python/mypy/pull/3005#discussion_r106779110 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| pkch | https://github.com/pkch |
| Mar 18, 2017 | https://github.com/python/mypy/pull/3005#discussion_r106787676 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 19, 2017 | https://github.com/python/mypy/pull/3005#discussion_r106821763 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| pkch | https://github.com/pkch |
| Mar 20, 2017 | https://github.com/python/mypy/pull/3005#discussion_r106850414 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #3037 | https://github.com/python/mypy/issues/3037 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| test-data/unit/fixtures/isinstancelist.pyi | https://github.com/python/mypy/pull/3005/files#diff-45bdb112d44b19cdd3d2811845265ed9d1c2d5ead67d6a57892b0dd9fa202646 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 18, 2017 | https://github.com/python/mypy/pull/3005#discussion_r106779191 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| mypy/semanal.py | https://github.com/python/mypy/pull/3005/files#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 18, 2017 | https://github.com/python/mypy/pull/3005#discussion_r106779405 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| pkch | https://github.com/pkch |
| Mar 18, 2017 | https://github.com/python/mypy/pull/3005#discussion_r106788906 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #2999 | https://github.com/python/mypy/issues/2999 |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 21, 2017 | https://github.com/python/mypy/pull/3005#discussion_r107137369 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| test-data/unit/check-isinstance.test | https://github.com/python/mypy/pull/3005/files#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 18, 2017 | https://github.com/python/mypy/pull/3005#discussion_r106779507 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| test-data/unit/check-isinstance.test | https://github.com/python/mypy/pull/3005/files#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 18, 2017 | https://github.com/python/mypy/pull/3005#discussion_r106779564 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| test-data/unit/check-isinstance.test | https://github.com/python/mypy/pull/3005/files#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 18, 2017 | https://github.com/python/mypy/pull/3005#discussion_r106779609 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| test-data/unit/check-isinstance.test | https://github.com/python/mypy/pull/3005/files#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 18, 2017 | https://github.com/python/mypy/pull/3005#discussion_r106779639 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Mar 18, 2017
| https://github.com/python/mypy/pull/3005#ref-pullrequest-214059417 |
|
Fix inference logic for isinstance
#2997
| https://github.com/python/mypy/pull/2997 |
| https://github.com/pkch |
| pkch | https://github.com/pkch |
| Mar 19, 2017 | https://github.com/python/mypy/pull/3005#issuecomment-287602879 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| @ilevkivskyi | https://github.com/ilevkivskyi |
| #3005 (comment) | https://github.com/python/mypy/pull/3005#discussion_r106779110 |
| #2995 | https://github.com/python/mypy/pull/2995 |
| #2997 | https://github.com/python/mypy/pull/2997 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 19, 2017 | https://github.com/python/mypy/pull/3005#issuecomment-287655529 |
| @pkch | https://github.com/pkch |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| pkch | https://github.com/pkch |
| March 20, 2017 00:59 | https://github.com/python/mypy/pull/3005#commits-pushed-158c889 |
|
| https://github.com/pkch |
| Make no inference when variables present in second argument to isinst… | https://github.com/python/mypy/pull/3005/commits/158c88961865c3c24653ddb85704897702781975 |
| 158c889 | https://github.com/python/mypy/pull/3005/commits/158c88961865c3c24653ddb85704897702781975 |
|
| https://github.com/pkch |
| Add failing unit tests | https://github.com/python/mypy/pull/3005/commits/c5525bd2b6f89c79d20c37b386d2031b190eed3e |
| c5525bd | https://github.com/python/mypy/pull/3005/commits/c5525bd2b6f89c79d20c37b386d2031b190eed3e |
|
| https://github.com/pkch |
| Infer type from issubclass | https://github.com/python/mypy/pull/3005/commits/1776e908aa2b5ba84550fb373173aa6ac159b53c |
| 1776e90 | https://github.com/python/mypy/pull/3005/commits/1776e908aa2b5ba84550fb373173aa6ac159b53c |
|
| https://github.com/pkch |
| Apply CR comments | https://github.com/python/mypy/pull/3005/commits/3334b8e67151f80cc62cdad31d4408bc9b01c32d |
| 3334b8e | https://github.com/python/mypy/pull/3005/commits/3334b8e67151f80cc62cdad31d4408bc9b01c32d |
| https://github.com/pkch |
| pkch | https://github.com/pkch |
| force-pushed | https://github.com/python/mypy/compare/fe27fdaf86bae719903a67dc6253fa3beab9e2fb..3334b8e67151f80cc62cdad31d4408bc9b01c32d |
| fe27fda | https://github.com/python/mypy/commit/fe27fdaf86bae719903a67dc6253fa3beab9e2fb |
| 3334b8e | https://github.com/python/mypy/commit/3334b8e67151f80cc62cdad31d4408bc9b01c32d |
|
Compare
| https://github.com/python/mypy/compare/fe27fdaf86bae719903a67dc6253fa3beab9e2fb..3334b8e67151f80cc62cdad31d4408bc9b01c32d |
| March 20, 2017 08:25 | https://github.com/python/mypy/pull/3005#event-1006283315 |
| https://github.com/pkch |
| pkch | https://github.com/pkch |
|
Mar 20, 2017
| https://github.com/python/mypy/pull/3005#ref-issue-215355642 |
|
Prohibit parameterized generics in isinstance
#3037
| https://github.com/python/mypy/issues/3037 |
|
| https://github.com/pkch |
| Fix 3.3 syntax, updated typeshed | https://github.com/python/mypy/pull/3005/commits/3587549c4d3f5174738234df011a68049e3d663a |
| 3587549 | https://github.com/python/mypy/pull/3005/commits/3587549c4d3f5174738234df011a68049e3d663a |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Mar 21, 2017
| https://github.com/python/mypy/pull/3005#pullrequestreview-28089774 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3005/files/3587549c4d3f5174738234df011a68049e3d663a |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/3005#pullrequestreview-28089774 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| test-data/unit/check-isinstance.test | https://github.com/python/mypy/pull/3005/files/3587549c4d3f5174738234df011a68049e3d663a#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 21, 2017 | https://github.com/python/mypy/pull/3005#discussion_r107137302 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| mypy/semanal.py | https://github.com/python/mypy/pull/3005/files#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 21, 2017 | https://github.com/python/mypy/pull/3005#discussion_r107137369 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| mypy/checker.py | https://github.com/python/mypy/pull/3005/files/3587549c4d3f5174738234df011a68049e3d663a#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 21, 2017 | https://github.com/python/mypy/pull/3005#discussion_r107137752 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| mypy/checker.py | https://github.com/python/mypy/pull/3005/files/3587549c4d3f5174738234df011a68049e3d663a#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 21, 2017 | https://github.com/python/mypy/pull/3005#discussion_r107137828 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| test-data/unit/check-isinstance.test | https://github.com/python/mypy/pull/3005/files/3587549c4d3f5174738234df011a68049e3d663a#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 21, 2017 | https://github.com/python/mypy/pull/3005#discussion_r107138764 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| pkch | https://github.com/pkch |
| Mar 21, 2017 | https://github.com/python/mypy/pull/3005#discussion_r107249879 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 21, 2017 | https://github.com/python/mypy/pull/3005#discussion_r107252973 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| pkch | https://github.com/pkch |
| Mar 21, 2017 | https://github.com/python/mypy/pull/3005#discussion_r107255947 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| test-data/unit/check-isinstance.test | https://github.com/python/mypy/pull/3005/files/3587549c4d3f5174738234df011a68049e3d663a#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 21, 2017 | https://github.com/python/mypy/pull/3005#discussion_r107139370 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| pkch | https://github.com/pkch |
| March 21, 2017 12:20 | https://github.com/python/mypy/pull/3005#commits-pushed-81e1923 |
|
| https://github.com/pkch |
| More CR fixes | https://github.com/python/mypy/pull/3005/commits/81e19234191860985359b01040b3d536731bb76a |
| 81e1923 | https://github.com/python/mypy/pull/3005/commits/81e19234191860985359b01040b3d536731bb76a |
|
| https://github.com/pkch |
| Fix testr | https://github.com/python/mypy/pull/3005/commits/e4ffdc5a0121d3e103b6ddd9a80504b96a7d7779 |
| e4ffdc5 | https://github.com/python/mypy/pull/3005/commits/e4ffdc5a0121d3e103b6ddd9a80504b96a7d7779 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Mar 21, 2017
| https://github.com/python/mypy/pull/3005#pullrequestreview-28221369 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3005/files/e4ffdc5a0121d3e103b6ddd9a80504b96a7d7779 |
| mypy/semanal.py | https://github.com/python/mypy/pull/3005/files/e4ffdc5a0121d3e103b6ddd9a80504b96a7d7779#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 21, 2017 | https://github.com/python/mypy/pull/3005#discussion_r107259871 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Mar 21, 2017
| https://github.com/python/mypy/pull/3005#pullrequestreview-28221662 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3005/files/e4ffdc5a0121d3e103b6ddd9a80504b96a7d7779 |
| pkch | https://github.com/pkch |
| March 21, 2017 13:04 | https://github.com/python/mypy/pull/3005#commits-pushed-9440a52 |
|
| https://github.com/pkch |
| Revert accidental format change | https://github.com/python/mypy/pull/3005/commits/9440a528753713c97eab4e862b9eb1f56460ddbe |
| 9440a52 | https://github.com/python/mypy/pull/3005/commits/9440a528753713c97eab4e862b9eb1f56460ddbe |
|
| https://github.com/pkch |
| Merge branch 'master' into issubclass | https://github.com/python/mypy/pull/3005/commits/c831401487c86c155659d883426830bef7344686 |
| c831401 | https://github.com/python/mypy/pull/3005/commits/c831401487c86c155659d883426830bef7344686 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Apr 13, 2017 | https://github.com/python/mypy/pull/3005#issuecomment-293848995 |
| @pkch | https://github.com/pkch |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| pkch | https://github.com/pkch |
| April 13, 2017 07:01 | https://github.com/python/mypy/pull/3005#commits-pushed-a4a7214 |
|
| https://github.com/pkch |
| Merge branch 'master' into issubclass | https://github.com/python/mypy/pull/3005/commits/a4a7214fff4cb3fab13c9f6ae6d43f944eca46b8 |
| a4a7214 | https://github.com/python/mypy/pull/3005/commits/a4a7214fff4cb3fab13c9f6ae6d43f944eca46b8 |
|
| https://github.com/pkch |
| Address CR | https://github.com/python/mypy/pull/3005/commits/f94ca45878ada874de15d362dd261acbc775277c |
| f94ca45 | https://github.com/python/mypy/pull/3005/commits/f94ca45878ada874de15d362dd261acbc775277c |
|
| https://github.com/pkch |
| Rename type into typ | https://github.com/python/mypy/pull/3005/commits/a260b791445c2e421c731fa31c5c61ff6d25d077 |
| a260b79 | https://github.com/python/mypy/pull/3005/commits/a260b791445c2e421c731fa31c5c61ff6d25d077 |
|
| https://github.com/pkch |
| Merge branch 'master' into issubclass | https://github.com/python/mypy/pull/3005/commits/fbd0b91e6daace029c14735cec19d15d6ee38cd2 |
| fbd0b91 | https://github.com/python/mypy/pull/3005/commits/fbd0b91e6daace029c14735cec19d15d6ee38cd2 |
| https://github.com/pkch |
| pkch | https://github.com/pkch |
| force-pushed | https://github.com/python/mypy/compare/75bee74cfb55d71b870edea36894d7bebf7f8546..fbd0b91e6daace029c14735cec19d15d6ee38cd2 |
| 75bee74 | https://github.com/python/mypy/commit/75bee74cfb55d71b870edea36894d7bebf7f8546 |
| fbd0b91 | https://github.com/python/mypy/commit/fbd0b91e6daace029c14735cec19d15d6ee38cd2 |
|
Compare
| https://github.com/python/mypy/compare/75bee74cfb55d71b870edea36894d7bebf7f8546..fbd0b91e6daace029c14735cec19d15d6ee38cd2 |
| April 13, 2017 14:54 | https://github.com/python/mypy/pull/3005#event-1042039403 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Apr 13, 2017 | https://github.com/python/mypy/pull/3005#issuecomment-294044313 |
| @pkch | https://github.com/pkch |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| https://github.com/pkch |
| pkch | https://github.com/pkch |
| Apr 14, 2017 | https://github.com/python/mypy/pull/3005#issuecomment-294053678 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
|
| https://github.com/pkch |
| Fix unreachable block crash | https://github.com/python/mypy/pull/3005/commits/e48d983ddaf24fbce7a0d40bf4c7dd7716767dc6 |
| e48d983 | https://github.com/python/mypy/pull/3005/commits/e48d983ddaf24fbce7a0d40bf4c7dd7716767dc6 |
| https://github.com/pkch |
| pkch | https://github.com/pkch |
| force-pushed | https://github.com/python/mypy/compare/62d0d0a205c536d09305c1edb7515024cf758393..e48d983ddaf24fbce7a0d40bf4c7dd7716767dc6 |
| 62d0d0a | https://github.com/python/mypy/commit/62d0d0a205c536d09305c1edb7515024cf758393 |
| e48d983 | https://github.com/python/mypy/commit/e48d983ddaf24fbce7a0d40bf4c7dd7716767dc6 |
|
Compare
| https://github.com/python/mypy/compare/62d0d0a205c536d09305c1edb7515024cf758393..e48d983ddaf24fbce7a0d40bf4c7dd7716767dc6 |
| April 14, 2017 00:22 | https://github.com/python/mypy/pull/3005#event-1042795529 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Apr 14, 2017 | https://github.com/python/mypy/pull/3005#issuecomment-294055697 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Apr 14, 2017
| https://github.com/python/mypy/pull/3005#pullrequestreview-32910781 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3005/files/e48d983ddaf24fbce7a0d40bf4c7dd7716767dc6 |
| test-data/unit/check-isinstance.test | https://github.com/python/mypy/pull/3005/files/fbd0b91e6daace029c14735cec19d15d6ee38cd2..e48d983ddaf24fbce7a0d40bf4c7dd7716767dc6#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Apr 14, 2017 | https://github.com/python/mypy/pull/3005#discussion_r111648318 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| pkch | https://github.com/pkch |
| Apr 19, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112269874 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Apr 19, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112271099 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Apr 19, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112271675 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| pkch | https://github.com/pkch |
| Apr 19, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112295452 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Apr 20, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112383399 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @pkch | https://github.com/pkch |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| pkch | https://github.com/pkch |
| Apr 20, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112387588 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #3032 | https://github.com/python/mypy/issues/3032 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Apr 20, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112389530 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @pkch | https://github.com/pkch |
| #3117 | https://github.com/python/mypy/issues/3117 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| pkch | https://github.com/pkch |
| Apr 20, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112392142 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #3129 | https://github.com/python/mypy/pull/3129 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Apr 20, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112392541 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @pkch | https://github.com/pkch |
| #3129 | https://github.com/python/mypy/pull/3129 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Apr 19, 2017 | https://github.com/python/mypy/pull/3005#issuecomment-295361083 |
| @gvanrossum | https://github.com/gvanrossum |
| @pkch | https://github.com/pkch |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Apr 19, 2017 | https://github.com/python/mypy/pull/3005#issuecomment-295394782 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| pkch | https://github.com/pkch |
| April 19, 2017 12:38 | https://github.com/python/mypy/pull/3005#commits-pushed-b0ce683 |
|
| https://github.com/pkch |
| Add back integration tests | https://github.com/python/mypy/pull/3005/commits/b0ce6838199549955f5decd8bc932e96e683339c |
| b0ce683 | https://github.com/python/mypy/pull/3005/commits/b0ce6838199549955f5decd8bc932e96e683339c |
|
| https://github.com/pkch |
| Add union destructuring test | https://github.com/python/mypy/pull/3005/commits/aca05c7d4e271686f11335a9157a8db18e525587 |
| aca05c7 | https://github.com/python/mypy/pull/3005/commits/aca05c7d4e271686f11335a9157a8db18e525587 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Apr 20, 2017
| https://github.com/python/mypy/pull/3005#pullrequestreview-33697586 |
|
View reviewed changes
| https://github.com/python/mypy/pull/3005/files/aca05c7d4e271686f11335a9157a8db18e525587 |
| test-data/unit/check-isinstance.test | https://github.com/python/mypy/pull/3005/files/b0ce6838199549955f5decd8bc932e96e683339c..aca05c7d4e271686f11335a9157a8db18e525587#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Apr 20, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112388259 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @pkch | https://github.com/pkch |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| pkch | https://github.com/pkch |
| Apr 20, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112389804 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Apr 20, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112391167 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @pkch | https://github.com/pkch |
| typing docs | https://docs.python.org/3/library/typing.html#typing.Type |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| pkch | https://github.com/pkch |
| Apr 20, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112394811 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Apr 20, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112396280 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @pkch | https://github.com/pkch |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Apr 21, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112655565 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @pkch | https://github.com/pkch |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| pkch | https://github.com/pkch |
| Apr 21, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112659410 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Apr 21, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112662334 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @pkch | https://github.com/pkch |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| pkch | https://github.com/pkch |
| Apr 21, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112666664 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @ilevkivskyi | https://github.com/ilevkivskyi |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Apr 21, 2017 | https://github.com/python/mypy/pull/3005#discussion_r112678620 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @pkch | https://github.com/pkch |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
| https://github.com/pkch |
| pkch | https://github.com/pkch |
| force-pushed | https://github.com/python/mypy/compare/408f19eaaadba60601705924f1578b6195f33c4d..aca05c7d4e271686f11335a9157a8db18e525587 |
| 408f19e | https://github.com/python/mypy/commit/408f19eaaadba60601705924f1578b6195f33c4d |
| aca05c7 | https://github.com/python/mypy/commit/aca05c7d4e271686f11335a9157a8db18e525587 |
|
Compare
| https://github.com/python/mypy/compare/408f19eaaadba60601705924f1578b6195f33c4d..aca05c7d4e271686f11335a9157a8db18e525587 |
| April 21, 2017 10:17 | https://github.com/python/mypy/pull/3005#event-1052194385 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| c38a836 | https://github.com/python/mypy/commit/c38a83621ca6478b9b8663dc5200e2387aa560e9 |
| Apr 21, 2017 | https://github.com/python/mypy/pull/3005#event-1052373541 |
| https://github.com/pkch |
| pkch | https://github.com/pkch |
|
Apr 21, 2017
| https://github.com/python/mypy/pull/3005#ref-pullrequest-223407607 |
|
Standardize Type[Union[...]] -> Union[Type[...]]
#3209
| https://github.com/python/mypy/pull/3209 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F3005 |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
|
| https://github.com/python/mypy/pull/3005/files/aca05c7d4e271686f11335a9157a8db18e525587 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
|
Types should be promoted by issubclass
| https://github.com/python/mypy/issues/2909 |
| Please reload this page | https://github.com/python/mypy/pull/3005 |
|
| https://github.com/pkch |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/gvanrossum |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |