| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0c80fff3-a3a4-f976-204a-2e875bea1c97 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8EE6:5537E:1612A7F:1D05FD5:6B001229 |
| html-safe-nonce | 3aaaa1daff101c25201d507d9180407cbc699de3afffef32f429dbc91ab359e8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RUU2OjU1MzdFOjE2MTJBN0Y6MUQwNUZENTo2QjAwMTIyOSIsInZpc2l0b3JfaWQiOiIyMDEyNDU2OTg2MTc5ODAxNjQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 281a4ba3efe1813db06f99696f39963b1e63f87956ef7a381c53251c2cd2b9f3 |
| hovercard-subject-tag | pull_request:110611818 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/2997/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9a058a642cf7862d787e5e07803395a2b0aca21a4d533bd6ae5599da9a072323/python/mypy/pull/2997 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9a058a642cf7862d787e5e07803395a2b0aca21a4d533bd6ae5599da9a072323/python/mypy/pull/2997 |
| og:image:alt | Fixes #2993 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | pkch |
| hostname | github.com |
| expected-hostname | github.com |
| None | cf7ee0062053ad9eb05b6e5de57bd96c2055708bcbada4144946b5ec129cf1d7 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9cab7de176a56362d2aabcbb4d1e07e846eba8a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/2997#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2997 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2997 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/2997 |
| Reload | https://github.com/python/mypy/pull/2997 |
| Reload | https://github.com/python/mypy/pull/2997 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| JukkaL | https://github.com/JukkaL |
| python:master | https://github.com/python/mypy/tree/master |
| pkch:fix-isinstance-inference | https://github.com/pkch/mypy/tree/fix-isinstance-inference |
| Conversation | https://github.com/python/mypy/pull/2997 |
| Commits8 (8) | https://github.com/python/mypy/pull/2997/commits |
| Checks | https://github.com/python/mypy/pull/2997/checks |
| Files changed | https://github.com/python/mypy/pull/2997/files |
| Fix inference logic for isinstance | https://github.com/python/mypy/pull/2997#top |
| JukkaL | https://github.com/JukkaL |
| python:master | https://github.com/python/mypy/tree/master |
| pkch:fix-isinstance-inference | https://github.com/pkch/mypy/tree/fix-isinstance-inference |
|
| https://github.com/pkch |
| pkch | https://github.com/pkch |
| Mar 14, 2017 | https://github.com/python/mypy/pull/2997#issue-214059417 |
| #2993 | https://github.com/python/mypy/issues/2993 |
| Please reload this page | https://github.com/python/mypy/pull/2997 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Mar 14, 2017
| https://github.com/python/mypy/pull/2997#ref-issue-214012619 |
|
Incorrect inference with isinstance()
#2993
| https://github.com/python/mypy/issues/2993 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Mar 14, 2017
| https://github.com/python/mypy/pull/2997#pullrequestreview-26883985 |
|
View reviewed changes
| https://github.com/python/mypy/pull/2997/files |
| gvanrossum | https://github.com/gvanrossum |
| https://github.com/python/mypy/pull/2997#pullrequestreview-26883985 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2997 |
| mypy/checker.py | https://github.com/python/mypy/pull/2997/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| gvanrossum | https://github.com/gvanrossum |
| Mar 14, 2017 | https://github.com/python/mypy/pull/2997#discussion_r105981232 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2997 |
| https://github.com/pkch |
| pkch | https://github.com/pkch |
| force-pushed | https://github.com/python/mypy/compare/a61bf32a6862fde04c905196f8fba1c485a6333c..79a8085fc24f4aa6e3668315f9b355eff0734125 |
| a61bf32 | https://github.com/python/mypy/commit/a61bf32a6862fde04c905196f8fba1c485a6333c |
| 79a8085 | https://github.com/python/mypy/commit/79a8085fc24f4aa6e3668315f9b355eff0734125 |
|
Compare
| https://github.com/python/mypy/compare/a61bf32a6862fde04c905196f8fba1c485a6333c..79a8085fc24f4aa6e3668315f9b355eff0734125 |
| March 14, 2017 20:30 | https://github.com/python/mypy/pull/2997#event-999781734 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Mar 18, 2017 | https://github.com/python/mypy/pull/2997#issuecomment-287558344 |
| #2995 | https://github.com/python/mypy/pull/2995 |
| #3005 | https://github.com/python/mypy/pull/3005 |
| #2995 | https://github.com/python/mypy/pull/2995 |
| Please reload this page | https://github.com/python/mypy/pull/2997 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Mar 18, 2017
| https://github.com/python/mypy/pull/2997#pullrequestreview-27733046 |
|
View reviewed changes
| https://github.com/python/mypy/pull/2997/files |
| mypy/semanal.py | https://github.com/python/mypy/pull/2997/files#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| JukkaL | https://github.com/JukkaL |
| Mar 18, 2017 | https://github.com/python/mypy/pull/2997#discussion_r106789852 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2997 |
| mypy/semanal.py | https://github.com/python/mypy/pull/2997/files#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164 |
| JukkaL | https://github.com/JukkaL |
| Mar 18, 2017 | https://github.com/python/mypy/pull/2997#discussion_r106789866 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2997 |
| test-data/unit/check-isinstance.test | https://github.com/python/mypy/pull/2997/files#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb |
| JukkaL | https://github.com/JukkaL |
| Mar 18, 2017 | https://github.com/python/mypy/pull/2997#discussion_r106789890 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2997 |
| test-data/unit/check-isinstance.test | https://github.com/python/mypy/pull/2997/files#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb |
| JukkaL | https://github.com/JukkaL |
| Mar 18, 2017 | https://github.com/python/mypy/pull/2997#discussion_r106789985 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2997 |
| https://github.com/pkch |
| pkch | https://github.com/pkch |
| force-pushed | https://github.com/python/mypy/compare/bca997d33a6d4710df3dea15a0a1a8f647043c7d..6ea4f4d1cfa9f44006a837c744e3af8e9faf5439 |
| bca997d | https://github.com/python/mypy/commit/bca997d33a6d4710df3dea15a0a1a8f647043c7d |
| 6ea4f4d | https://github.com/python/mypy/commit/6ea4f4d1cfa9f44006a837c744e3af8e9faf5439 |
|
Compare
| https://github.com/python/mypy/compare/bca997d33a6d4710df3dea15a0a1a8f647043c7d..6ea4f4d1cfa9f44006a837c744e3af8e9faf5439 |
| March 18, 2017 21:30 | https://github.com/python/mypy/pull/2997#event-1005662595 |
| pkch | https://github.com/pkch |
| March 18, 2017 18:25 | https://github.com/python/mypy/pull/2997#commits-pushed-a29069e |
|
| https://github.com/pkch |
| Make no inference when variables present in second argument to isinst… | https://github.com/python/mypy/pull/2997/commits/a29069e1c487468d7b50a538890e11a6aeb40893 |
| a29069e | https://github.com/python/mypy/pull/2997/commits/a29069e1c487468d7b50a538890e11a6aeb40893 |
|
| https://github.com/pkch |
| Fix formatting | https://github.com/python/mypy/pull/2997/commits/8d7811ac0bc414b028c3a751c69bb0813923c39f |
| 8d7811a | https://github.com/python/mypy/pull/2997/commits/8d7811ac0bc414b028c3a751c69bb0813923c39f |
|
| https://github.com/pkch |
| Add unit test | https://github.com/python/mypy/pull/2997/commits/14efa1639b50bce05052b36c5abdd3e6a8189aad |
| 14efa16 | https://github.com/python/mypy/pull/2997/commits/14efa1639b50bce05052b36c5abdd3e6a8189aad |
|
| https://github.com/pkch |
| Replace isinstance with cast to deal with | https://github.com/python/mypy/pull/2997/commits/d9f261f3726a7a10f040e2ffd314ce5ef0e9ab5a |
| python#2999 | https://github.com/python/mypy/issues/2999 |
| ; rename test | https://github.com/python/mypy/pull/2997/commits/d9f261f3726a7a10f040e2ffd314ce5ef0e9ab5a |
| d9f261f | https://github.com/python/mypy/pull/2997/commits/d9f261f3726a7a10f040e2ffd314ce5ef0e9ab5a |
|
| https://github.com/pkch |
| Apply CR comments | https://github.com/python/mypy/pull/2997/commits/b110b1143c6a97c0445b441e65a90f75980f281d |
| b110b11 | https://github.com/python/mypy/pull/2997/commits/b110b1143c6a97c0445b441e65a90f75980f281d |
|
| https://github.com/pkch |
| Add failing unit test for ininstance with type objects | https://github.com/python/mypy/pull/2997/commits/fc1aa62332e185066688340e4fb378283bb65428 |
| fc1aa62 | https://github.com/python/mypy/pull/2997/commits/fc1aa62332e185066688340e4fb378283bb65428 |
|
| https://github.com/pkch |
| Fix type inference with type objects in isinstance | https://github.com/python/mypy/pull/2997/commits/be30faa7f9c230c966a5f9555b3713086f935bcf |
| be30faa | https://github.com/python/mypy/pull/2997/commits/be30faa7f9c230c966a5f9555b3713086f935bcf |
| https://github.com/pkch |
| pkch | https://github.com/pkch |
| force-pushed | https://github.com/python/mypy/compare/2fa26d1a7e878fea5e2fe511063004aa3378cb04..be30faa7f9c230c966a5f9555b3713086f935bcf |
| 2fa26d1 | https://github.com/python/mypy/commit/2fa26d1a7e878fea5e2fe511063004aa3378cb04 |
| be30faa | https://github.com/python/mypy/commit/be30faa7f9c230c966a5f9555b3713086f935bcf |
|
Compare
| https://github.com/python/mypy/compare/2fa26d1a7e878fea5e2fe511063004aa3378cb04..be30faa7f9c230c966a5f9555b3713086f935bcf |
| March 19, 2017 01:58 | https://github.com/python/mypy/pull/2997#event-1005717990 |
| https://github.com/pkch |
| pkch | https://github.com/pkch |
|
Mar 19, 2017
| https://github.com/python/mypy/pull/2997#ref-pullrequest-214284773 |
|
Infer types from issubclass() calls
#3005
| https://github.com/python/mypy/pull/3005 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Mar 19, 2017
| https://github.com/python/mypy/pull/2997#pullrequestreview-27754282 |
|
View reviewed changes
| https://github.com/python/mypy/pull/2997/files/be30faa7f9c230c966a5f9555b3713086f935bcf |
| mypy/checker.py | https://github.com/python/mypy/pull/2997/files/be30faa7f9c230c966a5f9555b3713086f935bcf#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| JukkaL | https://github.com/JukkaL |
| Mar 19, 2017 | https://github.com/python/mypy/pull/2997#discussion_r106813515 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2997 |
| mypy/checker.py | https://github.com/python/mypy/pull/2997/files/be30faa7f9c230c966a5f9555b3713086f935bcf#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| JukkaL | https://github.com/JukkaL |
| Mar 19, 2017 | https://github.com/python/mypy/pull/2997#discussion_r106813557 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2997 |
| test-data/unit/check-isinstance.test | https://github.com/python/mypy/pull/2997/files/be30faa7f9c230c966a5f9555b3713086f935bcf#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb |
| JukkaL | https://github.com/JukkaL |
| Mar 19, 2017 | https://github.com/python/mypy/pull/2997#discussion_r106813591 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2997 |
| test-data/unit/check-isinstance.test | https://github.com/python/mypy/pull/2997/files/be30faa7f9c230c966a5f9555b3713086f935bcf#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb |
| JukkaL | https://github.com/JukkaL |
| Mar 19, 2017 | https://github.com/python/mypy/pull/2997#discussion_r106813610 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2997 |
| mypy/checker.py | https://github.com/python/mypy/pull/2997/files/be30faa7f9c230c966a5f9555b3713086f935bcf#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| JukkaL | https://github.com/JukkaL |
| Mar 19, 2017 | https://github.com/python/mypy/pull/2997#discussion_r106813622 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2997 |
|
| https://github.com/pkch |
| Apply CR comments | https://github.com/python/mypy/pull/2997/commits/f0bfcb683e65ed032e193e0480bed1b0cf0b8b50 |
| f0bfcb6 | https://github.com/python/mypy/pull/2997/commits/f0bfcb683e65ed032e193e0480bed1b0cf0b8b50 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| 0b28da6 | https://github.com/python/mypy/commit/0b28da6ffb245b3034421b37c5e92e5794a01065 |
| Mar 19, 2017 | https://github.com/python/mypy/pull/2997#event-1005979667 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Mar 27, 2017
| https://github.com/python/mypy/pull/2997#ref-issue-217278877 |
|
isinstance with self.__class__ infers 'object' as the type
#3061
| https://github.com/python/mypy/issues/3061 |
| https://github.com/pkch |
| pkch | https://github.com/pkch |
|
Apr 15, 2017
| https://github.com/python/mypy/pull/2997#ref-issue-221921264 |
|
Type inference engine simplifies too aggressively
#3178
| https://github.com/python/mypy/issues/3178 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2997 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/2997/files/be30faa7f9c230c966a5f9555b3713086f935bcf |
|
| https://github.com/gvanrossum |
|
gvanrossum
| https://github.com/gvanrossum |
|
| https://github.com/python/mypy/pull/2997/files/419af97f76ed0332d1ba5d5eb7b36a6e7b789b20 |
| Please reload this page | https://github.com/python/mypy/pull/2997 |
| Please reload this page | https://github.com/python/mypy/pull/2997 |
|
| https://github.com/pkch |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/JukkaL |
|
| https://github.com/gvanrossum |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |