René's URL Explorer Experiment


Title: Fix inference logic for isinstance by pkch · Pull Request #2997 · python/mypy · GitHub

Open Graph Title: Fix inference logic for isinstance by pkch · Pull Request #2997 · python/mypy

X Title: Fix inference logic for isinstance by pkch · Pull Request #2997 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #2993

X Description: Fixes #2993

Opengraph URL: https://github.com/python/mypy/pull/2997

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0c80fff3-a3a4-f976-204a-2e875bea1c97
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8EE6:5537E:1612A7F:1D05FD5:6B001229
html-safe-nonce3aaaa1daff101c25201d507d9180407cbc699de3afffef32f429dbc91ab359e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RUU2OjU1MzdFOjE2MTJBN0Y6MUQwNUZENTo2QjAwMTIyOSIsInZpc2l0b3JfaWQiOiIyMDEyNDU2OTg2MTc5ODAxNjQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac281a4ba3efe1813db06f99696f39963b1e63f87956ef7a381c53251c2cd2b9f3
hovercard-subject-tagpull_request:110611818
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/2997/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9a058a642cf7862d787e5e07803395a2b0aca21a4d533bd6ae5599da9a072323/python/mypy/pull/2997
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9a058a642cf7862d787e5e07803395a2b0aca21a4d533bd6ae5599da9a072323/python/mypy/pull/2997
og:image:altFixes #2993
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepkch
hostnamegithub.com
expected-hostnamegithub.com
Nonecf7ee0062053ad9eb05b6e5de57bd96c2055708bcbada4144946b5ec129cf1d7
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9cab7de176a56362d2aabcbb4d1e07e846eba8a0
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/2997#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2997
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2997
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/2997
Reloadhttps://github.com/python/mypy/pull/2997
Reloadhttps://github.com/python/mypy/pull/2997
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
pkch:fix-isinstance-inferencehttps://github.com/pkch/mypy/tree/fix-isinstance-inference
Conversationhttps://github.com/python/mypy/pull/2997
Commits8 (8)https://github.com/python/mypy/pull/2997/commits
Checkshttps://github.com/python/mypy/pull/2997/checks
Files changedhttps://github.com/python/mypy/pull/2997/files
Fix inference logic for isinstancehttps://github.com/python/mypy/pull/2997#top
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
pkch:fix-isinstance-inferencehttps://github.com/pkch/mypy/tree/fix-isinstance-inference
https://github.com/pkch
pkchhttps://github.com/pkch
Mar 14, 2017https://github.com/python/mypy/pull/2997#issue-214059417
#2993https://github.com/python/mypy/issues/2993
Please reload this pagehttps://github.com/python/mypy/pull/2997
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Mar 14, 2017 https://github.com/python/mypy/pull/2997#ref-issue-214012619
Incorrect inference with isinstance() #2993 https://github.com/python/mypy/issues/2993
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Mar 14, 2017 https://github.com/python/mypy/pull/2997#pullrequestreview-26883985
View reviewed changes https://github.com/python/mypy/pull/2997/files
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/mypy/pull/2997#pullrequestreview-26883985
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2997
mypy/checker.pyhttps://github.com/python/mypy/pull/2997/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
gvanrossumhttps://github.com/gvanrossum
Mar 14, 2017https://github.com/python/mypy/pull/2997#discussion_r105981232
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2997
https://github.com/pkch
pkchhttps://github.com/pkch
force-pushedhttps://github.com/python/mypy/compare/a61bf32a6862fde04c905196f8fba1c485a6333c..79a8085fc24f4aa6e3668315f9b355eff0734125
a61bf32https://github.com/python/mypy/commit/a61bf32a6862fde04c905196f8fba1c485a6333c
79a8085https://github.com/python/mypy/commit/79a8085fc24f4aa6e3668315f9b355eff0734125
Compare https://github.com/python/mypy/compare/a61bf32a6862fde04c905196f8fba1c485a6333c..79a8085fc24f4aa6e3668315f9b355eff0734125
March 14, 2017 20:30https://github.com/python/mypy/pull/2997#event-999781734
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Mar 18, 2017https://github.com/python/mypy/pull/2997#issuecomment-287558344
#2995https://github.com/python/mypy/pull/2995
#3005https://github.com/python/mypy/pull/3005
#2995https://github.com/python/mypy/pull/2995
Please reload this pagehttps://github.com/python/mypy/pull/2997
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Mar 18, 2017 https://github.com/python/mypy/pull/2997#pullrequestreview-27733046
View reviewed changes https://github.com/python/mypy/pull/2997/files
mypy/semanal.pyhttps://github.com/python/mypy/pull/2997/files#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
JukkaLhttps://github.com/JukkaL
Mar 18, 2017https://github.com/python/mypy/pull/2997#discussion_r106789852
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2997
mypy/semanal.pyhttps://github.com/python/mypy/pull/2997/files#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
JukkaLhttps://github.com/JukkaL
Mar 18, 2017https://github.com/python/mypy/pull/2997#discussion_r106789866
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2997
test-data/unit/check-isinstance.testhttps://github.com/python/mypy/pull/2997/files#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb
JukkaLhttps://github.com/JukkaL
Mar 18, 2017https://github.com/python/mypy/pull/2997#discussion_r106789890
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2997
test-data/unit/check-isinstance.testhttps://github.com/python/mypy/pull/2997/files#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb
JukkaLhttps://github.com/JukkaL
Mar 18, 2017https://github.com/python/mypy/pull/2997#discussion_r106789985
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2997
https://github.com/pkch
pkchhttps://github.com/pkch
force-pushedhttps://github.com/python/mypy/compare/bca997d33a6d4710df3dea15a0a1a8f647043c7d..6ea4f4d1cfa9f44006a837c744e3af8e9faf5439
bca997dhttps://github.com/python/mypy/commit/bca997d33a6d4710df3dea15a0a1a8f647043c7d
6ea4f4dhttps://github.com/python/mypy/commit/6ea4f4d1cfa9f44006a837c744e3af8e9faf5439
Compare https://github.com/python/mypy/compare/bca997d33a6d4710df3dea15a0a1a8f647043c7d..6ea4f4d1cfa9f44006a837c744e3af8e9faf5439
March 18, 2017 21:30https://github.com/python/mypy/pull/2997#event-1005662595
pkchhttps://github.com/pkch
March 18, 2017 18:25https://github.com/python/mypy/pull/2997#commits-pushed-a29069e
https://github.com/pkch
Make no inference when variables present in second argument to isinst…https://github.com/python/mypy/pull/2997/commits/a29069e1c487468d7b50a538890e11a6aeb40893
a29069ehttps://github.com/python/mypy/pull/2997/commits/a29069e1c487468d7b50a538890e11a6aeb40893
https://github.com/pkch
Fix formattinghttps://github.com/python/mypy/pull/2997/commits/8d7811ac0bc414b028c3a751c69bb0813923c39f
8d7811ahttps://github.com/python/mypy/pull/2997/commits/8d7811ac0bc414b028c3a751c69bb0813923c39f
https://github.com/pkch
Add unit testhttps://github.com/python/mypy/pull/2997/commits/14efa1639b50bce05052b36c5abdd3e6a8189aad
14efa16https://github.com/python/mypy/pull/2997/commits/14efa1639b50bce05052b36c5abdd3e6a8189aad
https://github.com/pkch
Replace isinstance with cast to deal withhttps://github.com/python/mypy/pull/2997/commits/d9f261f3726a7a10f040e2ffd314ce5ef0e9ab5a
python#2999https://github.com/python/mypy/issues/2999
; rename testhttps://github.com/python/mypy/pull/2997/commits/d9f261f3726a7a10f040e2ffd314ce5ef0e9ab5a
d9f261fhttps://github.com/python/mypy/pull/2997/commits/d9f261f3726a7a10f040e2ffd314ce5ef0e9ab5a
https://github.com/pkch
Apply CR commentshttps://github.com/python/mypy/pull/2997/commits/b110b1143c6a97c0445b441e65a90f75980f281d
b110b11https://github.com/python/mypy/pull/2997/commits/b110b1143c6a97c0445b441e65a90f75980f281d
https://github.com/pkch
Add failing unit test for ininstance with type objectshttps://github.com/python/mypy/pull/2997/commits/fc1aa62332e185066688340e4fb378283bb65428
fc1aa62https://github.com/python/mypy/pull/2997/commits/fc1aa62332e185066688340e4fb378283bb65428
https://github.com/pkch
Fix type inference with type objects in isinstancehttps://github.com/python/mypy/pull/2997/commits/be30faa7f9c230c966a5f9555b3713086f935bcf
be30faahttps://github.com/python/mypy/pull/2997/commits/be30faa7f9c230c966a5f9555b3713086f935bcf
https://github.com/pkch
pkchhttps://github.com/pkch
force-pushedhttps://github.com/python/mypy/compare/2fa26d1a7e878fea5e2fe511063004aa3378cb04..be30faa7f9c230c966a5f9555b3713086f935bcf
2fa26d1https://github.com/python/mypy/commit/2fa26d1a7e878fea5e2fe511063004aa3378cb04
be30faahttps://github.com/python/mypy/commit/be30faa7f9c230c966a5f9555b3713086f935bcf
Compare https://github.com/python/mypy/compare/2fa26d1a7e878fea5e2fe511063004aa3378cb04..be30faa7f9c230c966a5f9555b3713086f935bcf
March 19, 2017 01:58https://github.com/python/mypy/pull/2997#event-1005717990
https://github.com/pkch
pkchhttps://github.com/pkch
Mar 19, 2017 https://github.com/python/mypy/pull/2997#ref-pullrequest-214284773
Infer types from issubclass() calls #3005 https://github.com/python/mypy/pull/3005
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Mar 19, 2017 https://github.com/python/mypy/pull/2997#pullrequestreview-27754282
View reviewed changes https://github.com/python/mypy/pull/2997/files/be30faa7f9c230c966a5f9555b3713086f935bcf
mypy/checker.pyhttps://github.com/python/mypy/pull/2997/files/be30faa7f9c230c966a5f9555b3713086f935bcf#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
JukkaLhttps://github.com/JukkaL
Mar 19, 2017https://github.com/python/mypy/pull/2997#discussion_r106813515
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2997
mypy/checker.pyhttps://github.com/python/mypy/pull/2997/files/be30faa7f9c230c966a5f9555b3713086f935bcf#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
JukkaLhttps://github.com/JukkaL
Mar 19, 2017https://github.com/python/mypy/pull/2997#discussion_r106813557
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2997
test-data/unit/check-isinstance.testhttps://github.com/python/mypy/pull/2997/files/be30faa7f9c230c966a5f9555b3713086f935bcf#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb
JukkaLhttps://github.com/JukkaL
Mar 19, 2017https://github.com/python/mypy/pull/2997#discussion_r106813591
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2997
test-data/unit/check-isinstance.testhttps://github.com/python/mypy/pull/2997/files/be30faa7f9c230c966a5f9555b3713086f935bcf#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb
JukkaLhttps://github.com/JukkaL
Mar 19, 2017https://github.com/python/mypy/pull/2997#discussion_r106813610
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2997
mypy/checker.pyhttps://github.com/python/mypy/pull/2997/files/be30faa7f9c230c966a5f9555b3713086f935bcf#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
JukkaLhttps://github.com/JukkaL
Mar 19, 2017https://github.com/python/mypy/pull/2997#discussion_r106813622
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2997
https://github.com/pkch
Apply CR commentshttps://github.com/python/mypy/pull/2997/commits/f0bfcb683e65ed032e193e0480bed1b0cf0b8b50
f0bfcb6https://github.com/python/mypy/pull/2997/commits/f0bfcb683e65ed032e193e0480bed1b0cf0b8b50
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
0b28da6https://github.com/python/mypy/commit/0b28da6ffb245b3034421b37c5e92e5794a01065
Mar 19, 2017https://github.com/python/mypy/pull/2997#event-1005979667
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Mar 27, 2017 https://github.com/python/mypy/pull/2997#ref-issue-217278877
isinstance with self.__class__ infers 'object' as the type #3061 https://github.com/python/mypy/issues/3061
https://github.com/pkch
pkchhttps://github.com/pkch
Apr 15, 2017 https://github.com/python/mypy/pull/2997#ref-issue-221921264
Type inference engine simplifies too aggressively #3178 https://github.com/python/mypy/issues/3178
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2997
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/2997/files/be30faa7f9c230c966a5f9555b3713086f935bcf
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/mypy/pull/2997/files/419af97f76ed0332d1ba5d5eb7b36a6e7b789b20
Please reload this pagehttps://github.com/python/mypy/pull/2997
Please reload this pagehttps://github.com/python/mypy/pull/2997
https://github.com/pkch
https://github.com/ilevkivskyi
https://github.com/JukkaL
https://github.com/gvanrossum
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.