René's URL Explorer Experiment


Title: Implement ClassVar semantics (fixes #2771) by miedzinski · Pull Request #2873 · python/mypy · GitHub

Open Graph Title: Implement ClassVar semantics (fixes #2771) by miedzinski · Pull Request #2873 · python/mypy

X Title: Implement ClassVar semantics (fixes #2771) by miedzinski · Pull Request #2873 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Support ClassVar annotations Implements ClassVar introduced in PEP 526. Resolves #2771, #2879. Support annotating class attributes with ClassVar[...]. Prohibit ClassVar annotations outside class b...

X Description: Support ClassVar annotations Implements ClassVar introduced in PEP 526. Resolves #2771, #2879. Support annotating class attributes with ClassVar[...]. Prohibit ClassVar annotations outside class b...

Opengraph URL: https://github.com/python/mypy/pull/2873

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a6642a39-0165-4cae-62f6-9e95439265fb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA6DC:1A2F85:C40D2F:1076FB4:6B004F59
html-safe-noncefaa9e84990f0f1f747a0093e40441cf98895f3af119e51c639dcd8ad3d8d4ad9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkRDOjFBMkY4NTpDNDBEMkY6MTA3NkZCNDo2QjAwNEY1OSIsInZpc2l0b3JfaWQiOiIyODczODQ2MzcxNDExMDU0NDI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace1ad07842edd358a49e77895a5126c3df05b084b4689100dfa19469f8b73dd4f
hovercard-subject-tagpull_request:106418018
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/2873/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/874e5187f6b155bd4fe9e983162845cbe8adb3b907e3d6442e482c8b5dbd1a5b/python/mypy/pull/2873
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/874e5187f6b155bd4fe9e983162845cbe8adb3b907e3d6442e482c8b5dbd1a5b/python/mypy/pull/2873
og:image:altSupport ClassVar annotations Implements ClassVar introduced in PEP 526. Resolves #2771, #2879. Support annotating class attributes with ClassVar[...]. Prohibit ClassVar annotations outside class b...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiedzinski
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/2873#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2873
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2873
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/2873
Reloadhttps://github.com/python/mypy/pull/2873
Reloadhttps://github.com/python/mypy/pull/2873
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
miedzinski:classvarhttps://github.com/miedzinski/mypy/tree/classvar
Conversationhttps://github.com/python/mypy/pull/2873
Commits24 (24)https://github.com/python/mypy/pull/2873/commits
Checkshttps://github.com/python/mypy/pull/2873/checks
Files changedhttps://github.com/python/mypy/pull/2873/files
Implement ClassVar semantics (fixes #2771)https://github.com/python/mypy/pull/2873#top
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
miedzinski:classvarhttps://github.com/miedzinski/mypy/tree/classvar
https://github.com/miedzinski
miedzinskihttps://github.com/miedzinski
Feb 15, 2017https://github.com/python/mypy/pull/2873#issue-207954587
Please reload this pagehttps://github.com/python/mypy/pull/2873
#2771https://github.com/python/mypy/issues/2771
#2879https://github.com/python/mypy/pull/2879
Generic class atributes aren't fully instantiated #2878https://github.com/python/mypy/issues/2878
Please reload this pagehttps://github.com/python/mypy/pull/2873
miedzinskihttps://github.com/miedzinski
February 15, 2017 23:46https://github.com/python/mypy/pull/2873#commits-pushed-d6b370d
https://github.com/miedzinski
Implement ClassVar semantics (https://github.com/python/mypy/pull/2873/commits/d6b370d2035bfe7861e62c43af22272b3d8974d3
fixeshttps://github.com/python/mypy/pull/2873/commits/d6b370d2035bfe7861e62c43af22272b3d8974d3
python#2771https://github.com/python/mypy/issues/2771
)https://github.com/python/mypy/pull/2873/commits/d6b370d2035bfe7861e62c43af22272b3d8974d3
d6b370dhttps://github.com/python/mypy/pull/2873/commits/d6b370d2035bfe7861e62c43af22272b3d8974d3
https://github.com/miedzinski
Fix type annotationshttps://github.com/python/mypy/pull/2873/commits/950b383fed6141477d8f5c297153e8a01d1b1df5
950b383https://github.com/python/mypy/pull/2873/commits/950b383fed6141477d8f5c297153e8a01d1b1df5
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 15, 2017 https://github.com/python/mypy/pull/2873#pullrequestreview-22137459
View reviewed changes https://github.com/python/mypy/pull/2873/files/950b383fed6141477d8f5c297153e8a01d1b1df5
mypy/checkexpr.pyhttps://github.com/python/mypy/pull/2873/files/950b383fed6141477d8f5c297153e8a01d1b1df5#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07
ilevkivskyihttps://github.com/ilevkivskyi
Feb 15, 2017https://github.com/python/mypy/pull/2873#discussion_r101409304
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
mypy/subtypes.pyhttps://github.com/python/mypy/pull/2873/files/950b383fed6141477d8f5c297153e8a01d1b1df5#diff-3641fc675bdf772ec816dbb1b8ef258e9f07c15f604d83d7549bf7b873757a54
ilevkivskyihttps://github.com/ilevkivskyi
Feb 15, 2017https://github.com/python/mypy/pull/2873#discussion_r101410082
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
mypy/checker.pyhttps://github.com/python/mypy/pull/2873/files/950b383fed6141477d8f5c297153e8a01d1b1df5#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
ilevkivskyihttps://github.com/ilevkivskyi
Feb 15, 2017https://github.com/python/mypy/pull/2873#discussion_r101410772
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
mypy/typeanal.pyhttps://github.com/python/mypy/pull/2873/files/950b383fed6141477d8f5c297153e8a01d1b1df5#diff-cb65de0aabb09922bb9dca4a4221ac0ca58f6fa26b6fa2a74ac4a9e6fd3d8136
ilevkivskyihttps://github.com/ilevkivskyi
Feb 15, 2017https://github.com/python/mypy/pull/2873#discussion_r101410947
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
mypy/types.pyhttps://github.com/python/mypy/pull/2873/files/950b383fed6141477d8f5c297153e8a01d1b1df5#diff-265bbd9d8b179bfc6a75071cd473edbad7afbf73f011b830ac42c38438b60664
ilevkivskyihttps://github.com/ilevkivskyi
Feb 15, 2017https://github.com/python/mypy/pull/2873#discussion_r101411539
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
test-data/unit/check-classvar.testhttps://github.com/python/mypy/pull/2873/files/950b383fed6141477d8f5c297153e8a01d1b1df5#diff-65dbfcc0ba9b9588516658887e357d1a6a16e7a7199c73f8c0b50fb32ce041d3
ilevkivskyihttps://github.com/ilevkivskyi
Feb 15, 2017https://github.com/python/mypy/pull/2873#discussion_r101412736
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 15, 2017https://github.com/python/mypy/pull/2873#issuecomment-280180480
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/miedzinski
miedzinskihttps://github.com/miedzinski
Feb 15, 2017https://github.com/python/mypy/pull/2873#issuecomment-280182127
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 16, 2017https://github.com/python/mypy/pull/2873#issuecomment-280185522
Please reload this pagehttps://github.com/python/mypy/pull/2873
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/miedzinski
miedzinskihttps://github.com/miedzinski
Feb 16, 2017https://github.com/python/mypy/pull/2873#issuecomment-280186890
Please reload this pagehttps://github.com/python/mypy/pull/2873
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/elazarg
elazarghttps://github.com/elazarg
Feb 16, 2017https://github.com/python/mypy/pull/2873#issuecomment-280273397
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/miedzinski
Remove ClassVarType, use Var.is_classvar flaghttps://github.com/python/mypy/pull/2873/commits/cdfdbbc260e38141b90d07016c64b591a170e621
cdfdbbchttps://github.com/python/mypy/pull/2873/commits/cdfdbbc260e38141b90d07016c64b591a170e621
https://github.com/miedzinski
miedzinskihttps://github.com/miedzinski
force-pushedhttps://github.com/python/mypy/compare/27ddabcda653a215f5f32c059378cb05a1b733b3..cdfdbbc260e38141b90d07016c64b591a170e621
27ddabchttps://github.com/python/mypy/commit/27ddabcda653a215f5f32c059378cb05a1b733b3
cdfdbbchttps://github.com/python/mypy/commit/cdfdbbc260e38141b90d07016c64b591a170e621
Compare https://github.com/python/mypy/compare/27ddabcda653a215f5f32c059378cb05a1b733b3..cdfdbbc260e38141b90d07016c64b591a170e621
February 16, 2017 20:36https://github.com/python/mypy/pull/2873#event-965677434
https://github.com/miedzinski
miedzinskihttps://github.com/miedzinski
Feb 16, 2017https://github.com/python/mypy/pull/2873#issuecomment-280453429
@ilevkivskyihttps://github.com/ilevkivskyi
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/miedzinski
Add test case against TypeVarhttps://github.com/python/mypy/pull/2873/commits/01a7a69e98d61cf251194bc59364e43be2a39767
01a7a69https://github.com/python/mypy/pull/2873/commits/01a7a69e98d61cf251194bc59364e43be2a39767
https://github.com/miedzinski
miedzinskihttps://github.com/miedzinski
Feb 16, 2017https://github.com/python/mypy/pull/2873#issuecomment-280479147
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 17, 2017 https://github.com/python/mypy/pull/2873#pullrequestreview-22445911
View reviewed changes https://github.com/python/mypy/pull/2873/files/01a7a69e98d61cf251194bc59364e43be2a39767
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/2873#pullrequestreview-22445911
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
mypy/checkmember.pyhttps://github.com/python/mypy/pull/2873/files/01a7a69e98d61cf251194bc59364e43be2a39767#diff-b6a1cf066b85ca4f4de2404deb3df0fcdfa50663740257c516722be4ef4c3c58
ilevkivskyihttps://github.com/ilevkivskyi
Feb 17, 2017https://github.com/python/mypy/pull/2873#discussion_r101709228
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
miedzinskihttps://github.com/miedzinski
Feb 17, 2017https://github.com/python/mypy/pull/2873#discussion_r101771278
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
mypy/semanal.pyhttps://github.com/python/mypy/pull/2873/files/01a7a69e98d61cf251194bc59364e43be2a39767#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
ilevkivskyihttps://github.com/ilevkivskyi
Feb 17, 2017https://github.com/python/mypy/pull/2873#discussion_r101714999
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
miedzinskihttps://github.com/miedzinski
Feb 17, 2017https://github.com/python/mypy/pull/2873#discussion_r101770651
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
mypy/semanal.pyhttps://github.com/python/mypy/pull/2873/files/01a7a69e98d61cf251194bc59364e43be2a39767#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
ilevkivskyihttps://github.com/ilevkivskyi
Feb 17, 2017https://github.com/python/mypy/pull/2873#discussion_r101715424
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
mypy/typeanal.pyhttps://github.com/python/mypy/pull/2873/files/01a7a69e98d61cf251194bc59364e43be2a39767#diff-cb65de0aabb09922bb9dca4a4221ac0ca58f6fa26b6fa2a74ac4a9e6fd3d8136
ilevkivskyihttps://github.com/ilevkivskyi
Feb 17, 2017https://github.com/python/mypy/pull/2873#discussion_r101715691
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
test-data/unit/check-classvar.testhttps://github.com/python/mypy/pull/2873/files/01a7a69e98d61cf251194bc59364e43be2a39767#diff-65dbfcc0ba9b9588516658887e357d1a6a16e7a7199c73f8c0b50fb32ce041d3
ilevkivskyihttps://github.com/ilevkivskyi
Feb 17, 2017https://github.com/python/mypy/pull/2873#discussion_r101715976
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
test-data/unit/check-classvar.testhttps://github.com/python/mypy/pull/2873/files/01a7a69e98d61cf251194bc59364e43be2a39767#diff-65dbfcc0ba9b9588516658887e357d1a6a16e7a7199c73f8c0b50fb32ce041d3
ilevkivskyihttps://github.com/ilevkivskyi
Feb 17, 2017https://github.com/python/mypy/pull/2873#discussion_r101717353
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
miedzinskihttps://github.com/miedzinski
Feb 17, 2017https://github.com/python/mypy/pull/2873#discussion_r101770004
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
test-data/unit/check-classvar.testhttps://github.com/python/mypy/pull/2873/files/01a7a69e98d61cf251194bc59364e43be2a39767#diff-65dbfcc0ba9b9588516658887e357d1a6a16e7a7199c73f8c0b50fb32ce041d3
ilevkivskyihttps://github.com/ilevkivskyi
Feb 17, 2017https://github.com/python/mypy/pull/2873#discussion_r101717873
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
test-data/unit/semanal-classvar.testhttps://github.com/python/mypy/pull/2873/files/01a7a69e98d61cf251194bc59364e43be2a39767#diff-5b32410dd914d32b2b082a337998c81ab2ffce9d21690e63c3c5e683949d1bc1
ilevkivskyihttps://github.com/ilevkivskyi
Feb 17, 2017https://github.com/python/mypy/pull/2873#discussion_r101718692
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
miedzinskihttps://github.com/miedzinski
Feb 17, 2017https://github.com/python/mypy/pull/2873#discussion_r101770180
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
test-data/unit/semanal-classvar.testhttps://github.com/python/mypy/pull/2873/files/01a7a69e98d61cf251194bc59364e43be2a39767#diff-5b32410dd914d32b2b082a337998c81ab2ffce9d21690e63c3c5e683949d1bc1
ilevkivskyihttps://github.com/ilevkivskyi
Feb 17, 2017https://github.com/python/mypy/pull/2873#discussion_r101719957
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
miedzinskihttps://github.com/miedzinski
February 17, 2017 14:43https://github.com/python/mypy/pull/2873#commits-pushed-d52b4e3
https://github.com/miedzinski
Fix if statement in check_classvar_definitionhttps://github.com/python/mypy/pull/2873/commits/d52b4e3f5587c506dd91b0576f5b659019d59370
d52b4e3https://github.com/python/mypy/pull/2873/commits/d52b4e3f5587c506dd91b0576f5b659019d59370
https://github.com/miedzinski
Change error message about ClassVar arg counthttps://github.com/python/mypy/pull/2873/commits/15e1e85597b445641ec8ce172a3122dee2230729
15e1e85https://github.com/python/mypy/pull/2873/commits/15e1e85597b445641ec8ce172a3122dee2230729
https://github.com/miedzinski
Add more testshttps://github.com/python/mypy/pull/2873/commits/781245f586b05004e869718c364ab437d54ca95d
781245fhttps://github.com/python/mypy/pull/2873/commits/781245f586b05004e869718c364ab437d54ca95d
https://github.com/miedzinski
miedzinskihttps://github.com/miedzinski
Feb 17, 2017https://github.com/python/mypy/pull/2873#issuecomment-280676499
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 17, 2017 https://github.com/python/mypy/pull/2873#pullrequestreview-22536110
View reviewed changes https://github.com/python/mypy/pull/2873/files/781245f586b05004e869718c364ab437d54ca95d
test-data/unit/semanal-classvar.testhttps://github.com/python/mypy/pull/2873/files/781245f586b05004e869718c364ab437d54ca95d#diff-5b32410dd914d32b2b082a337998c81ab2ffce9d21690e63c3c5e683949d1bc1
ilevkivskyihttps://github.com/ilevkivskyi
Feb 17, 2017https://github.com/python/mypy/pull/2873#discussion_r101794204
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/miedzinski
Remove duplicate test casehttps://github.com/python/mypy/pull/2873/commits/cd61a5da7b912c603b783a90b4395e134ac90e91
cd61a5dhttps://github.com/python/mypy/pull/2873/commits/cd61a5da7b912c603b783a90b4395e134ac90e91
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 17, 2017https://github.com/python/mypy/pull/2873#issuecomment-280705468
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 17, 2017 https://github.com/python/mypy/pull/2873#pullrequestreview-22545833
View reviewed changes https://github.com/python/mypy/pull/2873/files/cd61a5da7b912c603b783a90b4395e134ac90e91
test-data/unit/check-classvar.testhttps://github.com/python/mypy/pull/2873/files/cd61a5da7b912c603b783a90b4395e134ac90e91#diff-65dbfcc0ba9b9588516658887e357d1a6a16e7a7199c73f8c0b50fb32ce041d3
ilevkivskyihttps://github.com/ilevkivskyi
Feb 17, 2017https://github.com/python/mypy/pull/2873#discussion_r101803264
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
ilevkivskyihttps://github.com/ilevkivskyi
Feb 22, 2017https://github.com/python/mypy/pull/2873#discussion_r102465524
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@miedzinskihttps://github.com/miedzinski
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 17, 2017https://github.com/python/mypy/pull/2873#issuecomment-280715666
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/miedzinski
Move ClassVar override checks to TypeCheckerhttps://github.com/python/mypy/pull/2873/commits/9c29911cb3ce8299f11dca6ed4018b1eec1dce54
9c29911https://github.com/python/mypy/pull/2873/commits/9c29911cb3ce8299f11dca6ed4018b1eec1dce54
https://github.com/miedzinski
miedzinskihttps://github.com/miedzinski
force-pushedhttps://github.com/python/mypy/compare/1de9b6add158ca573c2bb5e7ecc1a34f8005978b..9c29911cb3ce8299f11dca6ed4018b1eec1dce54
1de9b6ahttps://github.com/python/mypy/commit/1de9b6add158ca573c2bb5e7ecc1a34f8005978b
9c29911https://github.com/python/mypy/commit/9c29911cb3ce8299f11dca6ed4018b1eec1dce54
Compare https://github.com/python/mypy/compare/1de9b6add158ca573c2bb5e7ecc1a34f8005978b..9c29911cb3ce8299f11dca6ed4018b1eec1dce54
February 17, 2017 17:58https://github.com/python/mypy/pull/2873#event-967328966
https://github.com/miedzinski
Prohibit ClassVar inside other types or in signatureshttps://github.com/python/mypy/pull/2873/commits/b618718cf20988b3943010980387475795dc31bc
b618718https://github.com/python/mypy/pull/2873/commits/b618718cf20988b3943010980387475795dc31bc
https://github.com/miedzinski
miedzinskihttps://github.com/miedzinski
Feb 17, 2017 https://github.com/python/mypy/pull/2873#ref-issue-208542932
Generic class atributes aren't fully instantiated #2878 https://github.com/python/mypy/issues/2878
https://github.com/miedzinski
miedzinskihttps://github.com/miedzinski
Feb 17, 2017https://github.com/python/mypy/pull/2873#issuecomment-280753793
#2878https://github.com/python/mypy/issues/2878
Please reload this pagehttps://github.com/python/mypy/pull/2873
miedzinskihttps://github.com/miedzinski
February 17, 2017 22:18https://github.com/python/mypy/pull/2873#commits-pushed-cb6786f
https://github.com/miedzinski
Prohibit defining ClassVars on selfhttps://github.com/python/mypy/pull/2873/commits/cb6786fb6dea99ca9cf7821f7af9e57a1951d89c
cb6786fhttps://github.com/python/mypy/pull/2873/commits/cb6786fb6dea99ca9cf7821f7af9e57a1951d89c
https://github.com/miedzinski
Add more testshttps://github.com/python/mypy/pull/2873/commits/a427d61947a3290c9b7a9b291cb26d2da9c9ed8d
a427d61https://github.com/python/mypy/pull/2873/commits/a427d61947a3290c9b7a9b291cb26d2da9c9ed8d
https://github.com/miedzinski
miedzinskihttps://github.com/miedzinski
Feb 17, 2017https://github.com/python/mypy/pull/2873#issuecomment-280775051
@ilevkivskyihttps://github.com/ilevkivskyi
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 18, 2017 https://github.com/python/mypy/pull/2873#pullrequestreview-22634671
View reviewed changes https://github.com/python/mypy/pull/2873/files/a427d61947a3290c9b7a9b291cb26d2da9c9ed8d
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/2873#pullrequestreview-22634671
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
mypy/semanal.pyhttps://github.com/python/mypy/pull/2873/files/a427d61947a3290c9b7a9b291cb26d2da9c9ed8d#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
ilevkivskyihttps://github.com/ilevkivskyi
Feb 18, 2017https://github.com/python/mypy/pull/2873#discussion_r101889330
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
miedzinskihttps://github.com/miedzinski
Feb 18, 2017https://github.com/python/mypy/pull/2873#discussion_r101893835
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
mypy/semanal.pyhttps://github.com/python/mypy/pull/2873/files/a427d61947a3290c9b7a9b291cb26d2da9c9ed8d#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
ilevkivskyihttps://github.com/ilevkivskyi
Feb 18, 2017https://github.com/python/mypy/pull/2873#discussion_r101889382
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
mypy/typeanal.pyhttps://github.com/python/mypy/pull/2873/files/a427d61947a3290c9b7a9b291cb26d2da9c9ed8d#diff-cb65de0aabb09922bb9dca4a4221ac0ca58f6fa26b6fa2a74ac4a9e6fd3d8136
ilevkivskyihttps://github.com/ilevkivskyi
Feb 18, 2017https://github.com/python/mypy/pull/2873#discussion_r101889487
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
test-data/unit/check-classvar.testhttps://github.com/python/mypy/pull/2873/files/a427d61947a3290c9b7a9b291cb26d2da9c9ed8d#diff-65dbfcc0ba9b9588516658887e357d1a6a16e7a7199c73f8c0b50fb32ce041d3
ilevkivskyihttps://github.com/ilevkivskyi
Feb 18, 2017https://github.com/python/mypy/pull/2873#discussion_r101889665
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
test-data/unit/check-classvar.testhttps://github.com/python/mypy/pull/2873/files/a427d61947a3290c9b7a9b291cb26d2da9c9ed8d#diff-65dbfcc0ba9b9588516658887e357d1a6a16e7a7199c73f8c0b50fb32ce041d3
ilevkivskyihttps://github.com/ilevkivskyi
Feb 18, 2017https://github.com/python/mypy/pull/2873#discussion_r101889758
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
test-data/unit/semanal-classvar.testhttps://github.com/python/mypy/pull/2873/files/a427d61947a3290c9b7a9b291cb26d2da9c9ed8d#diff-5b32410dd914d32b2b082a337998c81ab2ffce9d21690e63c3c5e683949d1bc1
ilevkivskyihttps://github.com/ilevkivskyi
Feb 18, 2017https://github.com/python/mypy/pull/2873#discussion_r101889883
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
test-data/unit/semanal-classvar.testhttps://github.com/python/mypy/pull/2873/files/a427d61947a3290c9b7a9b291cb26d2da9c9ed8d#diff-5b32410dd914d32b2b082a337998c81ab2ffce9d21690e63c3c5e683949d1bc1
ilevkivskyihttps://github.com/ilevkivskyi
Feb 18, 2017https://github.com/python/mypy/pull/2873#discussion_r101889925
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
test-data/unit/semanal-classvar.testhttps://github.com/python/mypy/pull/2873/files/a427d61947a3290c9b7a9b291cb26d2da9c9ed8d#diff-5b32410dd914d32b2b082a337998c81ab2ffce9d21690e63c3c5e683949d1bc1
ilevkivskyihttps://github.com/ilevkivskyi
Feb 18, 2017https://github.com/python/mypy/pull/2873#discussion_r101890022
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
miedzinskihttps://github.com/miedzinski
February 18, 2017 13:57https://github.com/python/mypy/pull/2873#commits-pushed-35e2c68
https://github.com/miedzinski
Fix analysing implicit tuple typeshttps://github.com/python/mypy/pull/2873/commits/35e2c68b814c9b91eb394ed4aebbe30965025948
35e2c68https://github.com/python/mypy/pull/2873/commits/35e2c68b814c9b91eb394ed4aebbe30965025948
https://github.com/miedzinski
Add more meaningful error message on attribute overridehttps://github.com/python/mypy/pull/2873/commits/e12115807e89961f57320ce40ee738cfd7dbeebb
e121158https://github.com/python/mypy/pull/2873/commits/e12115807e89961f57320ce40ee738cfd7dbeebb
https://github.com/miedzinski
Add better error message on assignmentshttps://github.com/python/mypy/pull/2873/commits/5e2aafc26800a685e213280c1417664e0f000d0b
5e2aafchttps://github.com/python/mypy/pull/2873/commits/5e2aafc26800a685e213280c1417664e0f000d0b
https://github.com/miedzinski
Add more precise errors on ClassVar definitionshttps://github.com/python/mypy/pull/2873/commits/137215e0540fb895911c83f35d66830e9d62c1a3
137215ehttps://github.com/python/mypy/pull/2873/commits/137215e0540fb895911c83f35d66830e9d62c1a3
https://github.com/miedzinski
Minor style improvementshttps://github.com/python/mypy/pull/2873/commits/5dd131ab6e2585cbd3da717bfc371c8ce75ef056
5dd131ahttps://github.com/python/mypy/pull/2873/commits/5dd131ab6e2585cbd3da717bfc371c8ce75ef056
https://github.com/miedzinski
Prohibit ClassVars in for and with statementshttps://github.com/python/mypy/pull/2873/commits/30a4185245e1d6a99e1b7db5c013b54baa979680
30a4185https://github.com/python/mypy/pull/2873/commits/30a4185245e1d6a99e1b7db5c013b54baa979680
https://github.com/miedzinski
miedzinskihttps://github.com/miedzinski
Feb 18, 2017https://github.com/python/mypy/pull/2873#issuecomment-280848278
@ilevkivskyihttps://github.com/ilevkivskyi
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/miedzinski
Rename check_classvar_definition to is_classvarhttps://github.com/python/mypy/pull/2873/commits/bcce34d4825bdb5f157de216a95c0dd54048b413
bcce34dhttps://github.com/python/mypy/pull/2873/commits/bcce34d4825bdb5f157de216a95c0dd54048b413
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 19, 2017 https://github.com/python/mypy/pull/2873#pullrequestreview-22662698
View reviewed changes https://github.com/python/mypy/pull/2873/files/bcce34d4825bdb5f157de216a95c0dd54048b413
test-data/unit/semanal-classvar.testhttps://github.com/python/mypy/pull/2873/files/bcce34d4825bdb5f157de216a95c0dd54048b413#diff-5b32410dd914d32b2b082a337998c81ab2ffce9d21690e63c3c5e683949d1bc1
ilevkivskyihttps://github.com/ilevkivskyi
Feb 19, 2017https://github.com/python/mypy/pull/2873#discussion_r101921298
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 19, 2017https://github.com/python/mypy/pull/2873#issuecomment-280928405
@miedzinskihttps://github.com/miedzinski
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/miedzinski
Don't consider types in signatures as nestedhttps://github.com/python/mypy/pull/2873/commits/7ddca4bee90992031e1162f1667d9002ae6e351a
7ddca4bhttps://github.com/python/mypy/pull/2873/commits/7ddca4bee90992031e1162f1667d9002ae6e351a
https://github.com/miedzinski
miedzinskihttps://github.com/miedzinski
Feb 19, 2017https://github.com/python/mypy/pull/2873#issuecomment-280937912
@ilevkivskyihttps://github.com/ilevkivskyi
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 19, 2017https://github.com/python/mypy/pull/2873#issuecomment-280938475
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 19, 2017 https://github.com/python/mypy/pull/2873#pullrequestreview-22665946
View reviewed changes https://github.com/python/mypy/pull/2873/files/7ddca4bee90992031e1162f1667d9002ae6e351a
https://github.com/miedzinski
Prohibit generic class variableshttps://github.com/python/mypy/pull/2873/commits/92b3532dff7954cd59c8c2b900219d5b64c5f206
92b3532https://github.com/python/mypy/pull/2873/commits/92b3532dff7954cd59c8c2b900219d5b64c5f206
https://github.com/miedzinski
miedzinskihttps://github.com/miedzinski
Feb 22, 2017https://github.com/python/mypy/pull/2873#issuecomment-281741337
@ilevkivskyihttps://github.com/ilevkivskyi
#2878https://github.com/python/mypy/issues/2878
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 24, 2017https://github.com/python/mypy/pull/2873#issuecomment-282431520
#2878https://github.com/python/mypy/issues/2878
#2878 (comment)https://github.com/python/mypy/issues/2878#issuecomment-282302705
#2878https://github.com/python/mypy/issues/2878
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/miedzinski
Prohibit access to generic instance variables via classhttps://github.com/python/mypy/pull/2873/commits/20b1abe4df13f88ff03b513950f450937de47650
20b1abehttps://github.com/python/mypy/pull/2873/commits/20b1abe4df13f88ff03b513950f450937de47650
https://github.com/miedzinski
miedzinskihttps://github.com/miedzinski
Feb 28, 2017https://github.com/python/mypy/pull/2873#issuecomment-283086939
@ilevkivskyihttps://github.com/ilevkivskyi
#2878https://github.com/python/mypy/issues/2878
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Mar 1, 2017https://github.com/python/mypy/pull/2873#issuecomment-283280001
@JukkaLhttps://github.com/JukkaL
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Mar 8, 2017 https://github.com/python/mypy/pull/2873#pullrequestreview-25875767
View reviewed changes https://github.com/python/mypy/pull/2873/files/20b1abe4df13f88ff03b513950f450937de47650
test-data/unit/check-incremental.testhttps://github.com/python/mypy/pull/2873/files/20b1abe4df13f88ff03b513950f450937de47650#diff-9d27bf05ef2e69475128ad073eb20b12cd347361fef9982761aa1776ed1964a8
JukkaLhttps://github.com/JukkaL
Mar 8, 2017https://github.com/python/mypy/pull/2873#discussion_r105015185
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Mar 8, 2017https://github.com/python/mypy/pull/2873#issuecomment-285160380
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/mypy/pull/2873
miedzinskihttps://github.com/miedzinski
March 9, 2017 18:39https://github.com/python/mypy/pull/2873#commits-pushed-3362e65
https://github.com/miedzinski
Merge branch 'master' into classvarhttps://github.com/python/mypy/pull/2873/commits/3362e65940256d45e645ba358c9624d12a180d90
3362e65https://github.com/python/mypy/pull/2873/commits/3362e65940256d45e645ba358c9624d12a180d90
https://github.com/miedzinski
Add incremental checking testhttps://github.com/python/mypy/pull/2873/commits/5430b329e3e624984ebe0f85bde95aa53f58687c
5430b32https://github.com/python/mypy/pull/2873/commits/5430b329e3e624984ebe0f85bde95aa53f58687c
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
fb0917dhttps://github.com/python/mypy/commit/fb0917d08ff8316e2c3ebfff357852497c547e44
Mar 9, 2017https://github.com/python/mypy/pull/2873#event-993698877
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Mar 9, 2017https://github.com/python/mypy/pull/2873#issuecomment-285447874
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Apr 14, 2017 https://github.com/python/mypy/pull/2873#ref-issue-221750722
Type variables bound by a generic class make no sense in static or class methods. #3172 https://github.com/python/mypy/issues/3172
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2873
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/2873/files/20b1abe4df13f88ff03b513950f450937de47650
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/2873/files/7ddca4bee90992031e1162f1667d9002ae6e351a
Please reload this pagehttps://github.com/python/mypy/pull/2873
Please reload this pagehttps://github.com/python/mypy/pull/2873
https://github.com/miedzinski
https://github.com/ilevkivskyi
https://github.com/elazarg
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.