René's URL Explorer Experiment


Title: Conditional type-check based on callable call by afrieder · Pull Request #2627 · python/mypy · GitHub

Open Graph Title: Conditional type-check based on callable call by afrieder · Pull Request #2627 · python/mypy

X Title: Conditional type-check based on callable call by afrieder · Pull Request #2627 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #1973 This is my first PR to mypy, so let me know if this is out of scope, poor style, wrong, if it needs more tests, etc, etc. I'm happy to learn. The naïve thing is to make use of condi...

X Description: Fixes #1973 This is my first PR to mypy, so let me know if this is out of scope, poor style, wrong, if it needs more tests, etc, etc. I'm happy to learn. The naïve thing is to make use of c...

Opengraph URL: https://github.com/python/mypy/pull/2627

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7258b460-ad43-b172-fa2a-df5300af34d3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD22A:194E10:20EAA91:2CC01CB:6B001F90
html-safe-nonced4055c084cb00cb202f0b69fa51854880702abec2843450af3bb90408e129d70
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjJBOjE5NEUxMDoyMEVBQTkxOjJDQzAxQ0I6NkIwMDFGOTAiLCJ2aXNpdG9yX2lkIjoiNDc0NDEwOTU1OTk5NDM5MjQ2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4b891d539b8200905f8b7d985a42a88d65f4efe5766e924d4ce86be6d38f24fa
hovercard-subject-tagpull_request:99818306
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/2627/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ea3de628bc02638feca1864efff7302240e81a7ffa4372f0a271a136a230556e/python/mypy/pull/2627
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ea3de628bc02638feca1864efff7302240e81a7ffa4372f0a271a136a230556e/python/mypy/pull/2627
og:image:altFixes #1973 This is my first PR to mypy, so let me know if this is out of scope, poor style, wrong, if it needs more tests, etc, etc. I'm happy to learn. The naïve thing is to make use of condi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameafrieder
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/2627#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2627
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2627
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/2627
Reloadhttps://github.com/python/mypy/pull/2627
Reloadhttps://github.com/python/mypy/pull/2627
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
gvanrossumhttps://github.com/gvanrossum
python:masterhttps://github.com/python/mypy/tree/master
Conversationhttps://github.com/python/mypy/pull/2627
Commits4 (4)https://github.com/python/mypy/pull/2627/commits
Checkshttps://github.com/python/mypy/pull/2627/checks
Files changedhttps://github.com/python/mypy/pull/2627/files
Conditional type-check based on callable callhttps://github.com/python/mypy/pull/2627#top
gvanrossumhttps://github.com/gvanrossum
python:masterhttps://github.com/python/mypy/tree/master
https://github.com/afrieder
afriederhttps://github.com/afrieder
Jan 1, 2017https://github.com/python/mypy/pull/2627#issue-198257737
Please reload this pagehttps://github.com/python/mypy/pull/2627
#1973https://github.com/python/mypy/issues/1973
Please reload this pagehttps://github.com/python/mypy/pull/2627
https://github.com/ambv
ambvhttps://github.com/ambv
Jan 1, 2017 https://github.com/python/mypy/pull/2627#pullrequestreview-14817064
View reviewed changes https://github.com/python/mypy/pull/2627/files
ambvhttps://github.com/ambv
https://github.com/python/mypy/pull/2627#pullrequestreview-14817064
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2627
mypy/checker.pyhttps://github.com/python/mypy/pull/2627/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
ambvhttps://github.com/ambv
Jan 1, 2017https://github.com/python/mypy/pull/2627#discussion_r94288297
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2627
afriederhttps://github.com/afrieder
Jan 1, 2017https://github.com/python/mypy/pull/2627#discussion_r94289148
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2627
test-data/unit/fixtures/callable.pyihttps://github.com/python/mypy/pull/2627/files#diff-45baa061da0b30e66db670a6f6650ff3b94496d7785fc69d6f6cd0279c2864fe
ambvhttps://github.com/ambv
Jan 1, 2017https://github.com/python/mypy/pull/2627#discussion_r94288388
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#599https://github.com/python/mypy/issues/599
Please reload this pagehttps://github.com/python/mypy/pull/2627
https://github.com/ambv
ambvhttps://github.com/ambv
Jan 1, 2017https://github.com/python/mypy/pull/2627#issuecomment-269920422
Please reload this pagehttps://github.com/python/mypy/pull/2627
https://github.com/afrieder
afriederhttps://github.com/afrieder
Jan 2, 2017https://github.com/python/mypy/pull/2627#issuecomment-269926480
Please reload this pagehttps://github.com/python/mypy/pull/2627
Please reload this pagehttps://github.com/python/mypy/pull/2627
https://github.com/rwbarton
rwbartonhttps://github.com/rwbarton
Jan 2, 2017https://github.com/python/mypy/pull/2627#issuecomment-269929142
Please reload this pagehttps://github.com/python/mypy/pull/2627
https://github.com/afrieder
afriederhttps://github.com/afrieder
Jan 2, 2017https://github.com/python/mypy/pull/2627#issuecomment-269929563
Please reload this pagehttps://github.com/python/mypy/pull/2627
https://github.com/rwbarton
rwbartonhttps://github.com/rwbarton
Jan 2, 2017https://github.com/python/mypy/pull/2627#issuecomment-269930209
Please reload this pagehttps://github.com/python/mypy/pull/2627
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 2, 2017https://github.com/python/mypy/pull/2627#issuecomment-269930428
@JukkaLhttps://github.com/JukkaL
#1973https://github.com/python/mypy/issues/1973
Please reload this pagehttps://github.com/python/mypy/pull/2627
https://github.com/rwbarton
rwbartonhttps://github.com/rwbarton
Jan 2, 2017https://github.com/python/mypy/pull/2627#issuecomment-269930546
Please reload this pagehttps://github.com/python/mypy/pull/2627
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 2, 2017https://github.com/python/mypy/pull/2627#issuecomment-269930600
Please reload this pagehttps://github.com/python/mypy/pull/2627
https://github.com/rwbarton
rwbartonhttps://github.com/rwbarton
Jan 2, 2017https://github.com/python/mypy/pull/2627#issuecomment-269930691
Please reload this pagehttps://github.com/python/mypy/pull/2627
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 2, 2017https://github.com/python/mypy/pull/2627#issuecomment-269932805
Please reload this pagehttps://github.com/python/mypy/pull/2627
https://github.com/afrieder
afriederhttps://github.com/afrieder
Jan 2, 2017https://github.com/python/mypy/pull/2627#issuecomment-270034313
Please reload this pagehttps://github.com/python/mypy/pull/2627
Please reload this pagehttps://github.com/python/mypy/pull/2627
afriederhttps://github.com/afrieder
January 3, 2017 21:07https://github.com/python/mypy/pull/2627#commits-pushed-a985400
https://github.com/afrieder
Introduces conditional type inference based on callablehttps://github.com/python/mypy/pull/2627/commits/a985400c27cf492f91eb566637b2e89e0de4284c
a985400https://github.com/python/mypy/pull/2627/commits/a985400c27cf492f91eb566637b2e89e0de4284c
https://github.com/afrieder
Add tests for callable type-checkerhttps://github.com/python/mypy/pull/2627/commits/25c73d038105ff25cef08cd181bb84b60ec39e93
25c73d0https://github.com/python/mypy/pull/2627/commits/25c73d038105ff25cef08cd181bb84b60ec39e93
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 11, 2017https://github.com/python/mypy/pull/2627#issuecomment-271739698
@JukkaLhttps://github.com/JukkaL
Please reload this pagehttps://github.com/python/mypy/pull/2627
https://github.com/afrieder
afriederhttps://github.com/afrieder
Jan 11, 2017 https://github.com/python/mypy/pull/2627#pullrequestreview-16046458
View reviewed changes https://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93
mypy/checker.pyhttps://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
afriederhttps://github.com/afrieder
Jan 11, 2017https://github.com/python/mypy/pull/2627#discussion_r95490233
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2627
gvanrossumhttps://github.com/gvanrossum
Jan 11, 2017https://github.com/python/mypy/pull/2627#discussion_r95491074
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2627
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 11, 2017 https://github.com/python/mypy/pull/2627#pullrequestreview-16047325
View reviewed changes https://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93
mypy/checker.pyhttps://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
gvanrossumhttps://github.com/gvanrossum
Jan 11, 2017https://github.com/python/mypy/pull/2627#discussion_r95491074
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2627
mypy/checker.pyhttps://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
gvanrossumhttps://github.com/gvanrossum
Jan 11, 2017https://github.com/python/mypy/pull/2627#discussion_r95491119
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2627
mypy/checker.pyhttps://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
gvanrossumhttps://github.com/gvanrossum
Jan 11, 2017https://github.com/python/mypy/pull/2627#discussion_r95491246
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2627
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 11, 2017 https://github.com/python/mypy/pull/2627#pullrequestreview-16055066
View reviewed changes https://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93
mypy/checker.pyhttps://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
gvanrossumhttps://github.com/gvanrossum
Jan 11, 2017https://github.com/python/mypy/pull/2627#discussion_r95498826
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2627
mypy/checker.pyhttps://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
gvanrossumhttps://github.com/gvanrossum
Jan 11, 2017https://github.com/python/mypy/pull/2627#discussion_r95499228
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2627
afriederhttps://github.com/afrieder
January 10, 2017 21:34https://github.com/python/mypy/pull/2627#commits-pushed-4dd7b90
https://github.com/afrieder
Rewrote callable checking to work properlyhttps://github.com/python/mypy/pull/2627/commits/4dd7b905f1b9b87607ca0d910850d9ec402023b3
4dd7b90https://github.com/python/mypy/pull/2627/commits/4dd7b905f1b9b87607ca0d910850d9ec402023b3
https://github.com/afrieder
Added more testshttps://github.com/python/mypy/pull/2627/commits/de057d137d8f48ba5cb96bbf7f109a9960f70022
de057d1https://github.com/python/mypy/pull/2627/commits/de057d137d8f48ba5cb96bbf7f109a9960f70022
https://github.com/afrieder
afriederhttps://github.com/afrieder
Jan 11, 2017https://github.com/python/mypy/pull/2627#issuecomment-271770258
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/mypy/pull/2627
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jan 11, 2017https://github.com/python/mypy/pull/2627#issuecomment-271777199
Please reload this pagehttps://github.com/python/mypy/pull/2627
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
f8ff732https://github.com/python/mypy/commit/f8ff732945426b53320785a4a7850f05c972302d
Jan 11, 2017https://github.com/python/mypy/pull/2627#event-918582879
https://github.com/ddfisher
ddfisherhttps://github.com/ddfisher
Jan 19, 2017 https://github.com/python/mypy/pull/2627#ref-issue-201917403
Type of 'and' expressions may be too general #2716 https://github.com/python/mypy/issues/2716
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Dec 6, 2017 https://github.com/python/mypy/pull/2627#ref-issue-238271729
Calling callable in an if-condition makes mypy think branch in unreachable #3605 https://github.com/python/mypy/issues/3605
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Feb 20, 2021 https://github.com/python/mypy/pull/2627#ref-issue-812280867
inspect.isfunction and inspect.ismethod #10117 https://github.com/python/mypy/issues/10117
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2627
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93
https://github.com/ambv
ambv https://github.com/ambv
https://github.com/python/mypy/pull/2627/files/0f28b209410475c528111fae2918281c9e5614de
Please reload this pagehttps://github.com/python/mypy/pull/2627
Please reload this pagehttps://github.com/python/mypy/pull/2627
https://github.com/afrieder
https://github.com/ambv
https://github.com/rwbarton
https://github.com/gvanrossum
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.