| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7258b460-ad43-b172-fa2a-df5300af34d3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D22A:194E10:20EAA91:2CC01CB:6B001F90 |
| html-safe-nonce | d4055c084cb00cb202f0b69fa51854880702abec2843450af3bb90408e129d70 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjJBOjE5NEUxMDoyMEVBQTkxOjJDQzAxQ0I6NkIwMDFGOTAiLCJ2aXNpdG9yX2lkIjoiNDc0NDEwOTU1OTk5NDM5MjQ2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4b891d539b8200905f8b7d985a42a88d65f4efe5766e924d4ce86be6d38f24fa |
| hovercard-subject-tag | pull_request:99818306 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/2627/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ea3de628bc02638feca1864efff7302240e81a7ffa4372f0a271a136a230556e/python/mypy/pull/2627 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ea3de628bc02638feca1864efff7302240e81a7ffa4372f0a271a136a230556e/python/mypy/pull/2627 |
| og:image:alt | Fixes #1973
This is my first PR to mypy, so let me know if this is out of scope, poor style, wrong, if it needs more tests, etc, etc. I'm happy to learn.
The naïve thing is to make use of condi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | afrieder |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/2627#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2627 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2627 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/2627 |
| Reload | https://github.com/python/mypy/pull/2627 |
| Reload | https://github.com/python/mypy/pull/2627 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| gvanrossum | https://github.com/gvanrossum |
| python:master | https://github.com/python/mypy/tree/master |
| Conversation | https://github.com/python/mypy/pull/2627 |
| Commits4 (4) | https://github.com/python/mypy/pull/2627/commits |
| Checks | https://github.com/python/mypy/pull/2627/checks |
| Files changed | https://github.com/python/mypy/pull/2627/files |
| Conditional type-check based on callable call | https://github.com/python/mypy/pull/2627#top |
| gvanrossum | https://github.com/gvanrossum |
| python:master | https://github.com/python/mypy/tree/master |
|
| https://github.com/afrieder |
| afrieder | https://github.com/afrieder |
| Jan 1, 2017 | https://github.com/python/mypy/pull/2627#issue-198257737 |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| #1973 | https://github.com/python/mypy/issues/1973 |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| https://github.com/ambv |
| ambv | https://github.com/ambv |
|
Jan 1, 2017
| https://github.com/python/mypy/pull/2627#pullrequestreview-14817064 |
|
View reviewed changes
| https://github.com/python/mypy/pull/2627/files |
| ambv | https://github.com/ambv |
| https://github.com/python/mypy/pull/2627#pullrequestreview-14817064 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| mypy/checker.py | https://github.com/python/mypy/pull/2627/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| ambv | https://github.com/ambv |
| Jan 1, 2017 | https://github.com/python/mypy/pull/2627#discussion_r94288297 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| afrieder | https://github.com/afrieder |
| Jan 1, 2017 | https://github.com/python/mypy/pull/2627#discussion_r94289148 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| test-data/unit/fixtures/callable.pyi | https://github.com/python/mypy/pull/2627/files#diff-45baa061da0b30e66db670a6f6650ff3b94496d7785fc69d6f6cd0279c2864fe |
| ambv | https://github.com/ambv |
| Jan 1, 2017 | https://github.com/python/mypy/pull/2627#discussion_r94288388 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #599 | https://github.com/python/mypy/issues/599 |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| https://github.com/ambv |
| ambv | https://github.com/ambv |
| Jan 1, 2017 | https://github.com/python/mypy/pull/2627#issuecomment-269920422 |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| https://github.com/afrieder |
| afrieder | https://github.com/afrieder |
| Jan 2, 2017 | https://github.com/python/mypy/pull/2627#issuecomment-269926480 |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| https://github.com/rwbarton |
| rwbarton | https://github.com/rwbarton |
| Jan 2, 2017 | https://github.com/python/mypy/pull/2627#issuecomment-269929142 |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| https://github.com/afrieder |
| afrieder | https://github.com/afrieder |
| Jan 2, 2017 | https://github.com/python/mypy/pull/2627#issuecomment-269929563 |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| https://github.com/rwbarton |
| rwbarton | https://github.com/rwbarton |
| Jan 2, 2017 | https://github.com/python/mypy/pull/2627#issuecomment-269930209 |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Jan 2, 2017 | https://github.com/python/mypy/pull/2627#issuecomment-269930428 |
| @JukkaL | https://github.com/JukkaL |
| #1973 | https://github.com/python/mypy/issues/1973 |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| https://github.com/rwbarton |
| rwbarton | https://github.com/rwbarton |
| Jan 2, 2017 | https://github.com/python/mypy/pull/2627#issuecomment-269930546 |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Jan 2, 2017 | https://github.com/python/mypy/pull/2627#issuecomment-269930600 |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| https://github.com/rwbarton |
| rwbarton | https://github.com/rwbarton |
| Jan 2, 2017 | https://github.com/python/mypy/pull/2627#issuecomment-269930691 |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Jan 2, 2017 | https://github.com/python/mypy/pull/2627#issuecomment-269932805 |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| https://github.com/afrieder |
| afrieder | https://github.com/afrieder |
| Jan 2, 2017 | https://github.com/python/mypy/pull/2627#issuecomment-270034313 |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| afrieder | https://github.com/afrieder |
| January 3, 2017 21:07 | https://github.com/python/mypy/pull/2627#commits-pushed-a985400 |
|
| https://github.com/afrieder |
| Introduces conditional type inference based on callable | https://github.com/python/mypy/pull/2627/commits/a985400c27cf492f91eb566637b2e89e0de4284c |
| a985400 | https://github.com/python/mypy/pull/2627/commits/a985400c27cf492f91eb566637b2e89e0de4284c |
|
| https://github.com/afrieder |
| Add tests for callable type-checker | https://github.com/python/mypy/pull/2627/commits/25c73d038105ff25cef08cd181bb84b60ec39e93 |
| 25c73d0 | https://github.com/python/mypy/pull/2627/commits/25c73d038105ff25cef08cd181bb84b60ec39e93 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Jan 11, 2017 | https://github.com/python/mypy/pull/2627#issuecomment-271739698 |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| https://github.com/afrieder |
| afrieder | https://github.com/afrieder |
|
Jan 11, 2017
| https://github.com/python/mypy/pull/2627#pullrequestreview-16046458 |
|
View reviewed changes
| https://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93 |
| mypy/checker.py | https://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| afrieder | https://github.com/afrieder |
| Jan 11, 2017 | https://github.com/python/mypy/pull/2627#discussion_r95490233 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| gvanrossum | https://github.com/gvanrossum |
| Jan 11, 2017 | https://github.com/python/mypy/pull/2627#discussion_r95491074 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Jan 11, 2017
| https://github.com/python/mypy/pull/2627#pullrequestreview-16047325 |
|
View reviewed changes
| https://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93 |
| mypy/checker.py | https://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| gvanrossum | https://github.com/gvanrossum |
| Jan 11, 2017 | https://github.com/python/mypy/pull/2627#discussion_r95491074 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| mypy/checker.py | https://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| gvanrossum | https://github.com/gvanrossum |
| Jan 11, 2017 | https://github.com/python/mypy/pull/2627#discussion_r95491119 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| mypy/checker.py | https://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| gvanrossum | https://github.com/gvanrossum |
| Jan 11, 2017 | https://github.com/python/mypy/pull/2627#discussion_r95491246 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Jan 11, 2017
| https://github.com/python/mypy/pull/2627#pullrequestreview-16055066 |
|
View reviewed changes
| https://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93 |
| mypy/checker.py | https://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| gvanrossum | https://github.com/gvanrossum |
| Jan 11, 2017 | https://github.com/python/mypy/pull/2627#discussion_r95498826 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| mypy/checker.py | https://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| gvanrossum | https://github.com/gvanrossum |
| Jan 11, 2017 | https://github.com/python/mypy/pull/2627#discussion_r95499228 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| afrieder | https://github.com/afrieder |
| January 10, 2017 21:34 | https://github.com/python/mypy/pull/2627#commits-pushed-4dd7b90 |
|
| https://github.com/afrieder |
| Rewrote callable checking to work properly | https://github.com/python/mypy/pull/2627/commits/4dd7b905f1b9b87607ca0d910850d9ec402023b3 |
| 4dd7b90 | https://github.com/python/mypy/pull/2627/commits/4dd7b905f1b9b87607ca0d910850d9ec402023b3 |
|
| https://github.com/afrieder |
| Added more tests | https://github.com/python/mypy/pull/2627/commits/de057d137d8f48ba5cb96bbf7f109a9960f70022 |
| de057d1 | https://github.com/python/mypy/pull/2627/commits/de057d137d8f48ba5cb96bbf7f109a9960f70022 |
| https://github.com/afrieder |
| afrieder | https://github.com/afrieder |
| Jan 11, 2017 | https://github.com/python/mypy/pull/2627#issuecomment-271770258 |
| @gvanrossum | https://github.com/gvanrossum |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Jan 11, 2017 | https://github.com/python/mypy/pull/2627#issuecomment-271777199 |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| f8ff732 | https://github.com/python/mypy/commit/f8ff732945426b53320785a4a7850f05c972302d |
| Jan 11, 2017 | https://github.com/python/mypy/pull/2627#event-918582879 |
| https://github.com/ddfisher |
| ddfisher | https://github.com/ddfisher |
|
Jan 19, 2017
| https://github.com/python/mypy/pull/2627#ref-issue-201917403 |
|
Type of 'and' expressions may be too general
#2716
| https://github.com/python/mypy/issues/2716 |
| https://github.com/msullivan |
| msullivan | https://github.com/msullivan |
|
Dec 6, 2017
| https://github.com/python/mypy/pull/2627#ref-issue-238271729 |
|
Calling callable in an if-condition makes mypy think branch in unreachable
#3605
| https://github.com/python/mypy/issues/3605 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Feb 20, 2021
| https://github.com/python/mypy/pull/2627#ref-issue-812280867 |
|
inspect.isfunction and inspect.ismethod
#10117
| https://github.com/python/mypy/issues/10117 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2627 |
|
| https://github.com/gvanrossum |
|
gvanrossum
| https://github.com/gvanrossum |
|
| https://github.com/python/mypy/pull/2627/files/25c73d038105ff25cef08cd181bb84b60ec39e93 |
|
| https://github.com/ambv |
|
ambv
| https://github.com/ambv |
|
| https://github.com/python/mypy/pull/2627/files/0f28b209410475c528111fae2918281c9e5614de |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
| Please reload this page | https://github.com/python/mypy/pull/2627 |
|
| https://github.com/afrieder |
|
| https://github.com/ambv |
|
| https://github.com/rwbarton |
|
| https://github.com/gvanrossum |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |