| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9b4fce7e-50b3-d7d0-11f7-0de6d949b62c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CAC4:3E4AC7:22B13AE:2F03561:6B0025E5 |
| html-safe-nonce | 26011361fb8f0e2e682bcc3edcab588aca1fd46d346669890bb44e1bd8588098 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUM0OjNFNEFDNzoyMkIxM0FFOjJGMDM1NjE6NkIwMDI1RTUiLCJ2aXNpdG9yX2lkIjoiNzQzOTUyODUxODM4OTYwNTg2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e398f17364405286028920c8bf45c3441226bf756ea0ca4caf0456850b4ccf8d |
| hovercard-subject-tag | pull_request:96467191 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/2526/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b4040845f22c7483820fb9d383bc8b67d89c3f8ca11aebc59115d0088ebd6bd3/python/mypy/pull/2526 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b4040845f22c7483820fb9d383bc8b67d89c3f8ca11aebc59115d0088ebd6bd3/python/mypy/pull/2526 |
| og:image:alt | Partially resolves #2486 . If the approach here looks good I can extend the diff to recognize __setitem__ as well, which would fully resolve #2486 . |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | davidfstr |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/2526#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2526 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2526 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/2526 |
| Reload | https://github.com/python/mypy/pull/2526 |
| Reload | https://github.com/python/mypy/pull/2526 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| JukkaL | https://github.com/JukkaL |
| python:master | https://github.com/python/mypy/tree/master |
| davidfstr:typeddict_getitem | https://github.com/davidfstr/mypy/tree/typeddict_getitem |
| Conversation | https://github.com/python/mypy/pull/2526 |
| Commits2 (2) | https://github.com/python/mypy/pull/2526/commits |
| Checks | https://github.com/python/mypy/pull/2526/checks |
| Files changed | https://github.com/python/mypy/pull/2526/files |
| TypedDict: Recognize __getitem__ and __setitem__ access. | https://github.com/python/mypy/pull/2526#top |
| JukkaL | https://github.com/JukkaL |
| python:master | https://github.com/python/mypy/tree/master |
| davidfstr:typeddict_getitem | https://github.com/davidfstr/mypy/tree/typeddict_getitem |
|
| https://github.com/davidfstr |
| davidfstr | https://github.com/davidfstr |
| Dec 5, 2016 | https://github.com/python/mypy/pull/2526#issue-193408508 |
| #2486 | https://github.com/python/mypy/issues/2486 |
| #2486 | https://github.com/python/mypy/issues/2486 |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
| https://github.com/davidfstr |
| davidfstr | https://github.com/davidfstr |
|
Dec 5, 2016
| https://github.com/python/mypy/pull/2526#ref-issue-118277802 |
|
Dictionaries as structs
#985
| https://github.com/python/mypy/issues/985 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Dec 5, 2016 | https://github.com/python/mypy/pull/2526#issuecomment-264915081 |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
| https://github.com/davidfstr |
| davidfstr | https://github.com/davidfstr |
| Dec 6, 2016 | https://github.com/python/mypy/pull/2526#issuecomment-265060435 |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| Dec 7, 2016 | https://github.com/python/mypy/pull/2526#issuecomment-265583984 |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
| https://github.com/davidfstr |
| davidfstr | https://github.com/davidfstr |
| force-pushed | https://github.com/python/mypy/compare/3226d1cea3989d642a9e168439e21f872932a966..9f607209eaf6b00e2121b0ef885f5e3dc1230b28 |
| 3226d1c | https://github.com/python/mypy/commit/3226d1cea3989d642a9e168439e21f872932a966 |
| 9f60720 | https://github.com/python/mypy/commit/9f607209eaf6b00e2121b0ef885f5e3dc1230b28 |
|
Compare
| https://github.com/python/mypy/compare/3226d1cea3989d642a9e168439e21f872932a966..9f607209eaf6b00e2121b0ef885f5e3dc1230b28 |
| December 12, 2016 00:58 | https://github.com/python/mypy/pull/2526#event-889747061 |
| https://github.com/davidfstr |
| davidfstr | https://github.com/davidfstr |
| Dec 12, 2016 | https://github.com/python/mypy/pull/2526#event-889747203 |
| https://github.com/davidfstr |
| davidfstr | https://github.com/davidfstr |
| Dec 12, 2016 | https://github.com/python/mypy/pull/2526#issuecomment-266322507 |
| #2486 | https://github.com/python/mypy/issues/2486 |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Dec 13, 2016
| https://github.com/python/mypy/pull/2526#pullrequestreview-12708102 |
|
View reviewed changes
| https://github.com/python/mypy/pull/2526/files |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/2526#pullrequestreview-12708102 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
| test-data/unit/check-typeddict.test | https://github.com/python/mypy/pull/2526/files#diff-1db589b0c06e93bf0f492fb32a043ad16c054379c19cd39da57960e98c4b8be0 |
| JukkaL | https://github.com/JukkaL |
| Dec 13, 2016 | https://github.com/python/mypy/pull/2526#discussion_r92197363 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
| mypy/messages.py | https://github.com/python/mypy/pull/2526/files#diff-81ed300e83205366be4a93b57bbe65edb0826dbeda7f1655e506d5cc103c69c0 |
| JukkaL | https://github.com/JukkaL |
| Dec 13, 2016 | https://github.com/python/mypy/pull/2526#discussion_r92198821 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
| mypy/messages.py | https://github.com/python/mypy/pull/2526/files#diff-81ed300e83205366be4a93b57bbe65edb0826dbeda7f1655e506d5cc103c69c0 |
| JukkaL | https://github.com/JukkaL |
| Dec 13, 2016 | https://github.com/python/mypy/pull/2526#discussion_r92198893 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
| mypy/checkexpr.py | https://github.com/python/mypy/pull/2526/files#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07 |
| JukkaL | https://github.com/JukkaL |
| Dec 13, 2016 | https://github.com/python/mypy/pull/2526#discussion_r92199628 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
|
| https://github.com/davidfstr |
| TypedDict: Recognize __getitem__ and __setitem__ access. | https://github.com/python/mypy/pull/2526/commits/654eaf630b1c60975e15636f8076e6025a626659 |
| 654eaf6 | https://github.com/python/mypy/pull/2526/commits/654eaf630b1c60975e15636f8076e6025a626659 |
| https://github.com/davidfstr |
| davidfstr | https://github.com/davidfstr |
| force-pushed | https://github.com/python/mypy/compare/9f607209eaf6b00e2121b0ef885f5e3dc1230b28..ca7d07215fd9136b4f636ff206189e8db2a010ef |
| 9f60720 | https://github.com/python/mypy/commit/9f607209eaf6b00e2121b0ef885f5e3dc1230b28 |
| ca7d072 | https://github.com/python/mypy/commit/ca7d07215fd9136b4f636ff206189e8db2a010ef |
|
Compare
| https://github.com/python/mypy/compare/9f607209eaf6b00e2121b0ef885f5e3dc1230b28..ca7d07215fd9136b4f636ff206189e8db2a010ef |
| December 16, 2016 02:58 | https://github.com/python/mypy/pull/2526#event-896183950 |
| https://github.com/davidfstr |
| davidfstr | https://github.com/davidfstr |
| Dec 16, 2016 | https://github.com/python/mypy/pull/2526#issuecomment-267509219 |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Dec 16, 2016 | https://github.com/python/mypy/pull/2526#issuecomment-267528130 |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
| https://github.com/davidfstr |
| davidfstr | https://github.com/davidfstr |
| Dec 18, 2016 | https://github.com/python/mypy/pull/2526#issuecomment-267802791 |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
| https://github.com/davidfstr |
| davidfstr | https://github.com/davidfstr |
| Dec 18, 2016 | https://github.com/python/mypy/pull/2526#issuecomment-267803070 |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
|
| https://github.com/davidfstr |
| Integrate feedback. | https://github.com/python/mypy/pull/2526/commits/7b1258284dacf503664153ff62969616be90a112 |
| 7b12582 | https://github.com/python/mypy/pull/2526/commits/7b1258284dacf503664153ff62969616be90a112 |
| https://github.com/davidfstr |
| davidfstr | https://github.com/davidfstr |
| force-pushed | https://github.com/python/mypy/compare/ca7d07215fd9136b4f636ff206189e8db2a010ef..7b1258284dacf503664153ff62969616be90a112 |
| ca7d072 | https://github.com/python/mypy/commit/ca7d07215fd9136b4f636ff206189e8db2a010ef |
| 7b12582 | https://github.com/python/mypy/commit/7b1258284dacf503664153ff62969616be90a112 |
|
Compare
| https://github.com/python/mypy/compare/ca7d07215fd9136b4f636ff206189e8db2a010ef..7b1258284dacf503664153ff62969616be90a112 |
| December 18, 2016 04:49 | https://github.com/python/mypy/pull/2526#event-897762134 |
| https://github.com/davidfstr |
| davidfstr | https://github.com/davidfstr |
| Dec 18, 2016 | https://github.com/python/mypy/pull/2526#issuecomment-267803455 |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| Dec 20, 2016 | https://github.com/python/mypy/pull/2526#issuecomment-268303219 |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| 8453dda | https://github.com/python/mypy/commit/8453dda84ada8581d38d622df740aa75b5e67622 |
| Dec 20, 2016 | https://github.com/python/mypy/pull/2526#event-900446234 |
| https://github.com/davidfstr |
| davidfstr | https://github.com/davidfstr |
| January 22, 2017 22:45 | https://github.com/python/mypy/pull/2526#event-932138430 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2526 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/2526/files/9f607209eaf6b00e2121b0ef885f5e3dc1230b28 |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
|
Getting and setting items of TypedDict
| https://github.com/python/mypy/issues/2486 |
| Please reload this page | https://github.com/python/mypy/pull/2526 |
|
| https://github.com/davidfstr |
|
| https://github.com/gvanrossum |
|
| https://github.com/JukkaL |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |