| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1b4bd00f-999f-51e8-e8e6-f628bb4c98e4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C312:B7CF9:6AF764:8EBB0D:6B003617 |
| html-safe-nonce | 8e0526ddd657bdd38e9ce219f521e9cd01b4d0ae8e7e96650f1d4edb73a22c38 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzEyOkI3Q0Y5OjZBRjc2NDo4RUJCMEQ6NkIwMDM2MTciLCJ2aXNpdG9yX2lkIjoiODE5Mjk3OTc3NDgzNTAxMzE0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6ab975569a7bc880a1d297dcda2d58b923a3bb5500aa7cc9a2932c4af94ad523 |
| hovercard-subject-tag | pull_request:93993819 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/2465/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/75098ae5c8f5f1c7e5f0c45c9302647169552879bcfc4c0d7fcdfa7605a11fbc/python/mypy/pull/2465 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/75098ae5c8f5f1c7e5f0c45c9302647169552879bcfc4c0d7fcdfa7605a11fbc/python/mypy/pull/2465 |
| og:image:alt | Fixes #1691
Fixes #2456
This is a simple-minded fix. In the future we could add more rules for tuples in meet.py (for example for homogeneous tuples, a tuple and an iterable etc).
Tests are based o... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ilevkivskyi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/2465#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2465 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2465 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/2465 |
| Reload | https://github.com/python/mypy/pull/2465 |
| Reload | https://github.com/python/mypy/pull/2465 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| JukkaL | https://github.com/JukkaL |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:fix-union-tuple | https://github.com/ilevkivskyi/mypy/tree/fix-union-tuple |
| Conversation | https://github.com/python/mypy/pull/2465 |
| Commits3 (3) | https://github.com/python/mypy/pull/2465/commits |
| Checks | https://github.com/python/mypy/pull/2465/checks |
| Files changed | https://github.com/python/mypy/pull/2465/files |
| meet.py should consider all Tuple[t1, t2, ...] as subtypes of plain tuple | https://github.com/python/mypy/pull/2465#top |
| JukkaL | https://github.com/JukkaL |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:fix-union-tuple | https://github.com/ilevkivskyi/mypy/tree/fix-union-tuple |
|
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Nov 16, 2016 | https://github.com/python/mypy/pull/2465#issue-189748671 |
| #1691 | https://github.com/python/mypy/issues/1691 |
| #2456 | https://github.com/python/mypy/issues/2456 |
| Please reload this page | https://github.com/python/mypy/pull/2465 |
|
| https://github.com/ilevkivskyi |
| Fix isinstance(Tuple[int, str], tuple) | https://github.com/python/mypy/pull/2465/commits/d4c4c2263e78f3d16656382227aeea73c29e1c80 |
| d4c4c22 | https://github.com/python/mypy/pull/2465/commits/d4c4c2263e78f3d16656382227aeea73c29e1c80 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| Nov 16, 2016 | https://github.com/python/mypy/pull/2465#issuecomment-260997462 |
| Please reload this page | https://github.com/python/mypy/pull/2465 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Nov 22, 2016 | https://github.com/python/mypy/pull/2465#issuecomment-262228828 |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/2465 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Nov 22, 2016
| https://github.com/python/mypy/pull/2465#pullrequestreview-9658908 |
|
View reviewed changes
| https://github.com/python/mypy/pull/2465/files/d4c4c2263e78f3d16656382227aeea73c29e1c80 |
| mypy/meet.py | https://github.com/python/mypy/pull/2465/files/d4c4c2263e78f3d16656382227aeea73c29e1c80#diff-cdffaffb73fce8b49d0e95f9edde45fcd45462465182c182a41e022d897da965 |
| JukkaL | https://github.com/JukkaL |
| Nov 22, 2016 | https://github.com/python/mypy/pull/2465#discussion_r89110547 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2465 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Nov 22, 2016 | https://github.com/python/mypy/pull/2465#discussion_r89126770 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/2465 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Nov 22, 2016
| https://github.com/python/mypy/pull/2465#pullrequestreview-9659120 |
|
View reviewed changes
| https://github.com/python/mypy/pull/2465/files/d4c4c2263e78f3d16656382227aeea73c29e1c80 |
| test-data/unit/check-tuples.test | https://github.com/python/mypy/pull/2465/files/d4c4c2263e78f3d16656382227aeea73c29e1c80#diff-2f422513eaffa66a44d24f865707a7dd06766b68f38bf4aefd465aa1fdf8adba |
| JukkaL | https://github.com/JukkaL |
| Nov 22, 2016 | https://github.com/python/mypy/pull/2465#discussion_r89110772 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2465 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Nov 22, 2016 | https://github.com/python/mypy/pull/2465#discussion_r89126803 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/2465 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Nov 22, 2016
| https://github.com/python/mypy/pull/2465#pullrequestreview-9659413 |
|
View reviewed changes
| https://github.com/python/mypy/pull/2465/files/d4c4c2263e78f3d16656382227aeea73c29e1c80 |
| test-data/unit/check-tuples.test | https://github.com/python/mypy/pull/2465/files/d4c4c2263e78f3d16656382227aeea73c29e1c80#diff-2f422513eaffa66a44d24f865707a7dd06766b68f38bf4aefd465aa1fdf8adba |
| JukkaL | https://github.com/JukkaL |
| Nov 22, 2016 | https://github.com/python/mypy/pull/2465#discussion_r89111068 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2465 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| Nov 22, 2016 | https://github.com/python/mypy/pull/2465#issuecomment-262236018 |
| Please reload this page | https://github.com/python/mypy/pull/2465 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| November 22, 2016 14:14 | https://github.com/python/mypy/pull/2465#commits-pushed-bc1b89e |
|
| https://github.com/ilevkivskyi |
| Simplify tests by --hide-error-context | https://github.com/python/mypy/pull/2465/commits/bc1b89e6b9e70e504ce0df4e2af4ebb16e877625 |
| bc1b89e | https://github.com/python/mypy/pull/2465/commits/bc1b89e6b9e70e504ce0df4e2af4ebb16e877625 |
|
| https://github.com/ilevkivskyi |
| Make meet for tuples apply to all homogeneous tuples | https://github.com/python/mypy/pull/2465/commits/bdd027e9043080ba2682b8276c25b0e2ecbe600d |
| bdd027e | https://github.com/python/mypy/pull/2465/commits/bdd027e9043080ba2682b8276c25b0e2ecbe600d |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Nov 22, 2016 | https://github.com/python/mypy/pull/2465#issuecomment-262256508 |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/2465 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| Nov 22, 2016 | https://github.com/python/mypy/pull/2465#issuecomment-262261525 |
| Please reload this page | https://github.com/python/mypy/pull/2465 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| 5f8c447 | https://github.com/python/mypy/commit/5f8c44762f35bf34d7107c3425b977ac7880ae4d |
| Nov 22, 2016 | https://github.com/python/mypy/pull/2465#event-868308530 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2465 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/2465/files/d4c4c2263e78f3d16656382227aeea73c29e1c80 |
| Please reload this page | https://github.com/python/mypy/pull/2465 |
|
isinstance checks don't work with tuple types
| https://github.com/python/mypy/issues/2456 |
|
Variable incorrectly typed as None, misleading error message
| https://github.com/python/mypy/issues/1691 |
| Please reload this page | https://github.com/python/mypy/pull/2465 |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/JukkaL |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |