René's URL Explorer Experiment


Title: fix: ClassVar[Final[...]] collapses to Any instead of inner type (#21906) by chenzeyan54-commits · Pull Request #22012 · python/mypy · GitHub

Open Graph Title: fix: ClassVar[Final[...]] collapses to Any instead of inner type (#21906) by chenzeyan54-commits · Pull Request #22012 · python/mypy

X Title: fix: ClassVar[Final[...]] collapses to Any instead of inner type (#21906) by chenzeyan54-commits · Pull Request #22012 · python/mypy

Description: Summary Fixes #21906 On Python 3.13+, ClassVar[Final[...]] accepts the annotation (no valid-type error), but the variable's type still silently collapses to AnyType(from_error), losing all type information. Root Cause In try_analyze_special_unbound_type's FINAL_TYPE_NAMES branch, when self.allow_final is True (i.e. the nested Final is legitimately accepted, e.g. inside ClassVar[Final[...]] on 3.13+), the code fell through to return AnyType(TypeOfAny.from_error) instead of analyzing the inner type. Fix In the same branch, when self.allow_final is True and the Final has type arguments, preserve and return the inner type by recursing into anal_type(t.args[0]): elif not self.allow_final: self.fail( "Final can be only used as an outermost qualifier ...", t, code=codes.VALID_TYPE, ) elif t.args: # Nested Final[...] is accepted here (e.g. ClassVar[Final[...]] on 3.13+); # preserve and return the inner type instead of collapsing to Any. return self.anal_type(t.args[0]) return AnyType(TypeOfAny.from_error) Verification Added regression guard testFinalUsedWithClassVarAfterPy313PreservesType in test-data/unit/check-final.test — reveal_type(A.cv) reports builtins.dict[type[B], __main__.A instead of Any. Existing testFinalUsedWithClassVarAfterPy313 (no error) and testFinalUsedWithClassVar (3.12 still errors) are unaffected.

Open Graph Description: Summary Fixes #21906 On Python 3.13+, ClassVar[Final[...]] accepts the annotation (no valid-type error), but the variable's type still silently collapses to AnyType(from_error), losing all type...

X Description: Summary Fixes #21906 On Python 3.13+, ClassVar[Final[...]] accepts the annotation (no valid-type error), but the variable's type still silently collapses to AnyType(from_error), losing all ...

Opengraph URL: https://github.com/python/mypy/pull/22012

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:76541455-47d0-1e16-27aa-8b7a4928e408
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A1E:177432:2CF299:3A3DB8:6AFFA699
html-safe-nonce1ded60a46dfedbbc894085448c084d331640e8b40050a4bb3a5cb448f88a1047
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTFFOjE3NzQzMjoyQ0YyOTk6M0EzREI4OjZBRkZBNjk5IiwidmlzaXRvcl9pZCI6IjI2NzA5NzQwODA4MTA3MjI5NjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac45a55c9ad81526023cd68e3ae18aee0585d4f58fb027e27a2f714d2e302e0f22
hovercard-subject-tagpull_request:4584957219
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/mypy/pull/22012/files
twitter:imagehttps://avatars.githubusercontent.com/u/263139938?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/263139938?s=400&v=4
og:image:altSummary Fixes #21906 On Python 3.13+, ClassVar[Final[...]] accepts the annotation (no valid-type error), but the variable's type still silently collapses to AnyType(from_error), losing all type...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None6a41d7f592f24f38b58637f25dec5e9e26cb838995072a495a552ba4e4eecf75
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0e75efa5f34074f831bc22b1a793c40d20fa144b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/mypy/pull/22012/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F22012%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F22012%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/22012/files
Reloadhttps://github.com/python/mypy/pull/22012/files
Reloadhttps://github.com/python/mypy/pull/22012/files
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fmypy%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fmypy%2Fissues%2Fnew%2Fchoose
chenzeyan54-commitshttps://github.com/chenzeyan54-commits
python:masterhttps://github.com/python/mypy/tree/master
chenzeyan54-commits:fix/classvar-final-inner-type-21906https://github.com/chenzeyan54-commits/mypy/tree/fix/classvar-final-inner-type-21906
Conversation 1 https://github.com/python/mypy/pull/22012
Commits 1 https://github.com/python/mypy/pull/22012/commits
Checks 24 https://github.com/python/mypy/pull/22012/checks
Files changed https://github.com/python/mypy/pull/22012/files
Please reload this pagehttps://github.com/python/mypy/pull/22012/files
fix: ClassVar[Final[...]] collapses to Any instead of inner type (#21906) https://github.com/python/mypy/pull/22012/files#top
Show all changes 1 commit https://github.com/python/mypy/pull/22012/files
5d4321f fix: ClassVar[Final[...]] collapses to Any instead of inner type (#21… Sep 20, 2026 https://github.com/python/mypy/pull/22012/commits/5d4321f1132e6e02adbe05e9ef031dde07a47fbf
Clear filters https://github.com/python/mypy/pull/22012/files
Please reload this pagehttps://github.com/python/mypy/pull/22012/files
Please reload this pagehttps://github.com/python/mypy/pull/22012/files
typeanal.py https://github.com/python/mypy/pull/22012/files#diff-cb65de0aabb09922bb9dca4a4221ac0ca58f6fa26b6fa2a74ac4a9e6fd3d8136
check-final.test https://github.com/python/mypy/pull/22012/files#diff-f4872f5865881c8964f6166a87c1c3aa1cc120e27cfdb8c050b547cf4282de47
mypy/typeanal.pyhttps://github.com/python/mypy/pull/22012/files#diff-cb65de0aabb09922bb9dca4a4221ac0ca58f6fa26b6fa2a74ac4a9e6fd3d8136
View file https://github.com/python/mypy/blob/5d4321f1132e6e02adbe05e9ef031dde07a47fbf/mypy/typeanal.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/22012/{{ revealButtonHref }}
https://github.com/python/mypy/pull/22012/files#diff-cb65de0aabb09922bb9dca4a4221ac0ca58f6fa26b6fa2a74ac4a9e6fd3d8136
https://github.com/python/mypy/pull/22012/files#diff-cb65de0aabb09922bb9dca4a4221ac0ca58f6fa26b6fa2a74ac4a9e6fd3d8136
test-data/unit/check-final.testhttps://github.com/python/mypy/pull/22012/files#diff-f4872f5865881c8964f6166a87c1c3aa1cc120e27cfdb8c050b547cf4282de47
View file https://github.com/python/mypy/blob/5d4321f1132e6e02adbe05e9ef031dde07a47fbf/test-data/unit/check-final.test
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/22012/{{ revealButtonHref }}
https://github.com/python/mypy/pull/22012/files#diff-f4872f5865881c8964f6166a87c1c3aa1cc120e27cfdb8c050b547cf4282de47
https://github.com/python/mypy/pull/22012/files#diff-f4872f5865881c8964f6166a87c1c3aa1cc120e27cfdb8c050b547cf4282de47
Please reload this pagehttps://github.com/python/mypy/pull/22012/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.