| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7d0dd0ca-f7d0-2a40-27ef-b904fda35d83 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E222:251AC0:B98906:F6274B:6B004A47 |
| html-safe-nonce | 771dd716752f700b52f50e00a9b8ae6df7d186005f2aacb93f0634cdfe04a1eb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjIyOjI1MUFDMDpCOTg5MDY6RjYyNzRCOjZCMDA0QTQ3IiwidmlzaXRvcl9pZCI6IjY1NTU4ODkxNTgxNjA2NjUxNTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ce0a1a488f8ccc1a696adb39fd08d7e912b631854811ab0ab48604ac1319aa8d |
| hovercard-subject-tag | pull_request:87150205 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/2191/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fc807a63ed68afaffa6c942ed1ebd42590fe613b0e4df82b48e281d108304ba5/python/mypy/pull/2191 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fc807a63ed68afaffa6c942ed1ebd42590fe613b0e4df82b48e281d108304ba5/python/mypy/pull/2191 |
| og:image:alt | This is based on a TODO from pull request #2168 to fix the behavior for checking bytes in Python 3 when the minor version is less than 3.5. Per #2168, bytes formatting in Python 3 is only supported... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | buckbaskin |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b27c5dde30676028abd5c5fc53ce5c9b625f8281 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/2191#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2191 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2191 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/2191 |
| Reload | https://github.com/python/mypy/pull/2191 |
| Reload | https://github.com/python/mypy/pull/2191 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests545 (545) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| gvanrossum | https://github.com/gvanrossum |
| python:master | https://github.com/python/mypy/tree/master |
| buckbaskin:addPyversion2 | https://github.com/buckbaskin/mypy/tree/addPyversion2 |
| Conversation | https://github.com/python/mypy/pull/2191 |
| Commits17 (17) | https://github.com/python/mypy/pull/2191/commits |
| Checks | https://github.com/python/mypy/pull/2191/checks |
| Files changed | https://github.com/python/mypy/pull/2191/files |
| Use pyversion variable to change bytes checking for python 3 less than 3.5 | https://github.com/python/mypy/pull/2191#top |
| gvanrossum | https://github.com/gvanrossum |
| python:master | https://github.com/python/mypy/tree/master |
| buckbaskin:addPyversion2 | https://github.com/buckbaskin/mypy/tree/addPyversion2 |
|
| https://github.com/buckbaskin |
| buckbaskin | https://github.com/buckbaskin |
| Sep 28, 2016 | https://github.com/python/mypy/pull/2191#issue-179815762 |
| #2168 | https://github.com/python/mypy/pull/2168 |
| #2168 | https://github.com/python/mypy/pull/2168 |
| Please reload this page | https://github.com/python/mypy/pull/2191 |
| September 14, 2016 12:09 | https://github.com/python/mypy/pull/2191#commits-pushed-34ffd12 |
| Add a code example for the typing.IO module | https://github.com/python/mypy/pull/2191/commits/34ffd126504e03c75325161ecf93dc92d1202c7c |
| 34ffd12 | https://github.com/python/mypy/pull/2191/commits/34ffd126504e03c75325161ecf93dc92d1202c7c |
| Merge branch 'master' of | https://github.com/python/mypy/pull/2191/commits/190a12074fa34dda650837eb72b787e7d71e2c01 |
| https://github.com/python/mypy | https://github.com/python/mypy |
| 190a120 | https://github.com/python/mypy/pull/2191/commits/190a12074fa34dda650837eb72b787e7d71e2c01 |
| Merge branch 'master' of | https://github.com/python/mypy/pull/2191/commits/ca645f2a02c768e8e897c0a239f8e93ee9ceb12e |
| https://github.com/python/mypy | https://github.com/python/mypy |
| ca645f2 | https://github.com/python/mypy/pull/2191/commits/ca645f2a02c768e8e897c0a239f8e93ee9ceb12e |
| Merge branch 'master' of | https://github.com/python/mypy/pull/2191/commits/f52bcd3a83d43acd1404a5144feafbc15eedc0c3 |
| https://github.com/python/mypy | https://github.com/python/mypy |
| f52bcd3 | https://github.com/python/mypy/pull/2191/commits/f52bcd3a83d43acd1404a5144feafbc15eedc0c3 |
| Merge branch 'master' of | https://github.com/python/mypy/pull/2191/commits/f27e28b94c745c3fbba608efc4ee29b7d8f33f2e |
| https://github.com/python/mypy | https://github.com/python/mypy |
| f27e28b | https://github.com/python/mypy/pull/2191/commits/f27e28b94c745c3fbba608efc4ee29b7d8f33f2e |
| First commit for checking with pyversion | https://github.com/python/mypy/pull/2191/commits/dc69cb551866a515e61723b9e0255648315b7f4b |
| dc69cb5 | https://github.com/python/mypy/pull/2191/commits/dc69cb551866a515e61723b9e0255648315b7f4b |
| Fix 3 lint errors | https://github.com/python/mypy/pull/2191/commits/31f97b1133b14c981ce2f08e503373e141a4640e |
| 31f97b1 | https://github.com/python/mypy/pull/2191/commits/31f97b1133b14c981ce2f08e503373e141a4640e |
| Remove extra print statement | https://github.com/python/mypy/pull/2191/commits/e211611292bdd9bde8f88061c3fb0a17a3e176c9 |
| e211611 | https://github.com/python/mypy/pull/2191/commits/e211611292bdd9bde8f88061c3fb0a17a3e176c9 |
| Fix TODO for different behavior below Python 3.5 | https://github.com/python/mypy/pull/2191/commits/38478b8db0dbce330601ee9617c76ad1d7ee365a |
| 38478b8 | https://github.com/python/mypy/pull/2191/commits/38478b8db0dbce330601ee9617c76ad1d7ee365a |
| Merge branch 'master' of | https://github.com/python/mypy/pull/2191/commits/d501c10214ddf06c1764b75a991c49291a3d7ff5 |
| https://github.com/python/mypy | https://github.com/python/mypy |
| into addPyver… | https://github.com/python/mypy/pull/2191/commits/d501c10214ddf06c1764b75a991c49291a3d7ff5 |
| d501c10 | https://github.com/python/mypy/pull/2191/commits/d501c10214ddf06c1764b75a991c49291a3d7ff5 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Sep 28, 2016
| https://github.com/python/mypy/pull/2191#pullrequestreview-1978739 |
|
View reviewed changes
| https://github.com/python/mypy/pull/2191/files/d501c10214ddf06c1764b75a991c49291a3d7ff5 |
| gvanrossum | https://github.com/gvanrossum |
| https://github.com/python/mypy/pull/2191#pullrequestreview-1978739 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2191 |
| mypy/checker.py | https://github.com/python/mypy/pull/2191/files/d501c10214ddf06c1764b75a991c49291a3d7ff5#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| gvanrossum | https://github.com/gvanrossum |
| Sep 28, 2016 | https://github.com/python/mypy/pull/2191#discussion_r80962748 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2191 |
| mypy/checkexpr.py | https://github.com/python/mypy/pull/2191/files/d501c10214ddf06c1764b75a991c49291a3d7ff5#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07 |
| gvanrossum | https://github.com/gvanrossum |
| Sep 28, 2016 | https://github.com/python/mypy/pull/2191#discussion_r80963003 |
| Please reload this page | https://github.com/python/mypy/pull/2191 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2191 |
| mypy/build.py | https://github.com/python/mypy/pull/2191/files/d501c10214ddf06c1764b75a991c49291a3d7ff5#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998 |
| gvanrossum | https://github.com/gvanrossum |
| Sep 28, 2016 | https://github.com/python/mypy/pull/2191#discussion_r80963325 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2191 |
| mypy/checkstrformat.py | https://github.com/python/mypy/pull/2191/files/d501c10214ddf06c1764b75a991c49291a3d7ff5#diff-11d0c95de3a5c95b84ff3e1a28a16ea78f32aebbdbb21f2974dcf69437838e3e |
| gvanrossum | https://github.com/gvanrossum |
| Sep 28, 2016 | https://github.com/python/mypy/pull/2191#discussion_r80963547 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2191 |
| mypy/checkstrformat.py | https://github.com/python/mypy/pull/2191/files/d501c10214ddf06c1764b75a991c49291a3d7ff5#diff-11d0c95de3a5c95b84ff3e1a28a16ea78f32aebbdbb21f2974dcf69437838e3e |
| gvanrossum | https://github.com/gvanrossum |
| Sep 28, 2016 | https://github.com/python/mypy/pull/2191#discussion_r80964041 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2191 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Sep 29, 2016 | https://github.com/python/mypy/pull/2191#event-807701260 |
| October 5, 2016 01:11 | https://github.com/python/mypy/pull/2191#commits-pushed-ba94521 |
| Add a type annotation to pyversion | https://github.com/python/mypy/pull/2191/commits/ba945219972da47e79b2e5d4c6a5133394f896d7 |
| ba94521 | https://github.com/python/mypy/pull/2191/commits/ba945219972da47e79b2e5d4c6a5133394f896d7 |
| Move python version checking out of check_str_interpolation | https://github.com/python/mypy/pull/2191/commits/43a5b5948c3151e601d8dd48e30938ee259f7c30 |
| 43a5b59 | https://github.com/python/mypy/pull/2191/commits/43a5b5948c3151e601d8dd48e30938ee259f7c30 |
| Remove extraneous pyversion variable from class TypeChecker | https://github.com/python/mypy/pull/2191/commits/d2efaa3479fa67a57adc6b087bb2cf3c75ce93af |
| d2efaa3 | https://github.com/python/mypy/pull/2191/commits/d2efaa3479fa67a57adc6b087bb2cf3c75ce93af |
| Remove unnecessary change to mypy/checker.py | https://github.com/python/mypy/pull/2191/commits/0ea85c0621bf9cb00b21ba851b9dc0946714de0f |
| 0ea85c0 | https://github.com/python/mypy/pull/2191/commits/0ea85c0621bf9cb00b21ba851b9dc0946714de0f |
| Revise logic organization for version checking, BytesExpr | https://github.com/python/mypy/pull/2191/commits/8804fa3748cd8feb0c46a5973357b2b452d6df45 |
| 8804fa3 | https://github.com/python/mypy/pull/2191/commits/8804fa3748cd8feb0c46a5973357b2b452d6df45 |
| Fix lint + typo in line | https://github.com/python/mypy/pull/2191/commits/ab7a8f7da2e1e7de07e255a35cab1cb77f905d13 |
| ab7a8f7 | https://github.com/python/mypy/pull/2191/commits/ab7a8f7da2e1e7de07e255a35cab1cb77f905d13 |
| Remove extraneous print statement from checkexpr | https://github.com/python/mypy/pull/2191/commits/1056e207acffcd3381954b8f41d2627db2a635d3 |
| 1056e20 | https://github.com/python/mypy/pull/2191/commits/1056e207acffcd3381954b8f41d2627db2a635d3 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| 30bd4c8 | https://github.com/python/mypy/commit/30bd4c85bfb4936f4042eb625d8b978ff2bd929f |
| Oct 5, 2016 | https://github.com/python/mypy/pull/2191#event-814020233 |
| gvanrossum | https://github.com/gvanrossum |
|
Oct 5, 2016
| https://github.com/python/mypy/pull/2191#ref-commit-7e2b3b4 |
|
| https://github.com/buckbaskin |
| Use pyversion variable to change bytes checking for python 3 less tha… | https://github.com/python/mypy/commit/7e2b3b42b1488f66c2922728e8a0e92e06d0f141 |
| 7e2b3b4 | https://github.com/python/mypy/commit/7e2b3b42b1488f66c2922728e8a0e92e06d0f141 |
| #2191 | https://github.com/python/mypy/pull/2191 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Oct 5, 2016 | https://github.com/python/mypy/pull/2191#issuecomment-251822679 |
| Please reload this page | https://github.com/python/mypy/pull/2191 |
| 7e2b3b4 | https://github.com/python/mypy/commit/7e2b3b42b1488f66c2922728e8a0e92e06d0f141 |
| Please reload this page | https://github.com/python/mypy/pull/2191 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Oct 5, 2016 | https://github.com/python/mypy/pull/2191#event-814023106 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2191 |
|
| https://github.com/gvanrossum |
|
gvanrossum
| https://github.com/gvanrossum |
|
| https://github.com/python/mypy/pull/2191/files/d501c10214ddf06c1764b75a991c49291a3d7ff5 |
| Please reload this page | https://github.com/python/mypy/pull/2191 |
| Please reload this page | https://github.com/python/mypy/pull/2191 |
|
| https://github.com/buckbaskin |
|
| https://github.com/gvanrossum |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |