René's URL Explorer Experiment


Title: Use pyversion variable to change bytes checking for python 3 less than 3.5 by buckbaskin · Pull Request #2191 · python/mypy · GitHub

Open Graph Title: Use pyversion variable to change bytes checking for python 3 less than 3.5 by buckbaskin · Pull Request #2191 · python/mypy

X Title: Use pyversion variable to change bytes checking for python 3 less than 3.5 by buckbaskin · Pull Request #2191 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This is based on a TODO from pull request #2168 to fix the behavior for checking bytes in Python 3 when the minor version is less than 3.5. Per #2168, bytes formatting in Python 3 is only supported...

X Description: This is based on a TODO from pull request #2168 to fix the behavior for checking bytes in Python 3 when the minor version is less than 3.5. Per #2168, bytes formatting in Python 3 is only supported...

Opengraph URL: https://github.com/python/mypy/pull/2191

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7d0dd0ca-f7d0-2a40-27ef-b904fda35d83
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE222:251AC0:B98906:F6274B:6B004A47
html-safe-nonce771dd716752f700b52f50e00a9b8ae6df7d186005f2aacb93f0634cdfe04a1eb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjIyOjI1MUFDMDpCOTg5MDY6RjYyNzRCOjZCMDA0QTQ3IiwidmlzaXRvcl9pZCI6IjY1NTU4ODkxNTgxNjA2NjUxNTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacce0a1a488f8ccc1a696adb39fd08d7e912b631854811ab0ab48604ac1319aa8d
hovercard-subject-tagpull_request:87150205
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/2191/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fc807a63ed68afaffa6c942ed1ebd42590fe613b0e4df82b48e281d108304ba5/python/mypy/pull/2191
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fc807a63ed68afaffa6c942ed1ebd42590fe613b0e4df82b48e281d108304ba5/python/mypy/pull/2191
og:image:altThis is based on a TODO from pull request #2168 to fix the behavior for checking bytes in Python 3 when the minor version is less than 3.5. Per #2168, bytes formatting in Python 3 is only supported...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebuckbaskin
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/2191#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2191
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2191
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/2191
Reloadhttps://github.com/python/mypy/pull/2191
Reloadhttps://github.com/python/mypy/pull/2191
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
gvanrossumhttps://github.com/gvanrossum
python:masterhttps://github.com/python/mypy/tree/master
buckbaskin:addPyversion2https://github.com/buckbaskin/mypy/tree/addPyversion2
Conversationhttps://github.com/python/mypy/pull/2191
Commits17 (17)https://github.com/python/mypy/pull/2191/commits
Checkshttps://github.com/python/mypy/pull/2191/checks
Files changedhttps://github.com/python/mypy/pull/2191/files
Use pyversion variable to change bytes checking for python 3 less than 3.5https://github.com/python/mypy/pull/2191#top
gvanrossumhttps://github.com/gvanrossum
python:masterhttps://github.com/python/mypy/tree/master
buckbaskin:addPyversion2https://github.com/buckbaskin/mypy/tree/addPyversion2
https://github.com/buckbaskin
buckbaskinhttps://github.com/buckbaskin
Sep 28, 2016https://github.com/python/mypy/pull/2191#issue-179815762
#2168https://github.com/python/mypy/pull/2168
#2168https://github.com/python/mypy/pull/2168
Please reload this pagehttps://github.com/python/mypy/pull/2191
September 14, 2016 12:09https://github.com/python/mypy/pull/2191#commits-pushed-34ffd12
Add a code example for the typing.IO modulehttps://github.com/python/mypy/pull/2191/commits/34ffd126504e03c75325161ecf93dc92d1202c7c
34ffd12https://github.com/python/mypy/pull/2191/commits/34ffd126504e03c75325161ecf93dc92d1202c7c
Merge branch 'master' ofhttps://github.com/python/mypy/pull/2191/commits/190a12074fa34dda650837eb72b787e7d71e2c01
https://github.com/python/mypyhttps://github.com/python/mypy
190a120https://github.com/python/mypy/pull/2191/commits/190a12074fa34dda650837eb72b787e7d71e2c01
Merge branch 'master' ofhttps://github.com/python/mypy/pull/2191/commits/ca645f2a02c768e8e897c0a239f8e93ee9ceb12e
https://github.com/python/mypyhttps://github.com/python/mypy
ca645f2https://github.com/python/mypy/pull/2191/commits/ca645f2a02c768e8e897c0a239f8e93ee9ceb12e
Merge branch 'master' ofhttps://github.com/python/mypy/pull/2191/commits/f52bcd3a83d43acd1404a5144feafbc15eedc0c3
https://github.com/python/mypyhttps://github.com/python/mypy
f52bcd3https://github.com/python/mypy/pull/2191/commits/f52bcd3a83d43acd1404a5144feafbc15eedc0c3
Merge branch 'master' ofhttps://github.com/python/mypy/pull/2191/commits/f27e28b94c745c3fbba608efc4ee29b7d8f33f2e
https://github.com/python/mypyhttps://github.com/python/mypy
f27e28bhttps://github.com/python/mypy/pull/2191/commits/f27e28b94c745c3fbba608efc4ee29b7d8f33f2e
First commit for checking with pyversionhttps://github.com/python/mypy/pull/2191/commits/dc69cb551866a515e61723b9e0255648315b7f4b
dc69cb5https://github.com/python/mypy/pull/2191/commits/dc69cb551866a515e61723b9e0255648315b7f4b
Fix 3 lint errorshttps://github.com/python/mypy/pull/2191/commits/31f97b1133b14c981ce2f08e503373e141a4640e
31f97b1https://github.com/python/mypy/pull/2191/commits/31f97b1133b14c981ce2f08e503373e141a4640e
Remove extra print statementhttps://github.com/python/mypy/pull/2191/commits/e211611292bdd9bde8f88061c3fb0a17a3e176c9
e211611https://github.com/python/mypy/pull/2191/commits/e211611292bdd9bde8f88061c3fb0a17a3e176c9
Fix TODO for different behavior below Python 3.5https://github.com/python/mypy/pull/2191/commits/38478b8db0dbce330601ee9617c76ad1d7ee365a
38478b8https://github.com/python/mypy/pull/2191/commits/38478b8db0dbce330601ee9617c76ad1d7ee365a
Merge branch 'master' ofhttps://github.com/python/mypy/pull/2191/commits/d501c10214ddf06c1764b75a991c49291a3d7ff5
https://github.com/python/mypyhttps://github.com/python/mypy
into addPyver…https://github.com/python/mypy/pull/2191/commits/d501c10214ddf06c1764b75a991c49291a3d7ff5
d501c10https://github.com/python/mypy/pull/2191/commits/d501c10214ddf06c1764b75a991c49291a3d7ff5
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Sep 28, 2016 https://github.com/python/mypy/pull/2191#pullrequestreview-1978739
View reviewed changes https://github.com/python/mypy/pull/2191/files/d501c10214ddf06c1764b75a991c49291a3d7ff5
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/mypy/pull/2191#pullrequestreview-1978739
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2191
mypy/checker.pyhttps://github.com/python/mypy/pull/2191/files/d501c10214ddf06c1764b75a991c49291a3d7ff5#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
gvanrossumhttps://github.com/gvanrossum
Sep 28, 2016https://github.com/python/mypy/pull/2191#discussion_r80962748
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2191
mypy/checkexpr.pyhttps://github.com/python/mypy/pull/2191/files/d501c10214ddf06c1764b75a991c49291a3d7ff5#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07
gvanrossumhttps://github.com/gvanrossum
Sep 28, 2016https://github.com/python/mypy/pull/2191#discussion_r80963003
Please reload this pagehttps://github.com/python/mypy/pull/2191
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2191
mypy/build.pyhttps://github.com/python/mypy/pull/2191/files/d501c10214ddf06c1764b75a991c49291a3d7ff5#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
gvanrossumhttps://github.com/gvanrossum
Sep 28, 2016https://github.com/python/mypy/pull/2191#discussion_r80963325
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2191
mypy/checkstrformat.pyhttps://github.com/python/mypy/pull/2191/files/d501c10214ddf06c1764b75a991c49291a3d7ff5#diff-11d0c95de3a5c95b84ff3e1a28a16ea78f32aebbdbb21f2974dcf69437838e3e
gvanrossumhttps://github.com/gvanrossum
Sep 28, 2016https://github.com/python/mypy/pull/2191#discussion_r80963547
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2191
mypy/checkstrformat.pyhttps://github.com/python/mypy/pull/2191/files/d501c10214ddf06c1764b75a991c49291a3d7ff5#diff-11d0c95de3a5c95b84ff3e1a28a16ea78f32aebbdbb21f2974dcf69437838e3e
gvanrossumhttps://github.com/gvanrossum
Sep 28, 2016https://github.com/python/mypy/pull/2191#discussion_r80964041
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2191
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Sep 29, 2016https://github.com/python/mypy/pull/2191#event-807701260
October 5, 2016 01:11https://github.com/python/mypy/pull/2191#commits-pushed-ba94521
Add a type annotation to pyversionhttps://github.com/python/mypy/pull/2191/commits/ba945219972da47e79b2e5d4c6a5133394f896d7
ba94521https://github.com/python/mypy/pull/2191/commits/ba945219972da47e79b2e5d4c6a5133394f896d7
Move python version checking out of check_str_interpolationhttps://github.com/python/mypy/pull/2191/commits/43a5b5948c3151e601d8dd48e30938ee259f7c30
43a5b59https://github.com/python/mypy/pull/2191/commits/43a5b5948c3151e601d8dd48e30938ee259f7c30
Remove extraneous pyversion variable from class TypeCheckerhttps://github.com/python/mypy/pull/2191/commits/d2efaa3479fa67a57adc6b087bb2cf3c75ce93af
d2efaa3https://github.com/python/mypy/pull/2191/commits/d2efaa3479fa67a57adc6b087bb2cf3c75ce93af
Remove unnecessary change to mypy/checker.pyhttps://github.com/python/mypy/pull/2191/commits/0ea85c0621bf9cb00b21ba851b9dc0946714de0f
0ea85c0https://github.com/python/mypy/pull/2191/commits/0ea85c0621bf9cb00b21ba851b9dc0946714de0f
Revise logic organization for version checking, BytesExprhttps://github.com/python/mypy/pull/2191/commits/8804fa3748cd8feb0c46a5973357b2b452d6df45
8804fa3https://github.com/python/mypy/pull/2191/commits/8804fa3748cd8feb0c46a5973357b2b452d6df45
Fix lint + typo in linehttps://github.com/python/mypy/pull/2191/commits/ab7a8f7da2e1e7de07e255a35cab1cb77f905d13
ab7a8f7https://github.com/python/mypy/pull/2191/commits/ab7a8f7da2e1e7de07e255a35cab1cb77f905d13
Remove extraneous print statement from checkexprhttps://github.com/python/mypy/pull/2191/commits/1056e207acffcd3381954b8f41d2627db2a635d3
1056e20https://github.com/python/mypy/pull/2191/commits/1056e207acffcd3381954b8f41d2627db2a635d3
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
30bd4c8https://github.com/python/mypy/commit/30bd4c85bfb4936f4042eb625d8b978ff2bd929f
Oct 5, 2016https://github.com/python/mypy/pull/2191#event-814020233
gvanrossumhttps://github.com/gvanrossum
Oct 5, 2016 https://github.com/python/mypy/pull/2191#ref-commit-7e2b3b4
https://github.com/buckbaskin
Use pyversion variable to change bytes checking for python 3 less tha…https://github.com/python/mypy/commit/7e2b3b42b1488f66c2922728e8a0e92e06d0f141
7e2b3b4https://github.com/python/mypy/commit/7e2b3b42b1488f66c2922728e8a0e92e06d0f141
#2191https://github.com/python/mypy/pull/2191
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Oct 5, 2016https://github.com/python/mypy/pull/2191#issuecomment-251822679
Please reload this pagehttps://github.com/python/mypy/pull/2191
7e2b3b4https://github.com/python/mypy/commit/7e2b3b42b1488f66c2922728e8a0e92e06d0f141
Please reload this pagehttps://github.com/python/mypy/pull/2191
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Oct 5, 2016https://github.com/python/mypy/pull/2191#event-814023106
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2191
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/mypy/pull/2191/files/d501c10214ddf06c1764b75a991c49291a3d7ff5
Please reload this pagehttps://github.com/python/mypy/pull/2191
Please reload this pagehttps://github.com/python/mypy/pull/2191
https://github.com/buckbaskin
https://github.com/gvanrossum
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.