René's URL Explorer Experiment


Title: Fix sentinel identity loss through generic substitution and inference by edgarrmondragon · Pull Request #21888 · python/mypy · GitHub

Open Graph Title: Fix sentinel identity loss through generic substitution and inference by edgarrmondragon · Pull Request #21888 · python/mypy

X Title: Fix sentinel identity loss through generic substitution and inference by edgarrmondragon · Pull Request #21888 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: A sentinel's only way to identify itself is via its attached literal value, unlike e.g. enum members whose class already carries identity. That literal was being unconditionally stripped both w...

X Description: A sentinel's only way to identify itself is via its attached literal value, unlike e.g. enum members whose class already carries identity. That literal was being unconditionally stripped bo...

Opengraph URL: https://github.com/python/mypy/pull/21888

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:849b1309-293d-ba29-96e1-fda80ef6d6ac
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id89A8:33E41:38A249:4B2F94:6B0237C9
html-safe-noncec32349b53b22f03a89d36fbcc936a0985e54f3b88258c3608fd0b2230b3472f5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUE4OjMzRTQxOjM4QTI0OTo0QjJGOTQ6NkIwMjM3QzkiLCJ2aXNpdG9yX2lkIjoiNTcwMzYwNTU5MzIyMzM0NjEyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac42e2388ac2982b8c2af37016310494088854309b805ae80fad3d39a1c8800219
hovercard-subject-tagpull_request:4351420757
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/21888/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/53cac7630141230dffd453622adbde8c0dc51adfd94b9a6883b0ad20dff8cb0e/python/mypy/pull/21888
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/53cac7630141230dffd453622adbde8c0dc51adfd94b9a6883b0ad20dff8cb0e/python/mypy/pull/21888
og:image:altA sentinel's only way to identify itself is via its attached literal value, unlike e.g. enum members whose class already carries identity. That literal was being unconditionally stripped both w...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameedgarrmondragon
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/21888#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F21888
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F21888
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/21888
Reloadhttps://github.com/python/mypy/pull/21888
Reloadhttps://github.com/python/mypy/pull/21888
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
sobolevnhttps://github.com/sobolevn
python:masterhttps://github.com/python/mypy/tree/master
edgarrmondragon:sentinel-typevar-expandhttps://github.com/edgarrmondragon/--fork-mypy/tree/sentinel-typevar-expand
Conversationhttps://github.com/python/mypy/pull/21888
Commits3 (3)https://github.com/python/mypy/pull/21888/commits
Checkshttps://github.com/python/mypy/pull/21888/checks
Files changedhttps://github.com/python/mypy/pull/21888/files
Fix sentinel identity loss through generic substitution and inferencehttps://github.com/python/mypy/pull/21888#top
sobolevnhttps://github.com/sobolevn
python:masterhttps://github.com/python/mypy/tree/master
edgarrmondragon:sentinel-typevar-expandhttps://github.com/edgarrmondragon/--fork-mypy/tree/sentinel-typevar-expand
https://github.com/edgarrmondragon
edgarrmondragonhttps://github.com/edgarrmondragon
Aug 24, 2026https://github.com/python/mypy/pull/21888#issue-5238287754
Please reload this pagehttps://github.com/python/mypy/pull/21888
#21866https://github.com/python/mypy/issues/21866
#21647https://github.com/python/mypy/pull/21647
Please reload this pagehttps://github.com/python/mypy/pull/21888
https://github.com/edgarrmondragon
Fix sentinel identity loss through generic substitution and inferencehttps://github.com/python/mypy/pull/21888/commits/ee1e2c4406d45dcb78c96247dfb2c5525e90a8ee
ee1e2c4https://github.com/python/mypy/pull/21888/commits/ee1e2c4406d45dcb78c96247dfb2c5525e90a8ee
python#21866https://github.com/python/mypy/issues/21866
python#21647https://github.com/python/mypy/pull/21647
https://github.com/edgarrmondragon
edgarrmondragonhttps://github.com/edgarrmondragon
Aug 24, 2026 https://github.com/python/mypy/pull/21888#pullrequestreview-5011440172
View reviewed changes https://github.com/python/mypy/pull/21888/files/ee1e2c4406d45dcb78c96247dfb2c5525e90a8ee
test-data/unit/check-sentinels.testhttps://github.com/python/mypy/pull/21888/files/ee1e2c4406d45dcb78c96247dfb2c5525e90a8ee#diff-2fc1c2116daffab16921a82a2f65cabc6c57f4e4595925afc72fe5e94318f369
edgarrmondragonhttps://github.com/edgarrmondragon
Aug 24, 2026https://github.com/python/mypy/pull/21888#discussion_r3846493030
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#21647 (comment)https://github.com/python/mypy/pull/21647#discussion_r3622347050
https://typing.python.org/en/latest/spec/special-types.html#sentinelshttps://typing.python.org/en/latest/spec/special-types.html#sentinels
Please reload this pagehttps://github.com/python/mypy/pull/21888
A5rockshttps://github.com/A5rocks
Aug 25, 2026https://github.com/python/mypy/pull/21888#discussion_r3849480934
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/21888
edgarrmondragonhttps://github.com/edgarrmondragon
Aug 25, 2026https://github.com/python/mypy/pull/21888#discussion_r3849584844
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Sentinel instance is not assignable to Sentinel type microsoft/pyright#11529https://github.com/microsoft/pyright/issues/11529
Please reload this pagehttps://github.com/python/mypy/pull/21888
A5rockshttps://github.com/A5rocks
Aug 25, 2026https://github.com/python/mypy/pull/21888#discussion_r3853031535
Please reload this pagehttps://github.com/python/mypy/pull/21888
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/21888
edgarrmondragonhttps://github.com/edgarrmondragon
Aug 25, 2026https://github.com/python/mypy/pull/21888#discussion_r3855378687
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
1e752e2https://github.com/python/mypy/commit/1e752e217cab2e40cb732f7855fbe69844c11b14
Please reload this pagehttps://github.com/python/mypy/pull/21888
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F21888
https://github.com/edgarrmondragon
edgarrmondragonhttps://github.com/edgarrmondragon
August 24, 2026 19:19https://github.com/python/mypy/pull/21888#event-29934612441
https://github.com/edgarrmondragon
edgarrmondragonhttps://github.com/edgarrmondragon
Aug 24, 2026 https://github.com/python/mypy/pull/21888#ref-issue-5176931843
Invalid return type with sentinel and dict.get #21866 https://github.com/python/mypy/issues/21866
https://github.com/cdce8p
cdce8phttps://github.com/cdce8p
Aug 24, 2026 https://github.com/python/mypy/pull/21888#pullrequestreview-5012951039
View reviewed changes https://github.com/python/mypy/pull/21888/files/ee1e2c4406d45dcb78c96247dfb2c5525e90a8ee
cdce8phttps://github.com/cdce8p
https://github.com/python/mypy/pull/21888#pullrequestreview-5012951039
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@edgarrmondragonhttps://github.com/edgarrmondragon
Please reload this pagehttps://github.com/python/mypy/pull/21888
https://github.com/cdce8p
cdce8phttps://github.com/cdce8p
JelleZijlstrahttps://github.com/JelleZijlstra
August 24, 2026 21:59https://github.com/python/mypy/pull/21888#event-29942080320
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
Aug 25, 2026 https://github.com/python/mypy/pull/21888#pullrequestreview-5014836375
View reviewed changes https://github.com/python/mypy/pull/21888/files/ee1e2c4406d45dcb78c96247dfb2c5525e90a8ee
A5rockshttps://github.com/A5rocks
https://github.com/python/mypy/pull/21888#pullrequestreview-5014836375
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/21888
mypy/erasetype.pyhttps://github.com/python/mypy/pull/21888/files/ee1e2c4406d45dcb78c96247dfb2c5525e90a8ee#diff-c9f0543a93a28cd330d73dd1accda2e354fe46039866a54550c0f4fe66db731b
A5rockshttps://github.com/A5rocks
Aug 25, 2026https://github.com/python/mypy/pull/21888#discussion_r3849474403
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/21888
edgarrmondragonhttps://github.com/edgarrmondragon
Aug 25, 2026https://github.com/python/mypy/pull/21888#discussion_r3849812444
Please reload this pagehttps://github.com/python/mypy/pull/21888
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
ff4d71bhttps://github.com/python/mypy/commit/ff4d71b3abb85717fb61bef37fae7bd4b2af0da6
Please reload this pagehttps://github.com/python/mypy/pull/21888
ilevkivskyihttps://github.com/ilevkivskyi
Aug 25, 2026https://github.com/python/mypy/pull/21888#discussion_r3856369021
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/21888
ilevkivskyihttps://github.com/ilevkivskyi
Sep 1, 2026https://github.com/python/mypy/pull/21888#discussion_r3903038580
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/21888
ilevkivskyihttps://github.com/ilevkivskyi
Sep 1, 2026https://github.com/python/mypy/pull/21888#discussion_r3903597198
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#21919https://github.com/python/mypy/pull/21919
Please reload this pagehttps://github.com/python/mypy/pull/21888
test-data/unit/check-sentinels.testhttps://github.com/python/mypy/pull/21888/files/ee1e2c4406d45dcb78c96247dfb2c5525e90a8ee#diff-2fc1c2116daffab16921a82a2f65cabc6c57f4e4595925afc72fe5e94318f369
A5rockshttps://github.com/A5rocks
Aug 25, 2026https://github.com/python/mypy/pull/21888#discussion_r3849480934
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/21888
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
Aug 25, 2026 https://github.com/python/mypy/pull/21888#pullrequestreview-5014911062
View reviewed changes https://github.com/python/mypy/pull/21888/files/ee1e2c4406d45dcb78c96247dfb2c5525e90a8ee
test-data/unit/check-sentinels.testhttps://github.com/python/mypy/pull/21888/files/ee1e2c4406d45dcb78c96247dfb2c5525e90a8ee#diff-2fc1c2116daffab16921a82a2f65cabc6c57f4e4595925afc72fe5e94318f369
A5rockshttps://github.com/A5rocks
Aug 25, 2026https://github.com/python/mypy/pull/21888#discussion_r3849532640
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/21888
edgarrmondragonhttps://github.com/edgarrmondragon
Aug 25, 2026https://github.com/python/mypy/pull/21888#discussion_r3849591962
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/21888
https://github.com/edgarrmondragon
fix: Preserve sentinel identity in error messageshttps://github.com/python/mypy/pull/21888/commits/ff4d71b3abb85717fb61bef37fae7bd4b2af0da6
ff4d71bhttps://github.com/python/mypy/pull/21888/commits/ff4d71b3abb85717fb61bef37fae7bd4b2af0da6
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F21888
https://github.com/edgarrmondragon
Add a test for sentinel assigmenthttps://github.com/python/mypy/pull/21888/commits/1e752e217cab2e40cb732f7855fbe69844c11b14
1e752e2https://github.com/python/mypy/pull/21888/commits/1e752e217cab2e40cb732f7855fbe69844c11b14
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2026https://github.com/python/mypy/pull/21888#issuecomment-5414170580
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/21888
https://github.com/edgarrmondragon
edgarrmondragonhttps://github.com/edgarrmondragon
Aug 25, 2026 https://github.com/python/mypy/pull/21888#ref-pullrequest-5248486991
Refactor PEP 661 sentinel handling to use a synthetic nominal class #21894 https://github.com/python/mypy/pull/21894
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Aug 27, 2026 https://github.com/python/mypy/pull/21888#pullrequestreview-5037908603
View reviewed changes https://github.com/python/mypy/pull/21888/files/1e752e217cab2e40cb732f7855fbe69844c11b14
sobolevnhttps://github.com/sobolevn
https://github.com/python/mypy/pull/21888#pullrequestreview-5037908603
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/21888
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
44c0d9fhttps://github.com/python/mypy/commit/44c0d9f1efc39af78da28fced51261b022252fec
Aug 27, 2026https://github.com/python/mypy/pull/21888#event-30086654825
Please reload this pagehttps://github.com/python/mypy/pull/21888
https://github.com/edgarrmondragon
edgarrmondragonhttps://github.com/edgarrmondragon
August 27, 2026 13:43https://github.com/python/mypy/pull/21888#event-30107325904
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F21888
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/21888/files/ee1e2c4406d45dcb78c96247dfb2c5525e90a8ee
https://github.com/sobolevn
sobolevn https://github.com/sobolevn
https://github.com/python/mypy/pull/21888/files/1e752e217cab2e40cb732f7855fbe69844c11b14
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/A5rocks
A5rocks https://github.com/A5rocks
https://github.com/python/mypy/pull/21888/files/ff4d71b3abb85717fb61bef37fae7bd4b2af0da6
https://github.com/cdce8p
cdce8p https://github.com/cdce8p
https://github.com/python/mypy/pull/21888/files/ee1e2c4406d45dcb78c96247dfb2c5525e90a8ee
Please reload this pagehttps://github.com/python/mypy/pull/21888
Invalid return type with sentinel and dict.get https://github.com/python/mypy/issues/21866
Please reload this pagehttps://github.com/python/mypy/pull/21888
https://github.com/edgarrmondragon
https://github.com/sobolevn
https://github.com/ilevkivskyi
https://github.com/cdce8p
https://github.com/A5rocks
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.