| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e33f942b-1ec0-9948-6b5c-df55e7d76aa4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9E78:245A38:5F040A:7FFC5D:6B003560 |
| html-safe-nonce | 877bcd2b3177b7842e08c56b99629852f2276ef1236cad03116bfb77dbdaa8cd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTc4OjI0NUEzODo1RjA0MEE6N0ZGQzVEOjZCMDAzNTYwIiwidmlzaXRvcl9pZCI6IjMyMDkyOTgzMzY3MjkyODE4ODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 82edf975df092e8f8958fe0bbc8e75dc709e6fe50ef7335b67f6bfad64b3fd87 |
| hovercard-subject-tag | pull_request:86280855 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/2168/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/91b42291054f8318b72ef64ac34f65f24098b8448a7f648bd1012f4378f35d1b/python/mypy/pull/2168 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/91b42291054f8318b72ef64ac34f65f24098b8448a7f648bd1012f4378f35d1b/python/mypy/pull/2168 |
| og:image:alt | This pull request aims to fix the type checking of bytes strings. The code previously used a single path for both bytes and strings, which broke the example given in the bug (#2070) that expected a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | buckbaskin |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/2168#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2168 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2168 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/2168 |
| Reload | https://github.com/python/mypy/pull/2168 |
| Reload | https://github.com/python/mypy/pull/2168 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| gvanrossum | https://github.com/gvanrossum |
| python:master | https://github.com/python/mypy/tree/master |
| buckbaskin:fixBytes | https://github.com/buckbaskin/mypy/tree/fixBytes |
| Conversation | https://github.com/python/mypy/pull/2168 |
| Commits14 (14) | https://github.com/python/mypy/pull/2168/commits |
| Checks | https://github.com/python/mypy/pull/2168/checks |
| Files changed | https://github.com/python/mypy/pull/2168/files |
| Fix #2070 - bytes formatting incorrect in python 3 | https://github.com/python/mypy/pull/2168#top |
| gvanrossum | https://github.com/gvanrossum |
| python:master | https://github.com/python/mypy/tree/master |
| buckbaskin:fixBytes | https://github.com/buckbaskin/mypy/tree/fixBytes |
|
| https://github.com/buckbaskin |
| buckbaskin | https://github.com/buckbaskin |
| Sep 22, 2016 | https://github.com/python/mypy/pull/2168#issue-178525047 |
| #2070 | https://github.com/python/mypy/issues/2070 |
| Please reload this page | https://github.com/python/mypy/pull/2168 |
| September 14, 2016 12:09 | https://github.com/python/mypy/pull/2168#commits-pushed-34ffd12 |
| Add a code example for the typing.IO module | https://github.com/python/mypy/pull/2168/commits/34ffd126504e03c75325161ecf93dc92d1202c7c |
| 34ffd12 | https://github.com/python/mypy/pull/2168/commits/34ffd126504e03c75325161ecf93dc92d1202c7c |
| Merge branch 'master' of | https://github.com/python/mypy/pull/2168/commits/190a12074fa34dda650837eb72b787e7d71e2c01 |
| https://github.com/python/mypy | https://github.com/python/mypy |
| 190a120 | https://github.com/python/mypy/pull/2168/commits/190a12074fa34dda650837eb72b787e7d71e2c01 |
| Merge branch 'master' of | https://github.com/python/mypy/pull/2168/commits/ca645f2a02c768e8e897c0a239f8e93ee9ceb12e |
| https://github.com/python/mypy | https://github.com/python/mypy |
| ca645f2 | https://github.com/python/mypy/pull/2168/commits/ca645f2a02c768e8e897c0a239f8e93ee9ceb12e |
| Add a parallel path for bytes and str for checking % interpolation | https://github.com/python/mypy/pull/2168/commits/818adf7609cb794a43954c7901db1a511f1893c0 |
| 818adf7 | https://github.com/python/mypy/pull/2168/commits/818adf7609cb794a43954c7901db1a511f1893c0 |
| Update the expected type of first arg to check_byte_interpolation | https://github.com/python/mypy/pull/2168/commits/76d6d71ea967bfc446ec2ec4065e1248496cde55 |
| 76d6d71 | https://github.com/python/mypy/pull/2168/commits/76d6d71ea967bfc446ec2ec4065e1248496cde55 |
| https://github.com/buckbaskin |
| buckbaskin | https://github.com/buckbaskin |
| Sep 22, 2016 | https://github.com/python/mypy/pull/2168#event-798378560 |
| https://github.com/buckbaskin |
| buckbaskin | https://github.com/buckbaskin |
| Sep 22, 2016 | https://github.com/python/mypy/pull/2168#event-798379102 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Sep 22, 2016 | https://github.com/python/mypy/pull/2168#issuecomment-248993242 |
| Please reload this page | https://github.com/python/mypy/pull/2168 |
| Refactor code to reduce duplication in changes | https://github.com/python/mypy/pull/2168/commits/9920e9bf52f829a9bc60902ce5a0bb60392ebb78 |
| 9920e9b | https://github.com/python/mypy/pull/2168/commits/9920e9bf52f829a9bc60902ce5a0bb60392ebb78 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Sep 26, 2016
| https://github.com/python/mypy/pull/2168#pullrequestreview-1472240 |
|
View reviewed changes
| https://github.com/python/mypy/pull/2168/files/9920e9bf52f829a9bc60902ce5a0bb60392ebb78 |
| gvanrossum | https://github.com/gvanrossum |
| https://github.com/python/mypy/pull/2168#pullrequestreview-1472240 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2168 |
| mypy/checkexpr.py | https://github.com/python/mypy/pull/2168/files/76d6d71ea967bfc446ec2ec4065e1248496cde55..9920e9bf52f829a9bc60902ce5a0bb60392ebb78#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07 |
| gvanrossum | https://github.com/gvanrossum |
| Sep 26, 2016 | https://github.com/python/mypy/pull/2168#discussion_r80405013 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2168 |
| buckbaskin | https://github.com/buckbaskin |
| Sep 26, 2016 | https://github.com/python/mypy/pull/2168#discussion_r80406769 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2168 |
| September 26, 2016 00:05 | https://github.com/python/mypy/pull/2168#commits-pushed-af5dc00 |
| Reinstate type check for StrExpr, etc | https://github.com/python/mypy/pull/2168/commits/af5dc0034858f25c7ad31c031562df3af2726e49 |
| af5dc00 | https://github.com/python/mypy/pull/2168/commits/af5dc0034858f25c7ad31c031562df3af2726e49 |
| Add byte interpolation unit test cases | https://github.com/python/mypy/pull/2168/commits/3ce554c4da7c854b7774a0da245bc42b456e0448 |
| 3ce554c | https://github.com/python/mypy/pull/2168/commits/3ce554c4da7c854b7774a0da245bc42b456e0448 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Sep 26, 2016
| https://github.com/python/mypy/pull/2168#pullrequestreview-1473098 |
|
View reviewed changes
| https://github.com/python/mypy/pull/2168/files/3ce554c4da7c854b7774a0da245bc42b456e0448 |
| mypy/checkstrformat.py | https://github.com/python/mypy/pull/2168/files/3ce554c4da7c854b7774a0da245bc42b456e0448#diff-11d0c95de3a5c95b84ff3e1a28a16ea78f32aebbdbb21f2974dcf69437838e3e |
| gvanrossum | https://github.com/gvanrossum |
| Sep 26, 2016 | https://github.com/python/mypy/pull/2168#discussion_r80405964 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2168 |
| gvanrossum | https://github.com/gvanrossum |
| Sep 26, 2016 | https://github.com/python/mypy/pull/2168#discussion_r80406068 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2168 |
| buckbaskin | https://github.com/buckbaskin |
| Sep 26, 2016 | https://github.com/python/mypy/pull/2168#discussion_r80406227 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/2168 |
| Add TODO comments re bytes formatting functionality | https://github.com/python/mypy/pull/2168/commits/b769a8fb12df396f9aecf5302b024616e1ba3f41 |
| b769a8f | https://github.com/python/mypy/pull/2168/commits/b769a8fb12df396f9aecf5302b024616e1ba3f41 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Sep 26, 2016 | https://github.com/python/mypy/pull/2168#issuecomment-249476416 |
| @buckbaskin | https://github.com/buckbaskin |
| #2168 | https://github.com/python/mypy/pull/2168 |
| #2168 | https://github.com/python/mypy/pull/2168 |
| https://github.com/notifications/unsubscribe-auth/ACwrMlh-1BQHpJUtTe_S8SGDcrERQPZcks5qt0c4gaJpZM4KDicI | https://github.com/notifications/unsubscribe-auth/ACwrMlh-1BQHpJUtTe_S8SGDcrERQPZcks5qt0c4gaJpZM4KDicI |
| Please reload this page | https://github.com/python/mypy/pull/2168 |
| September 26, 2016 00:24 | https://github.com/python/mypy/pull/2168#commits-pushed-1c1d18b |
| Fix two lint errors in checkstrformat | https://github.com/python/mypy/pull/2168/commits/1c1d18b95c446f1c1c053b4b1ffe2eb0b14f77d9 |
| 1c1d18b | https://github.com/python/mypy/pull/2168/commits/1c1d18b95c446f1c1c053b4b1ffe2eb0b14f77d9 |
| Add a single Unicode python2 test | https://github.com/python/mypy/pull/2168/commits/31c7412ef458d2553462e29459513f2e03fe3f7a |
| 31c7412 | https://github.com/python/mypy/pull/2168/commits/31c7412ef458d2553462e29459513f2e03fe3f7a |
|
| https://github.com/gvanrossum |
| Clean up trailing comma. | https://github.com/python/mypy/pull/2168/commits/9a9b4aeae06a31ea281122c4570035f3050665e5 |
| 9a9b4ae | https://github.com/python/mypy/pull/2168/commits/9a9b4aeae06a31ea281122c4570035f3050665e5 |
|
| https://github.com/gvanrossum |
| Add periods to sentences. | https://github.com/python/mypy/pull/2168/commits/41bce18af965849bf873935052028dd661a8bd5d |
| 41bce18 | https://github.com/python/mypy/pull/2168/commits/41bce18af965849bf873935052028dd661a8bd5d |
|
| https://github.com/gvanrossum |
| Don't assume. | https://github.com/python/mypy/pull/2168/commits/592e456cea35f77560021448a90a5525e5c8f3ed |
| 592e456 | https://github.com/python/mypy/pull/2168/commits/592e456cea35f77560021448a90a5525e5c8f3ed |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Sep 26, 2016
| https://github.com/python/mypy/pull/2168#pullrequestreview-1562042 |
|
View reviewed changes
| https://github.com/python/mypy/pull/2168/files/592e456cea35f77560021448a90a5525e5c8f3ed |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| 2fbf387 | https://github.com/python/mypy/commit/2fbf38774bb32a6fe45c1ac1f67027ea02a827cf |
| Sep 26, 2016 | https://github.com/python/mypy/pull/2168#event-802494101 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Sep 26, 2016 | https://github.com/python/mypy/pull/2168#issuecomment-249610638 |
| Please reload this page | https://github.com/python/mypy/pull/2168 |
| https://github.com/buckbaskin |
| buckbaskin | https://github.com/buckbaskin |
| Sep 26, 2016 | https://github.com/python/mypy/pull/2168#issuecomment-249638231 |
| Please reload this page | https://github.com/python/mypy/pull/2168 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Sep 26, 2016 | https://github.com/python/mypy/pull/2168#issuecomment-249639169 |
| #2168 (comment) | https://github.com/python/mypy/pull/2168#issuecomment-249638231 |
| https://github.com/notifications/unsubscribe-auth/ACwrMrd0lTGvx44n0WhhQQqxF2vOO8Knks5quAC9gaJpZM4KDicI | https://github.com/notifications/unsubscribe-auth/ACwrMrd0lTGvx44n0WhhQQqxF2vOO8Knks5quAC9gaJpZM4KDicI |
| Please reload this page | https://github.com/python/mypy/pull/2168 |
| https://github.com/buckbaskin |
| buckbaskin | https://github.com/buckbaskin |
|
Sep 28, 2016
| https://github.com/python/mypy/pull/2168#ref-pullrequest-179815762 |
|
Use pyversion variable to change bytes checking for python 3 less than 3.5
#2191
| https://github.com/python/mypy/pull/2191 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2168 |
|
| https://github.com/gvanrossum |
|
gvanrossum
| https://github.com/gvanrossum |
|
| https://github.com/python/mypy/pull/2168/files/592e456cea35f77560021448a90a5525e5c8f3ed |
| Please reload this page | https://github.com/python/mypy/pull/2168 |
| Please reload this page | https://github.com/python/mypy/pull/2168 |
|
| https://github.com/buckbaskin |
|
| https://github.com/gvanrossum |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |