| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3de50fe7-6852-424b-f48a-25e52779b8a5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E98E:119971:447879:5BD952:6A57FF75 |
| html-safe-nonce | d7ba5375dfd65dfdf569b60ac8db9a2a34205f0d22275f0b4536f1e4d89787bf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOThFOjExOTk3MTo0NDc4Nzk6NUJEOTUyOjZBNTdGRjc1IiwidmlzaXRvcl9pZCI6IjUyNjQ2Njg0MDUyMzY0OTgyOTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | cf1419d6ef2fa0dbc22b8f299b465d963060a8a0127abbe89b66c098be2c533a |
| hovercard-subject-tag | pull_request:3560358538 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/21281/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b79f64dca97b868e63ac7eac73c75b7a442e9054f8eb6a5495909d4c74e39ad4/python/mypy/pull/21281 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b79f64dca97b868e63ac7eac73c75b7a442e9054f8eb6a5495909d4c74e39ad4/python/mypy/pull/21281 |
| og:image:alt | Fixes #21187, fully fixes this comment #9003 (comment) (previously improved on in 1.20 narrowing changes)
This diff adds general functionality that replaces a few different pieces of ad hoc logic:
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hauntsaninja |
| hostname | github.com |
| expected-hostname | github.com |
| None | 49c8c15fabcbf356d607a90ca115c13b273e42ff8b74155de050fd229a9b0121 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3fb1f684e7a833eb1b2d01d39875a2b52cb4fe9b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/mypy/pull/21281#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F21281 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F21281 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/21281 |
| Reload | https://github.com/python/mypy/pull/21281 |
| Reload | https://github.com/python/mypy/pull/21281 |
| Please reload this page | https://github.com/python/mypy/pull/21281 |
|
python
| https://github.com/python |
| mypy | https://github.com/python/mypy |
| Please reload this page | https://github.com/python/mypy/pull/21281 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fmypy |
|
Fork
3.2k
| https://github.com/login?return_to=%2Fpython%2Fmypy |
|
Star
20.5k
| https://github.com/login?return_to=%2Fpython%2Fmypy |
|
Code
| https://github.com/python/mypy |
|
Issues
2.7k
| https://github.com/python/mypy/issues |
|
Pull requests
465
| https://github.com/python/mypy/pulls |
|
Actions
| https://github.com/python/mypy/actions |
|
Projects
| https://github.com/python/mypy/projects |
|
Wiki
| https://github.com/python/mypy/wiki |
|
Security and quality
0
| https://github.com/python/mypy/security |
|
Insights
| https://github.com/python/mypy/pulse |
|
Code
| https://github.com/python/mypy |
|
Issues
| https://github.com/python/mypy/issues |
|
Pull requests
| https://github.com/python/mypy/pulls |
|
Actions
| https://github.com/python/mypy/actions |
|
Projects
| https://github.com/python/mypy/projects |
|
Wiki
| https://github.com/python/mypy/wiki |
|
Security and quality
| https://github.com/python/mypy/security |
|
Insights
| https://github.com/python/mypy/pulse |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| hauntsaninja:enumident2 | https://github.com/hauntsaninja/mypy/tree/enumident2 |
| Conversation | https://github.com/python/mypy/pull/21281 |
| Commits2 (2) | https://github.com/python/mypy/pull/21281/commits |
| Checks | https://github.com/python/mypy/pull/21281/checks |
| Files changed | https://github.com/python/mypy/pull/21281/files |
| Better narrowing for enums and other types with known equality | https://github.com/python/mypy/pull/21281#top |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| hauntsaninja:enumident2 | https://github.com/hauntsaninja/mypy/tree/enumident2 |
|
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| Apr 21, 2026 | https://github.com/python/mypy/pull/21281#issue-4300948412 |
| Please reload this page | https://github.com/python/mypy/pull/21281 |
| #21187 | https://github.com/python/mypy/issues/21187 |
| #9003 (comment) | https://github.com/python/mypy/issues/9003#issuecomment-778349487 |
| Optional bytes type not narrowed after asserting equality #20701 | https://github.com/python/mypy/issues/20701 |
| Please reload this page | https://github.com/python/mypy/pull/21281 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Apr 21, 2026
| https://github.com/python/mypy/pull/21281#ref-issue-4300949440 |
|
Check #21281
sterliakov/mypy-issues#289
| https://github.com/sterliakov/mypy-issues/issues/289 |
|
| https://github.com/hauntsaninja |
| Better narrowing for enums and other known types with equality | https://github.com/python/mypy/pull/21281/commits/e61527c4aeea57dfc3ba2072084ac693e7e15d97 |
| e61527c | https://github.com/python/mypy/pull/21281/commits/e61527c4aeea57dfc3ba2072084ac693e7e15d97 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| force-pushed | https://github.com/python/mypy/compare/97034719469d6116e3ab5c5b8548db8c104eb858..e61527c4aeea57dfc3ba2072084ac693e7e15d97 |
| 9703471 | https://github.com/python/mypy/commit/97034719469d6116e3ab5c5b8548db8c104eb858 |
| e61527c | https://github.com/python/mypy/commit/e61527c4aeea57dfc3ba2072084ac693e7e15d97 |
|
Compare
| https://github.com/python/mypy/compare/97034719469d6116e3ab5c5b8548db8c104eb858..e61527c4aeea57dfc3ba2072084ac693e7e15d97 |
| April 21, 2026 07:30 | https://github.com/python/mypy/pull/21281#event-24707950460 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F21281 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| April 21, 2026 07:59 | https://github.com/python/mypy/pull/21281#event-24708887175 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| Apr 21, 2026 | https://github.com/python/mypy/pull/21281#event-24726016054 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Apr 23, 2026
| https://github.com/python/mypy/pull/21281#ref-issue-3887960566 |
|
1.20 and 2.0 Release Planning
#20726
| https://github.com/python/mypy/issues/20726 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Apr 24, 2026
| https://github.com/python/mypy/pull/21281#pullrequestreview-4169902374 |
|
View reviewed changes
| https://github.com/python/mypy/pull/21281/files/e61527c4aeea57dfc3ba2072084ac693e7e15d97 |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/21281#pullrequestreview-4169902374 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/21281 |
| mypy/checker.py | https://github.com/python/mypy/pull/21281/files/e61527c4aeea57dfc3ba2072084ac693e7e15d97#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| Please reload this page | https://github.com/python/mypy/pull/21281 |
| mypy/checker.py | https://github.com/python/mypy/pull/21281/files/e61527c4aeea57dfc3ba2072084ac693e7e15d97#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04 |
| Please reload this page | https://github.com/python/mypy/pull/21281 |
| test-data/unit/check-narrowing.test | https://github.com/python/mypy/pull/21281/files/e61527c4aeea57dfc3ba2072084ac693e7e15d97#diff-0413401ad6a91bc5c66579455009ba606ee0ddfb0a78278c9e53618c83b53ed5 |
| JukkaL | https://github.com/JukkaL |
| Apr 24, 2026 | https://github.com/python/mypy/pull/21281#discussion_r3138009410 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/21281 |
| hauntsaninja | https://github.com/hauntsaninja |
| Apr 24, 2026 | https://github.com/python/mypy/pull/21281#discussion_r3140199469 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/21281 |
|
| https://github.com/hauntsaninja |
| tmp | https://github.com/python/mypy/pull/21281/commits/697d83273fc2206640e0955ae4fa1e8dfa1d9f49 |
| 697d832 | https://github.com/python/mypy/pull/21281/commits/697d83273fc2206640e0955ae4fa1e8dfa1d9f49 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Apr 24, 2026 | https://github.com/python/mypy/pull/21281#issuecomment-4316381540 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/21281 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| 1e96fb7 | https://github.com/python/mypy/commit/1e96fb723793fd4c86fa8772d2e3516bd1668587 |
| Apr 24, 2026 | https://github.com/python/mypy/pull/21281#event-24853980709 |
| Please reload this page | https://github.com/python/mypy/pull/21281 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| April 24, 2026 22:04 | https://github.com/python/mypy/pull/21281#event-24853981523 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Apr 28, 2026
| https://github.com/python/mypy/pull/21281#ref-pullrequest-4339999678 |
|
Fix narrowing for AbstractSet and Mapping
#21352
| https://github.com/python/mypy/pull/21352 |
| JukkaL | https://github.com/JukkaL |
|
Apr 28, 2026
| https://github.com/python/mypy/pull/21281#ref-commit-c4b9a29 |
|
| https://github.com/hauntsaninja |
| Fix narrowing for AbstractSet and Mapping ( | https://github.com/python/mypy/commit/c4b9a29505430433a6d8b4853bb3c02b42740017 |
| #21352 | https://github.com/python/mypy/pull/21352 |
| ) | https://github.com/python/mypy/commit/c4b9a29505430433a6d8b4853bb3c02b42740017 |
| c4b9a29 | https://github.com/python/mypy/commit/c4b9a29505430433a6d8b4853bb3c02b42740017 |
| #21281 | https://github.com/python/mypy/pull/21281 |
| #21151 | https://github.com/python/mypy/pull/21151 |
| JukkaL | https://github.com/JukkaL |
|
Apr 30, 2026
| https://github.com/python/mypy/pull/21281#ref-commit-2c9ddae |
|
| https://github.com/hauntsaninja |
|
| https://github.com/JukkaL |
| Fix narrowing for AbstractSet and Mapping ( | https://github.com/python/mypy/commit/2c9ddae00bd6182c6327ed0b5baf89ff8ffd3197 |
| #21352 | https://github.com/python/mypy/pull/21352 |
| ) | https://github.com/python/mypy/commit/2c9ddae00bd6182c6327ed0b5baf89ff8ffd3197 |
| 2c9ddae | https://github.com/python/mypy/commit/2c9ddae00bd6182c6327ed0b5baf89ff8ffd3197 |
| #21281 | https://github.com/python/mypy/pull/21281 |
| #21151 | https://github.com/python/mypy/pull/21151 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F21281 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/21281/files/e61527c4aeea57dfc3ba2072084ac693e7e15d97 |
|
[1.20 regression] Type narrowing is order sensitive in match-case statement with narrowed enum type
| https://github.com/python/mypy/issues/21187 |
| Please reload this page | https://github.com/python/mypy/pull/21281 |
|
| https://github.com/hauntsaninja |
|
| https://github.com/JukkaL |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |