René's URL Explorer Experiment


Title: Make Expression and Statement proper subclasses of Node by elazarg · Pull Request #2122 · python/mypy · GitHub

Open Graph Title: Make Expression and Statement proper subclasses of Node by elazarg · Pull Request #2122 · python/mypy

X Title: Make Expression and Statement proper subclasses of Node by elazarg · Pull Request #2122 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Resolves most of #1783 (except changing the parameters to NodeVisitor) Serious change - supersedes PR #2121

X Description: Resolves most of #1783 (except changing the parameters to NodeVisitor) Serious change - supersedes PR #2121

Opengraph URL: https://github.com/python/mypy/pull/2122

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6382bf94-c3bd-d435-04f3-2ac0ea6a28a5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB3A:22FAD4:F99DDE:14E89F2:6B005B69
html-safe-nonce6d228f65e80a23e18130a05b0c3e14916d5ecd1b9612fe225fce0cb07fbca9fb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjNBOjIyRkFENDpGOTlEREU6MTRFODlGMjo2QjAwNUI2OSIsInZpc2l0b3JfaWQiOiI4MDIzNjUwMjMzOTIzNjg5MzIxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7e62aa19e5e2d473a93365b119a234562f4f0e1e64a118220dc9e5cdbfa23402
hovercard-subject-tagpull_request:84807958
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/2122/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4c2894e04f9fb0375cc0a22ca582999720c4dd70d2aa58ad7580257cd1494c98/python/mypy/pull/2122
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4c2894e04f9fb0375cc0a22ca582999720c4dd70d2aa58ad7580257cd1494c98/python/mypy/pull/2122
og:image:altResolves most of #1783 (except changing the parameters to NodeVisitor) Serious change - supersedes PR #2121
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameelazarg
hostnamegithub.com
expected-hostnamegithub.com
None29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeacd927ba6112e3b01ba99c762bd699a4a4f5df7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/2122#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2122
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2122
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/2122
Reloadhttps://github.com/python/mypy/pull/2122
Reloadhttps://github.com/python/mypy/pull/2122
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
elazarghttps://github.com/elazarg
python:masterhttps://github.com/python/mypy/tree/master
elazarg:Expression_Subclass_Nodehttps://github.com/elazarg/mypy/tree/Expression_Subclass_Node
Conversationhttps://github.com/python/mypy/pull/2122
Commits11 (11)https://github.com/python/mypy/pull/2122/commits
Checkshttps://github.com/python/mypy/pull/2122/checks
Files changedhttps://github.com/python/mypy/pull/2122/files
Make Expression and Statement proper subclasses of Nodehttps://github.com/python/mypy/pull/2122#top
elazarghttps://github.com/elazarg
python:masterhttps://github.com/python/mypy/tree/master
elazarg:Expression_Subclass_Nodehttps://github.com/elazarg/mypy/tree/Expression_Subclass_Node
https://github.com/elazarg
elazarghttps://github.com/elazarg
Sep 12, 2016https://github.com/python/mypy/pull/2122#issue-176282517
Please reload this pagehttps://github.com/python/mypy/pull/2122
#1783https://github.com/python/mypy/issues/1783
#2121https://github.com/python/mypy/pull/2121
Please reload this pagehttps://github.com/python/mypy/pull/2122
elazarghttps://github.com/elazarg
September 12, 2016 03:15https://github.com/python/mypy/pull/2122#commits-pushed-1983a03
https://github.com/elazarg
Make Statement a proper subclass of Nodehttps://github.com/python/mypy/pull/2122/commits/1983a03dca3cf1b0024583d02edb0f08134da9a6
1983a03https://github.com/python/mypy/pull/2122/commits/1983a03dca3cf1b0024583d02edb0f08134da9a6
https://github.com/elazarg
remove NewType from import listhttps://github.com/python/mypy/pull/2122/commits/9c59230d46301980a945e1d1fc5fd42697ee3869
9c59230https://github.com/python/mypy/pull/2122/commits/9c59230d46301980a945e1d1fc5fd42697ee3869
https://github.com/elazarg
Make Expression a proper subclass of Nodehttps://github.com/python/mypy/pull/2122/commits/3aeb5f16e72e3e998854ac31b825bdb6c807ccde
3aeb5f1https://github.com/python/mypy/pull/2122/commits/3aeb5f16e72e3e998854ac31b825bdb6c807ccde
https://github.com/elazarg
linthttps://github.com/python/mypy/pull/2122/commits/c08eb96cea580422f4ef41723c57e95990bcb010
c08eb96https://github.com/python/mypy/pull/2122/commits/c08eb96cea580422f4ef41723c57e95990bcb010
https://github.com/elazarg
Tighten expression typeshttps://github.com/python/mypy/pull/2122/commits/6a9e94c991366176ad4b3ce34a5f53c4fbc9610e
6a9e94chttps://github.com/python/mypy/pull/2122/commits/6a9e94c991366176ad4b3ce34a5f53c4fbc9610e
https://github.com/elazarg
elazarghttps://github.com/elazarg
Sep 12, 2016 https://github.com/python/mypy/pull/2122#ref-issue-176342624
Differentiate LvalueTuple from expression TupleExpr (refactoring) #2123 https://github.com/python/mypy/issues/2123
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Sep 12, 2016 https://github.com/python/mypy/pull/2122#ref-pullrequest-176274154
Make Statement a proper subclass of Node #2121 https://github.com/python/mypy/pull/2121
gvanrossumhttps://github.com/gvanrossum
Sep 12, 2016 https://github.com/python/mypy/pull/2122#discussion-diff-78430346
View reviewed changes https://github.com/python/mypy/pull/2122/files/6a9e94c991366176ad4b3ce34a5f53c4fbc9610e#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68
mypy/nodes.pyhttps://github.com/python/mypy/pull/2122/files#diff-d17e62a76795c1a5e75fb9bfe726570f0963e1a8e0430cb78fc6d069a7b46e68
gvanrossumhttps://github.com/gvanrossum
Sep 12, 2016https://github.com/python/mypy/pull/2122#discussion_r78430346
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2122
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Sep 12, 2016https://github.com/python/mypy/pull/2122#issuecomment-246459288
Please reload this pagehttps://github.com/python/mypy/pull/2122
https://github.com/elazarg
elazarghttps://github.com/elazarg
Sep 13, 2016https://github.com/python/mypy/pull/2122#issuecomment-246539857
Please reload this pagehttps://github.com/python/mypy/pull/2122
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Sep 13, 2016https://github.com/python/mypy/pull/2122#issuecomment-246863796
Please reload this pagehttps://github.com/python/mypy/pull/2122
https://github.com/elazarg
elazarghttps://github.com/elazarg
Sep 14, 2016https://github.com/python/mypy/pull/2122#issuecomment-246865817
Please reload this pagehttps://github.com/python/mypy/pull/2122
elazarghttps://github.com/elazarg
September 14, 2016 22:51https://github.com/python/mypy/pull/2122#commits-pushed-95fd2cd
https://github.com/elazarg
remove LvalueExpressionhttps://github.com/python/mypy/pull/2122/commits/95fd2cdbc5660ace1a619641a9bbeef27d99cfbf
95fd2cdhttps://github.com/python/mypy/pull/2122/commits/95fd2cdbc5660ace1a619641a9bbeef27d99cfbf
https://github.com/elazarg
TypeMap as Optional[Dict]https://github.com/python/mypy/pull/2122/commits/b73a1ff1cd73f404a9d11ea0401270dde48524cc
b73a1ffhttps://github.com/python/mypy/pull/2122/commits/b73a1ff1cd73f404a9d11ea0401270dde48524cc
https://github.com/elazarg
Revert Expression/Statement to be aliases againhttps://github.com/python/mypy/pull/2122/commits/9a0e532422f7cf41238c5440ec8cb38c6d8decbd
9a0e532https://github.com/python/mypy/pull/2122/commits/9a0e532422f7cf41238c5440ec8cb38c6d8decbd
https://github.com/elazarg
revert parse-related fileshttps://github.com/python/mypy/pull/2122/commits/bb9d203b92b67b94d1b4837bd6ba1bd4fce6c2ce
bb9d203https://github.com/python/mypy/pull/2122/commits/bb9d203b92b67b94d1b4837bd6ba1bd4fce6c2ce
https://github.com/elazarg
Argument <: Declarationhttps://github.com/python/mypy/pull/2122/commits/7a46e7a52ec9f89071e1ef4742b6948e32053c3d
7a46e7ahttps://github.com/python/mypy/pull/2122/commits/7a46e7a52ec9f89071e1ef4742b6948e32053c3d
https://github.com/elazarg
elazarghttps://github.com/elazarg
Sep 14, 2016https://github.com/python/mypy/pull/2122#issuecomment-247185386
Please reload this pagehttps://github.com/python/mypy/pull/2122
https://github.com/elazarg
revert Declaration (which was alias anyway)https://github.com/python/mypy/pull/2122/commits/171eca5c862eca452110b20aaa6005a5307a0631
171eca5https://github.com/python/mypy/pull/2122/commits/171eca5c862eca452110b20aaa6005a5307a0631
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Sep 28, 2016https://github.com/python/mypy/pull/2122#issuecomment-250325706
Please reload this pagehttps://github.com/python/mypy/pull/2122
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Sep 29, 2016https://github.com/python/mypy/pull/2122#issuecomment-250601286
Please reload this pagehttps://github.com/python/mypy/pull/2122
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Sep 29, 2016https://github.com/python/mypy/pull/2122#event-807702178
https://github.com/elazarg
elazarghttps://github.com/elazarg
October 27, 2016 15:01https://github.com/python/mypy/pull/2122#event-838739117
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2122
Please reload this pagehttps://github.com/python/mypy/pull/2122
Please reload this pagehttps://github.com/python/mypy/pull/2122
https://github.com/elazarg
https://github.com/gvanrossum
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.