René's URL Explorer Experiment


Title: Fix narrowing for unions by hauntsaninja · Pull Request #20728 · python/mypy · GitHub

Open Graph Title: Fix narrowing for unions by hauntsaninja · Pull Request #20728 · python/mypy

X Title: Fix narrowing for unions by hauntsaninja · Pull Request #20728 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Previously we considered the else branch unreachable in the testNarrowingAnyUnion test case. It's also nice that the new code is more obviously correct Fixes #20330 This will help with landing ...

X Description: Previously we considered the else branch unreachable in the testNarrowingAnyUnion test case. It's also nice that the new code is more obviously correct Fixes #20330 This will help with land...

Opengraph URL: https://github.com/python/mypy/pull/20728

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:949df516-6142-60d7-b4e5-1f83181da0d0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC5E0:3265A:28E504:35BD09:6A59570D
html-safe-nonce3616a8bbbad2c20cf976e6448921fe616cd15de2ba2260423dd03f8ab9e65adc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNUUwOjMyNjVBOjI4RTUwNDozNUJEMDk6NkE1OTU3MEQiLCJ2aXNpdG9yX2lkIjoiMzAxNjk2MTM0NzQ5MjA3NTI3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6a1b2c9fa57e236fb7574e925905acccf1e21a34cae8c68d0cbf52b782e5f78e
hovercard-subject-tagpull_request:3239957280
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/20728/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6e7529ebdbd7bfbca02dca237e09c88358ba9652beadb6e44b5e57b56f2850b3/python/mypy/pull/20728
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6e7529ebdbd7bfbca02dca237e09c88358ba9652beadb6e44b5e57b56f2850b3/python/mypy/pull/20728
og:image:altPreviously we considered the else branch unreachable in the testNarrowingAnyUnion test case. It's also nice that the new code is more obviously correct Fixes #20330 This will help with landing ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehauntsaninja
hostnamegithub.com
expected-hostnamegithub.com
Nonea540949572872b935b393b36db38922db390ae71c859537d741b8f3eb7e545b5
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5f35ad1fb16417d6e6774c537b62a2fe92222907
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/mypy/pull/20728#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F20728
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F20728
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/20728
Reloadhttps://github.com/python/mypy/pull/20728
Reloadhttps://github.com/python/mypy/pull/20728
Please reload this pagehttps://github.com/python/mypy/pull/20728
python https://github.com/python
mypyhttps://github.com/python/mypy
Please reload this pagehttps://github.com/python/mypy/pull/20728
Notifications https://github.com/login?return_to=%2Fpython%2Fmypy
Fork 3.2k https://github.com/login?return_to=%2Fpython%2Fmypy
Star 20.5k https://github.com/login?return_to=%2Fpython%2Fmypy
Code https://github.com/python/mypy
Issues 2.7k https://github.com/python/mypy/issues
Pull requests 466 https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality 0 https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
Code https://github.com/python/mypy
Issues https://github.com/python/mypy/issues
Pull requests https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:narrow81https://github.com/hauntsaninja/mypy/tree/narrow81
Conversationhttps://github.com/python/mypy/pull/20728
Commits2 (2)https://github.com/python/mypy/pull/20728/commits
Checkshttps://github.com/python/mypy/pull/20728/checks
Files changedhttps://github.com/python/mypy/pull/20728/files
Fix narrowing for unionshttps://github.com/python/mypy/pull/20728#top
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:narrow81https://github.com/hauntsaninja/mypy/tree/narrow81
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Feb 3, 2026https://github.com/python/mypy/pull/20728#issue-3889806531
Please reload this pagehttps://github.com/python/mypy/pull/20728
#20330https://github.com/python/mypy/issues/20330
#20727https://github.com/python/mypy/pull/20727
Please reload this pagehttps://github.com/python/mypy/pull/20728
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Feb 3, 2026https://github.com/python/mypy/pull/20728#event-22488732608
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
force-pushedhttps://github.com/python/mypy/compare/187745a7893d11850aa6e803c8fba252189c8382..7b7df01ffae9cf8b2345d9c054d674ee8f286790
187745ahttps://github.com/python/mypy/commit/187745a7893d11850aa6e803c8fba252189c8382
7b7df01https://github.com/python/mypy/commit/7b7df01ffae9cf8b2345d9c054d674ee8f286790
Compare https://github.com/python/mypy/compare/187745a7893d11850aa6e803c8fba252189c8382..7b7df01ffae9cf8b2345d9c054d674ee8f286790
February 3, 2026 08:06https://github.com/python/mypy/pull/20728#event-22488870440
https://github.com/hauntsaninja
Fix narrowing for unions with Anyhttps://github.com/python/mypy/pull/20728/commits/f69eb3b66b88c26028e5df718da63151cea03ade
f69eb3bhttps://github.com/python/mypy/pull/20728/commits/f69eb3b66b88c26028e5df718da63151cea03ade
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
force-pushedhttps://github.com/python/mypy/compare/7b7df01ffae9cf8b2345d9c054d674ee8f286790..f69eb3b66b88c26028e5df718da63151cea03ade
7b7df01https://github.com/python/mypy/commit/7b7df01ffae9cf8b2345d9c054d674ee8f286790
f69eb3bhttps://github.com/python/mypy/commit/f69eb3b66b88c26028e5df718da63151cea03ade
Compare https://github.com/python/mypy/compare/7b7df01ffae9cf8b2345d9c054d674ee8f286790..f69eb3b66b88c26028e5df718da63151cea03ade
February 3, 2026 08:08https://github.com/python/mypy/pull/20728#event-22488903115
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Feb 3, 2026 https://github.com/python/mypy/pull/20728#ref-issue-3802163929
Better narrowing #20564 https://github.com/python/mypy/issues/20564
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Feb 3, 2026 https://github.com/python/mypy/pull/20728#ref-issue-3889838488
Check #20728 sterliakov/mypy-issues#261 https://github.com/sterliakov/mypy-issues/issues/261
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F20728
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Feb 3, 2026https://github.com/python/mypy/pull/20728#issuecomment-3839869908
Please reload this pagehttps://github.com/python/mypy/pull/20728
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Feb 3, 2026 https://github.com/python/mypy/pull/20728#pullrequestreview-3743843280
View reviewed changes https://github.com/python/mypy/pull/20728/files
test-data/unit/check-typeis.testhttps://github.com/python/mypy/pull/20728/files#diff-b6daa571602110b066888622002caea3654556d248977faf0f2a5813ec53e630
hauntsaninjahttps://github.com/hauntsaninja
Feb 3, 2026https://github.com/python/mypy/pull/20728#discussion_r2757889288
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#20330https://github.com/python/mypy/issues/20330
Please reload this pagehttps://github.com/python/mypy/pull/20728
test-data/unit/check-typeis.testhttps://github.com/python/mypy/pull/20728/files#diff-b6daa571602110b066888622002caea3654556d248977faf0f2a5813ec53e630
hauntsaninjahttps://github.com/hauntsaninja
Feb 3, 2026https://github.com/python/mypy/pull/20728#discussion_r2757895029
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/20728
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Feb 3, 2026 https://github.com/python/mypy/pull/20728#pullrequestreview-3743859729
View reviewed changes https://github.com/python/mypy/pull/20728/files
test-data/unit/check-isinstance.testhttps://github.com/python/mypy/pull/20728/files#diff-e3de7a75a8a107b4f462b164cdf4945d50505c5e9f7092b753c4add0c01530bb
hauntsaninjahttps://github.com/hauntsaninja
Feb 3, 2026https://github.com/python/mypy/pull/20728#discussion_r2757903083
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/20728
ilevkivskyihttps://github.com/ilevkivskyi
Feb 6, 2026https://github.com/python/mypy/pull/20728#discussion_r2776051542
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/20728
https://github.com/hauntsaninja
testshttps://github.com/python/mypy/pull/20728/commits/9304905833a0f79a8ed4e9fb7c7ed20bd4277130
9304905https://github.com/python/mypy/pull/20728/commits/9304905833a0f79a8ed4e9fb7c7ed20bd4277130
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
force-pushedhttps://github.com/python/mypy/compare/96eba9b11baa7da41cb380e7d9d547b2d0619ced..9304905833a0f79a8ed4e9fb7c7ed20bd4277130
96eba9bhttps://github.com/python/mypy/commit/96eba9b11baa7da41cb380e7d9d547b2d0619ced
9304905https://github.com/python/mypy/commit/9304905833a0f79a8ed4e9fb7c7ed20bd4277130
Compare https://github.com/python/mypy/compare/96eba9b11baa7da41cb380e7d9d547b2d0619ced..9304905833a0f79a8ed4e9fb7c7ed20bd4277130
February 3, 2026 08:40https://github.com/python/mypy/pull/20728#event-22489787232
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Feb 3, 2026 https://github.com/python/mypy/pull/20728#ref-pullrequest-3889382138
Improve narrowing with numeric types #20727 https://github.com/python/mypy/pull/20727
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Feb 3, 2026https://github.com/python/mypy/pull/20728#issuecomment-3839991146
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/20728
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
JukkaLhttps://github.com/JukkaL
ilevkivskyihttps://github.com/ilevkivskyi
February 4, 2026 19:30https://github.com/python/mypy/pull/20728#event-22538436082
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Feb 6, 2026https://github.com/python/mypy/pull/20728#issuecomment-3862584031
Please reload this pagehttps://github.com/python/mypy/pull/20728
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 6, 2026 https://github.com/python/mypy/pull/20728#pullrequestreview-3765181593
View reviewed changes https://github.com/python/mypy/pull/20728/files/9304905833a0f79a8ed4e9fb7c7ed20bd4277130
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/20728#pullrequestreview-3765181593
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/20728
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
79e9c78https://github.com/python/mypy/commit/79e9c78d6b142a7b8bba4609f079c30843536654
Feb 6, 2026https://github.com/python/mypy/pull/20728#event-22600221587
Please reload this pagehttps://github.com/python/mypy/pull/20728
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
February 6, 2026 21:36https://github.com/python/mypy/pull/20728#event-22600222045
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F20728
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/20728/files/9304905833a0f79a8ed4e9fb7c7ed20bd4277130
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
[1.18 regression] Negative type narrowing of TypeIs of Union with TypeVar not working https://github.com/python/mypy/issues/20330
Please reload this pagehttps://github.com/python/mypy/pull/20728
https://github.com/hauntsaninja
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.