René's URL Explorer Experiment


Title: Narrow types based on collection containment by hauntsaninja · Pull Request #20602 · python/mypy · GitHub

Open Graph Title: Narrow types based on collection containment by hauntsaninja · Pull Request #20602 · python/mypy

X Title: Narrow types based on collection containment by hauntsaninja · Pull Request #20602 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Test cases come from #17344 authored by Jordandev678 We've wanted to do this for a long time, but previous attempt was reverted due to issues like #17841 , #17864 , #17869 Following #20492 we ...

X Description: Test cases come from #17344 authored by Jordandev678 We've wanted to do this for a long time, but previous attempt was reverted due to issues like #17841 , #17864 , #17869 Following #20492...

Opengraph URL: https://github.com/python/mypy/pull/20602

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c7deb018-62f0-0163-ff78-0a64cdfd0608
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB90C:1978BB:272C89:349ADC:6A592586
html-safe-nonceca005909c181e5653b85fec4e983e3306a683b1e1aa1a56a14d90739a53b96ad
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTBDOjE5NzhCQjoyNzJDODk6MzQ5QURDOjZBNTkyNTg2IiwidmlzaXRvcl9pZCI6IjI3NTc1MDgwMDgxMzc3OTQ5NTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb7903d17235e26d217e5469b72f375dbeee6f36760507a064a1eb336cf2aca4e
hovercard-subject-tagpull_request:3182811960
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/20602/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f32eab1f0d0143494c4a4f340465da30cf85db263dffafd51d543968fdd98f48/python/mypy/pull/20602
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f32eab1f0d0143494c4a4f340465da30cf85db263dffafd51d543968fdd98f48/python/mypy/pull/20602
og:image:altTest cases come from #17344 authored by Jordandev678 We've wanted to do this for a long time, but previous attempt was reverted due to issues like #17841 , #17864 , #17869 Following #20492 we ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehauntsaninja
hostnamegithub.com
expected-hostnamegithub.com
None30abb2b48d3b1b476bbaf01f49ead8ef91062bfd762d3fa28a956f4c99653343
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef2e5b4fd472ea10ac216e358bbd0821a90dae8bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/mypy/pull/20602#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F20602
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F20602
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/20602
Reloadhttps://github.com/python/mypy/pull/20602
Reloadhttps://github.com/python/mypy/pull/20602
Please reload this pagehttps://github.com/python/mypy/pull/20602
python https://github.com/python
mypyhttps://github.com/python/mypy
Please reload this pagehttps://github.com/python/mypy/pull/20602
Notifications https://github.com/login?return_to=%2Fpython%2Fmypy
Fork 3.2k https://github.com/login?return_to=%2Fpython%2Fmypy
Star 20.5k https://github.com/login?return_to=%2Fpython%2Fmypy
Code https://github.com/python/mypy
Issues 2.7k https://github.com/python/mypy/issues
Pull requests 466 https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality 0 https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
Code https://github.com/python/mypy
Issues https://github.com/python/mypy/issues
Pull requests https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:narrow4https://github.com/hauntsaninja/mypy/tree/narrow4
Conversationhttps://github.com/python/mypy/pull/20602
Commits3 (3)https://github.com/python/mypy/pull/20602/commits
Checkshttps://github.com/python/mypy/pull/20602/checks
Files changedhttps://github.com/python/mypy/pull/20602/files
Narrow types based on collection containmenthttps://github.com/python/mypy/pull/20602#top
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:narrow4https://github.com/hauntsaninja/mypy/tree/narrow4
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jan 16, 2026https://github.com/python/mypy/pull/20602#issue-3823772196
Please reload this pagehttps://github.com/python/mypy/pull/20602
#17344https://github.com/python/mypy/pull/17344
#17841https://github.com/python/mypy/issues/17841
#17864https://github.com/python/mypy/issues/17864
#17869https://github.com/python/mypy/pull/17869
#20492https://github.com/python/mypy/pull/20492
#3229https://github.com/python/mypy/issues/3229
#20234https://github.com/python/mypy/issues/20234
#18208https://github.com/python/mypy/issues/18208
#16774https://github.com/python/mypy/issues/16774
Please reload this pagehttps://github.com/python/mypy/pull/20602
https://github.com/hauntsaninja
Narrow types based on collection containmenthttps://github.com/python/mypy/pull/20602/commits/ef3824cd521173c5d966fcce5285c7e622406898
ef3824chttps://github.com/python/mypy/pull/20602/commits/ef3824cd521173c5d966fcce5285c7e622406898
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jan 16, 2026 https://github.com/python/mypy/pull/20602#ref-issue-3802163929
Better narrowing #20564 https://github.com/python/mypy/issues/20564
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jan 16, 2026 https://github.com/python/mypy/pull/20602#ref-issue-3823775316
Check #20602 sterliakov/mypy-issues#242 https://github.com/sterliakov/mypy-issues/issues/242
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F20602
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jan 16, 2026https://github.com/python/mypy/pull/20602#issuecomment-3762017296
Please reload this pagehttps://github.com/python/mypy/pull/20602
Please reload this pagehttps://github.com/python/mypy/pull/20602
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jan 17, 2026 https://github.com/python/mypy/pull/20602#pullrequestreview-3673512301
View reviewed changes https://github.com/python/mypy/pull/20602/files/ef3824cd521173c5d966fcce5285c7e622406898
mypy/checker.pyhttps://github.com/python/mypy/pull/20602/files/ef3824cd521173c5d966fcce5285c7e622406898#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
hauntsaninjahttps://github.com/hauntsaninja
Jan 17, 2026https://github.com/python/mypy/pull/20602#discussion_r2700676402
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/20602
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jan 21, 2026https://github.com/python/mypy/pull/20602#issuecomment-3781080969
Please reload this pagehttps://github.com/python/mypy/pull/20602
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jan 22, 2026 https://github.com/python/mypy/pull/20602#ref-issue-3840788894
Regression with narrowing with TypeVar intersection #20628 https://github.com/python/mypy/issues/20628
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Jan 22, 2026 https://github.com/python/mypy/pull/20602#pullrequestreview-3693506380
View reviewed changes https://github.com/python/mypy/pull/20602/files/ef3824cd521173c5d966fcce5285c7e622406898
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/20602#pullrequestreview-3693506380
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/20602
test-data/unit/check-narrowing.testhttps://github.com/python/mypy/pull/20602/files/ef3824cd521173c5d966fcce5285c7e622406898#diff-0413401ad6a91bc5c66579455009ba606ee0ddfb0a78278c9e53618c83b53ed5
JukkaLhttps://github.com/JukkaL
Jan 22, 2026https://github.com/python/mypy/pull/20602#discussion_r2717762355
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/20602
hauntsaninjahttps://github.com/hauntsaninja
Jan 22, 2026https://github.com/python/mypy/pull/20602#discussion_r2718712227
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/20602
test-data/unit/check-narrowing.testhttps://github.com/python/mypy/pull/20602/files/ef3824cd521173c5d966fcce5285c7e622406898#diff-0413401ad6a91bc5c66579455009ba606ee0ddfb0a78278c9e53618c83b53ed5
JukkaLhttps://github.com/JukkaL
Jan 22, 2026https://github.com/python/mypy/pull/20602#discussion_r2717763364
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/20602
test-data/unit/check-narrowing.testhttps://github.com/python/mypy/pull/20602/files/ef3824cd521173c5d966fcce5285c7e622406898#diff-0413401ad6a91bc5c66579455009ba606ee0ddfb0a78278c9e53618c83b53ed5
JukkaLhttps://github.com/JukkaL
Jan 22, 2026https://github.com/python/mypy/pull/20602#discussion_r2717768897
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/20602
hauntsaninjahttps://github.com/hauntsaninja
Jan 22, 2026https://github.com/python/mypy/pull/20602#discussion_r2718733335
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/20602
https://github.com/hauntsaninja
rewrite test caseshttps://github.com/python/mypy/pull/20602/commits/0c2c57b642ced9bdce62b406b9f6876bb757aaeb
0c2c57bhttps://github.com/python/mypy/pull/20602/commits/0c2c57b642ced9bdce62b406b9f6876bb757aaeb
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F20602
https://github.com/hauntsaninja
fixtureshttps://github.com/python/mypy/pull/20602/commits/3e8ded4d961581f34336a68d98c608848c09a02f
3e8ded4https://github.com/python/mypy/pull/20602/commits/3e8ded4d961581f34336a68d98c608848c09a02f
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jan 22, 2026https://github.com/python/mypy/pull/20602#issuecomment-3787009120
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/20602
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
b91f53chttps://github.com/python/mypy/commit/b91f53c1b2d4cd12bf4e15781e447ebdd72f2b42
Jan 22, 2026https://github.com/python/mypy/pull/20602#event-22228005610
Please reload this pagehttps://github.com/python/mypy/pull/20602
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
January 22, 2026 22:15https://github.com/python/mypy/pull/20602#event-22228006097
https://github.com/cdce8p
cdce8phttps://github.com/cdce8p
Jan 28, 2026 https://github.com/python/mypy/pull/20602#ref-pullrequest-3862851963
Use a single pass for core narrowing logic, add comments #20659 https://github.com/python/mypy/pull/20659
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Feb 8, 2026 https://github.com/python/mypy/pull/20602#ref-pullrequest-3911624710
Avoid narrowing to NewType #20766 https://github.com/python/mypy/pull/20766
https://github.com/Noghpu
Noghpuhttps://github.com/Noghpu
Mar 7, 2026 https://github.com/python/mypy/pull/20602#ref-issue-4038696001
Narrow types based on collection containment facebook/pyrefly#2706 https://github.com/facebook/pyrefly/issues/2706
correctmosthttps://github.com/correctmost
Apr 1, 2026 https://github.com/python/mypy/pull/20602#ref-commit-b62b243
https://github.com/correctmost
Update mypy to 1.20.0https://github.com/correctmost/archinstall/commit/b62b243b10849971c39476264fdf7bb5eccf7359
b62b243https://github.com/correctmost/archinstall/commit/b62b243b10849971c39476264fdf7bb5eccf7359
python/mypy#20602https://github.com/python/mypy/pull/20602
https://github.com/correctmost
correctmosthttps://github.com/correctmost
Apr 1, 2026 https://github.com/python/mypy/pull/20602#ref-pullrequest-4186697849
Update mypy to 1.20.0 archlinux/archinstall#4352 https://github.com/archlinux/archinstall/pull/4352
svartkaninhttps://github.com/svartkanin
Apr 1, 2026 https://github.com/python/mypy/pull/20602#ref-commit-d70e03f
https://github.com/correctmost
Update mypy to 1.20.0 (https://github.com/archlinux/archinstall/commit/d70e03fa3beabc510f9ec43ddef02e2cc8cac4cb
#4352https://github.com/archlinux/archinstall/pull/4352
)https://github.com/archlinux/archinstall/commit/d70e03fa3beabc510f9ec43ddef02e2cc8cac4cb
d70e03fhttps://github.com/archlinux/archinstall/commit/d70e03fa3beabc510f9ec43ddef02e2cc8cac4cb
python/mypy#20602https://github.com/python/mypy/pull/20602
https://github.com/ordinary9843
ordinary9843https://github.com/ordinary9843
Apr 13, 2026 https://github.com/python/mypy/pull/20602#ref-pullrequest-4252380987
fix: do not narrow expression type to TypeVar on equality comparison #21209 https://github.com/python/mypy/pull/21209
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
May 5, 2026 https://github.com/python/mypy/pull/20602#ref-pullrequest-4387088762
Draft: generic forms engine for content review Skigim/Lifeguard#3 https://github.com/Skigim/Lifeguard/pull/3
https://github.com/randolf-scholz
randolf-scholzhttps://github.com/randolf-scholz
May 19, 2026 https://github.com/python/mypy/pull/20602#ref-issue-4480383533
[Regression 1.19.1 -> 1.20.0] value in container based narrowing causes false negatives. #21512 https://github.com/python/mypy/issues/21512
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F20602
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/20602/files/ef3824cd521173c5d966fcce5285c7e622406898
Incorrect type of enum in "if" clause https://github.com/python/mypy/issues/20234
Type Narrowing for Dictionary Keys Not Working with Literal Types After in Check https://github.com/python/mypy/issues/18208
Checking if a value is in a tuple does not narrow its type https://github.com/python/mypy/issues/16774
Type not narrowed correctly for if X in collection https://github.com/python/mypy/issues/3229
Please reload this pagehttps://github.com/python/mypy/pull/20602
https://github.com/hauntsaninja
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.