René's URL Explorer Experiment


Title: Fix Type Comparison Edge Cases by George-Ogden · Pull Request #20277 · python/mypy · GitHub

Open Graph Title: Fix Type Comparison Edge Cases by George-Ogden · Pull Request #20277 · python/mypy

X Title: Fix Type Comparison Edge Cases by George-Ogden · Pull Request #20277 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #20275 and #20041 This code snippet fails to type-check before this PR: class X: y: int def __eq__(self, other: object) -> bool: return type(other) is type(self) and other...

X Description: Fixes #20275 and #20041 This code snippet fails to type-check before this PR: class X: y: int def __eq__(self, other: object) -> bool: return type(other) is type(self) and o...

Opengraph URL: https://github.com/python/mypy/pull/20277

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5c679c1f-51cf-895a-b1db-42e1fbc99f8e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB012:16D958:23322A9:2F5CE88:6A59AB9A
html-safe-nonce463319e81169261edf71006c594cf035674595e18a2571e073f4b08865c36278
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDEyOjE2RDk1ODoyMzMyMkE5OjJGNUNFODg6NkE1OUFCOUEiLCJ2aXNpdG9yX2lkIjoiODQ3NjMwMDA5MjgyMzQxNTcwNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac657e2ee8e729194a8474779fe1757d2da002def86332510d67baa09669bdfcf0
hovercard-subject-tagpull_request:3031333908
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/20277/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fed200940e166e202dbb08a7b8deac8c34b6e19702b338e29d0b95a46ecda2f7/python/mypy/pull/20277
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fed200940e166e202dbb08a7b8deac8c34b6e19702b338e29d0b95a46ecda2f7/python/mypy/pull/20277
og:image:altFixes #20275 and #20041 This code snippet fails to type-check before this PR: class X: y: int def __eq__(self, other: object) -> bool: return type(other) is type(self) and other...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameGeorge-Ogden
hostnamegithub.com
expected-hostnamegithub.com
Noneba3976babb66479b1c943a8edc0777d96157da48fadc0161f9ddb219deee8353
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseab680789ae4a316cdaf0d5a292a1760140931cc4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/mypy/pull/20277#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F20277
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F20277
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/20277
Reloadhttps://github.com/python/mypy/pull/20277
Reloadhttps://github.com/python/mypy/pull/20277
Please reload this pagehttps://github.com/python/mypy/pull/20277
python https://github.com/python
mypyhttps://github.com/python/mypy
Please reload this pagehttps://github.com/python/mypy/pull/20277
Notifications https://github.com/login?return_to=%2Fpython%2Fmypy
Fork 3.2k https://github.com/login?return_to=%2Fpython%2Fmypy
Star 20.5k https://github.com/login?return_to=%2Fpython%2Fmypy
Code https://github.com/python/mypy
Issues 2.7k https://github.com/python/mypy/issues
Pull requests 466 https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality 0 https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
Code https://github.com/python/mypy
Issues https://github.com/python/mypy/issues
Pull requests https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
George-Ogdenhttps://github.com/George-Ogden
python:masterhttps://github.com/python/mypy/tree/master
George-Ogden:type-comparisonhttps://github.com/George-Ogden/mypy/tree/type-comparison
Conversationhttps://github.com/python/mypy/pull/20277
Commits12 (12)https://github.com/python/mypy/pull/20277/commits
Checkshttps://github.com/python/mypy/pull/20277/checks
Files changedhttps://github.com/python/mypy/pull/20277/files
Fix Type Comparison Edge Caseshttps://github.com/python/mypy/pull/20277#top
George-Ogdenhttps://github.com/George-Ogden
python:masterhttps://github.com/python/mypy/tree/master
George-Ogden:type-comparisonhttps://github.com/George-Ogden/mypy/tree/type-comparison
https://github.com/George-Ogden
George-Ogdenhttps://github.com/George-Ogden
Nov 20, 2025https://github.com/python/mypy/pull/20277#issue-3648934371
#20275https://github.com/python/mypy/issues/20275
#20041https://github.com/python/mypy/issues/20041
Please reload this pagehttps://github.com/python/mypy/pull/20277
George-Ogdenhttps://github.com/George-Ogden
November 20, 2025 18:39https://github.com/python/mypy/pull/20277#commits-pushed-19ba56b
https://github.com/George-Ogden
Neaten double check to type guardhttps://github.com/python/mypy/pull/20277/commits/19ba56bbeeec05aa9054e63622bdba8f55cec69e
19ba56bhttps://github.com/python/mypy/pull/20277/commits/19ba56bbeeec05aa9054e63622bdba8f55cec69e
https://github.com/George-Ogden
Use least type during type equality comparisonhttps://github.com/python/mypy/pull/20277/commits/df86e646e1b5fb69b4891fa281ea4056fcf5153f
df86e64https://github.com/python/mypy/pull/20277/commits/df86e646e1b5fb69b4891fa281ea4056fcf5153f
https://github.com/George-Ogden
Keep equal types in chained comparisonhttps://github.com/python/mypy/pull/20277/commits/9b8aadb9b688f6301235c1813f3f9e7840a84d45
9b8aadbhttps://github.com/python/mypy/pull/20277/commits/9b8aadb9b688f6301235c1813f3f9e7840a84d45
https://github.com/George-Ogden
Add unit tests for new caseshttps://github.com/python/mypy/pull/20277/commits/50939a5571a978b4000ffc1cf8ae72547b31279d
50939a5https://github.com/python/mypy/pull/20277/commits/50939a5571a978b4000ffc1cf8ae72547b31279d
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F20277
https://github.com/George-Ogden
George-Ogdenhttps://github.com/George-Ogden
Nov 20, 2025https://github.com/python/mypy/pull/20277#issuecomment-3560223536
Please reload this pagehttps://github.com/python/mypy/pull/20277
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
Nov 21, 2025 https://github.com/python/mypy/pull/20277#pullrequestreview-3491291378
View reviewed changes https://github.com/python/mypy/pull/20277/files/50939a5571a978b4000ffc1cf8ae72547b31279d
A5rockshttps://github.com/A5rocks
https://github.com/python/mypy/pull/20277#pullrequestreview-3491291378
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/20277
mypy/checker.pyhttps://github.com/python/mypy/pull/20277/files/50939a5571a978b4000ffc1cf8ae72547b31279d#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Please reload this pagehttps://github.com/python/mypy/pull/20277
mypy/checker.pyhttps://github.com/python/mypy/pull/20277/files/50939a5571a978b4000ffc1cf8ae72547b31279d#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Please reload this pagehttps://github.com/python/mypy/pull/20277
mypy/checker.pyhttps://github.com/python/mypy/pull/20277/files/50939a5571a978b4000ffc1cf8ae72547b31279d#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Please reload this pagehttps://github.com/python/mypy/pull/20277
George-Ogdenhttps://github.com/George-Ogden
November 21, 2025 08:32https://github.com/python/mypy/pull/20277#commits-pushed-1189e88
https://github.com/George-Ogden
Revert "Neaten double check to type guard"https://github.com/python/mypy/pull/20277/commits/1189e885c28ec28a816d9f22ffe949378dbdd8fa
1189e88https://github.com/python/mypy/pull/20277/commits/1189e885c28ec28a816d9f22ffe949378dbdd8fa
19ba56bhttps://github.com/George-Ogden/mypy/commit/19ba56bbeeec05aa9054e63622bdba8f55cec69e
https://github.com/George-Ogden
Compare type ranges using is_same_type_rangeshttps://github.com/python/mypy/pull/20277/commits/9e50b14ff25f55401ef201de604a48d2493c18df
9e50b14https://github.com/python/mypy/pull/20277/commits/9e50b14ff25f55401ef201de604a48d2493c18df
https://github.com/George-Ogden
Remove strict keyword from ziphttps://github.com/python/mypy/pull/20277/commits/cf82cb50a17894c9a50c1505c9a237934eaaf06b
cf82cb5https://github.com/python/mypy/pull/20277/commits/cf82cb50a17894c9a50c1505c9a237934eaaf06b
https://github.com/George-Ogden
Fix type hint on is_same_type_rangehttps://github.com/python/mypy/pull/20277/commits/2a5870cbe0ce566a8d66fb81c59a770f75f60f37
2a5870chttps://github.com/python/mypy/pull/20277/commits/2a5870cbe0ce566a8d66fb81c59a770f75f60f37
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F20277
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
Nov 21, 2025 https://github.com/python/mypy/pull/20277#pullrequestreview-3493862643
View reviewed changes https://github.com/python/mypy/pull/20277/files/2a5870cbe0ce566a8d66fb81c59a770f75f60f37
mypy/checker.pyhttps://github.com/python/mypy/pull/20277/files/2a5870cbe0ce566a8d66fb81c59a770f75f60f37#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Please reload this pagehttps://github.com/python/mypy/pull/20277
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Nov 21, 2025https://github.com/python/mypy/pull/20277#issuecomment-3564398371
#20275https://github.com/python/mypy/issues/20275
Please reload this pagehttps://github.com/python/mypy/pull/20277
https://github.com/George-Ogden
George-Ogdenhttps://github.com/George-Ogden
Nov 21, 2025https://github.com/python/mypy/pull/20277#issuecomment-3564637825
@tyrallahttps://github.com/tyralla
Please reload this pagehttps://github.com/python/mypy/pull/20277
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
Nov 22, 2025https://github.com/python/mypy/pull/20277#issuecomment-3565792759
Please reload this pagehttps://github.com/python/mypy/pull/20277
Please reload this pagehttps://github.com/python/mypy/pull/20277
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Nov 22, 2025https://github.com/python/mypy/pull/20277#issuecomment-3566093268
Please reload this pagehttps://github.com/python/mypy/pull/20277
https://github.com/George-Ogden
George-Ogdenhttps://github.com/George-Ogden
Nov 22, 2025https://github.com/python/mypy/pull/20277#issuecomment-3567071368
Please reload this pagehttps://github.com/python/mypy/pull/20277
https://github.com/George-Ogden
Rewrite find type equality to intersect instanceshttps://github.com/python/mypy/pull/20277/commits/d993793a7a5a86c1aef81113878f63bceee60201
d993793https://github.com/python/mypy/pull/20277/commits/d993793a7a5a86c1aef81113878f63bceee60201
https://github.com/George-Ogden
George-Ogdenhttps://github.com/George-Ogden
Nov 23, 2025https://github.com/python/mypy/pull/20277#issuecomment-3567760266
Please reload this pagehttps://github.com/python/mypy/pull/20277
https://github.com/George-Ogden
George-Ogdenhttps://github.com/George-Ogden
Nov 23, 2025https://github.com/python/mypy/pull/20277#issuecomment-3567760887
Please reload this pagehttps://github.com/python/mypy/pull/20277
Please reload this pagehttps://github.com/python/mypy/pull/20277
https://github.com/George-Ogden
Remove redundant codehttps://github.com/python/mypy/pull/20277/commits/91fbc3e62563620e248a4368ffb577da0b5bc8d0
91fbc3ehttps://github.com/python/mypy/pull/20277/commits/91fbc3e62563620e248a4368ffb577da0b5bc8d0
https://github.com/George-Ogden
George-Ogdenhttps://github.com/George-Ogden
Nov 23, 2025https://github.com/python/mypy/pull/20277#issuecomment-3567797705
Please reload this pagehttps://github.com/python/mypy/pull/20277
Please reload this pagehttps://github.com/python/mypy/pull/20277
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F20277
https://github.com/George-Ogden
Rewrite type equals narrowing with type rangeshttps://github.com/python/mypy/pull/20277/commits/7a5f33ed1f443ebbbe6b52c1eafb46e87d8d9c4f
7a5f33ehttps://github.com/python/mypy/pull/20277/commits/7a5f33ed1f443ebbbe6b52c1eafb46e87d8d9c4f
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F20277
https://github.com/George-Ogden
Use narrow_declared_type instead of meet_types for type narrowinghttps://github.com/python/mypy/pull/20277/commits/df9f69516de765fc76d2c7a25c84affc4fd7ddce
df9f695https://github.com/python/mypy/pull/20277/commits/df9f69516de765fc76d2c7a25c84affc4fd7ddce
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 24, 2025https://github.com/python/mypy/pull/20277#issuecomment-3572076493
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/20277
https://github.com/RiyaPrabhakar-git
RiyaPrabhakar-githttps://github.com/RiyaPrabhakar-git
GC-Content-Calculatorhttps://github.com/users/RiyaPrabhakar-git/projects/1
Dec 12, 2025https://github.com/python/mypy/pull/20277#event-21527478583
https://github.com/apps/github-project-automation
github-project-automationhttps://github.com/apps/github-project-automation
GC-Content-Calculatorhttps://github.com/users/RiyaPrabhakar-git/projects/1
Dec 12, 2025https://github.com/python/mypy/pull/20277#event-21527478622
Regression with Narrowing (Test Cases) #20600 https://github.com/python/mypy/issues/20600
Add more test cases for type narrowing #20603 https://github.com/python/mypy/pull/20603
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jan 16, 2026 https://github.com/python/mypy/pull/20277#ref-issue-3802163929
Better narrowing #20564 https://github.com/python/mypy/issues/20564
hauntsaninjahttps://github.com/hauntsaninja
Jan 23, 2026 https://github.com/python/mypy/pull/20277#ref-commit-0c63401
https://github.com/George-Ogden
https://github.com/hauntsaninja
Add more test cases for type narrowing (https://github.com/python/mypy/commit/0c6340170b2d0a9eb2e55eacd06709e8fd3d92b0
#20603https://github.com/python/mypy/pull/20603
)https://github.com/python/mypy/commit/0c6340170b2d0a9eb2e55eacd06709e8fd3d92b0
0c63401https://github.com/python/mypy/commit/0c6340170b2d0a9eb2e55eacd06709e8fd3d92b0
#20277https://github.com/python/mypy/pull/20277
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Feb 2, 2026https://github.com/python/mypy/pull/20277#issuecomment-3832823224
Please reload this pagehttps://github.com/python/mypy/pull/20277
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Feb 2, 2026https://github.com/python/mypy/pull/20277#event-22453581144
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F20277
https://github.com/A5rocks
A5rocks https://github.com/A5rocks
https://github.com/python/mypy/pull/20277/files/2a5870cbe0ce566a8d66fb81c59a770f75f60f37
Using type(other) is type(self) only works when revealing types https://github.com/python/mypy/issues/20275
Please reload this pagehttps://github.com/python/mypy/pull/20277
https://github.com/George-Ogden
https://github.com/tyralla
https://github.com/A5rocks
https://github.com/hauntsaninja
https://github.com/RiyaPrabhakar-git
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.