René's URL Explorer Experiment


Title: Make incremental not propagate staleness if the public interface of a module is unchanged (v2) by Michael0x2a · Pull Request #2014 · python/mypy · GitHub

Open Graph Title: Make incremental not propagate staleness if the public interface of a module is unchanged (v2) by Michael0x2a · Pull Request #2014 · python/mypy

X Title: Make incremental not propagate staleness if the public interface of a module is unchanged (v2) by Michael0x2a · Pull Request #2014 · python/mypy

Description: This pull request modifies incremental mode so that if a module is modified in a way such that the types for any of its publicly accessible symbols are unchanged, we recheck the file without queueing up the importers to be rechecked. Or, more precisely, if module A imports module B and module B's public interface is unchanged, then we consider module B to be internally stale but not externally stale and consider module A to still be fresh. It does so by producing a hash of the serialized version of the output before writing the cache data to a file, and saving that hash to the meta file. The hashes are then compared against each other in subsequent runs. This pull request is a strictly better version of #2002, although it also does not solve the "chained modules" problem.

Open Graph Description: This pull request modifies incremental mode so that if a module is modified in a way such that the types for any of its publicly accessible symbols are unchanged, we recheck the file without queuei...

X Description: This pull request modifies incremental mode so that if a module is modified in a way such that the types for any of its publicly accessible symbols are unchanged, we recheck the file without queuei...

Opengraph URL: https://github.com/python/mypy/pull/2014

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ecfd3a0e-d901-ed2b-6fda-e8e59235797f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAEF0:177D5B:2CFEE31:3B49E9F:6B001ACE
html-safe-nonce71ad5479aac578d5e45e8b626a6d6d304db19f1eb46cc0c0689885988bd8725d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUYwOjE3N0Q1QjoyQ0ZFRTMxOjNCNDlFOUY6NkIwMDFBQ0UiLCJ2aXNpdG9yX2lkIjoiNDg5NTEzMTM1MTgzNDk1ODU0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac209179487e596c45471dbbc77262d1b735b950eb6f4b17b0aecb9d030564b602
hovercard-subject-tagpull_request:81055605
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/mypy/pull/2014/files
twitter:imagehttps://avatars.githubusercontent.com/u/1424628?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1424628?s=400&v=4
og:image:altThis pull request modifies incremental mode so that if a module is modified in a way such that the types for any of its publicly accessible symbols are unchanged, we recheck the file without queuei...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonea2dd2291b1b13cc9c06f27ec92fa3dbaf34116fc24c9347b8539db61884c59f4
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release70121d4e855ee0bb7b75cf15d061d91f8863c0f8
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/mypy/pull/2014/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2014%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F2014%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/2014/files
Reloadhttps://github.com/python/mypy/pull/2014/files
Reloadhttps://github.com/python/mypy/pull/2014/files
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fmypy%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fmypy%2Fissues%2Fnew%2Fchoose
gvanrossumhttps://github.com/gvanrossum
python:masterhttps://github.com/python/mypy/tree/master
Michael0x2a:incremental-interface-2https://github.com/Michael0x2a/mypy/tree/incremental-interface-2
Conversation 12 https://github.com/python/mypy/pull/2014
Commits 17 https://github.com/python/mypy/pull/2014/commits
Checks 0 https://github.com/python/mypy/pull/2014/checks
Files changed https://github.com/python/mypy/pull/2014/files
Please reload this pagehttps://github.com/python/mypy/pull/2014/files
Make incremental not propagate staleness if the public interface of a module is unchanged (v2) https://github.com/python/mypy/pull/2014/files#top
Show all changes 17 commits https://github.com/python/mypy/pull/2014/files
81ab769 Add tests for interface-based incremental checks MichaelLeeDBX Aug 9, 2016 https://github.com/python/mypy/pull/2014/commits/81ab7695fac0553accff5a3dbf07ac773c2e8b71
926e30c Make incremental tests use 'rechecked' keyword MichaelLeeDBX Aug 11, 2016 https://github.com/python/mypy/pull/2014/commits/926e30c14b249209052cefd6b892de11a807c957
6703173 Add "rechecked" keyword to incremental tests MichaelLeeDBX Aug 11, 2016 https://github.com/python/mypy/pull/2014/commits/67031735adfbb88c899f04693fb08137a2b50f6e
73c22c3 Add more tests for incremental MichaelLeeDBX Aug 12, 2016 https://github.com/python/mypy/pull/2014/commits/73c22c362cdc54af3c9ac3ac4d47fc90e9f16340
961e19b Make incremental checks handle remote error MichaelLeeDBX Aug 12, 2016 https://github.com/python/mypy/pull/2014/commits/961e19beab834994ea430ff2c30f6f490375b7a0
d64a495 Modify write_cache to safe interface hash MichaelLeeDBX Aug 12, 2016 https://github.com/python/mypy/pull/2014/commits/d64a4953d4a6f207d7e92255ee3dcae141725e8a
bc93aca Load incremental hash when finding cache data MichaelLeeDBX Aug 12, 2016 https://github.com/python/mypy/pull/2014/commits/bc93aca25bd79c016f536deb0a1a3fe1b62d8418
9ff0d40 Refactor cache load so we can see the hash earlier MichaelLeeDBX Aug 12, 2016 https://github.com/python/mypy/pull/2014/commits/9ff0d407851f227f3d9bfae87614343179860bb6
0defbb8 Modify incremental to use interface checks MichaelLeeDBX Aug 12, 2016 https://github.com/python/mypy/pull/2014/commits/0defbb836006987fa672605f63aa52959de063a3
559ad00 Fix minor bug with verbose mode MichaelLeeDBX Aug 12, 2016 https://github.com/python/mypy/pull/2014/commits/559ad00dbfde9d870d56b7d973047cd608c92ad2
6acd57b Add extra test case for sneaky imports MichaelLeeDBX Aug 12, 2016 https://github.com/python/mypy/pull/2014/commits/6acd57b82b4570995deaf07b60a0f8c14e8f5c22
644c785 Fix tests to work with rebase MichaelLeeDBX Aug 16, 2016 https://github.com/python/mypy/pull/2014/commits/644c785cc5b9bfa19ae611800260e930c50e44ca
1bdbd1f Remove debugging code and make minor tweaks MichaelLeeDBX Aug 16, 2016 https://github.com/python/mypy/pull/2014/commits/1bdbd1ff6e5483ca3570867db4bd4e9b98237793
dc7ff95 Refactor and optimize cache writing code MichaelLeeDBX Aug 16, 2016 https://github.com/python/mypy/pull/2014/commits/dc7ff9573c6adde74a6779e979d049bd284e016a
8754d7e Update test case to work with new change MichaelLeeDBX Aug 16, 2016 https://github.com/python/mypy/pull/2014/commits/8754d7ec2c143cf93745e51d07fa46d2680daf2e
cdd6150 Fix failing test MichaelLeeDBX Aug 16, 2016 https://github.com/python/mypy/pull/2014/commits/cdd615089565b07093c25aad67009ec8645b4dbd
aaf0362 Rename compute_md5_hash, explain why we don't use hash(...) MichaelLeeDBX Aug 16, 2016 https://github.com/python/mypy/pull/2014/commits/aaf0362432c14abf3aadade7d3c8cf619f35936f
Clear filters https://github.com/python/mypy/pull/2014/files
Please reload this pagehttps://github.com/python/mypy/pull/2014/files
Please reload this pagehttps://github.com/python/mypy/pull/2014/files
build.py https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
data.py https://github.com/python/mypy/pull/2014/files#diff-37a6d75aa7e2778959e27eff15466ac487c02c5026524afc6a62476315199051
testcheck.py https://github.com/python/mypy/pull/2014/files#diff-a1728e8ba6e78bdc975a04007a7765fc56c65959bef3a8ca87b94fbf85370572
check-incremental.test https://github.com/python/mypy/pull/2014/files#diff-9d27bf05ef2e69475128ad073eb20b12cd347361fef9982761aa1776ed1964a8
check-newtype.test https://github.com/python/mypy/pull/2014/files#diff-a086b2c6c0e589b02bd1dc85550a57ee59ce1c4583d4fa11e73a691701258c75
dict.pyi https://github.com/python/mypy/pull/2014/files#diff-3d9af0eda3c5030382b6cb20aff9575a807be26bb929cad7502e1978881f541a
mypy/build.pyhttps://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
View file https://github.com/Michael0x2a/mypy/blob/aaf0362432c14abf3aadade7d3c8cf619f35936f/mypy/build.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/2014/{{ revealButtonHref }}
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
gvanrossumhttps://github.com/gvanrossum
Aug 15, 2016https://github.com/python/mypy/pull/2014/files#r74849034
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2014/files
Michael0x2ahttps://github.com/Michael0x2a
Aug 15, 2016https://github.com/python/mypy/pull/2014/files#r74852636
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/2014/files
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
https://github.com/python/mypy/pull/2014/files#diff-ea1209369af1f6691068ac958d46d42ed5ab3a6d1529f63d891ca9cab58e3998
mypy/test/data.pyhttps://github.com/python/mypy/pull/2014/files#diff-37a6d75aa7e2778959e27eff15466ac487c02c5026524afc6a62476315199051
View file https://github.com/Michael0x2a/mypy/blob/aaf0362432c14abf3aadade7d3c8cf619f35936f/mypy/test/data.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/2014/{{ revealButtonHref }}
https://github.com/python/mypy/pull/2014/files#diff-37a6d75aa7e2778959e27eff15466ac487c02c5026524afc6a62476315199051
https://github.com/python/mypy/pull/2014/files#diff-37a6d75aa7e2778959e27eff15466ac487c02c5026524afc6a62476315199051
https://github.com/python/mypy/pull/2014/files#diff-37a6d75aa7e2778959e27eff15466ac487c02c5026524afc6a62476315199051
https://github.com/python/mypy/pull/2014/files#diff-37a6d75aa7e2778959e27eff15466ac487c02c5026524afc6a62476315199051
https://github.com/python/mypy/pull/2014/files#diff-37a6d75aa7e2778959e27eff15466ac487c02c5026524afc6a62476315199051
https://github.com/python/mypy/pull/2014/files#diff-37a6d75aa7e2778959e27eff15466ac487c02c5026524afc6a62476315199051
Please reload this pagehttps://github.com/python/mypy/pull/2014/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.