| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0eb41a2e-07af-a977-604a-e8573211ff50 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C9D8:144E47:2C5D679:3A5F222:6B0016C4 |
| html-safe-nonce | 578cfa47a194505a4deaace026ec92fb6b080f24e503c4e8c983fafa6264d711 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUQ4OjE0NEU0NzoyQzVENjc5OjNBNUYyMjI6NkIwMDE2QzQiLCJ2aXNpdG9yX2lkIjoiODg4NDg5MjYxOTYwNDIzNTk3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2e4efe9ed90a0343e79f396dc32cfe9e49fef25bae5a24c70fe55305508b1677 |
| hovercard-subject-tag | pull_request:80279748 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/1989/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/dee5928f4082baea06eed6be59d97a95d92ee2c3dc6aba938a05357e38fce7e1/python/mypy/pull/1989 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dee5928f4082baea06eed6be59d97a95d92ee2c3dc6aba938a05357e38fce7e1/python/mypy/pull/1989 |
| og:image:alt | This is an implementation of my proposed fix for #1698 ( #1698 (comment) )
Relevant differences from the description there:
After the suggestion from @ddfisher I used class attributes in Type inst... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | dmoisset |
| hostname | github.com |
| expected-hostname | github.com |
| None | a2dd2291b1b13cc9c06f27ec92fa3dbaf34116fc24c9347b8539db61884c59f4 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 70121d4e855ee0bb7b75cf15d061d91f8863c0f8 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/1989#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F1989 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F1989 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/1989 |
| Reload | https://github.com/python/mypy/pull/1989 |
| Reload | https://github.com/python/mypy/pull/1989 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ddfisher | https://github.com/ddfisher |
| python:master | https://github.com/python/mypy/tree/master |
| dmoisset:fix1698 | https://github.com/dmoisset/mypy/tree/fix1698 |
| Conversation | https://github.com/python/mypy/pull/1989 |
| Commits15 (15) | https://github.com/python/mypy/pull/1989/commits |
| Checks | https://github.com/python/mypy/pull/1989/checks |
| Files changed | https://github.com/python/mypy/pull/1989/files |
| Fix for #1698 | https://github.com/python/mypy/pull/1989#top |
| ddfisher | https://github.com/ddfisher |
| python:master | https://github.com/python/mypy/tree/master |
| dmoisset:fix1698 | https://github.com/dmoisset/mypy/tree/fix1698 |
|
| https://github.com/dmoisset |
| dmoisset | https://github.com/dmoisset |
| Aug 5, 2016 | https://github.com/python/mypy/pull/1989#issue-169658349 |
| #1698 | https://github.com/python/mypy/issues/1698 |
| #1698 (comment) | https://github.com/python/mypy/issues/1698#issuecomment-233709981 |
| @ddfisher | https://github.com/ddfisher |
| Please reload this page | https://github.com/python/mypy/pull/1989 |
| dmoisset | https://github.com/dmoisset |
| August 5, 2016 18:10 | https://github.com/python/mypy/pull/1989#commits-pushed-a34af88 |
|
| https://github.com/dmoisset |
| Add initial definitions for can_be_true/true_only (and duals) | https://github.com/python/mypy/pull/1989/commits/a34af88a140d3ce670ed4545ce639f8f24970fa5 |
| a34af88 | https://github.com/python/mypy/pull/1989/commits/a34af88a140d3ce670ed4545ce639f8f24970fa5 |
|
| https://github.com/dmoisset |
| Test for the changes in the last commit | https://github.com/python/mypy/pull/1989/commits/b9291c4a569dffc23b9032674e0b5faf912e8f4c |
| b9291c4 | https://github.com/python/mypy/pull/1989/commits/b9291c4a569dffc23b9032674e0b5faf912e8f4c |
|
| https://github.com/dmoisset |
| Make find_isinstance_check on RefExpr use true_only/false_only | https://github.com/python/mypy/pull/1989/commits/317140be1cb8e9d6e100a48b2343191b36bfec29 |
| 317140b | https://github.com/python/mypy/pull/1989/commits/317140be1cb8e9d6e100a48b2343191b36bfec29 |
|
| https://github.com/dmoisset |
| Fix return type of find_isinstance_check, make tests pass again | https://github.com/python/mypy/pull/1989/commits/2c715049de55039aa7efb091fcd8474522cfca06 |
| 2c71504 | https://github.com/python/mypy/pull/1989/commits/2c715049de55039aa7efb091fcd8474522cfca06 |
|
| https://github.com/dmoisset |
| Update rules for checking boolean binary operators | https://github.com/python/mypy/pull/1989/commits/6b0398382b78a7273787aa308ce3e4753264f6db |
| 6b03983 | https://github.com/python/mypy/pull/1989/commits/6b0398382b78a7273787aa308ce3e4753264f6db |
|
| https://github.com/dmoisset |
| Add tests for type restrictions on if | https://github.com/python/mypy/pull/1989/commits/74ba9c5e6926ef3bfc05c0cd07a2ed4e9beaaaae |
| 74ba9c5 | https://github.com/python/mypy/pull/1989/commits/74ba9c5e6926ef3bfc05c0cd07a2ed4e9beaaaae |
|
| https://github.com/dmoisset |
| Fix typo | https://github.com/python/mypy/pull/1989/commits/21ab34d4d8fb6b965b4cd39c008a9c48fa839da0 |
| 21ab34d | https://github.com/python/mypy/pull/1989/commits/21ab34d4d8fb6b965b4cd39c008a9c48fa839da0 |
|
| https://github.com/dmoisset |
| Modified tests with dead code | https://github.com/python/mypy/pull/1989/commits/c70b0d26439bce7bdd3ada9c1407ec0e1e857fc5 |
| c70b0d2 | https://github.com/python/mypy/pull/1989/commits/c70b0d26439bce7bdd3ada9c1407ec0e1e857fc5 |
|
| https://github.com/dmoisset |
| Make unions truthiness aware | https://github.com/python/mypy/pull/1989/commits/ce802814fe942ffcab027266f14aba9289bf71d8 |
| ce80281 | https://github.com/python/mypy/pull/1989/commits/ce802814fe942ffcab027266f14aba9289bf71d8 |
|
| https://github.com/dmoisset |
| Enable truthiness checks independently of --strict-optional | https://github.com/python/mypy/pull/1989/commits/19d0920d2f3a5561b12e79ad062a442116edbd40 |
| 19d0920 | https://github.com/python/mypy/pull/1989/commits/19d0920d2f3a5561b12e79ad062a442116edbd40 |
|
disambiguate booleans on conditions ("and" & "or" operators)
#1698
| https://github.com/python/mypy/issues/1698 |
|
type checking on boolean expressions
#1871
| https://github.com/python/mypy/issues/1871 |
|
inferred type of "(cond and a) or b"
#1477
| https://github.com/python/mypy/issues/1477 |
|
Consider making None a normal Instance type with --strict-optional
#1847
| https://github.com/python/mypy/issues/1847 |
| https://github.com/ddfisher |
| ddfisher | https://github.com/ddfisher |
| Aug 5, 2016 | https://github.com/python/mypy/pull/1989#issuecomment-237976303 |
| Please reload this page | https://github.com/python/mypy/pull/1989 |
| https://github.com/ddfisher |
| ddfisher | https://github.com/ddfisher |
| Aug 5, 2016 | https://github.com/python/mypy/pull/1989#event-747213734 |
| ddfisher | https://github.com/ddfisher |
|
Aug 13, 2016
| https://github.com/python/mypy/pull/1989#discussion-diff-74676623 |
| View reviewed changes
| https://github.com/python/mypy/pull/1989/files/19d0920d2f3a5561b12e79ad062a442116edbd40#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07 |
| mypy/checkexpr.py | https://github.com/python/mypy/pull/1989/files#diff-42eda644ce5003e33ea0766d7601fcfb4934ad106429abfe115954a1fccddd07 |
| ddfisher | https://github.com/ddfisher |
| Aug 13, 2016 | https://github.com/python/mypy/pull/1989#discussion_r74676623 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/1989 |
| https://github.com/ddfisher |
| ddfisher | https://github.com/ddfisher |
| Aug 13, 2016 | https://github.com/python/mypy/pull/1989#issuecomment-239590204 |
| Please reload this page | https://github.com/python/mypy/pull/1989 |
| https://github.com/dmoisset |
| dmoisset | https://github.com/dmoisset |
| Aug 16, 2016 | https://github.com/python/mypy/pull/1989#issuecomment-240125582 |
| #1989 (comment) | https://github.com/python/mypy/pull/1989#issuecomment-239590204 |
| https://github.com/notifications/unsubscribe-auth/AAMQHaT8vwlAkFuuz-A50SOiBBIX_EXgks5qfRE9gaJpZM4Jd5oe | https://github.com/notifications/unsubscribe-auth/AAMQHaT8vwlAkFuuz-A50SOiBBIX_EXgks5qfRE9gaJpZM4Jd5oe |
| www.machinalis.com | http://www.machinalis.com |
| @dmoisset | https://github.com/dmoisset |
| Please reload this page | https://github.com/python/mypy/pull/1989 |
| dmoisset | https://github.com/dmoisset |
| August 16, 2016 17:33 | https://github.com/python/mypy/pull/1989#commits-pushed-9aa4799 |
|
| https://github.com/dmoisset |
| Unrestrict truthiness when joining types with mixed truthiness | https://github.com/python/mypy/pull/1989/commits/9aa4799d2a1b75967a0791e9dae7b42bb027d4dd |
| 9aa4799 | https://github.com/python/mypy/pull/1989/commits/9aa4799d2a1b75967a0791e9dae7b42bb027d4dd |
|
| https://github.com/dmoisset |
| Apply improvements suggested by | https://github.com/python/mypy/pull/1989/commits/e53c35572fc60388f1954e58f44639fdea65850b |
| @ddfisher | https://github.com/ddfisher |
| in his review | https://github.com/python/mypy/pull/1989/commits/e53c35572fc60388f1954e58f44639fdea65850b |
| e53c355 | https://github.com/python/mypy/pull/1989/commits/e53c35572fc60388f1954e58f44639fdea65850b |
|
| https://github.com/dmoisset |
| Merge remote-tracking branch 'origin/master' into fix1698 | https://github.com/python/mypy/pull/1989/commits/6026e66043dc3827ab2a695e76d5c6d190756432 |
| 6026e66 | https://github.com/python/mypy/pull/1989/commits/6026e66043dc3827ab2a695e76d5c6d190756432 |
| https://github.com/dmoisset |
| dmoisset | https://github.com/dmoisset |
| force-pushed | https://github.com/python/mypy/compare/a6d01e5558fb4f2f7dc0e9e968f832ecdeed4d84..6026e66043dc3827ab2a695e76d5c6d190756432 |
| a6d01e5 | https://github.com/python/mypy/commit/a6d01e5558fb4f2f7dc0e9e968f832ecdeed4d84 |
| 6026e66 | https://github.com/python/mypy/commit/6026e66043dc3827ab2a695e76d5c6d190756432 |
|
Compare
| https://github.com/python/mypy/compare/a6d01e5558fb4f2f7dc0e9e968f832ecdeed4d84..6026e66043dc3827ab2a695e76d5c6d190756432 |
| August 16, 2016 17:24 | https://github.com/python/mypy/pull/1989#event-757383169 |
| https://github.com/dmoisset |
| dmoisset | https://github.com/dmoisset |
| Aug 16, 2016 | https://github.com/python/mypy/pull/1989#issuecomment-240176868 |
| Please reload this page | https://github.com/python/mypy/pull/1989 |
| ddfisher | https://github.com/ddfisher |
|
Aug 16, 2016
| https://github.com/python/mypy/pull/1989#discussion-diff-75002438 |
| View reviewed changes
| https://github.com/python/mypy/pull/1989/files/6026e66043dc3827ab2a695e76d5c6d190756432#diff-dc731faa017a06257ba26e3eacaf17e68a6078aeaf9755d1c06d917fe13ce457 |
| mypy/join.py | https://github.com/python/mypy/pull/1989/files#diff-dc731faa017a06257ba26e3eacaf17e68a6078aeaf9755d1c06d917fe13ce457 |
| ddfisher | https://github.com/ddfisher |
| Aug 16, 2016 | https://github.com/python/mypy/pull/1989#discussion_r75002438 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/1989 |
| dmoisset | https://github.com/dmoisset |
| Aug 16, 2016 | https://github.com/python/mypy/pull/1989#discussion_r75002908 |
| Please reload this page | https://github.com/python/mypy/pull/1989 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/1989 |
| ddfisher | https://github.com/ddfisher |
| Aug 16, 2016 | https://github.com/python/mypy/pull/1989#discussion_r75005256 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/1989 |
| https://github.com/ddfisher |
| ddfisher | https://github.com/ddfisher |
| Aug 16, 2016 | https://github.com/python/mypy/pull/1989#issuecomment-240210429 |
| Please reload this page | https://github.com/python/mypy/pull/1989 |
| dmoisset | https://github.com/dmoisset |
| August 16, 2016 20:47 | https://github.com/python/mypy/pull/1989#commits-pushed-8053579 |
|
| https://github.com/dmoisset |
| Also check join_types for mixed truthiness | https://github.com/python/mypy/pull/1989/commits/805357942014d330a81e0542d15afdb8bd49e0dd |
| 8053579 | https://github.com/python/mypy/pull/1989/commits/805357942014d330a81e0542d15afdb8bd49e0dd |
|
| https://github.com/dmoisset |
| Simplify true_only as suggested by | https://github.com/python/mypy/pull/1989/commits/b364cdbcb3c1c2db9765dd55f2b835b26d0aae18 |
| @ddfisher | https://github.com/ddfisher |
| b364cdb | https://github.com/python/mypy/pull/1989/commits/b364cdbcb3c1c2db9765dd55f2b835b26d0aae18 |
| https://github.com/dmoisset |
| dmoisset | https://github.com/dmoisset |
| Aug 16, 2016 | https://github.com/python/mypy/pull/1989#issuecomment-240219142 |
| Please reload this page | https://github.com/python/mypy/pull/1989 |
| https://github.com/ddfisher |
| ddfisher | https://github.com/ddfisher |
| Aug 16, 2016 | https://github.com/python/mypy/pull/1989#issuecomment-240270309 |
| Please reload this page | https://github.com/python/mypy/pull/1989 |
| https://github.com/ddfisher |
| ddfisher | https://github.com/ddfisher |
| 9a8a8c0 | https://github.com/python/mypy/commit/9a8a8c098a592cccc87473019b29f56a5db9c7cb |
| Aug 16, 2016 | https://github.com/python/mypy/pull/1989#event-757823158 |
| https://github.com/ddfisher |
| ddfisher | https://github.com/ddfisher |
|
Aug 17, 2016
| https://github.com/python/mypy/pull/1989#ref-issue-171548775 |
|
Processing of Callables in make_simplified_union is order dependent
#2031
| https://github.com/python/mypy/issues/2031 |
| https://github.com/dmoisset |
| dmoisset | https://github.com/dmoisset |
| August 18, 2016 11:27 | https://github.com/python/mypy/pull/1989#event-759772954 |
| https://github.com/ddfisher |
| ddfisher | https://github.com/ddfisher |
|
Aug 18, 2016
| https://github.com/python/mypy/pull/1989#ref-pullrequest-162356532 |
|
Use information from find_isinstance_check in short-circuit case too
#1751
| https://github.com/python/mypy/pull/1751 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F1989 |
| Please reload this page | https://github.com/python/mypy/pull/1989 |
|
| https://github.com/ddfisher |
|
ddfisher
| https://github.com/ddfisher |
| Please reload this page | https://github.com/python/mypy/pull/1989 |
|
| https://github.com/dmoisset |
|
| https://github.com/ddfisher |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |