René's URL Explorer Experiment


Title: Somewhat better support for isinstance on old-style unions by hauntsaninja · Pull Request #19714 · python/mypy · GitHub

Open Graph Title: Somewhat better support for isinstance on old-style unions by hauntsaninja · Pull Request #19714 · python/mypy

X Title: Somewhat better support for isinstance on old-style unions by hauntsaninja · Pull Request #19714 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Partially fixes #17680 , remainder of the issue should probably be fixed in the isinstance stub

X Description: Partially fixes #17680 , remainder of the issue should probably be fixed in the isinstance stub

Opengraph URL: https://github.com/python/mypy/pull/19714

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:97779b4d-b592-cb7e-2f4d-1028c38356d7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB2E4:197995:2D3DB4F:3DC624F:6B005D60
html-safe-nonce760379d505e9387d8a6bd33a18e9430afd23c710c0bb2384c988dbd1815f1f94
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMkU0OjE5Nzk5NToyRDNEQjRGOjNEQzYyNEY6NkIwMDVENjAiLCJ2aXNpdG9yX2lkIjoiMzgxMDE5MzA2Njc2MjE1MTM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac19532fc22846dc0339989e631db4a73d51b88348e0394e33be46ab4d69719132
hovercard-subject-tagpull_request:2765571431
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/19714/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3831bdd53e701dff30982bd352ccdbb9597912698530b92eb7fc73f15d92d0c9/python/mypy/pull/19714
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3831bdd53e701dff30982bd352ccdbb9597912698530b92eb7fc73f15d92d0c9/python/mypy/pull/19714
og:image:altPartially fixes #17680 , remainder of the issue should probably be fixed in the isinstance stub
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehauntsaninja
hostnamegithub.com
expected-hostnamegithub.com
None29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeacd927ba6112e3b01ba99c762bd699a4a4f5df7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/19714#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19714
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19714
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/19714
Reloadhttps://github.com/python/mypy/pull/19714
Reloadhttps://github.com/python/mypy/pull/19714
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:mypybehavhttps://github.com/hauntsaninja/mypy/tree/mypybehav
Conversationhttps://github.com/python/mypy/pull/19714
Commits1 (1)https://github.com/python/mypy/pull/19714/commits
Checkshttps://github.com/python/mypy/pull/19714/checks
Files changedhttps://github.com/python/mypy/pull/19714/files
Somewhat better support for isinstance on old-style unionshttps://github.com/python/mypy/pull/19714#top
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:mypybehavhttps://github.com/hauntsaninja/mypy/tree/mypybehav
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Aug 22, 2025https://github.com/python/mypy/pull/19714#issue-3344635269
#17680https://github.com/python/mypy/issues/17680
Please reload this pagehttps://github.com/python/mypy/pull/19714
https://github.com/hauntsaninja
Somewhat better support for isinstance on old-style unionshttps://github.com/python/mypy/pull/19714/commits/320f33321d6d4d5a6138ae2d9adade40f89342a7
320f333https://github.com/python/mypy/pull/19714/commits/320f33321d6d4d5a6138ae2d9adade40f89342a7
python#17680https://github.com/python/mypy/issues/17680
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 22, 2025https://github.com/python/mypy/pull/19714#issuecomment-3213580979
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/19714
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Aug 22, 2025 https://github.com/python/mypy/pull/19714#pullrequestreview-3144638731
View reviewed changes https://github.com/python/mypy/pull/19714/files/320f33321d6d4d5a6138ae2d9adade40f89342a7
test-data/unit/check-unions.testhttps://github.com/python/mypy/pull/19714/files/320f33321d6d4d5a6138ae2d9adade40f89342a7#diff-b360c5af2e15a4304fb90f6686340f2303b5b960a7e30f6961d038d71fa75788
JelleZijlstrahttps://github.com/JelleZijlstra
Aug 22, 2025https://github.com/python/mypy/pull/19714#discussion_r2293830575
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19714
hauntsaninjahttps://github.com/hauntsaninja
Aug 22, 2025https://github.com/python/mypy/pull/19714#discussion_r2294730038
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/python/typeshed/blob/b6e21d05aec7ff1444ffc109c7d31d2f5bb28dbd/stdlib/builtins.pyi#L1537https://github.com/python/typeshed/blob/b6e21d05aec7ff1444ffc109c7d31d2f5bb28dbd/stdlib/builtins.pyi#L1537
Please reload this pagehttps://github.com/python/mypy/pull/19714
AlexWaygoodhttps://github.com/AlexWaygood
Aug 22, 2025https://github.com/python/mypy/pull/19714#discussion_r2294902346
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
python/typeshed#7508https://github.com/python/typeshed/pull/7508
Please reload this pagehttps://github.com/python/mypy/pull/19714
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Aug 22, 2025 https://github.com/python/mypy/pull/19714#pullrequestreview-3144639134
View reviewed changes https://github.com/python/mypy/pull/19714/files/320f33321d6d4d5a6138ae2d9adade40f89342a7
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
ac4cacbhttps://github.com/python/mypy/commit/ac4cacbba3c8511bb591fd11f813de66e79a7aa7
Aug 23, 2025https://github.com/python/mypy/pull/19714#event-19297187963
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
August 23, 2025 00:29https://github.com/python/mypy/pull/19714#event-19297188626
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19714
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/python/mypy/pull/19714/files/320f33321d6d4d5a6138ae2d9adade40f89342a7
https://github.com/AlexWaygood
AlexWaygood https://github.com/AlexWaygood
https://github.com/python/mypy/pull/19714/files/320f33321d6d4d5a6138ae2d9adade40f89342a7
Please reload this pagehttps://github.com/python/mypy/pull/19714
Support typing.Union/typing.Optional in isinstance check (/support old-style unions) https://github.com/python/mypy/issues/17680
Please reload this pagehttps://github.com/python/mypy/pull/19714
https://github.com/hauntsaninja
https://github.com/JelleZijlstra
https://github.com/AlexWaygood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.