René's URL Explorer Experiment


Title: Better support for `SomeEnum.item == some_literal` by sterliakov · Pull Request #19594 · python/mypy · GitHub

Open Graph Title: Better support for `SomeEnum.item == some_literal` by sterliakov · Pull Request #19594 · python/mypy

X Title: Better support for `SomeEnum.item == some_literal` by sterliakov · Pull Request #19594 · python/mypy

Description: Fixes #19576. Fixes #16327. Fixes #17162. Fixes #19753. This needs more feedback: is the logic I propose reasonable? Do we want to be stricter and reject such comparisons altogether? Or maybe only reject them if values are incompatible?

Open Graph Description: Fixes #19576. Fixes #16327. Fixes #17162. Fixes #19753. This needs more feedback: is the logic I propose reasonable? Do we want to be stricter and reject such comparisons altogether? Or maybe only ...

X Description: Fixes #19576. Fixes #16327. Fixes #17162. Fixes #19753. This needs more feedback: is the logic I propose reasonable? Do we want to be stricter and reject such comparisons altogether? Or maybe only ...

Opengraph URL: https://github.com/python/mypy/pull/19594

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:16d33550-b07d-9927-6fe7-994cab62c618
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D7E:16D09E:5EED46E:622228E:6A655A9F
html-safe-nonce4f0790c9c36d8bca828a9171fb3c6e36071a3009ff6fe0680024667b43b56d75
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDdFOjE2RDA5RTo1RUVENDZFOjYyMjIyOEU6NkE2NTVBOUYiLCJ2aXNpdG9yX2lkIjoiMzI4NjMyNDQ0NzcwOTMyMTg4NyIsInJlZ2lvbl9lZGdlIjoic2VhIiwicmVnaW9uX3JlbmRlciI6InNlYSJ9
visitor-hmac24eb77590debc94ec49ad05c15855c47fa86787cfa316e7bb4a6de4ddd95add3
hovercard-subject-tagpull_request:2719460978
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/mypy/pull/19594/commits/ba560f23ed0379aad24a8718ea4c4d335782adec
twitter:imagehttps://avatars.githubusercontent.com/u/50529348?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/50529348?s=400&v=4
og:image:altFixes #19576. Fixes #16327. Fixes #17162. Fixes #19753. This needs more feedback: is the logic I propose reasonable? Do we want to be stricter and reject such comparisons altogether? Or maybe only ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release309153364422b3c499922d1a2a6404910a58ed8e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/mypy/pull/19594/commits/ba560f23ed0379aad24a8718ea4c4d335782adec#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19594%2Fcommits%2Fba560f23ed0379aad24a8718ea4c4d335782adec
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19594%2Fcommits%2Fba560f23ed0379aad24a8718ea4c4d335782adec
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/19594/commits/ba560f23ed0379aad24a8718ea4c4d335782adec
Reloadhttps://github.com/python/mypy/pull/19594/commits/ba560f23ed0379aad24a8718ea4c4d335782adec
Reloadhttps://github.com/python/mypy/pull/19594/commits/ba560f23ed0379aad24a8718ea4c4d335782adec
Please reload this pagehttps://github.com/python/mypy/pull/19594/commits/ba560f23ed0379aad24a8718ea4c4d335782adec
python https://github.com/python
mypyhttps://github.com/python/mypy
Please reload this pagehttps://github.com/python/mypy/pull/19594/commits/ba560f23ed0379aad24a8718ea4c4d335782adec
Notifications https://github.com/login?return_to=%2Fpython%2Fmypy
Fork 3.3k https://github.com/login?return_to=%2Fpython%2Fmypy
Star 20.6k https://github.com/login?return_to=%2Fpython%2Fmypy
Code https://github.com/python/mypy
Issues 2.7k https://github.com/python/mypy/issues
Pull requests 474 https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality 0 https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
Code https://github.com/python/mypy
Issues https://github.com/python/mypy/issues
Pull requests https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fmypy%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fmypy%2Fissues%2Fnew%2Fchoose
sterliakovhttps://github.com/sterliakov
python:masterhttps://github.com/python/mypy/tree/master
sterliakov:bugfix/gh-19576-enum-comparison-overlaphttps://github.com/sterliakov/mypy/tree/bugfix/gh-19576-enum-comparison-overlap
Conversation 21 https://github.com/python/mypy/pull/19594
Commits 13 https://github.com/python/mypy/pull/19594/commits
Checks 19 https://github.com/python/mypy/pull/19594/checks
Files changed https://github.com/python/mypy/pull/19594/files
Please reload this pagehttps://github.com/python/mypy/pull/19594/commits/ba560f23ed0379aad24a8718ea4c4d335782adec
Better support for SomeEnum.item == some_literal https://github.com/python/mypy/pull/19594/commits/ba560f23ed0379aad24a8718ea4c4d335782adec#top
Show all changes 13 commits https://github.com/python/mypy/pull/19594/files
ab3ed33 Fix enum comparison with literal values sterliakov Aug 4, 2025 https://github.com/python/mypy/pull/19594/commits/ab3ed33b65f53786d214be34d147a60edaf1b887
6f4dbb8 Merge remote-tracking branch 'upstream/master' into bugfix/gh-19576-e… sterliakov Aug 7, 2025 https://github.com/python/mypy/pull/19594/commits/6f4dbb8163a218b9f2d6eaa78aa379e302270819
350aa53 Sync reachability and comparison overlap checks sterliakov Aug 7, 2025 https://github.com/python/mypy/pull/19594/commits/350aa53ed54d7dd3668b44487a18dff217016cf9
ebfc647 Fix selfcheck sterliakov Aug 7, 2025 https://github.com/python/mypy/pull/19594/commits/ebfc647bcbd243d191f71cfdef0cba6a1a73ce41
0001936 Oops sterliakov Aug 7, 2025 https://github.com/python/mypy/pull/19594/commits/0001936504a9c65ba509156bd6b06b4024548f18
c87c707 Prevent narrowing by equality to overlapping literals (discarding enu… sterliakov Aug 7, 2025 https://github.com/python/mypy/pull/19594/commits/c87c7074149944b7578f391f6bb3a2de270026fa
ba560f2 No, that was too much sterliakov Aug 28, 2025 https://github.com/python/mypy/pull/19594/commits/ba560f23ed0379aad24a8718ea4c4d335782adec
d96243d Pick unreachable branches more aggressively sterliakov Aug 28, 2025 https://github.com/python/mypy/pull/19594/commits/d96243d4c96096fd8efcc994c43cbb63366bc079
6c4f0aa Merge remote-tracking branch 'upstream/master' into bugfix/gh-19576-e… sterliakov Aug 28, 2025 https://github.com/python/mypy/pull/19594/commits/6c4f0aa207266ca5d1bc9139dbf34cd1963ef201
79262e7 Handle (str, Enum) and (int, Enum) subclasses narrowing sterliakov Aug 29, 2025 https://github.com/python/mypy/pull/19594/commits/79262e75facbec39b5c7c426ef20b54dce72bfa4
9fda66e Merge branch 'master' into bugfix/gh-19576-enum-comparison-overlap sterliakov Sep 16, 2025 https://github.com/python/mypy/pull/19594/commits/9fda66ecb0734feaf551ed2d6941a33715ee26c0
b3713a2 Merge branch 'master' into bugfix/gh-19576-enum-comparison-overlap sterliakov Oct 11, 2025 https://github.com/python/mypy/pull/19594/commits/b3713a27fd3ab9e2c3a78f3e7afdae8c9296143b
0017943 Merge branch 'master' into bugfix/gh-19576-enum-comparison-overlap sterliakov Oct 30, 2025 https://github.com/python/mypy/pull/19594/commits/00179434dfde0e60c6ea08f3f858cc0d64634af7
Clear filters https://github.com/python/mypy/pull/19594/commits/ba560f23ed0379aad24a8718ea4c4d335782adec
Please reload this pagehttps://github.com/python/mypy/pull/19594/commits/ba560f23ed0379aad24a8718ea4c4d335782adec
Please reload this pagehttps://github.com/python/mypy/pull/19594/commits/ba560f23ed0379aad24a8718ea4c4d335782adec
Prev https://github.com/python/mypy/pull/19594/commits/c87c7074149944b7578f391f6bb3a2de270026fa
Next https://github.com/python/mypy/pull/19594/commits/d96243d4c96096fd8efcc994c43cbb63366bc079
Please reload this pagehttps://github.com/python/mypy/pull/19594/commits/ba560f23ed0379aad24a8718ea4c4d335782adec
https://github.com/sterliakov
sterliakovhttps://github.com/python/mypy/commits?author=sterliakov
mypy/checker.pyhttps://github.com/python/mypy/pull/19594/commits/ba560f23ed0379aad24a8718ea4c4d335782adec#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
View file https://github.com/python/mypy/blob/ba560f23ed0379aad24a8718ea4c4d335782adec/mypy/checker.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/19594/commits/{{ revealButtonHref }}
https://github.com/python/mypy/pull/19594/commits/ba560f23ed0379aad24a8718ea4c4d335782adec#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
https://github.com/python/mypy/pull/19594/commits/ba560f23ed0379aad24a8718ea4c4d335782adec#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.