René's URL Explorer Experiment


Title: [match-case] Fix narrowing of class pattern with union-argument. by randolf-scholz · Pull Request #19473 · python/mypy · GitHub

Open Graph Title: [match-case] Fix narrowing of class pattern with union-argument. by randolf-scholz · Pull Request #19473 · python/mypy

X Title: [match-case] Fix narrowing of class pattern with union-argument. by randolf-scholz · Pull Request #19473 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #19468 I added factorization over UnionType inside the conditional_types function. Then try_expanding_sum_type_to_union needed to move to the start of the function so that we expand current_t...

X Description: Fixes #19468 I added factorization over UnionType inside the conditional_types function. Then try_expanding_sum_type_to_union needed to move to the start of the function so that we expand current_t...

Opengraph URL: https://github.com/python/mypy/pull/19473

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5d450e16-e818-cbe0-31d3-236b3698dba6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD81A:36D598:E227CB:12E66BF:6B0054CC
html-safe-nonceb5e11a2d088aedf8cbc7467308095a2c57ca6c24113dbcc59e253de905229d0f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODFBOjM2RDU5ODpFMjI3Q0I6MTJFNjZCRjo2QjAwNTRDQyIsInZpc2l0b3JfaWQiOiIyOTM4NTIwNTA4NjQ1MjY2NjM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac269a44069e320a438255324c9e65dc2726b87063796bf1f9d225333608ab186c
hovercard-subject-tagpull_request:2673708838
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/19473/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cfa40457e9dc787588f2021c392c78c56d4d05b6875e1d8c7bcf94eb7cabe7bd/python/mypy/pull/19473
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cfa40457e9dc787588f2021c392c78c56d4d05b6875e1d8c7bcf94eb7cabe7bd/python/mypy/pull/19473
og:image:altFixes #19468 I added factorization over UnionType inside the conditional_types function. Then try_expanding_sum_type_to_union needed to move to the start of the function so that we expand current_t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerandolf-scholz
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/19473#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19473
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19473
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/19473
Reloadhttps://github.com/python/mypy/pull/19473
Reloadhttps://github.com/python/mypy/pull/19473
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
randolf-scholzhttps://github.com/randolf-scholz
python:masterhttps://github.com/python/mypy/tree/master
randolf-scholz:fix_match_case_union_argumenthttps://github.com/randolf-scholz/mypy/tree/fix_match_case_union_argument
Conversationhttps://github.com/python/mypy/pull/19473
Commits3 (3)https://github.com/python/mypy/pull/19473/commits
Checkshttps://github.com/python/mypy/pull/19473/checks
Files changedhttps://github.com/python/mypy/pull/19473/files
[match-case] Fix narrowing of class pattern with union-argument.https://github.com/python/mypy/pull/19473#top
randolf-scholzhttps://github.com/randolf-scholz
python:masterhttps://github.com/python/mypy/tree/master
randolf-scholz:fix_match_case_union_argumenthttps://github.com/randolf-scholz/mypy/tree/fix_match_case_union_argument
https://github.com/randolf-scholz
randolf-scholzhttps://github.com/randolf-scholz
Jul 17, 2025https://github.com/python/mypy/pull/19473#issue-3239294664
Please reload this pagehttps://github.com/python/mypy/pull/19473
#19468https://github.com/python/mypy/issues/19468
https://mypy-play.net/?mypy=1.17.0&python=3.12&gist=e9ec514f49903022bd32a82ae1774abdhttps://mypy-play.net/?mypy=1.17.0&python=3.12&gist=e9ec514f49903022bd32a82ae1774abd
Please reload this pagehttps://github.com/python/mypy/pull/19473
https://github.com/randolf-scholz
inital commithttps://github.com/python/mypy/pull/19473/commits/7be0e87b58ab30e3c61bb64a475abb2acd70a124
7be0e87https://github.com/python/mypy/pull/19473/commits/7be0e87b58ab30e3c61bb64a475abb2acd70a124
https://github.com/randolf-scholz
randolf-scholzhttps://github.com/randolf-scholz
Jul 17, 2025https://github.com/python/mypy/pull/19473#event-18678671082
https://github.com/randolf-scholz
randolf-scholzhttps://github.com/randolf-scholz
Jul 17, 2025 https://github.com/python/mypy/pull/19473#pullrequestreview-3029214543
View reviewed changes https://github.com/python/mypy/pull/19473/files/7be0e87b58ab30e3c61bb64a475abb2acd70a124
mypy/checker.pyhttps://github.com/python/mypy/pull/19473/files/7be0e87b58ab30e3c61bb64a475abb2acd70a124#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
randolf-scholzhttps://github.com/randolf-scholz
Jul 17, 2025https://github.com/python/mypy/pull/19473#discussion_r2213143471
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19473
sterliakovhttps://github.com/sterliakov
Jul 27, 2025https://github.com/python/mypy/pull/19473#discussion_r2234043360
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19473
randolf-scholzhttps://github.com/randolf-scholz
Jul 27, 2025https://github.com/python/mypy/pull/19473#discussion_r2234054176
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19473
randolf-scholzhttps://github.com/randolf-scholz
Jul 27, 2025https://github.com/python/mypy/pull/19473#discussion_r2234064151
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19473
randolf-scholzhttps://github.com/randolf-scholz
Jul 27, 2025https://github.com/python/mypy/pull/19473#discussion_r2234079359
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@sterliakovhttps://github.com/sterliakov
#19517https://github.com/python/mypy/pull/19517
Please reload this pagehttps://github.com/python/mypy/pull/19473
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19473
https://github.com/randolf-scholz
Merge branch 'master' into fix_match_case_union_argumenthttps://github.com/python/mypy/pull/19473/commits/246e461d638dfa84dc303facc88d3e2eff7465ae
246e461https://github.com/python/mypy/pull/19473/commits/246e461d638dfa84dc303facc88d3e2eff7465ae
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19473
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
Jul 27, 2025 https://github.com/python/mypy/pull/19473#pullrequestreview-3059591023
View reviewed changes https://github.com/python/mypy/pull/19473/files/246e461d638dfa84dc303facc88d3e2eff7465ae
mypy/checker.pyhttps://github.com/python/mypy/pull/19473/files/246e461d638dfa84dc303facc88d3e2eff7465ae#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
sterliakovhttps://github.com/sterliakov
Jul 27, 2025https://github.com/python/mypy/pull/19473#discussion_r2234028362
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#19471https://github.com/python/mypy/pull/19471
Please reload this pagehttps://github.com/python/mypy/pull/19473
mypy/checker.pyhttps://github.com/python/mypy/pull/19473/files/7be0e87b58ab30e3c61bb64a475abb2acd70a124#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
sterliakovhttps://github.com/sterliakov
Jul 27, 2025https://github.com/python/mypy/pull/19473#discussion_r2234043360
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19473
https://github.com/randolf-scholz
randolf-scholzhttps://github.com/randolf-scholz
Jul 27, 2025 https://github.com/python/mypy/pull/19473#ref-pullrequest-3267301708
[match-case] Fix narrowing of class pattern with union-argument. #19517 https://github.com/python/mypy/pull/19517
https://github.com/randolf-scholz
Merge branch 'master' into fix_match_case_union_argumenthttps://github.com/python/mypy/pull/19473/commits/6c23017f9007a0bbebb82af05188b90fe84d367f
6c23017https://github.com/python/mypy/pull/19473/commits/6c23017f9007a0bbebb82af05188b90fe84d367f
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 27, 2025https://github.com/python/mypy/pull/19473#issuecomment-3124657767
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/19473
https://github.com/randolf-scholz
randolf-scholzhttps://github.com/randolf-scholz
July 27, 2025 19:34https://github.com/python/mypy/pull/19473#event-18841335940
https://github.com/randolf-scholz
randolf-scholzhttps://github.com/randolf-scholz
Jul 27, 2025https://github.com/python/mypy/pull/19473#issuecomment-3124682361
#19517https://github.com/python/mypy/pull/19517
Please reload this pagehttps://github.com/python/mypy/pull/19473
https://github.com/randolf-scholz
randolf-scholzhttps://github.com/randolf-scholz
Sep 16, 2025https://github.com/python/mypy/pull/19473#issuecomment-3298808651
@sterliakovhttps://github.com/sterliakov
#19517https://github.com/python/mypy/pull/19517
#19473 (comment)https://github.com/python/mypy/pull/19473#discussion_r2234043360
Please reload this pagehttps://github.com/python/mypy/pull/19473
https://github.com/randolf-scholz
randolf-scholzhttps://github.com/randolf-scholz
Sep 22, 2025https://github.com/python/mypy/pull/19473#event-19850744152
hauntsaninjahttps://github.com/hauntsaninja
Oct 23, 2025 https://github.com/python/mypy/pull/19473#ref-commit-fb16e93
https://github.com/randolf-scholz
[match-case] Fix narrowing of class pattern with union-argument. (https://github.com/python/mypy/commit/fb16e938d12f6b24b5edf8023d4adf8e0e36abb4
#19517https://github.com/python/mypy/pull/19517
fb16e93https://github.com/python/mypy/commit/fb16e938d12f6b24b5edf8023d4adf8e0e36abb4
https://github.com/python/mypy/pull/19517
#19468https://github.com/python/mypy/issues/19468
#19473https://github.com/python/mypy/pull/19473
#19473https://github.com/python/mypy/pull/19473
https://mypy-play.net/?mypy=1.17.0&python=3.12&gist=e9ec514f49903022bd32a82ae1774abdhttps://mypy-play.net/?mypy=1.17.0&python=3.12&gist=e9ec514f49903022bd32a82ae1774abd
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19473
https://github.com/sterliakov
sterliakov https://github.com/sterliakov
https://github.com/python/mypy/pull/19473/files/246e461d638dfa84dc303facc88d3e2eff7465ae
Please reload this pagehttps://github.com/python/mypy/pull/19473
[match-case] class pattern narrowing with Union-argument different from equivalent isinstance call. https://github.com/python/mypy/issues/19468
Please reload this pagehttps://github.com/python/mypy/pull/19473
https://github.com/randolf-scholz
https://github.com/sterliakov
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.