René's URL Explorer Experiment


Title: Phase 2 of async/await by gvanrossum · Pull Request #1946 · python/mypy · GitHub

Open Graph Title: Phase 2 of async/await by gvanrossum · Pull Request #1946 · python/mypy

X Title: Phase 2 of async/await by gvanrossum · Pull Request #1946 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: This PR adds support for decorating either generators or async def functions with @types.coroutine or @asyncio.coroutine. This will fix #1453.

X Description: This PR adds support for decorating either generators or async def functions with @types.coroutine or @asyncio.coroutine. This will fix #1453.

Opengraph URL: https://github.com/python/mypy/pull/1946

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6a17f727-7331-aa7f-753a-ce84f8ad9de8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA42A:77A5A:2F0607C:3E559AB:6B002B64
html-safe-nonce035683656437c1964a7361033cb416c0a8c85efcf7901f71f74e70cf21140f67
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDJBOjc3QTVBOjJGMDYwN0M6M0U1NTlBQjo2QjAwMkI2NCIsInZpc2l0b3JfaWQiOiI2Mzc0NTM4NjgyMzkyNjUyNjQ0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac21b4fc74534cb64afd4483f70c39777083699911de16da26b80003ebaf7a22c5
hovercard-subject-tagpull_request:78965200
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/1946/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/30d3d45857cf9c42c355d60fc71f428b209e3267af9335f17fcdc0972e0912c9/python/mypy/pull/1946
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/30d3d45857cf9c42c355d60fc71f428b209e3267af9335f17fcdc0972e0912c9/python/mypy/pull/1946
og:image:altThis PR adds support for decorating either generators or async def functions with @types.coroutine or @asyncio.coroutine. This will fix #1453.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegvanrossum
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/1946#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F1946
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F1946
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/1946
Reloadhttps://github.com/python/mypy/pull/1946
Reloadhttps://github.com/python/mypy/pull/1946
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ddfisherhttps://github.com/ddfisher
masterhttps://github.com/python/mypy/tree/master
add-crawl2-rebornhttps://github.com/python/mypy/tree/add-crawl2-reborn
Conversationhttps://github.com/python/mypy/pull/1946
Commits23 (23)https://github.com/python/mypy/pull/1946/commits
Checkshttps://github.com/python/mypy/pull/1946/checks
Files changedhttps://github.com/python/mypy/pull/1946/files
Phase 2 of async/awaithttps://github.com/python/mypy/pull/1946#top
ddfisherhttps://github.com/ddfisher
masterhttps://github.com/python/mypy/tree/master
add-crawl2-rebornhttps://github.com/python/mypy/tree/add-crawl2-reborn
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Jul 27, 2016https://github.com/python/mypy/pull/1946#issue-167770118
#1453https://github.com/python/mypy/issues/1453
Please reload this pagehttps://github.com/python/mypy/pull/1946
Design for using async+await with asyncio #1886 https://github.com/python/mypy/issues/1886
Allow yielding result of function that returns None #1933 https://github.com/python/mypy/issues/1933
Support PEP 492 syntax #1453 https://github.com/python/mypy/issues/1453
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
force-pushedhttps://github.com/python/mypy/compare/520a431911518d8971b77e74aae79c50649d6cf9..d0f7a5ede648ed2b56835d250797bf28c1fa4db4
520a431https://github.com/python/mypy/commit/520a431911518d8971b77e74aae79c50649d6cf9
d0f7a5ehttps://github.com/python/mypy/commit/d0f7a5ede648ed2b56835d250797bf28c1fa4db4
Compare https://github.com/python/mypy/compare/520a431911518d8971b77e74aae79c50649d6cf9..d0f7a5ede648ed2b56835d250797bf28c1fa4db4
August 2, 2016 23:17https://github.com/python/mypy/pull/1946#event-743145021
ddfisherhttps://github.com/ddfisher
Aug 3, 2016 https://github.com/python/mypy/pull/1946#discussion-diff-73413023
View reviewed changes https://github.com/python/mypy/pull/1946/files/30e1a4a30966a2b5d0f7199e781757ba0eebc608#diff-fffcfb62b62fcdb8d18c8039f067f9c2f26003af5556d40d8c362020e4af3b12
test-data/unit/lib-stub/typing.pyhttps://github.com/python/mypy/pull/1946/files#diff-fffcfb62b62fcdb8d18c8039f067f9c2f26003af5556d40d8c362020e4af3b12
ddfisherhttps://github.com/ddfisher
Aug 3, 2016https://github.com/python/mypy/pull/1946#discussion_r73413023
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/1946
gvanrossumhttps://github.com/gvanrossum
Aug 3, 2016https://github.com/python/mypy/pull/1946#discussion_r73413260
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/1946
ddfisherhttps://github.com/ddfisher
Aug 3, 2016https://github.com/python/mypy/pull/1946#discussion_r73413830
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/1946
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
force-pushedhttps://github.com/python/mypy/compare/30e1a4a30966a2b5d0f7199e781757ba0eebc608..77f2ba23b3f670f5e557b637126660c5f2c939be
30e1a4ahttps://github.com/python/mypy/commit/30e1a4a30966a2b5d0f7199e781757ba0eebc608
77f2ba2https://github.com/python/mypy/commit/77f2ba23b3f670f5e557b637126660c5f2c939be
Compare https://github.com/python/mypy/compare/30e1a4a30966a2b5d0f7199e781757ba0eebc608..77f2ba23b3f670f5e557b637126660c5f2c939be
August 3, 2016 22:36https://github.com/python/mypy/pull/1946#event-744552573
ddfisherhttps://github.com/ddfisher
Aug 3, 2016 https://github.com/python/mypy/pull/1946#discussion-diff-73439441
View reviewed changes https://github.com/python/mypy/pull/1946/files/77f2ba23b3f670f5e557b637126660c5f2c939be#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
mypy/checker.pyhttps://github.com/python/mypy/pull/1946/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
ddfisherhttps://github.com/ddfisher
Aug 3, 2016https://github.com/python/mypy/pull/1946#discussion_r73439441
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/1946
August 3, 2016 16:28https://github.com/python/mypy/pull/1946#commits-pushed-407503a
Pristine copy of crawl.py, to be converted to async/await next.https://github.com/python/mypy/pull/1946/commits/407503ab63b983b1c7c9de82562b79fe6564a063
407503ahttps://github.com/python/mypy/pull/1946/commits/407503ab63b983b1c7c9de82562b79fe6564a063
Got basic support for PEP 492 in asyncio code.https://github.com/python/mypy/pull/1946/commits/04e6e839fd89a8c6c2abc96cf34c9d97db4adfaf
04e6e83https://github.com/python/mypy/pull/1946/commits/04e6e839fd89a8c6c2abc96cf34c9d97db4adfaf
ddfisherhttps://github.com/ddfisher
Aug 3, 2016 https://github.com/python/mypy/pull/1946#discussion-diff-73439914
View reviewed changes https://github.com/python/mypy/pull/1946/files/77f2ba23b3f670f5e557b637126660c5f2c939be#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
mypy/checker.pyhttps://github.com/python/mypy/pull/1946/files#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
ddfisherhttps://github.com/ddfisher
Aug 3, 2016https://github.com/python/mypy/pull/1946#discussion_r73439914
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/1946
gvanrossumhttps://github.com/gvanrossum
Aug 3, 2016https://github.com/python/mypy/pull/1946#discussion_r73441557
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/1946
August 3, 2016 16:32https://github.com/python/mypy/pull/1946#commits-pushed-2834f73
Rewrite the get_generator_*_type() functions (again).https://github.com/python/mypy/pull/1946/commits/2834f730af005df0d61aeb2ebc8ffe68a3b10f7a
2834f73https://github.com/python/mypy/pull/1946/commits/2834f730af005df0d61aeb2ebc8ffe68a3b10f7a
Whoops, AwaitableGenerator is Python 3 only.https://github.com/python/mypy/pull/1946/commits/31d0362e251852fd8a6500fd9f65ebc4af2d4677
31d0362https://github.com/python/mypy/pull/1946/commits/31d0362e251852fd8a6500fd9f65ebc4af2d4677
Run file tests with --fast-parserhttps://github.com/python/mypy/pull/1946/commits/1340034facfbd3de9076bd2daf1de99102a2c370
1340034https://github.com/python/mypy/pull/1946/commits/1340034facfbd3de9076bd2daf1de99102a2c370
Rename ts (after send) to tc (after reCeive).https://github.com/python/mypy/pull/1946/commits/9f35170f25fe38b4cf736a8fe06731a879f19ef1
9f35170https://github.com/python/mypy/pull/1946/commits/9f35170f25fe38b4cf736a8fe06731a879f19ef1
Add unit tests forhttps://github.com/python/mypy/pull/1946/commits/4aa25410a238ace4eab94ca74cfeea666a197f94
@coroutinehttps://github.com/coroutine
.https://github.com/python/mypy/pull/1946/commits/4aa25410a238ace4eab94ca74cfeea666a197f94
4aa2541https://github.com/python/mypy/pull/1946/commits/4aa25410a238ace4eab94ca74cfeea666a197f94
Switch to 3-arg AwaitableGenerator.https://github.com/python/mypy/pull/1946/commits/662f38d58f66e49c46566574799acf021fe9e240
662f38dhttps://github.com/python/mypy/pull/1946/commits/662f38d58f66e49c46566574799acf021fe9e240
Add minimal test-data/unit/lib-stub/types.pyi, for coroutine.https://github.com/python/mypy/pull/1946/commits/8be06db5a76e5af36ce10b1c702972a873d59b0a
8be06dbhttps://github.com/python/mypy/pull/1946/commits/8be06db5a76e5af36ce10b1c702972a873d59b0a
Fixup comments.https://github.com/python/mypy/pull/1946/commits/637eaf41cad01e528c9127a32f222660349c4d92
637eaf4https://github.com/python/mypy/pull/1946/commits/637eaf41cad01e528c9127a32f222660349c4d92
Update lib-stub/typing.py.https://github.com/python/mypy/pull/1946/commits/a97872d16a6deb2085b825c1ca31a63d9409762d
a97872dhttps://github.com/python/mypy/pull/1946/commits/a97872d16a6deb2085b825c1ca31a63d9409762d
Reorganize the test matrix. Check in the test program.https://github.com/python/mypy/pull/1946/commits/319d4035ab67c6cdd5b49a40782e40ea611800a1
319d403https://github.com/python/mypy/pull/1946/commits/319d4035ab67c6cdd5b49a40782e40ea611800a1
Complete the compatibility matrix.https://github.com/python/mypy/pull/1946/commits/17bed84be703f504b2469bcd278ed33440ec2202
17bed84https://github.com/python/mypy/pull/1946/commits/17bed84be703f504b2469bcd278ed33440ec2202
Make is_async_def() type-safe.https://github.com/python/mypy/pull/1946/commits/712d1a4f9b08acc674852659b05306e09c371757
712d1a4https://github.com/python/mypy/pull/1946/commits/712d1a4f9b08acc674852659b05306e09c371757
Fix options for testFullCoroutineMatrix.https://github.com/python/mypy/pull/1946/commits/dcf011b7f82e907651c9aad8d413aff3272c8056
dcf011bhttps://github.com/python/mypy/pull/1946/commits/dcf011b7f82e907651c9aad8d413aff3272c8056
Sync typeshedhttps://github.com/python/mypy/pull/1946/commits/6ffe63b3d06ee038a6037657d2ad52c9db1482f4
6ffe63bhttps://github.com/python/mypy/pull/1946/commits/6ffe63b3d06ee038a6037657d2ad52c9db1482f4
Wrap ProactorEventLoop import in platform check.https://github.com/python/mypy/pull/1946/commits/505206593a3e77f31b3a13c9a177266e46841d59
5052065https://github.com/python/mypy/pull/1946/commits/505206593a3e77f31b3a13c9a177266e46841d59
August 3, 2016 16:32https://github.com/python/mypy/pull/1946#commits-pushed-fc2fd88
Remove no-op @asyncio.coroutine decorators.https://github.com/python/mypy/pull/1946/commits/fc2fd88626b0656b4193cc0b13661c6022d74de7
fc2fd88https://github.com/python/mypy/pull/1946/commits/fc2fd88626b0656b4193cc0b13661c6022d74de7
Reduce output volume in -q mode.https://github.com/python/mypy/pull/1946/commits/a9e591165547220d98b34fa9e5ab1da0a4e71654
a9e5911https://github.com/python/mypy/pull/1946/commits/a9e591165547220d98b34fa9e5ab1da0a4e71654
Always define --iocp.https://github.com/python/mypy/pull/1946/commits/c725a299ea2a27e65aab0f302de68f1c649734e5
c725a29https://github.com/python/mypy/pull/1946/commits/c725a299ea2a27e65aab0f302de68f1c649734e5
Let check_awaitable_expr() compute iter_type in visit_yield_from_expr().https://github.com/python/mypy/pull/1946/commits/49e5a6fd7797064cc72037ea15f0ec9e32997613
49e5a6fhttps://github.com/python/mypy/pull/1946/commits/49e5a6fd7797064cc72037ea15f0ec9e32997613
Clarify what is going on in is_async_def().https://github.com/python/mypy/pull/1946/commits/637d381d7c32de115f072c30297c047f6348a02a
637d381https://github.com/python/mypy/pull/1946/commits/637d381d7c32de115f072c30297c047f6348a02a
Respond to code review (simplify AwaitableGenerator test, restore com…https://github.com/python/mypy/pull/1946/commits/839dc7dc01bd017abf97ce4aa8a716ad2a369523
839dc7dhttps://github.com/python/mypy/pull/1946/commits/839dc7dc01bd017abf97ce4aa8a716ad2a369523
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
force-pushedhttps://github.com/python/mypy/compare/77f2ba23b3f670f5e557b637126660c5f2c939be..839dc7dc01bd017abf97ce4aa8a716ad2a369523
77f2ba2https://github.com/python/mypy/commit/77f2ba23b3f670f5e557b637126660c5f2c939be
839dc7dhttps://github.com/python/mypy/commit/839dc7dc01bd017abf97ce4aa8a716ad2a369523
Compare https://github.com/python/mypy/compare/77f2ba23b3f670f5e557b637126660c5f2c939be..839dc7dc01bd017abf97ce4aa8a716ad2a369523
August 3, 2016 23:44https://github.com/python/mypy/pull/1946#event-744606889
https://github.com/ddfisher
ddfisherhttps://github.com/ddfisher
340d34ehttps://github.com/python/mypy/commit/340d34eb02c2224913e9de35547e11aae36d6e19
Aug 3, 2016https://github.com/python/mypy/pull/1946#event-744615308
https://github.com/ddfisher
ddfisherhttps://github.com/ddfisher
August 3, 2016 23:57https://github.com/python/mypy/pull/1946#event-744615344
https://github.com/ddfisher
ddfisherhttps://github.com/ddfisher
Aug 3, 2016https://github.com/python/mypy/pull/1946#issuecomment-237411431
Please reload this pagehttps://github.com/python/mypy/pull/1946
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F1946
Please reload this pagehttps://github.com/python/mypy/pull/1946
Support PEP 492 syntax https://github.com/python/mypy/issues/1453
Please reload this pagehttps://github.com/python/mypy/pull/1946
https://github.com/gvanrossum
https://github.com/ddfisher
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.