René's URL Explorer Experiment


Title: Check property decorators stricter by sterliakov · Pull Request #19313 · python/mypy · GitHub

Open Graph Title: Check property decorators stricter by sterliakov · Pull Request #19313 · python/mypy

X Title: Check property decorators stricter by sterliakov · Pull Request #19313 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #19312. Fixes #18327. Only accept @current_prop_name.{setter,deleter} as property-related decorators.

X Description: Fixes #19312. Fixes #18327. Only accept @current_prop_name.{setter,deleter} as property-related decorators.

Opengraph URL: https://github.com/python/mypy/pull/19313

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d285bc5a-6dee-d466-f05b-adc52175f963
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA422:22E601:CC10FA:111CD3A:6B005120
html-safe-nonce969f76b39b6ae52ab6bf85139b95c63e924fe27807d5836ecadfd98bfe014cee
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDIyOjIyRTYwMTpDQzEwRkE6MTExQ0QzQTo2QjAwNTEyMCIsInZpc2l0b3JfaWQiOiI2Njg5NTQwMTEzNjg2MzUyMTYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1ebbcb803b5c2dec34a7dc167810d92baa53d8adf3390907cb413c489bcbf557
hovercard-subject-tagpull_request:2602097788
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/19313/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e971f3e71883052bd9558d80cb4e246815ea579b30737970335d449016cc427e/python/mypy/pull/19313
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e971f3e71883052bd9558d80cb4e246815ea579b30737970335d449016cc427e/python/mypy/pull/19313
og:image:altFixes #19312. Fixes #18327. Only accept @current_prop_name.{setter,deleter} as property-related decorators.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesterliakov
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/19313#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19313
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19313
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/19313
Reloadhttps://github.com/python/mypy/pull/19313
Reloadhttps://github.com/python/mypy/pull/19313
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
sterliakov:bugfix/gh-19312-setter-of-nothinghttps://github.com/sterliakov/mypy/tree/bugfix/gh-19312-setter-of-nothing
Conversationhttps://github.com/python/mypy/pull/19313
Commits7 (7)https://github.com/python/mypy/pull/19313/commits
Checkshttps://github.com/python/mypy/pull/19313/checks
Files changedhttps://github.com/python/mypy/pull/19313/files
Check property decorators stricterhttps://github.com/python/mypy/pull/19313#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
sterliakov:bugfix/gh-19312-setter-of-nothinghttps://github.com/sterliakov/mypy/tree/bugfix/gh-19312-setter-of-nothing
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
Jun 18, 2025https://github.com/python/mypy/pull/19313#issue-3157265631
Please reload this pagehttps://github.com/python/mypy/pull/19313
#19312https://github.com/python/mypy/issues/19312
#18327https://github.com/python/mypy/issues/18327
Please reload this pagehttps://github.com/python/mypy/pull/19313
sterliakovhttps://github.com/sterliakov
June 18, 2025 17:10https://github.com/python/mypy/pull/19313#commits-pushed-b6411cf
https://github.com/sterliakov
Check property setter/deleter decorators stricterhttps://github.com/python/mypy/pull/19313/commits/b6411cf8f00880360b2cf73e9f1ed673adb46c18
b6411cfhttps://github.com/python/mypy/pull/19313/commits/b6411cf8f00880360b2cf73e9f1ed673adb46c18
https://github.com/sterliakov
Fix selfcheckhttps://github.com/python/mypy/pull/19313/commits/29a47f1550d3c167e2c0dcba5fa80466aff086f1
29a47f1https://github.com/python/mypy/pull/19313/commits/29a47f1550d3c167e2c0dcba5fa80466aff086f1
https://github.com/sterliakov
Update one more testhttps://github.com/python/mypy/pull/19313/commits/e0092bfd23d4e088412757e2a98f06c83b55d244
e0092bfhttps://github.com/python/mypy/pull/19313/commits/e0092bfd23d4e088412757e2a98f06c83b55d244
https://github.com/brianschubert
brianschuberthttps://github.com/brianschubert
Jun 18, 2025 https://github.com/python/mypy/pull/19313#pullrequestreview-2939921919
View reviewed changes https://github.com/python/mypy/pull/19313/files/e0092bfd23d4e088412757e2a98f06c83b55d244
mypy/semanal.pyhttps://github.com/python/mypy/pull/19313/files/e0092bfd23d4e088412757e2a98f06c83b55d244#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
brianschuberthttps://github.com/brianschubert
Jun 18, 2025https://github.com/python/mypy/pull/19313#discussion_r2155028852
Please reload this pagehttps://github.com/python/mypy/pull/19313
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19313
sterliakovhttps://github.com/sterliakov
Jun 18, 2025https://github.com/python/mypy/pull/19313#discussion_r2155567051
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19313
sterliakovhttps://github.com/sterliakov
Jun 21, 2025https://github.com/python/mypy/pull/19313#discussion_r2160172088
Please reload this pagehttps://github.com/python/mypy/pull/19313
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
this github searchhttps://github.com/search?q=lang%3Apython+%2F%5E%5Cs%2B%40%5Cw%2B%5C.getter%2F&type=code&p=1
microsoft/pyright#10633https://github.com/microsoft/pyright/issues/10633
Please reload this pagehttps://github.com/python/mypy/pull/19313
sterliakovhttps://github.com/sterliakov
Jun 22, 2025https://github.com/python/mypy/pull/19313#discussion_r2160374523
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19313
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19313
sterliakovhttps://github.com/sterliakov
June 22, 2025 00:25https://github.com/python/mypy/pull/19313#commits-pushed-25ea889
https://github.com/sterliakov
Document and test .getter rejectionhttps://github.com/python/mypy/pull/19313/commits/25ea88911c79acfe441150ee5851a5ac3b7c41c1
25ea889https://github.com/python/mypy/pull/19313/commits/25ea88911c79acfe441150ee5851a5ac3b7c41c1
https://github.com/sterliakov
Merge remote-tracking branch 'upstream/master' into bugfix/https://github.com/python/mypy/pull/19313/commits/2f229933efae5df1316b23d77c564f9368350f37
pythongh-1…https://github.com/python/mypy/issues/19312
2f22993https://github.com/python/mypy/pull/19313/commits/2f229933efae5df1316b23d77c564f9368350f37
…9312https://github.com/python/mypy/issues/19312
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19313
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
Jun 22, 2025 https://github.com/python/mypy/pull/19313#ref-issue-3165479810
@some_property.getter is accepted and silently ignored microsoft/pyright#10633 https://github.com/microsoft/pyright/issues/10633
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
brianschuberthttps://github.com/brianschubert
June 22, 2025 15:01https://github.com/python/mypy/pull/19313#event-18261619729
https://github.com/brianschubert
brianschuberthttps://github.com/brianschubert
Jun 22, 2025 https://github.com/python/mypy/pull/19313#pullrequestreview-2948229161
View reviewed changes https://github.com/python/mypy/pull/19313/files/2f229933efae5df1316b23d77c564f9368350f37
brianschuberthttps://github.com/brianschubert
https://github.com/python/mypy/pull/19313#pullrequestreview-2948229161
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19313
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/19313/files/2f229933efae5df1316b23d77c564f9368350f37#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
Please reload this pagehttps://github.com/python/mypy/pull/19313
mypy/semanal.pyhttps://github.com/python/mypy/pull/19313/files/2f229933efae5df1316b23d77c564f9368350f37#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
Please reload this pagehttps://github.com/python/mypy/pull/19313
mypy/semanal.pyhttps://github.com/python/mypy/pull/19313/files/2f229933efae5df1316b23d77c564f9368350f37#diff-f782aad4853edceb67a88efe43d2869579d075a77b8e8dd2add91e818a9fa164
brianschuberthttps://github.com/brianschubert
Jun 22, 2025https://github.com/python/mypy/pull/19313#discussion_r2160387980
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19313
sterliakovhttps://github.com/sterliakov
Jun 22, 2025https://github.com/python/mypy/pull/19313#discussion_r2160390449
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19313
https://github.com/sterliakov
Address review comments: use better context, quote identifiers and ad…https://github.com/python/mypy/pull/19313/commits/ee52e56b635b5b57fc86dcc3426deba525126c45
ee52e56https://github.com/python/mypy/pull/19313/commits/ee52e56b635b5b57fc86dcc3426deba525126c45
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19313
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
ilevkivskyihttps://github.com/ilevkivskyi
June 27, 2025 15:34https://github.com/python/mypy/pull/19313#event-18360055186
https://github.com/sterliakov
Merge branch 'master' into bugfix/https://github.com/python/mypy/pull/19313/commits/7bf390bef0f231db7c6f519d6d142279f201be10
pythongh-19312https://github.com/python/mypy/issues/19312
-setter-of-nothinghttps://github.com/python/mypy/pull/19313/commits/7bf390bef0f231db7c6f519d6d142279f201be10
7bf390bhttps://github.com/python/mypy/pull/19313/commits/7bf390bef0f231db7c6f519d6d142279f201be10
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 4, 2025https://github.com/python/mypy/pull/19313#issuecomment-3034225785
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/19313
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Jul 7, 2025 https://github.com/python/mypy/pull/19313#pullrequestreview-2993623924
View reviewed changes https://github.com/python/mypy/pull/19313/files/7bf390bef0f231db7c6f519d6d142279f201be10
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/19313#pullrequestreview-2993623924
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19313
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
0b7afdahttps://github.com/python/mypy/commit/0b7afdaf281f23fd2982b79d736fa2ab054bc76a
Jul 7, 2025https://github.com/python/mypy/pull/19313#event-18504308885
https://github.com/tungol
tungolhttps://github.com/tungol
Jul 8, 2025 https://github.com/python/mypy/pull/19313#ref-issue-2754604152
Mypy doesn't object to cached_property methods that don't exist #18327 https://github.com/python/mypy/issues/18327
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19313
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/19313/files/7bf390bef0f231db7c6f519d6d142279f201be10
https://github.com/brianschubert
brianschubert https://github.com/brianschubert
https://github.com/python/mypy/pull/19313/files/2f229933efae5df1316b23d77c564f9368350f37
Please reload this pagehttps://github.com/python/mypy/pull/19313
Mypy doesn't object to cached_property methods that don't exist https://github.com/python/mypy/issues/18327
False negative on setter field of undefined variable https://github.com/python/mypy/issues/19312
Please reload this pagehttps://github.com/python/mypy/pull/19313
https://github.com/sterliakov
https://github.com/ilevkivskyi
https://github.com/brianschubert
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.