René's URL Explorer Experiment


Title: Re-widen custom properties after narrowing by ilevkivskyi · Pull Request #19296 · python/mypy · GitHub

Open Graph Title: Re-widen custom properties after narrowing by ilevkivskyi · Pull Request #19296 · python/mypy

X Title: Re-widen custom properties after narrowing by ilevkivskyi · Pull Request #19296 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #10399 This is another smaller cleanup for #7724. The current logic as documented is IMO correct, for attributes (either properties or custom descriptors) with setter type different from get...

X Description: Fixes #10399 This is another smaller cleanup for #7724. The current logic as documented is IMO correct, for attributes (either properties or custom descriptors) with setter type different from get...

Opengraph URL: https://github.com/python/mypy/pull/19296

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7b2edb98-7138-3793-4940-34730bb8330b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD190:1334EF:BAD8D4:F3D053:6AFFF225
html-safe-noncefa9a4e9f9b468ef4c6722c16ed101a9cedd01a46a4ba5d90d39bb6296186882f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTkwOjEzMzRFRjpCQUQ4RDQ6RjNEMDUzOjZBRkZGMjI1IiwidmlzaXRvcl9pZCI6IjgxNTgwNjI4MTU5OTk5NDczMDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4c68efe72f2bf82c9c80d4bd0ae8e8a2ececf8db25ed01a3526cab29e63e208c
hovercard-subject-tagpull_request:2592451565
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/19296/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ce3d96451e8d0b7e54a5e6d0c1a621605365749eecf6150c978ea3ddf12d3cee/python/mypy/pull/19296
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ce3d96451e8d0b7e54a5e6d0c1a621605365749eecf6150c978ea3ddf12d3cee/python/mypy/pull/19296
og:image:altFixes #10399 This is another smaller cleanup for #7724. The current logic as documented is IMO correct, for attributes (either properties or custom descriptors) with setter type different from get...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/19296#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19296
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19296
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/19296
Reloadhttps://github.com/python/mypy/pull/19296
Reloadhttps://github.com/python/mypy/pull/19296
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:correct-setter-narrowhttps://github.com/ilevkivskyi/mypy/tree/correct-setter-narrow
Conversationhttps://github.com/python/mypy/pull/19296
Commits2 (2)https://github.com/python/mypy/pull/19296/commits
Checkshttps://github.com/python/mypy/pull/19296/checks
Files changedhttps://github.com/python/mypy/pull/19296/files
Re-widen custom properties after narrowinghttps://github.com/python/mypy/pull/19296#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:correct-setter-narrowhttps://github.com/ilevkivskyi/mypy/tree/correct-setter-narrow
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Jun 14, 2025https://github.com/python/mypy/pull/19296#issue-3146018537
#10399https://github.com/python/mypy/issues/10399
#7724https://github.com/python/mypy/issues/7724
Please reload this pagehttps://github.com/python/mypy/pull/19296
https://github.com/ilevkivskyi
Re-widen custom properties after narrowinghttps://github.com/python/mypy/pull/19296/commits/5f7e2c6a854e9c0d38ba4664239bb701a2cfe0af
5f7e2c6https://github.com/python/mypy/pull/19296/commits/5f7e2c6a854e9c0d38ba4664239bb701a2cfe0af
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
JukkaLhttps://github.com/JukkaL
hauntsaninjahttps://github.com/hauntsaninja
June 14, 2025 11:18https://github.com/python/mypy/pull/19296#event-18148510648
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19296
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
Jun 15, 2025 https://github.com/python/mypy/pull/19296#pullrequestreview-2930358566
View reviewed changes https://github.com/python/mypy/pull/19296/files/5f7e2c6a854e9c0d38ba4664239bb701a2cfe0af
mypy/checker.pyhttps://github.com/python/mypy/pull/19296/files/5f7e2c6a854e9c0d38ba4664239bb701a2cfe0af#diff-f96a2d6138bc6cdf2a07c4d37f6071cc25c1631afc107e277a28d5b59fc0ef04
Please reload this pagehttps://github.com/python/mypy/pull/19296
test-data/unit/check-narrowing.testhttps://github.com/python/mypy/pull/19296/files/5f7e2c6a854e9c0d38ba4664239bb701a2cfe0af#diff-0413401ad6a91bc5c66579455009ba606ee0ddfb0a78278c9e53618c83b53ed5
sterliakovhttps://github.com/sterliakov
Jun 15, 2025https://github.com/python/mypy/pull/19296#discussion_r2148851705
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19296
JukkaLhttps://github.com/JukkaL
Jun 16, 2025https://github.com/python/mypy/pull/19296#discussion_r2150340345
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19296
sterliakovhttps://github.com/sterliakov
Jun 18, 2025https://github.com/python/mypy/pull/19296#discussion_r2154451373
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@JukkaLhttps://github.com/JukkaL
Please reload this pagehttps://github.com/python/mypy/pull/19296
sterliakovhttps://github.com/sterliakov
Jun 18, 2025https://github.com/python/mypy/pull/19296#discussion_r2154654586
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19296
ilevkivskyihttps://github.com/ilevkivskyi
Jun 18, 2025https://github.com/python/mypy/pull/19296#discussion_r2155389145
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@sterliakovhttps://github.com/sterliakov
Please reload this pagehttps://github.com/python/mypy/pull/19296
sterliakovhttps://github.com/sterliakov
Jun 18, 2025https://github.com/python/mypy/pull/19296#discussion_r2155563491
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19296
ilevkivskyihttps://github.com/ilevkivskyi
Jun 18, 2025https://github.com/python/mypy/pull/19296#discussion_r2155709076
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19296
sterliakovhttps://github.com/sterliakov
Jun 19, 2025https://github.com/python/mypy/pull/19296#discussion_r2155799278
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19296
ilevkivskyihttps://github.com/ilevkivskyi
Jun 19, 2025https://github.com/python/mypy/pull/19296#discussion_r2155830947
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19296
https://github.com/ilevkivskyi
https://github.com/sterliakov
Fix typohttps://github.com/python/mypy/pull/19296/commits/e9c58d83724adec1ead7303f1af4d4f9220d3a97
e9c58d8https://github.com/python/mypy/pull/19296/commits/e9c58d83724adec1ead7303f1af4d4f9220d3a97
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 18, 2025https://github.com/python/mypy/pull/19296#issuecomment-2985613792
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/19296
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jun 19, 2025 https://github.com/python/mypy/pull/19296#pullrequestreview-2943815026
View reviewed changes https://github.com/python/mypy/pull/19296/files/e9c58d83724adec1ead7303f1af4d4f9220d3a97
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
96fcd59https://github.com/python/mypy/commit/96fcd59585d1460440967f5dd6bdc82d43703187
Jun 19, 2025https://github.com/python/mypy/pull/19296#event-18236528246
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
June 19, 2025 21:57https://github.com/python/mypy/pull/19296#event-18236529080
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19296
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/python/mypy/pull/19296/files/e9c58d83724adec1ead7303f1af4d4f9220d3a97
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/sterliakov
sterliakov https://github.com/sterliakov
https://github.com/python/mypy/pull/19296/files/5f7e2c6a854e9c0d38ba4664239bb701a2cfe0af
Please reload this pagehttps://github.com/python/mypy/pull/19296
Type narrowing behavior for data descriptor assignment is incorrect in some cases https://github.com/python/mypy/issues/10399
Please reload this pagehttps://github.com/python/mypy/pull/19296
https://github.com/ilevkivskyi
https://github.com/JukkaL
https://github.com/hauntsaninja
https://github.com/sterliakov
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.