René's URL Explorer Experiment


Title: Improve the handling of "iteration dependent" errors and notes in finally clauses. by tyralla · Pull Request #19270 · python/mypy · GitHub

Open Graph Title: Improve the handling of "iteration dependent" errors and notes in finally clauses. by tyralla · Pull Request #19270 · python/mypy

X Title: Improve the handling of "iteration dependent" errors and notes in finally clauses. by tyralla · Pull Request #19270 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #19269 This PR refactors the logic implemented in #19118 (which only targeted repeatedly checked loops) and applies it to repeatedly checked finally clauses. I moved nearly all relevant code ...

X Description: Fixes #19269 This PR refactors the logic implemented in #19118 (which only targeted repeatedly checked loops) and applies it to repeatedly checked finally clauses. I moved nearly all relevant code ...

Opengraph URL: https://github.com/python/mypy/pull/19270

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:00c6b1ef-6ad3-230a-cfe2-747a849016da
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC9AA:171905:3A89A6:4DB7BE:6A5B2808
html-safe-noncec945ed2ddd39d61aa37e0fa60c08d5abe5ed0b6b24b8be41b1aee62040ac0d2a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUFBOjE3MTkwNTozQTg5QTY6NERCN0JFOjZBNUIyODA4IiwidmlzaXRvcl9pZCI6IjMzMDM4MTEyNjUzMjAzOTY4MDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca9ac3a565b573e18923b4c57c7155efc89c0af6cca190386684ed096f61e8688
hovercard-subject-tagpull_request:2581781814
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/19270/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/97c95cf986937e93353f893aa0896d197029f0c902d78d29135c78ef3dfcdba2/python/mypy/pull/19270
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/97c95cf986937e93353f893aa0896d197029f0c902d78d29135c78ef3dfcdba2/python/mypy/pull/19270
og:image:altFixes #19269 This PR refactors the logic implemented in #19118 (which only targeted repeatedly checked loops) and applies it to repeatedly checked finally clauses. I moved nearly all relevant code ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametyralla
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/mypy/pull/19270#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19270
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19270
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/19270
Reloadhttps://github.com/python/mypy/pull/19270
Reloadhttps://github.com/python/mypy/pull/19270
Please reload this pagehttps://github.com/python/mypy/pull/19270
python https://github.com/python
mypyhttps://github.com/python/mypy
Please reload this pagehttps://github.com/python/mypy/pull/19270
Notifications https://github.com/login?return_to=%2Fpython%2Fmypy
Fork 3.2k https://github.com/login?return_to=%2Fpython%2Fmypy
Star 20.5k https://github.com/login?return_to=%2Fpython%2Fmypy
Code https://github.com/python/mypy
Issues 2.7k https://github.com/python/mypy/issues
Pull requests 467 https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality 0 https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
Code https://github.com/python/mypy
Issues https://github.com/python/mypy/issues
Pull requests https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
tyralla:fix/narrowing_unreachable_try_finallyhttps://github.com/tyralla/mypy/tree/fix/narrowing_unreachable_try_finally
Conversationhttps://github.com/python/mypy/pull/19270
Commits7 (7)https://github.com/python/mypy/pull/19270/commits
Checkshttps://github.com/python/mypy/pull/19270/checks
Files changedhttps://github.com/python/mypy/pull/19270/files
Improve the handling of "iteration dependent" errors and notes in finally clauses.https://github.com/python/mypy/pull/19270#top
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
tyralla:fix/narrowing_unreachable_try_finallyhttps://github.com/tyralla/mypy/tree/fix/narrowing_unreachable_try_finally
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Jun 10, 2025https://github.com/python/mypy/pull/19270#issue-3134056596
#19269https://github.com/python/mypy/issues/19269
#19118https://github.com/python/mypy/pull/19118
Please reload this pagehttps://github.com/python/mypy/pull/19270
tyrallahttps://github.com/tyralla
June 10, 2025 07:09https://github.com/python/mypy/pull/19270#commits-pushed-71a3b28
https://github.com/tyralla
Improve the handling of "iteration dependend" errors and notes in fin…https://github.com/python/mypy/pull/19270/commits/71a3b280aa7d0f4d44ec642ddd29048b50c85c75
71a3b28https://github.com/python/mypy/pull/19270/commits/71a3b280aa7d0f4d44ec642ddd29048b50c85c75
https://github.com/marketplace/pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hookshttps://github.com/python/mypy/pull/19270/commits/fc1c79075d1957d869b620fe3b3d9d7df99e9148
fc1c790https://github.com/python/mypy/pull/19270/commits/fc1c79075d1957d869b620fe3b3d9d7df99e9148
https://pre-commit.cihttps://pre-commit.ci
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Jun 10, 2025https://github.com/python/mypy/pull/19270#issuecomment-2959778461
#19256https://github.com/python/mypy/issues/19256
Please reload this pagehttps://github.com/python/mypy/pull/19270
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Jun 10, 2025https://github.com/python/mypy/pull/19270#event-18078503467
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19270
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Jun 10, 2025https://github.com/python/mypy/pull/19270#issuecomment-2959958351
@A5rockshttps://github.com/A5rocks
@JukkaLhttps://github.com/JukkaL
#19118https://github.com/python/mypy/pull/19118
Please reload this pagehttps://github.com/python/mypy/pull/19270
https://github.com/tyralla
tyrallahttps://github.com/tyralla
A5rockshttps://github.com/A5rocks
JukkaLhttps://github.com/JukkaL
June 10, 2025 16:41https://github.com/python/mypy/pull/19270#event-18079296862
tyrallahttps://github.com/tyralla
June 10, 2025 18:52https://github.com/python/mypy/pull/19270#commits-pushed-84de3bb
https://github.com/tyralla
Merge branch 'master' into fix/narrowing_unreachable_try_finallyhttps://github.com/python/mypy/pull/19270/commits/84de3bba381b2721869e59b04ab6ae02a12f7ad2
84de3bbhttps://github.com/python/mypy/pull/19270/commits/84de3bba381b2721869e59b04ab6ae02a12f7ad2
https://github.com/tyralla
fix typohttps://github.com/python/mypy/pull/19270/commits/2ddab269cd9dd7a6c447c956fd90d781d79755e7
2ddab26https://github.com/python/mypy/pull/19270/commits/2ddab269cd9dd7a6c447c956fd90d781d79755e7
https://github.com/marketplace/pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hookshttps://github.com/python/mypy/pull/19270/commits/0b6f6b96eba700315e6aa734787ddd1538c382ca
0b6f6b9https://github.com/python/mypy/pull/19270/commits/0b6f6b96eba700315e6aa734787ddd1538c382ca
https://pre-commit.cihttps://pre-commit.ci
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19270
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Jun 12, 2025 https://github.com/python/mypy/pull/19270#ref-issue-3128687430
Unreachability should work for constrained type vars #19256 https://github.com/python/mypy/issues/19256
https://github.com/tyralla
Merge branch 'master' into fix/narrowing_unreachable_try_finallyhttps://github.com/python/mypy/pull/19270/commits/435b1f533338304c2e58c1581719dc43b6ae06bc
435b1f5https://github.com/python/mypy/pull/19270/commits/435b1f533338304c2e58c1581719dc43b6ae06bc
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19270
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jun 18, 2025 https://github.com/python/mypy/pull/19270#ref-issue-3150899916
1.17 Release Planning #19306 https://github.com/python/mypy/issues/19306
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Jun 19, 2025 https://github.com/python/mypy/pull/19270#pullrequestreview-2943478702
View reviewed changes https://github.com/python/mypy/pull/19270/files/435b1f533338304c2e58c1581719dc43b6ae06bc
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/19270#pullrequestreview-2943478702
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19270
mypy/errors.pyhttps://github.com/python/mypy/pull/19270/files/435b1f533338304c2e58c1581719dc43b6ae06bc#diff-eef80074ed3627574b7a784f0e2a4e9d4670e7c2156f559ada501980ea5d1ca2
JukkaLhttps://github.com/JukkaL
Jun 19, 2025https://github.com/python/mypy/pull/19270#discussion_r2157291732
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19270
tyrallahttps://github.com/tyralla
Jun 20, 2025https://github.com/python/mypy/pull/19270#discussion_r2158194592
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19270
mypy/errors.pyhttps://github.com/python/mypy/pull/19270/files/435b1f533338304c2e58c1581719dc43b6ae06bc#diff-eef80074ed3627574b7a784f0e2a4e9d4670e7c2156f559ada501980ea5d1ca2
JukkaLhttps://github.com/JukkaL
Jun 19, 2025https://github.com/python/mypy/pull/19270#discussion_r2157301238
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19270
mypy/errors.pyhttps://github.com/python/mypy/pull/19270/files/435b1f533338304c2e58c1581719dc43b6ae06bc#diff-eef80074ed3627574b7a784f0e2a4e9d4670e7c2156f559ada501980ea5d1ca2
JukkaLhttps://github.com/JukkaL
Jun 19, 2025https://github.com/python/mypy/pull/19270#discussion_r2157308973
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19270
https://github.com/tyralla
Support the "or syntax" for revealed unions.https://github.com/python/mypy/pull/19270/commits/af8b672ab2a89630be56c1494bea0877cad7c507
af8b672https://github.com/python/mypy/pull/19270/commits/af8b672ab2a89630be56c1494bea0877cad7c507
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Jun 20, 2025https://github.com/python/mypy/pull/19270#issuecomment-2990035273
Please reload this pagehttps://github.com/python/mypy/pull/19270
@JukkaLhttps://github.com/JukkaL
Please reload this pagehttps://github.com/python/mypy/pull/19270
https://github.com/tyralla
tyrallahttps://github.com/tyralla
JukkaLhttps://github.com/JukkaL
June 20, 2025 07:02https://github.com/python/mypy/pull/19270#event-18240717423
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 20, 2025https://github.com/python/mypy/pull/19270#issuecomment-2990054920
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/19270
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Jun 20, 2025 https://github.com/python/mypy/pull/19270#pullrequestreview-2946667492
View reviewed changes https://github.com/python/mypy/pull/19270/files/af8b672ab2a89630be56c1494bea0877cad7c507
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
4322d4fhttps://github.com/python/mypy/commit/4322d4f443ef7568b1c0f4fec8df9e12e90fd8b9
Jun 20, 2025https://github.com/python/mypy/pull/19270#event-18250149064
Please reload this pagehttps://github.com/python/mypy/pull/19270
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Jun 21, 2025 https://github.com/python/mypy/pull/19270#ref-pullrequest-3165455942
Combine the revealed types of multiple iteration steps in a more robust manner. #19324 https://github.com/python/mypy/pull/19324
JukkaLhttps://github.com/JukkaL
Jul 7, 2025 https://github.com/python/mypy/pull/19270#ref-commit-1fde143
https://github.com/tyralla
Combine the revealed types of multiple iteration steps in a more robu…https://github.com/python/mypy/commit/1fde1438f6c47963ecd6e10a8c410ac41ba05103
1fde143https://github.com/python/mypy/commit/1fde1438f6c47963ecd6e10a8c410ac41ba05103
#19324https://github.com/python/mypy/pull/19324
#19118https://github.com/python/mypy/pull/19118
#19270https://github.com/python/mypy/pull/19270
@JukkaLhttps://github.com/JukkaL
esarphttps://github.com/esarp
Jul 10, 2025 https://github.com/python/mypy/pull/19270#ref-commit-ab4fd57
https://github.com/tyralla
https://github.com/esarp
Improve the handling of "iteration dependent" errors and notes in fin…https://github.com/python/mypy/commit/ab4fd57d45b7f81cf281b17b7d3697ac9f79bc15
ab4fd57https://github.com/python/mypy/commit/ab4fd57d45b7f81cf281b17b7d3697ac9f79bc15
#19270https://github.com/python/mypy/pull/19270
#19269https://github.com/python/mypy/issues/19269
#19118https://github.com/python/mypy/pull/19118
esarphttps://github.com/esarp
Jul 10, 2025 https://github.com/python/mypy/pull/19270#ref-commit-a182dec
https://github.com/tyralla
https://github.com/esarp
Combine the revealed types of multiple iteration steps in a more robu…https://github.com/python/mypy/commit/a182dec997b418b925fe0c28575c50debba0bb3a
a182dechttps://github.com/python/mypy/commit/a182dec997b418b925fe0c28575c50debba0bb3a
#19324https://github.com/python/mypy/pull/19324
#19118https://github.com/python/mypy/pull/19118
#19270https://github.com/python/mypy/pull/19270
@JukkaLhttps://github.com/JukkaL
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Jul 20, 2025 https://github.com/python/mypy/pull/19270#ref-issue-1301083227
False positive statement is unreachable in try-finally related to KeyboardInterrupt #13104 https://github.com/python/mypy/issues/13104
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19270
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/19270/files/af8b672ab2a89630be56c1494bea0877cad7c507
https://github.com/A5rocks
A5rocks https://github.com/A5rocks
Wrong unreachable note in finally section https://github.com/python/mypy/issues/19269
Please reload this pagehttps://github.com/python/mypy/pull/19270
https://github.com/tyralla
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.