| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8e07b5ca-7ea4-3b07-aee9-eafdf37190a2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BCF0:171905:37EBDD:4A37D6:6A5B26EC |
| html-safe-nonce | 1903be5e29309d356434e77df49eaa430e73e3937f44c9d389086bc271179871 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0YwOjE3MTkwNTozN0VCREQ6NEEzN0Q2OjZBNUIyNkVDIiwidmlzaXRvcl9pZCI6IjM5ODY4NDI3MDE4MzcwNTE2MjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1410888286722095a79d8b5910efec9dd7aef3af36b1d327f0cb061b5a512f2e |
| hovercard-subject-tag | pull_request:2574542236 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/19245/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6a9c8f959c91a8112085c8123f1dd74ea88cb8e8ae456ca40b1ecf7d155caee8/python/mypy/pull/19245 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6a9c8f959c91a8112085c8123f1dd74ea88cb8e8ae456ca40b1ecf7d155caee8/python/mypy/pull/19245 |
| og:image:alt | Fixes #14987
I was puzzled as to why my previous attempts to avoid false unreachable warnings for loops failed for issue #14987. After some debugging, I realised that the underlying problem is tha... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tyralla |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/mypy/pull/19245#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19245 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19245 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/19245 |
| Reload | https://github.com/python/mypy/pull/19245 |
| Reload | https://github.com/python/mypy/pull/19245 |
| Please reload this page | https://github.com/python/mypy/pull/19245 |
|
python
| https://github.com/python |
| mypy | https://github.com/python/mypy |
| Please reload this page | https://github.com/python/mypy/pull/19245 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fmypy |
|
Fork
3.2k
| https://github.com/login?return_to=%2Fpython%2Fmypy |
|
Star
20.5k
| https://github.com/login?return_to=%2Fpython%2Fmypy |
|
Code
| https://github.com/python/mypy |
|
Issues
2.7k
| https://github.com/python/mypy/issues |
|
Pull requests
467
| https://github.com/python/mypy/pulls |
|
Actions
| https://github.com/python/mypy/actions |
|
Projects
| https://github.com/python/mypy/projects |
|
Wiki
| https://github.com/python/mypy/wiki |
|
Security and quality
0
| https://github.com/python/mypy/security |
|
Insights
| https://github.com/python/mypy/pulse |
|
Code
| https://github.com/python/mypy |
|
Issues
| https://github.com/python/mypy/issues |
|
Pull requests
| https://github.com/python/mypy/pulls |
|
Actions
| https://github.com/python/mypy/actions |
|
Projects
| https://github.com/python/mypy/projects |
|
Wiki
| https://github.com/python/mypy/wiki |
|
Security and quality
| https://github.com/python/mypy/security |
|
Insights
| https://github.com/python/mypy/pulse |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| tyralla:fix/fix_narrow_promotions_in_unions | https://github.com/tyralla/mypy/tree/fix/fix_narrow_promotions_in_unions |
| Conversation | https://github.com/python/mypy/pull/19245 |
| Commits7 (7) | https://github.com/python/mypy/pull/19245/commits |
| Checks | https://github.com/python/mypy/pull/19245/checks |
| Files changed | https://github.com/python/mypy/pull/19245/files |
| Improve the support for promotions inside unions. | https://github.com/python/mypy/pull/19245#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| tyralla:fix/fix_narrow_promotions_in_unions | https://github.com/tyralla/mypy/tree/fix/fix_narrow_promotions_in_unions |
|
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Jun 6, 2025 | https://github.com/python/mypy/pull/19245#issue-3125948228 |
| Please reload this page | https://github.com/python/mypy/pull/19245 |
| #14987 | https://github.com/python/mypy/issues/14987 |
| #14987 | https://github.com/python/mypy/issues/14987 |
| Please reload this page | https://github.com/python/mypy/pull/19245 |
|
| https://github.com/tyralla |
| Improve the support for promotions inside unions. | https://github.com/python/mypy/pull/19245/commits/df070ec772f772ca6ebd731f7901f51899aceb28 |
| df070ec | https://github.com/python/mypy/pull/19245/commits/df070ec772f772ca6ebd731f7901f51899aceb28 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19245 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Jun 6, 2025 | https://github.com/python/mypy/pull/19245#issuecomment-2951126791 |
| #19118 | https://github.com/python/mypy/pull/19118 |
| @ilevkivskyi | https://github.com/ilevkivskyi |
| Please reload this page | https://github.com/python/mypy/pull/19245 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| ilevkivskyi | https://github.com/ilevkivskyi |
| June 6, 2025 22:52 | https://github.com/python/mypy/pull/19245#event-18029702701 |
|
| https://github.com/tyralla |
| Merge branch 'master' into fix/fix_narrow_promotions_in_unions | https://github.com/python/mypy/pull/19245/commits/bd2a103b8baf879e2666d3d1dbc68cb4f86f6c39 |
| bd2a103 | https://github.com/python/mypy/pull/19245/commits/bd2a103b8baf879e2666d3d1dbc68cb4f86f6c39 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19245 |
| https://github.com/sterliakov |
| sterliakov | https://github.com/sterliakov |
|
Jun 7, 2025
| https://github.com/python/mypy/pull/19245#pullrequestreview-2907642469 |
|
View reviewed changes
| https://github.com/python/mypy/pull/19245/files/bd2a103b8baf879e2666d3d1dbc68cb4f86f6c39 |
| mypy/meet.py | https://github.com/python/mypy/pull/19245/files/bd2a103b8baf879e2666d3d1dbc68cb4f86f6c39#diff-cdffaffb73fce8b49d0e95f9edde45fcd45462465182c182a41e022d897da965 |
| sterliakov | https://github.com/sterliakov |
| Jun 7, 2025 | https://github.com/python/mypy/pull/19245#discussion_r2134046989 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/19245 |
| A5rocks | https://github.com/A5rocks |
| Jun 10, 2025 | https://github.com/python/mypy/pull/19245#discussion_r2136712791 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/19245 |
| tyralla | https://github.com/tyralla |
| Jun 10, 2025 | https://github.com/python/mypy/pull/19245#discussion_r2138237227 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @A5rocks | https://github.com/A5rocks |
| Please reload this page | https://github.com/python/mypy/pull/19245 |
| JukkaL | https://github.com/JukkaL |
| Jun 13, 2025 | https://github.com/python/mypy/pull/19245#discussion_r2145403354 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/19245 |
| tyralla | https://github.com/tyralla |
| Jun 13, 2025 | https://github.com/python/mypy/pull/19245#discussion_r2145475790 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/19245 |
| https://github.com/A5rocks |
| A5rocks | https://github.com/A5rocks |
|
Jun 10, 2025
| https://github.com/python/mypy/pull/19245#pullrequestreview-2911680658 |
|
View reviewed changes
| https://github.com/python/mypy/pull/19245/files/bd2a103b8baf879e2666d3d1dbc68cb4f86f6c39 |
| mypy/meet.py | https://github.com/python/mypy/pull/19245/files/bd2a103b8baf879e2666d3d1dbc68cb4f86f6c39#diff-cdffaffb73fce8b49d0e95f9edde45fcd45462465182c182a41e022d897da965 |
| A5rocks | https://github.com/A5rocks |
| Jun 10, 2025 | https://github.com/python/mypy/pull/19245#discussion_r2136712791 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/19245 |
| tyralla | https://github.com/tyralla |
| June 13, 2025 18:19 | https://github.com/python/mypy/pull/19245#commits-pushed-2c820d3 |
|
| https://github.com/tyralla |
| do not use itertools.product | https://github.com/python/mypy/pull/19245/commits/2c820d3fcfed1de4a585185b6aea8adfc6bdc061 |
| 2c820d3 | https://github.com/python/mypy/pull/19245/commits/2c820d3fcfed1de4a585185b6aea8adfc6bdc061 |
|
| https://github.com/tyralla |
| Merge branch 'master' into fix/fix_narrow_promotions_in_unions | https://github.com/python/mypy/pull/19245/commits/e202c7a0d4355d01bf75f36e3ca9b5d132e9f689 |
| e202c7a | https://github.com/python/mypy/pull/19245/commits/e202c7a0d4355d01bf75f36e3ca9b5d132e9f689 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19245 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| JukkaL | https://github.com/JukkaL |
| June 13, 2025 17:25 | https://github.com/python/mypy/pull/19245#event-18138038859 |
|
| https://github.com/tyralla |
| Merge branch 'master' into fix/fix_narrow_promotions_in_unions | https://github.com/python/mypy/pull/19245/commits/17d4218d562d85a1b207629cd974ea25232c29d9 |
| 17d4218 | https://github.com/python/mypy/pull/19245/commits/17d4218d562d85a1b207629cd974ea25232c29d9 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19245 |
| https://github.com/sterliakov |
| sterliakov | https://github.com/sterliakov |
|
Jun 27, 2025
| https://github.com/python/mypy/pull/19245#ref-issue-3183366231 |
|
Check #19245
sterliakov/mypy-issues#90
| https://github.com/sterliakov/mypy-issues/issues/90 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Jul 7, 2025
| https://github.com/python/mypy/pull/19245#pullrequestreview-2993638816 |
|
View reviewed changes
| https://github.com/python/mypy/pull/19245/files/17d4218d562d85a1b207629cd974ea25232c29d9 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/mypy/pull/19245#pullrequestreview-2993638816 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/19245 |
|
| https://github.com/ilevkivskyi |
| Merge branch 'master' into fix/fix_narrow_promotions_in_unions | https://github.com/python/mypy/pull/19245/commits/666170504effe50905888834502051dfc2e78820 |
| 6661705 | https://github.com/python/mypy/pull/19245/commits/666170504effe50905888834502051dfc2e78820 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Jul 7, 2025 | https://github.com/python/mypy/pull/19245#issuecomment-3044919730 |
| @tyralla | https://github.com/tyralla |
| Please reload this page | https://github.com/python/mypy/pull/19245 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19245 |
|
| https://github.com/tyralla |
| fix the order in a revealed union | https://github.com/python/mypy/pull/19245/commits/4a1ae229368795dedd4ba3efa8ebc78c6a6860b9 |
| 4a1ae22 | https://github.com/python/mypy/pull/19245/commits/4a1ae229368795dedd4ba3efa8ebc78c6a6860b9 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Jul 7, 2025 | https://github.com/python/mypy/pull/19245#issuecomment-3046325446 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/19245 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| cb3bddd | https://github.com/python/mypy/commit/cb3bddd41149405e2dfaa615cfc4c6f109eb80f3 |
| Jul 7, 2025 | https://github.com/python/mypy/pull/19245#event-18511773984 |
| Please reload this page | https://github.com/python/mypy/pull/19245 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Jul 7, 2025 | https://github.com/python/mypy/pull/19245#issuecomment-3046330249 |
| #19324 | https://github.com/python/mypy/pull/19324 |
| Please reload this page | https://github.com/python/mypy/pull/19245 |
| https://github.com/tyralla |
| tyralla | https://github.com/tyralla |
| Jul 7, 2025 | https://github.com/python/mypy/pull/19245#issuecomment-3046334596 |
| Please reload this page | https://github.com/python/mypy/pull/19245 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19245 |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
|
| https://github.com/python/mypy/pull/19245/files/17d4218d562d85a1b207629cd974ea25232c29d9 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/sterliakov |
|
sterliakov
| https://github.com/sterliakov |
|
| https://github.com/python/mypy/pull/19245/files/bd2a103b8baf879e2666d3d1dbc68cb4f86f6c39 |
|
| https://github.com/A5rocks |
|
A5rocks
| https://github.com/A5rocks |
|
| https://github.com/python/mypy/pull/19245/files/bd2a103b8baf879e2666d3d1dbc68cb4f86f6c39 |
|
False positive unreachable when variable is set and reset inside loop
| https://github.com/python/mypy/issues/14987 |
| Please reload this page | https://github.com/python/mypy/pull/19245 |
|
| https://github.com/tyralla |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/JukkaL |
|
| https://github.com/A5rocks |
|
| https://github.com/sterliakov |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |