René's URL Explorer Experiment


Title: Fix nondeterministic type checking caused by nonassociative of None joins by hauntsaninja · Pull Request #19158 · python/mypy · GitHub

Open Graph Title: Fix nondeterministic type checking caused by nonassociative of None joins by hauntsaninja · Pull Request #19158 · python/mypy

X Title: Fix nondeterministic type checking caused by nonassociative of None joins by hauntsaninja · Pull Request #19158 · python/mypy

Description: Fixes #19121 (xarray case) See #19147 for context The ordering of the union is still nondeterministic. We could solve this by change the solver to use dict[Type, None instead of set[Type] since dicts are ordered. But doing so could paper over further bad solving from nonassociativity or noncommutativity

Open Graph Description: Fixes #19121 (xarray case) See #19147 for context The ordering of the union is still nondeterministic. We could solve this by change the solver to use dict[Type, None instead of set[Type] since dic...

X Description: Fixes #19121 (xarray case) See #19147 for context The ordering of the union is still nondeterministic. We could solve this by change the solver to use dict[Type, None instead of set[Type] since dic...

Opengraph URL: https://github.com/python/mypy/pull/19158

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:62575809-1e62-36b5-39d6-51cce5dab601
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id923C:196AE6:12C1412:18C773A:6A5C5500
html-safe-nonce8dfba157ae29d9f4dc06314fbfece0126fa82b71ac48d7f452a8ad08e2a5bc6c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjNDOjE5NkFFNjoxMkMxNDEyOjE4Qzc3M0E6NkE1QzU1MDAiLCJ2aXNpdG9yX2lkIjoiNDU4NjkzOTI2NDc2MDgyOTE4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf6af32a4e76989c883969d4e348670551822acc283ca100d5f49d99cb1698313
hovercard-subject-tagpull_request:2548262768
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/mypy/pull/19158/files
twitter:imagehttps://avatars.githubusercontent.com/u/12621235?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/12621235?s=400&v=4
og:image:altFixes #19121 (xarray case) See #19147 for context The ordering of the union is still nondeterministic. We could solve this by change the solver to use dict[Type, None instead of set[Type] since dic...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/mypy/pull/19158/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19158%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19158%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/19158/files
Reloadhttps://github.com/python/mypy/pull/19158/files
Reloadhttps://github.com/python/mypy/pull/19158/files
Please reload this pagehttps://github.com/python/mypy/pull/19158/files
python https://github.com/python
mypyhttps://github.com/python/mypy
Please reload this pagehttps://github.com/python/mypy/pull/19158/files
Notifications https://github.com/login?return_to=%2Fpython%2Fmypy
Fork 3.2k https://github.com/login?return_to=%2Fpython%2Fmypy
Star 20.5k https://github.com/login?return_to=%2Fpython%2Fmypy
Code https://github.com/python/mypy
Issues 2.7k https://github.com/python/mypy/issues
Pull requests 468 https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality 0 https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
Code https://github.com/python/mypy
Issues https://github.com/python/mypy/issues
Pull requests https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fmypy%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fmypy%2Fissues%2Fnew%2Fchoose
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:uniondethttps://github.com/hauntsaninja/mypy/tree/uniondet
Conversation 4 https://github.com/python/mypy/pull/19158
Commits 2 https://github.com/python/mypy/pull/19158/commits
Checks 0 https://github.com/python/mypy/pull/19158/checks
Files changed https://github.com/python/mypy/pull/19158/files
Please reload this pagehttps://github.com/python/mypy/pull/19158/files
Fix nondeterministic type checking caused by nonassociative of None joins https://github.com/python/mypy/pull/19158/files#top
Show all changes 2 commits https://github.com/python/mypy/pull/19158/files
b35fba1 Fix nondeterministic type checking caused by nonassociative of None j… hauntsaninja May 28, 2025 https://github.com/python/mypy/pull/19158/commits/b35fba1962857b518db60aca33402e18a4496235
51ddef5 fix test hauntsaninja May 28, 2025 https://github.com/python/mypy/pull/19158/commits/51ddef5a0878fd109b0f796eb1051c940309e48c
Clear filters https://github.com/python/mypy/pull/19158/files
Please reload this pagehttps://github.com/python/mypy/pull/19158/files
Please reload this pagehttps://github.com/python/mypy/pull/19158/files
solve.py https://github.com/python/mypy/pull/19158/files#diff-f41f9947ded8eb006addab30699f8fceaff979541a5e768acbee016a39a7bb4a
check-generics.test https://github.com/python/mypy/pull/19158/files#diff-66e952c0f29c9c94526c50e69b4eaae5bad35ea0e249c9fd2edcf0b4be9f93af
check-varargs.test https://github.com/python/mypy/pull/19158/files#diff-c4e3efc892a6993e27db5a9ec878e54a89f4d790f4c2187b68b2d9f5385c641e
mypy/solve.pyhttps://github.com/python/mypy/pull/19158/files#diff-f41f9947ded8eb006addab30699f8fceaff979541a5e768acbee016a39a7bb4a
View file https://github.com/hauntsaninja/mypy/blob/51ddef5a0878fd109b0f796eb1051c940309e48c/mypy/solve.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/19158/{{ revealButtonHref }}
https://github.com/python/mypy/pull/19158/files#diff-f41f9947ded8eb006addab30699f8fceaff979541a5e768acbee016a39a7bb4a
https://github.com/python/mypy/pull/19158/files#diff-f41f9947ded8eb006addab30699f8fceaff979541a5e768acbee016a39a7bb4a
test-data/unit/check-generics.testhttps://github.com/python/mypy/pull/19158/files#diff-66e952c0f29c9c94526c50e69b4eaae5bad35ea0e249c9fd2edcf0b4be9f93af
View file https://github.com/hauntsaninja/mypy/blob/51ddef5a0878fd109b0f796eb1051c940309e48c/test-data/unit/check-generics.test
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/19158/{{ revealButtonHref }}
https://github.com/python/mypy/pull/19158/files#diff-66e952c0f29c9c94526c50e69b4eaae5bad35ea0e249c9fd2edcf0b4be9f93af
JukkaLhttps://github.com/JukkaL
May 28, 2025https://github.com/python/mypy/pull/19158/files#r2111359892
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19158/files
JukkaLhttps://github.com/JukkaL
May 28, 2025https://github.com/python/mypy/pull/19158/files#r2111366607
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19158/files
test-data/unit/check-varargs.testhttps://github.com/python/mypy/pull/19158/files#diff-c4e3efc892a6993e27db5a9ec878e54a89f4d790f4c2187b68b2d9f5385c641e
View file https://github.com/hauntsaninja/mypy/blob/51ddef5a0878fd109b0f796eb1051c940309e48c/test-data/unit/check-varargs.test
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/19158/{{ revealButtonHref }}
https://github.com/python/mypy/pull/19158/files#diff-c4e3efc892a6993e27db5a9ec878e54a89f4d790f4c2187b68b2d9f5385c641e
https://github.com/python/mypy/pull/19158/files#diff-c4e3efc892a6993e27db5a9ec878e54a89f4d790f4c2187b68b2d9f5385c641e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.