| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e9fa1366-1519-7e89-c859-5d75a6972a78 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E05A:3081D4:C2E7ED:FC04CA:6A5C2B6B |
| html-safe-nonce | a7777e4da25c95e042d1c3d7de4fdb3a1f5521d4021ef735f58f4ea72e797bd2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDVBOjMwODFENDpDMkU3RUQ6RkMwNENBOjZBNUMyQjZCIiwidmlzaXRvcl9pZCI6IjQxNDg2MTE4NDYxNzcwNDEyNTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 15517e2e34c5fa37280f3d230e55855f61858463178bf23a8c66868c3a91fec7 |
| hovercard-subject-tag | pull_request:2542666308 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/19147/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3b6f40475ce81e5027d60367005d7b14ec07359b1de1b17455b522b796077aaa/python/mypy/pull/19147 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3b6f40475ce81e5027d60367005d7b14ec07359b1de1b17455b522b796077aaa/python/mypy/pull/19147 |
| og:image:alt | I thought about doing this in join_type_list, but most callers look like they do have some deterministic order.
Fixes #19121 (torchvision case only, haven't looked at xarray)
Fixes #16979 (OP c... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hauntsaninja |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/mypy/pull/19147#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19147 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19147 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/19147 |
| Reload | https://github.com/python/mypy/pull/19147 |
| Reload | https://github.com/python/mypy/pull/19147 |
| Please reload this page | https://github.com/python/mypy/pull/19147 |
|
python
| https://github.com/python |
| mypy | https://github.com/python/mypy |
| Please reload this page | https://github.com/python/mypy/pull/19147 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fmypy |
|
Fork
3.2k
| https://github.com/login?return_to=%2Fpython%2Fmypy |
|
Star
20.5k
| https://github.com/login?return_to=%2Fpython%2Fmypy |
|
Code
| https://github.com/python/mypy |
|
Issues
2.7k
| https://github.com/python/mypy/issues |
|
Pull requests
468
| https://github.com/python/mypy/pulls |
|
Actions
| https://github.com/python/mypy/actions |
|
Projects
| https://github.com/python/mypy/projects |
|
Wiki
| https://github.com/python/mypy/wiki |
|
Security and quality
0
| https://github.com/python/mypy/security |
|
Insights
| https://github.com/python/mypy/pulse |
|
Code
| https://github.com/python/mypy |
|
Issues
| https://github.com/python/mypy/issues |
|
Pull requests
| https://github.com/python/mypy/pulls |
|
Actions
| https://github.com/python/mypy/actions |
|
Projects
| https://github.com/python/mypy/projects |
|
Wiki
| https://github.com/python/mypy/wiki |
|
Security and quality
| https://github.com/python/mypy/security |
|
Insights
| https://github.com/python/mypy/pulse |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| hauntsaninja:nondeterm | https://github.com/hauntsaninja/mypy/tree/nondeterm |
| Conversation | https://github.com/python/mypy/pull/19147 |
| Commits7 (7) | https://github.com/python/mypy/pull/19147/commits |
| Checks | https://github.com/python/mypy/pull/19147/checks |
| Files changed | https://github.com/python/mypy/pull/19147/files |
| Fix nondeterministic type checking caused by nonassociativity of joins | https://github.com/python/mypy/pull/19147#top |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| hauntsaninja:nondeterm | https://github.com/hauntsaninja/mypy/tree/nondeterm |
|
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| May 25, 2025 | https://github.com/python/mypy/pull/19147#issue-3089599934 |
| Please reload this page | https://github.com/python/mypy/pull/19147 |
| #19121 | https://github.com/python/mypy/issues/19121 |
| #16979 | https://github.com/python/mypy/issues/16979 |
| #18402 | https://github.com/python/mypy/pull/18402 |
| Please reload this page | https://github.com/python/mypy/pull/19147 |
| hauntsaninja | https://github.com/hauntsaninja |
| May 25, 2025 14:19 | https://github.com/python/mypy/pull/19147#commits-pushed-f02c757 |
|
| https://github.com/hauntsaninja |
| test | https://github.com/python/mypy/pull/19147/commits/f02c757d00e407c677495d098899f950a8a4928b |
| f02c757 | https://github.com/python/mypy/pull/19147/commits/f02c757d00e407c677495d098899f950a8a4928b |
|
| https://github.com/hauntsaninja |
| fix | https://github.com/python/mypy/pull/19147/commits/62c03999f4dada530c82db202cbdd7d947abb13f |
| 62c0399 | https://github.com/python/mypy/pull/19147/commits/62c03999f4dada530c82db202cbdd7d947abb13f |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| May 25, 2025 | https://github.com/python/mypy/pull/19147#event-17805629217 |
| pre-commit-ci | https://github.com/apps/pre-commit-ci |
| May 25, 2025 21:57 | https://github.com/python/mypy/pull/19147#commits-pushed-45fa530 |
|
| https://github.com/marketplace/pre-commit-ci |
| [pre-commit.ci] auto fixes from pre-commit.com hooks | https://github.com/python/mypy/pull/19147/commits/45fa530791cf92e84deeb91848ed562888d120d7 |
| 45fa530 | https://github.com/python/mypy/pull/19147/commits/45fa530791cf92e84deeb91848ed562888d120d7 |
| https://pre-commit.ci | https://pre-commit.ci |
|
| https://github.com/hauntsaninja |
| oops | https://github.com/python/mypy/pull/19147/commits/8b8a3a7019a3ef10b5d5a0d68e5302f23626a1ba |
| 8b8a3a7 | https://github.com/python/mypy/pull/19147/commits/8b8a3a7019a3ef10b5d5a0d68e5302f23626a1ba |
|
| https://github.com/hauntsaninja |
| fix | https://github.com/python/mypy/pull/19147/commits/18562b032bda52ff6497c3acecacd051a6f829c3 |
| 18562b0 | https://github.com/python/mypy/pull/19147/commits/18562b032bda52ff6497c3acecacd051a6f829c3 |
|
| https://github.com/hauntsaninja |
| makes other test cases a bit better | https://github.com/python/mypy/pull/19147/commits/ae7b8689ea9b976c4db724b542653771a8b5fabb |
| ae7b868 | https://github.com/python/mypy/pull/19147/commits/ae7b8689ea9b976c4db724b542653771a8b5fabb |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19147 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| May 25, 2025 | https://github.com/python/mypy/pull/19147#issuecomment-2908168468 |
| Please reload this page | https://github.com/python/mypy/pull/19147 |
|
Fix nondeterministic type checking by making join with explicit Protocol and type promotion commute
#18402
| https://github.com/python/mypy/pull/18402 |
|
MyPy is nondeterministic across runs
#16979
| https://github.com/python/mypy/issues/16979 |
|
Nondeterministic type checking on pytorch/vision
#19121
| https://github.com/python/mypy/issues/19121 |
|
| https://github.com/hauntsaninja |
| remove the extra test case | https://github.com/python/mypy/pull/19147/commits/b2fc336e39522fbf72545a601b063756617b7983 |
| b2fc336 | https://github.com/python/mypy/pull/19147/commits/b2fc336e39522fbf72545a601b063756617b7983 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| May 26, 2025 | https://github.com/python/mypy/pull/19147#issuecomment-2908816737 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/19147 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
May 27, 2025
| https://github.com/python/mypy/pull/19147#pullrequestreview-2870522819 |
|
View reviewed changes
| https://github.com/python/mypy/pull/19147/files/b2fc336e39522fbf72545a601b063756617b7983 |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/19147#pullrequestreview-2870522819 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/19147 |
| mypy/solve.py | https://github.com/python/mypy/pull/19147/files/b2fc336e39522fbf72545a601b063756617b7983#diff-f41f9947ded8eb006addab30699f8fceaff979541a5e768acbee016a39a7bb4a |
| JukkaL | https://github.com/JukkaL |
| May 27, 2025 | https://github.com/python/mypy/pull/19147#discussion_r2108818241 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/19147 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| May 27, 2025 | https://github.com/python/mypy/pull/19147#issuecomment-2913501705 |
| Please reload this page | https://github.com/python/mypy/pull/19147 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| f328ad6 | https://github.com/python/mypy/commit/f328ad6ab81fba3c8470e98f8e6795813a89f810 |
| May 28, 2025 | https://github.com/python/mypy/pull/19147#event-17842491605 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| May 28, 2025 03:55 | https://github.com/python/mypy/pull/19147#event-17842491855 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
May 28, 2025
| https://github.com/python/mypy/pull/19147#ref-pullrequest-3095921430 |
|
Fix nondeterministic type checking caused by nonassociative of None joins
#19158
| https://github.com/python/mypy/pull/19158 |
| JukkaL | https://github.com/JukkaL |
|
May 28, 2025
| https://github.com/python/mypy/pull/19147#ref-commit-29e125f |
|
| https://github.com/hauntsaninja |
| Fix nondeterministic type checking caused by nonassociative of None j… | https://github.com/python/mypy/commit/29e125f858e75bb9ba6f0c389718bc14075e866a |
| 29e125f | https://github.com/python/mypy/commit/29e125f858e75bb9ba6f0c389718bc14075e866a |
| #19158 | https://github.com/python/mypy/pull/19158 |
| #19121 | https://github.com/python/mypy/issues/19121 |
| #19147 | https://github.com/python/mypy/pull/19147 |
| hauntsaninja | https://github.com/hauntsaninja |
|
Jun 1, 2025
| https://github.com/python/mypy/pull/19147#ref-commit-0ea8488 |
|
| https://github.com/hauntsaninja |
| Fix nondeterministic type checking by making join with explicit Proto… | https://github.com/python/mypy/commit/0ea84886e5a6decdb46b5bae93c4452a0a6ca6bb |
| 0ea8488 | https://github.com/python/mypy/commit/0ea84886e5a6decdb46b5bae93c4452a0a6ca6bb |
| #18402 | https://github.com/python/mypy/pull/18402 |
| #16979 | https://github.com/python/mypy/issues/16979 |
| #19147 | https://github.com/python/mypy/pull/19147 |
| #16979 (comment) | https://github.com/python/mypy/issues/16979#issuecomment-1982283536 |
| https://github.com/mr-c |
| mr-c | https://github.com/mr-c |
| Jul 15, 2025 | https://github.com/python/mypy/pull/19147#issuecomment-3073049849 |
| Please reload this page | https://github.com/python/mypy/pull/19147 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| Jul 15, 2025 | https://github.com/python/mypy/pull/19147#issuecomment-3075186200 |
| Please reload this page | https://github.com/python/mypy/pull/19147 |
| Please reload this page | https://github.com/python/mypy/pull/19147 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Jul 20, 2025
| https://github.com/python/mypy/pull/19147#ref-issue-3246421633 |
|
1.17.0 regression: dict literals incompatible with Sequence[TypedDict]
#19483
| https://github.com/python/mypy/issues/19483 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
May 10, 2026
| https://github.com/python/mypy/pull/19147#ref-pullrequest-4414909356 |
|
Fix nondeterminism from nonassociativity of overload joins
#21455
| https://github.com/python/mypy/pull/21455 |
| hauntsaninja | https://github.com/hauntsaninja |
|
May 10, 2026
| https://github.com/python/mypy/pull/19147#ref-commit-010f0a2 |
|
| https://github.com/hauntsaninja |
| Fix nondeterminism from nonassociativity of overload joins ( | https://github.com/python/mypy/commit/010f0a2c4a5e4b7ac4e9fd1388ac072ffd2e8e5d |
| #21455 | https://github.com/python/mypy/pull/21455 |
| ) | https://github.com/python/mypy/commit/010f0a2c4a5e4b7ac4e9fd1388ac072ffd2e8e5d |
| 010f0a2 | https://github.com/python/mypy/commit/010f0a2c4a5e4b7ac4e9fd1388ac072ffd2e8e5d |
| #21445 | https://github.com/python/mypy/issues/21445 |
| #19147 | https://github.com/python/mypy/pull/19147 |
| #19158 | https://github.com/python/mypy/pull/19158 |
| JukkaL | https://github.com/JukkaL |
|
May 10, 2026
| https://github.com/python/mypy/pull/19147#ref-commit-116d60b |
|
| https://github.com/hauntsaninja |
|
| https://github.com/JukkaL |
| Fix nondeterminism from nonassociativity of overload joins ( | https://github.com/python/mypy/commit/116d60bdd3fdfe8d97c6afe99370910db56f1b92 |
| #21455 | https://github.com/python/mypy/pull/21455 |
| ) | https://github.com/python/mypy/commit/116d60bdd3fdfe8d97c6afe99370910db56f1b92 |
| 116d60b | https://github.com/python/mypy/commit/116d60bdd3fdfe8d97c6afe99370910db56f1b92 |
| #21445 | https://github.com/python/mypy/issues/21445 |
| #19147 | https://github.com/python/mypy/pull/19147 |
| #19158 | https://github.com/python/mypy/pull/19158 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19147 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/19147/files/b2fc336e39522fbf72545a601b063756617b7983 |
|
Nondeterministic type checking on pytorch/vision
| https://github.com/python/mypy/issues/19121 |
|
MyPy is nondeterministic across runs
| https://github.com/python/mypy/issues/16979 |
| Please reload this page | https://github.com/python/mypy/pull/19147 |
|
| https://github.com/hauntsaninja |
|
| https://github.com/mr-c |
|
| https://github.com/JukkaL |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |