René's URL Explorer Experiment


Title: Do not cache module lookup results that may become invalid in future by sterliakov · Pull Request #19044 · python/mypy · GitHub

Open Graph Title: Do not cache module lookup results that may become invalid in future by sterliakov · Pull Request #19044 · python/mypy

X Title: Do not cache module lookup results that may become invalid in future by sterliakov · Pull Request #19044 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #19037. See my analysis in #19037 for motivation. As a side note, with this patch the second run behaves as expected (without it mypy tries to reanalyze a lot of modules during the 2nd run, n...

X Description: Fixes #19037. See my analysis in #19037 for motivation. As a side note, with this patch the second run behaves as expected (without it mypy tries to reanalyze a lot of modules during the 2nd run, n...

Opengraph URL: https://github.com/python/mypy/pull/19044

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:782254fa-efb0-e8ae-fb87-63693aaea8c8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id90AE:251AC0:7385AD:9924F9:6B0037ED
html-safe-nonce036b70200dd5e40e14fbcc6c04f2f4677d5861f2d9a223ada73fbe4fb2dc82e2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEFFOjI1MUFDMDo3Mzg1QUQ6OTkyNEY5OjZCMDAzN0VEIiwidmlzaXRvcl9pZCI6IjUxODk3ODUwOTIwOTYwMTQzMTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac899dda1aac38bc0fd7152869eaef9f3857a0602dc48b875a01c2e9eddc1d0e27
hovercard-subject-tagpull_request:2502149289
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/19044/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/173217dd01a23e17535609176c6b803efababb1958172921f580dbc83edaf995/python/mypy/pull/19044
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/173217dd01a23e17535609176c6b803efababb1958172921f580dbc83edaf995/python/mypy/pull/19044
og:image:altFixes #19037. See my analysis in #19037 for motivation. As a side note, with this patch the second run behaves as expected (without it mypy tries to reanalyze a lot of modules during the 2nd run, n...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesterliakov
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/19044#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19044
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19044
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/19044
Reloadhttps://github.com/python/mypy/pull/19044
Reloadhttps://github.com/python/mypy/pull/19044
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
sterliakov:bugfix/gh-19037-namespace-package-lookup-cachinghttps://github.com/sterliakov/mypy/tree/bugfix/gh-19037-namespace-package-lookup-caching
Conversationhttps://github.com/python/mypy/pull/19044
Commits4 (4)https://github.com/python/mypy/pull/19044/commits
Checkshttps://github.com/python/mypy/pull/19044/checks
Files changedhttps://github.com/python/mypy/pull/19044/files
Do not cache module lookup results that may become invalid in futurehttps://github.com/python/mypy/pull/19044#top
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
sterliakov:bugfix/gh-19037-namespace-package-lookup-cachinghttps://github.com/sterliakov/mypy/tree/bugfix/gh-19037-namespace-package-lookup-caching
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
May 6, 2025https://github.com/python/mypy/pull/19044#issue-3043427490
Please reload this pagehttps://github.com/python/mypy/pull/19044
#19037https://github.com/python/mypy/issues/19037
#19037https://github.com/python/mypy/issues/19037
Please reload this pagehttps://github.com/python/mypy/pull/19044
https://github.com/sterliakov
Do not cache lookup results that may become invalid in futurehttps://github.com/python/mypy/pull/19044/commits/99957d7fab21c3ee9ee2511afc5a781cbaf5246d
99957d7https://github.com/python/mypy/pull/19044/commits/99957d7fab21c3ee9ee2511afc5a781cbaf5246d
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
May 6, 2025 https://github.com/python/mypy/pull/19044#ref-issue-3040331878
Empty vs filled cache inconsistency for google-cloud-logging & google-cloud-pubsub together with type: ignore comments #19037 https://github.com/python/mypy/issues/19037
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19044
sterliakovhttps://github.com/sterliakov
May 6, 2025 19:56https://github.com/python/mypy/pull/19044#commits-pushed-a5e7ea5
https://github.com/sterliakov
And a testhttps://github.com/python/mypy/pull/19044/commits/a5e7ea56bf94a727827881d42e5f8eff8e6177fb
a5e7ea5https://github.com/python/mypy/pull/19044/commits/a5e7ea56bf94a727827881d42e5f8eff8e6177fb
https://github.com/sterliakov
Fix windows testcase (path normalization was never tested here...)https://github.com/python/mypy/pull/19044/commits/307d4461f25cd705dd932ef149f7a574f27747c9
307d446https://github.com/python/mypy/pull/19044/commits/307d4461f25cd705dd932ef149f7a574f27747c9
https://github.com/sterliakov
Document _find_module returnhttps://github.com/python/mypy/pull/19044/commits/dbfcab153931bf6bb6e903f094c24a2a7a1f743b
dbfcab1https://github.com/python/mypy/pull/19044/commits/dbfcab153931bf6bb6e903f094c24a2a7a1f743b
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 6, 2025https://github.com/python/mypy/pull/19044#issuecomment-2855666909
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/19044
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
May 6, 2025https://github.com/python/mypy/pull/19044#issuecomment-2855809048
#10360https://github.com/python/mypy/issues/10360
#16149https://github.com/python/mypy/issues/16149
Please reload this pagehttps://github.com/python/mypy/pull/19044
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
May 6, 2025https://github.com/python/mypy/pull/19044#issuecomment-2856214737
Please reload this pagehttps://github.com/python/mypy/pull/19044
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
May 6, 2025 22:02https://github.com/python/mypy/pull/19044#event-17545199769
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
May 7, 2025 https://github.com/python/mypy/pull/19044#pullrequestreview-2822373941
View reviewed changes https://github.com/python/mypy/pull/19044/files/dbfcab153931bf6bb6e903f094c24a2a7a1f743b
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/19044#pullrequestreview-2822373941
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/19044
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
79ff4ffhttps://github.com/python/mypy/commit/79ff4ff3cedd6ca2786bdf8a8d531e944c51758a
May 7, 2025https://github.com/python/mypy/pull/19044#event-17559383227
https://github.com/VictorEngmarkHexagon
VictorEngmarkHexagonhttps://github.com/VictorEngmarkHexagon
Nov 26, 2025 https://github.com/python/mypy/pull/19044#ref-issue-3666917147
False positives about non-existing import when using mypy cache #20300 https://github.com/python/mypy/issues/20300
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Feb 4, 2026 https://github.com/python/mypy/pull/19044#ref-pullrequest-3898917722
Fix crash on partially typed namespace package #20742 https://github.com/python/mypy/pull/20742
ilevkivskyihttps://github.com/ilevkivskyi
Feb 6, 2026 https://github.com/python/mypy/pull/19044#ref-commit-1d18566
https://github.com/ilevkivskyi
Fix crash on partially typed namespace package (https://github.com/python/mypy/commit/1d18566919ab18ea53e38283bf9516fe2e33548f
#20742https://github.com/python/mypy/pull/20742
)https://github.com/python/mypy/commit/1d18566919ab18ea53e38283bf9516fe2e33548f
1d18566https://github.com/python/mypy/commit/1d18566919ab18ea53e38283bf9516fe2e33548f
#16214https://github.com/python/mypy/issues/16214
#20658https://github.com/python/mypy/pull/20658
#19044https://github.com/python/mypy/pull/19044
#20105https://github.com/python/mypy/issues/20105
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19044
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/19044/files/dbfcab153931bf6bb6e903f094c24a2a7a1f743b
Please reload this pagehttps://github.com/python/mypy/pull/19044
Empty vs filled cache inconsistency for google-cloud-logging & google-cloud-pubsub together with type: ignore comments https://github.com/python/mypy/issues/19037
Please reload this pagehttps://github.com/python/mypy/pull/19044
https://github.com/sterliakov
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.