| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fff24c56-cd5e-79fa-c939-8b442f5f562e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A084:1BAE29:1450D:1C5FB:6B004CF5 |
| html-safe-nonce | 2c67cb092ef5bfb5f186ca675ef0a081e4a349ad88c3aaa9cf2a26b69e73f52c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDg0OjFCQUUyOToxNDUwRDoxQzVGQjo2QjAwNENGNSIsInZpc2l0b3JfaWQiOiI3Njk3MzAxNzM1MjU3MTY1MDQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9cd7126226c118d299e21fa0b94e76794b21e690334fd432490b43401e84388a |
| hovercard-subject-tag | pull_request:2496606552 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/19018/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9808d4ecd8bcc9a06814b2a5f5b62eee64e73942d51fd35f4d54812a6f8878b4/python/mypy/pull/19018 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9808d4ecd8bcc9a06814b2a5f5b62eee64e73942d51fd35f4d54812a6f8878b4/python/mypy/pull/19018 |
| og:image:alt | Fixes #19017. Fixes #17731.
This is a rather naive change: python does that at runtime. kw_only args can be in any order, and non-kwonly args should remain sorted as-is (stable sort). I don't u... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sterliakov |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b27c5dde30676028abd5c5fc53ce5c9b625f8281 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/19018#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19018 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19018 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/19018 |
| Reload | https://github.com/python/mypy/pull/19018 |
| Reload | https://github.com/python/mypy/pull/19018 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| JukkaL | https://github.com/JukkaL |
| python:master | https://github.com/python/mypy/tree/master |
| sterliakov:bugfix/gh-19017-dataclass-fields-kwonly-order | https://github.com/sterliakov/mypy/tree/bugfix/gh-19017-dataclass-fields-kwonly-order |
| Conversation | https://github.com/python/mypy/pull/19018 |
| Commits5 (5) | https://github.com/python/mypy/pull/19018/commits |
| Checks | https://github.com/python/mypy/pull/19018/checks |
| Files changed | https://github.com/python/mypy/pull/19018/files |
| Move dataclass kw_only fields to the end of the signature | https://github.com/python/mypy/pull/19018#top |
| JukkaL | https://github.com/JukkaL |
| python:master | https://github.com/python/mypy/tree/master |
| sterliakov:bugfix/gh-19017-dataclass-fields-kwonly-order | https://github.com/sterliakov/mypy/tree/bugfix/gh-19017-dataclass-fields-kwonly-order |
|
| https://github.com/sterliakov |
| sterliakov | https://github.com/sterliakov |
| May 3, 2025 | https://github.com/python/mypy/pull/19018#issue-3037085808 |
| Please reload this page | https://github.com/python/mypy/pull/19018 |
| #19017 | https://github.com/python/mypy/issues/19017 |
| #17731 | https://github.com/python/mypy/issues/17731 |
| Please reload this page | https://github.com/python/mypy/pull/19018 |
| sterliakov | https://github.com/sterliakov |
| May 3, 2025 04:00 | https://github.com/python/mypy/pull/19018#commits-pushed-ceef876 |
|
| https://github.com/sterliakov |
| Kwonly attributes are moved to the end in all cases, this behaviour d… | https://github.com/python/mypy/pull/19018/commits/ceef8764dba2f386ca0c0ec2a5895dfeccd37f48 |
| ceef876 | https://github.com/python/mypy/pull/19018/commits/ceef8764dba2f386ca0c0ec2a5895dfeccd37f48 |
|
| https://github.com/sterliakov |
| Add regression test for another issue | https://github.com/python/mypy/pull/19018/commits/63edf493c36def7edbee1510d4b5071c796b8788 |
| 63edf49 | https://github.com/python/mypy/pull/19018/commits/63edf493c36def7edbee1510d4b5071c796b8788 |
|
| https://github.com/sterliakov |
| Revert previous attempt... | https://github.com/python/mypy/pull/19018/commits/39138a70c960a3ecf647b3f37d4ad59eb582cd62 |
| 39138a7 | https://github.com/python/mypy/pull/19018/commits/39138a70c960a3ecf647b3f37d4ad59eb582cd62 |
|
| https://github.com/sterliakov |
| Yes, this test was also wrong | https://github.com/python/mypy/pull/19018/commits/b9503ad39fd87f9b0dc69a7d84f379a0a53fd213 |
| b9503ad | https://github.com/python/mypy/pull/19018/commits/b9503ad39fd87f9b0dc69a7d84f379a0a53fd213 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19018 |
| https://github.com/sterliakov |
| sterliakov | https://github.com/sterliakov |
| May 3, 2025 16:33 | https://github.com/python/mypy/pull/19018#event-17508212739 |
| https://github.com/sterliakov |
| sterliakov | https://github.com/sterliakov |
| A5rocks | https://github.com/A5rocks |
| May 3, 2025 16:34 | https://github.com/python/mypy/pull/19018#event-17508213190 |
| https://github.com/A5rocks |
| A5rocks | https://github.com/A5rocks |
|
May 3, 2025
| https://github.com/python/mypy/pull/19018#pullrequestreview-2813319224 |
|
View reviewed changes
| https://github.com/python/mypy/pull/19018/files/b9503ad39fd87f9b0dc69a7d84f379a0a53fd213 |
| A5rocks | https://github.com/A5rocks |
| https://github.com/python/mypy/pull/19018#pullrequestreview-2813319224 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/19018 |
| https://github.com/sterliakov |
| sterliakov | https://github.com/sterliakov |
| May 3, 2025 | https://github.com/python/mypy/pull/19018#issuecomment-2848863793 |
| #13539 | https://github.com/python/mypy/pull/13539 |
| Please reload this page | https://github.com/python/mypy/pull/19018 |
| https://github.com/NeilGirdhar |
| NeilGirdhar | https://github.com/NeilGirdhar |
| May 9, 2025 | https://github.com/python/mypy/pull/19018#issuecomment-2866773448 |
| #17564 | https://github.com/python/mypy/issues/17564 |
| Please reload this page | https://github.com/python/mypy/pull/19018 |
| https://github.com/sterliakov |
| sterliakov | https://github.com/sterliakov |
| May 9, 2025 | https://github.com/python/mypy/pull/19018#issuecomment-2867113799 |
| Please reload this page | https://github.com/python/mypy/pull/19018 |
| @NeilGirdhar | https://github.com/NeilGirdhar |
| Please reload this page | https://github.com/python/mypy/pull/19018 |
| https://github.com/NeilGirdhar |
| NeilGirdhar | https://github.com/NeilGirdhar |
| May 9, 2025 | https://github.com/python/mypy/pull/19018#issuecomment-2867116610 |
| Please reload this page | https://github.com/python/mypy/pull/19018 |
| https://github.com/sterliakov |
| sterliakov | https://github.com/sterliakov |
| May 9, 2025 | https://github.com/python/mypy/pull/19018#issuecomment-2867154191 |
| #17564 | https://github.com/python/mypy/issues/17564 |
| Please reload this page | https://github.com/python/mypy/pull/19018 |
|
| https://github.com/sterliakov |
| Merge remote-tracking branch 'upstream/master' into bugfix/ | https://github.com/python/mypy/pull/19018/commits/61761e41fef9705a102a3201df057ff527f0057e |
| pythongh-1… | https://github.com/python/mypy/issues/19017 |
| 61761e4 | https://github.com/python/mypy/pull/19018/commits/61761e41fef9705a102a3201df057ff527f0057e |
| …9017 | https://github.com/python/mypy/issues/19017 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Jun 4, 2025 | https://github.com/python/mypy/pull/19018#issuecomment-2941837382 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/19018 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
| b147d11 | https://github.com/python/mypy/commit/b147d11b06b5a68d9a235d11885842cbbd701399 |
| Jun 5, 2025 | https://github.com/python/mypy/pull/19018#event-18000998206 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Apr 16, 2026
| https://github.com/python/mypy/pull/19018#ref-pullrequest-2535872526 |
|
Arguments without a default cannot follow attributes with one
#17785
| https://github.com/python/mypy/pull/17785 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F19018 |
|
| https://github.com/A5rocks |
|
A5rocks
| https://github.com/A5rocks |
|
| https://github.com/python/mypy/pull/19018/files/b9503ad39fd87f9b0dc69a7d84f379a0a53fd213 |
| Please reload this page | https://github.com/python/mypy/pull/19018 |
|
kw_only dataclass fields confuse mypy on argument order
| https://github.com/python/mypy/issues/19017 |
|
Attributes without a default cannot follow attributes with one
| https://github.com/python/mypy/issues/17731 |
| Please reload this page | https://github.com/python/mypy/pull/19018 |
|
| https://github.com/sterliakov |
|
| https://github.com/NeilGirdhar |
|
| https://github.com/A5rocks |
|
| https://github.com/JukkaL |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |