| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cab19122-838c-5235-c63d-f82d1949f39f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E806:3CBF1A:1F0CA9A:2A796C9:6B002112 |
| html-safe-nonce | 9f32e3a3fd3b5b1153adec5627893acfbbcab6065319c36d363d67e1f5421fc0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODA2OjNDQkYxQToxRjBDQTlBOjJBNzk2Qzk6NkIwMDIxMTIiLCJ2aXNpdG9yX2lkIjoiMzY0NzMzMDU5MjI3NTU3MDk2MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7e72c28846cf2888a7584a82b6b370eea37e62ea385726acffb25e85761e29be |
| hovercard-subject-tag | pull_request:2483013038 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/18972/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/997bf5f230df21a3111b77eec53bd5f83e8a40ce4f05f27a0e509e25ecfcf16c/python/mypy/pull/18972 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/997bf5f230df21a3111b77eec53bd5f83e8a40ce4f05f27a0e509e25ecfcf16c/python/mypy/pull/18972 |
| og:image:alt | Fixes #18967
Fixes #16494
Fixes #15793
Fixes #12949
As you can see from updated test cases, it is kind of gray area, so whether we go this way will depend on the mypy_primer results (and also poten... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ilevkivskyi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/18972#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18972 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18972 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/18972 |
| Reload | https://github.com/python/mypy/pull/18972 |
| Reload | https://github.com/python/mypy/pull/18972 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests546 (546) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:no-never-binder | https://github.com/ilevkivskyi/mypy/tree/no-never-binder |
| Conversation | https://github.com/python/mypy/pull/18972 |
| Commits1 (1) | https://github.com/python/mypy/pull/18972/commits |
| Checks | https://github.com/python/mypy/pull/18972/checks |
| Files changed | https://github.com/python/mypy/pull/18972/files |
| Do not narrow types to Never with binder | https://github.com/python/mypy/pull/18972#top |
| ilevkivskyi | https://github.com/ilevkivskyi |
| python:master | https://github.com/python/mypy/tree/master |
| ilevkivskyi:no-never-binder | https://github.com/ilevkivskyi/mypy/tree/no-never-binder |
|
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Apr 26, 2025 | https://github.com/python/mypy/pull/18972#issue-3021668468 |
| Please reload this page | https://github.com/python/mypy/pull/18972 |
| #18967 | https://github.com/python/mypy/issues/18967 |
| #16494 | https://github.com/python/mypy/issues/16494 |
| #15793 | https://github.com/python/mypy/issues/15793 |
| #12949 | https://github.com/python/mypy/issues/12949 |
| Please reload this page | https://github.com/python/mypy/pull/18972 |
|
| https://github.com/ilevkivskyi |
| Do not narrow types to Never with binder | https://github.com/python/mypy/pull/18972/commits/90787ff46e811e6e74adea950eb680e78e5bcfff |
| 90787ff | https://github.com/python/mypy/pull/18972/commits/90787ff46e811e6e74adea950eb680e78e5bcfff |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| JukkaL | https://github.com/JukkaL |
| April 26, 2025 09:42 | https://github.com/python/mypy/pull/18972#event-17415534398 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Apr 26, 2025 | https://github.com/python/mypy/pull/18972#issuecomment-2832019549 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/18972 |
| https://github.com/sterliakov |
| sterliakov | https://github.com/sterliakov |
| Apr 26, 2025 | https://github.com/python/mypy/pull/18972#issuecomment-2832446823 |
| sterliakov/mypy-issues#27 | https://github.com/sterliakov/mypy-issues/issues/27 |
| Please reload this page | https://github.com/python/mypy/pull/18972 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Apr 26, 2025 | https://github.com/python/mypy/pull/18972#issuecomment-2832547644 |
| Please reload this page | https://github.com/python/mypy/pull/18972 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Apr 29, 2025
| https://github.com/python/mypy/pull/18972#ref-issue-3020098602 |
|
Change of binder behavior whan narrowing to unrelated type
#18967
| https://github.com/python/mypy/issues/18967 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Apr 30, 2025 | https://github.com/python/mypy/pull/18972#issuecomment-2842329468 |
| @JukkaL | https://github.com/JukkaL |
| Please reload this page | https://github.com/python/mypy/pull/18972 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
Apr 30, 2025
| https://github.com/python/mypy/pull/18972#pullrequestreview-2807508242 |
|
View reviewed changes
| https://github.com/python/mypy/pull/18972/files/90787ff46e811e6e74adea950eb680e78e5bcfff |
| JukkaL | https://github.com/JukkaL |
| https://github.com/python/mypy/pull/18972#pullrequestreview-2807508242 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/18972 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| c724a6a | https://github.com/python/mypy/commit/c724a6a806655f94d0c705a7121e3d671eced96d |
| Apr 30, 2025 | https://github.com/python/mypy/pull/18972#event-17475431045 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| April 30, 2025 15:35 | https://github.com/python/mypy/pull/18972#event-17475433355 |
| jhance | https://github.com/jhance |
|
May 8, 2025
| https://github.com/python/mypy/pull/18972#ref-commit-ea8aacd |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/jhance |
| Do not narrow types to Never with binder ( | https://github.com/python/mypy/commit/ea8aacd27d8d7252ee88b5715889be03e0e88c3f |
| #18972 | https://github.com/python/mypy/pull/18972 |
| ) | https://github.com/python/mypy/commit/ea8aacd27d8d7252ee88b5715889be03e0e88c3f |
| ea8aacd | https://github.com/python/mypy/commit/ea8aacd27d8d7252ee88b5715889be03e0e88c3f |
| #18967 | https://github.com/python/mypy/issues/18967 |
| #16494 | https://github.com/python/mypy/issues/16494 |
| #15793 | https://github.com/python/mypy/issues/15793 |
| #12949 | https://github.com/python/mypy/issues/12949 |
|
[1.16 regression] determining exhaustive match on an enum with type members
#19151
| https://github.com/python/mypy/issues/19151 |
|
[1.16 regression] failure to exhaustively narrow type var bounded by union with value pattern match
#19159
| https://github.com/python/mypy/issues/19159 |
|
[1.16 regression] narrowing a typevar via comparison to None
#19166
| https://github.com/python/mypy/issues/19166 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Jun 10, 2025
| https://github.com/python/mypy/pull/18972#ref-issue-1979342441 |
|
when narrowing types on union of subtypes
#16413
| https://github.com/python/mypy/issues/16413 |
| https://github.com/brianschubert |
| brianschubert | https://github.com/brianschubert |
|
Jun 12, 2025
| https://github.com/python/mypy/pull/18972#ref-issue-3138453181 |
|
1.16 changed behavior of redefined variable to None
#19280
| https://github.com/python/mypy/issues/19280 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18972 |
|
| https://github.com/JukkaL |
|
JukkaL
| https://github.com/JukkaL |
|
| https://github.com/python/mypy/pull/18972/files/90787ff46e811e6e74adea950eb680e78e5bcfff |
| Please reload this page | https://github.com/python/mypy/pull/18972 |
|
Change of binder behavior whan narrowing to unrelated type
| https://github.com/python/mypy/issues/18967 |
|
Type-narrowing from parent to child class produces Never if inheriting from a concrete version of a generic parent class.
| https://github.com/python/mypy/issues/16494 |
|
mypy thinks value is when it isn't
| https://github.com/python/mypy/issues/15793 |
|
isinstance erases type info
| https://github.com/python/mypy/issues/12949 |
| Please reload this page | https://github.com/python/mypy/pull/18972 |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/sterliakov |
|
| https://github.com/JukkaL |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |