René's URL Explorer Experiment


Title: Do not narrow types to Never with binder by ilevkivskyi · Pull Request #18972 · python/mypy · GitHub

Open Graph Title: Do not narrow types to Never with binder by ilevkivskyi · Pull Request #18972 · python/mypy

X Title: Do not narrow types to Never with binder by ilevkivskyi · Pull Request #18972 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #18967 Fixes #16494 Fixes #15793 Fixes #12949 As you can see from updated test cases, it is kind of gray area, so whether we go this way will depend on the mypy_primer results (and also poten...

X Description: Fixes #18967 Fixes #16494 Fixes #15793 Fixes #12949 As you can see from updated test cases, it is kind of gray area, so whether we go this way will depend on the mypy_primer results (and also poten...

Opengraph URL: https://github.com/python/mypy/pull/18972

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cab19122-838c-5235-c63d-f82d1949f39f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE806:3CBF1A:1F0CA9A:2A796C9:6B002112
html-safe-nonce9f32e3a3fd3b5b1153adec5627893acfbbcab6065319c36d363d67e1f5421fc0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODA2OjNDQkYxQToxRjBDQTlBOjJBNzk2Qzk6NkIwMDIxMTIiLCJ2aXNpdG9yX2lkIjoiMzY0NzMzMDU5MjI3NTU3MDk2MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7e72c28846cf2888a7584a82b6b370eea37e62ea385726acffb25e85761e29be
hovercard-subject-tagpull_request:2483013038
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/18972/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/997bf5f230df21a3111b77eec53bd5f83e8a40ce4f05f27a0e509e25ecfcf16c/python/mypy/pull/18972
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/997bf5f230df21a3111b77eec53bd5f83e8a40ce4f05f27a0e509e25ecfcf16c/python/mypy/pull/18972
og:image:altFixes #18967 Fixes #16494 Fixes #15793 Fixes #12949 As you can see from updated test cases, it is kind of gray area, so whether we go this way will depend on the mypy_primer results (and also poten...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/18972#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18972
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18972
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/18972
Reloadhttps://github.com/python/mypy/pull/18972
Reloadhttps://github.com/python/mypy/pull/18972
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:no-never-binderhttps://github.com/ilevkivskyi/mypy/tree/no-never-binder
Conversationhttps://github.com/python/mypy/pull/18972
Commits1 (1)https://github.com/python/mypy/pull/18972/commits
Checkshttps://github.com/python/mypy/pull/18972/checks
Files changedhttps://github.com/python/mypy/pull/18972/files
Do not narrow types to Never with binderhttps://github.com/python/mypy/pull/18972#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:no-never-binderhttps://github.com/ilevkivskyi/mypy/tree/no-never-binder
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Apr 26, 2025https://github.com/python/mypy/pull/18972#issue-3021668468
Please reload this pagehttps://github.com/python/mypy/pull/18972
#18967https://github.com/python/mypy/issues/18967
#16494https://github.com/python/mypy/issues/16494
#15793https://github.com/python/mypy/issues/15793
#12949https://github.com/python/mypy/issues/12949
Please reload this pagehttps://github.com/python/mypy/pull/18972
https://github.com/ilevkivskyi
Do not narrow types to Never with binderhttps://github.com/python/mypy/pull/18972/commits/90787ff46e811e6e74adea950eb680e78e5bcfff
90787ffhttps://github.com/python/mypy/pull/18972/commits/90787ff46e811e6e74adea950eb680e78e5bcfff
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
JukkaLhttps://github.com/JukkaL
April 26, 2025 09:42https://github.com/python/mypy/pull/18972#event-17415534398
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 26, 2025https://github.com/python/mypy/pull/18972#issuecomment-2832019549
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/18972
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
Apr 26, 2025https://github.com/python/mypy/pull/18972#issuecomment-2832446823
sterliakov/mypy-issues#27https://github.com/sterliakov/mypy-issues/issues/27
Please reload this pagehttps://github.com/python/mypy/pull/18972
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Apr 26, 2025https://github.com/python/mypy/pull/18972#issuecomment-2832547644
Please reload this pagehttps://github.com/python/mypy/pull/18972
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Apr 29, 2025 https://github.com/python/mypy/pull/18972#ref-issue-3020098602
Change of binder behavior whan narrowing to unrelated type #18967 https://github.com/python/mypy/issues/18967
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Apr 30, 2025https://github.com/python/mypy/pull/18972#issuecomment-2842329468
@JukkaLhttps://github.com/JukkaL
Please reload this pagehttps://github.com/python/mypy/pull/18972
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Apr 30, 2025 https://github.com/python/mypy/pull/18972#pullrequestreview-2807508242
View reviewed changes https://github.com/python/mypy/pull/18972/files/90787ff46e811e6e74adea950eb680e78e5bcfff
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/18972#pullrequestreview-2807508242
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/18972
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
c724a6ahttps://github.com/python/mypy/commit/c724a6a806655f94d0c705a7121e3d671eced96d
Apr 30, 2025https://github.com/python/mypy/pull/18972#event-17475431045
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
April 30, 2025 15:35https://github.com/python/mypy/pull/18972#event-17475433355
jhancehttps://github.com/jhance
May 8, 2025 https://github.com/python/mypy/pull/18972#ref-commit-ea8aacd
https://github.com/ilevkivskyi
https://github.com/jhance
Do not narrow types to Never with binder (https://github.com/python/mypy/commit/ea8aacd27d8d7252ee88b5715889be03e0e88c3f
#18972https://github.com/python/mypy/pull/18972
)https://github.com/python/mypy/commit/ea8aacd27d8d7252ee88b5715889be03e0e88c3f
ea8aacdhttps://github.com/python/mypy/commit/ea8aacd27d8d7252ee88b5715889be03e0e88c3f
#18967https://github.com/python/mypy/issues/18967
#16494https://github.com/python/mypy/issues/16494
#15793https://github.com/python/mypy/issues/15793
#12949https://github.com/python/mypy/issues/12949
[1.16 regression] determining exhaustive match on an enum with type members #19151 https://github.com/python/mypy/issues/19151
[1.16 regression] failure to exhaustively narrow type var bounded by union with value pattern match #19159 https://github.com/python/mypy/issues/19159
[1.16 regression] narrowing a typevar via comparison to None #19166 https://github.com/python/mypy/issues/19166
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jun 10, 2025 https://github.com/python/mypy/pull/18972#ref-issue-1979342441
when narrowing types on union of subtypes #16413 https://github.com/python/mypy/issues/16413
https://github.com/brianschubert
brianschuberthttps://github.com/brianschubert
Jun 12, 2025 https://github.com/python/mypy/pull/18972#ref-issue-3138453181
1.16 changed behavior of redefined variable to None #19280 https://github.com/python/mypy/issues/19280
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18972
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/18972/files/90787ff46e811e6e74adea950eb680e78e5bcfff
Please reload this pagehttps://github.com/python/mypy/pull/18972
Change of binder behavior whan narrowing to unrelated type https://github.com/python/mypy/issues/18967
Type-narrowing from parent to child class produces Never if inheriting from a concrete version of a generic parent class. https://github.com/python/mypy/issues/16494
mypy thinks value is when it isn't https://github.com/python/mypy/issues/15793
isinstance erases type info https://github.com/python/mypy/issues/12949
Please reload this pagehttps://github.com/python/mypy/pull/18972
https://github.com/ilevkivskyi
https://github.com/sterliakov
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.