René's URL Explorer Experiment


Title: Exclude irrelevant members in `narrow_declared_type` from union overlapping with enum by sterliakov · Pull Request #18897 · python/mypy · GitHub

Open Graph Title: Exclude irrelevant members in `narrow_declared_type` from union overlapping with enum by sterliakov · Pull Request #18897 · python/mypy

X Title: Exclude irrelevant members in `narrow_declared_type` from union overlapping with enum by sterliakov · Pull Request #18897 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #18895. The original implementation of that block was introduced as a performance optimization in #12032. It's in fact incorrect: it produces overly optimistic meets, assuming that any ma...

X Description: Fixes #18895. The original implementation of that block was introduced as a performance optimization in #12032. It's in fact incorrect: it produces overly optimistic meets, assuming that an...

Opengraph URL: https://github.com/python/mypy/pull/18897

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7febf774-c087-1f6f-6c54-831c683f91ac
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC806:11BB24:2178A87:2D68E24:6B001F95
html-safe-nonce862f43385065a9fa22a435dcf7cdde0b35d67ba16925a5a02fdfa1611e54fe51
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODA2OjExQkIyNDoyMTc4QTg3OjJENjhFMjQ6NkIwMDFGOTUiLCJ2aXNpdG9yX2lkIjoiNTQ4OTI1Mzc2OTg2ODc0NjY0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac93163f5b63252d92125ad5cd4109528aa59545de0e11e98c74c3a3e93b91d0d4
hovercard-subject-tagpull_request:2444147937
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/18897/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/15d238b9a7ef0257afdb9bd980125c7933f6dec8670e6acd690a550eedad1af6/python/mypy/pull/18897
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/15d238b9a7ef0257afdb9bd980125c7933f6dec8670e6acd690a550eedad1af6/python/mypy/pull/18897
og:image:altFixes #18895. The original implementation of that block was introduced as a performance optimization in #12032. It's in fact incorrect: it produces overly optimistic meets, assuming that any ma...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesterliakov
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/18897#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18897
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18897
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/18897
Reloadhttps://github.com/python/mypy/pull/18897
Reloadhttps://github.com/python/mypy/pull/18897
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
sobolevnhttps://github.com/sobolevn
python:masterhttps://github.com/python/mypy/tree/master
sterliakov:masterhttps://github.com/sterliakov/mypy/tree/master
Conversationhttps://github.com/python/mypy/pull/18897
Commits6 (6)https://github.com/python/mypy/pull/18897/commits
Checkshttps://github.com/python/mypy/pull/18897/checks
Files changedhttps://github.com/python/mypy/pull/18897/files
Exclude irrelevant members in narrow_declared_type from union overlapping with enumhttps://github.com/python/mypy/pull/18897#top
sobolevnhttps://github.com/sobolevn
python:masterhttps://github.com/python/mypy/tree/master
sterliakov:masterhttps://github.com/sterliakov/mypy/tree/master
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
Apr 7, 2025https://github.com/python/mypy/pull/18897#issue-2977785308
Please reload this pagehttps://github.com/python/mypy/pull/18897
#18895https://github.com/python/mypy/issues/18895
#12032https://github.com/python/mypy/pull/12032
#18895https://github.com/python/mypy/issues/18895
Please reload this pagehttps://github.com/python/mypy/pull/18897
sterliakovhttps://github.com/sterliakov
April 7, 2025 21:20https://github.com/python/mypy/pull/18897#commits-pushed-274789c
https://github.com/sterliakov
Do not leak TypeGuardedType from narrow_declared_type with enumshttps://github.com/python/mypy/pull/18897/commits/274789caece4686606e78c60f9a9e4fd8cfec672
274789chttps://github.com/python/mypy/pull/18897/commits/274789caece4686606e78c60f9a9e4fd8cfec672
https://github.com/sterliakov
Restore error backhttps://github.com/python/mypy/pull/18897/commits/aa219cff7eea6ffb79d238fb419fb408bdcad5fb
aa219cfhttps://github.com/python/mypy/pull/18897/commits/aa219cff7eea6ffb79d238fb419fb408bdcad5fb
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
April 7, 2025 19:30https://github.com/python/mypy/pull/18897#event-17159405860
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18897
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
Apr 8, 2025https://github.com/python/mypy/pull/18897#event-17174213683
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
Apr 8, 2025https://github.com/python/mypy/pull/18897#issuecomment-2787003457
Please reload this pagehttps://github.com/python/mypy/pull/18897
@sobolevnhttps://github.com/sobolevn
#12032https://github.com/python/mypy/pull/12032
Please reload this pagehttps://github.com/python/mypy/pull/18897
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Apr 8, 2025 https://github.com/python/mypy/pull/18897#pullrequestreview-2750789019
View reviewed changes https://github.com/python/mypy/pull/18897/files/aa219cff7eea6ffb79d238fb419fb408bdcad5fb
test-data/unit/check-typeguard.testhttps://github.com/python/mypy/pull/18897/files/aa219cff7eea6ffb79d238fb419fb408bdcad5fb#diff-ad4f23953abd6459e54da402b4ee3f0c62562fe8a606fb0f73fa57ebb196e3d1
Please reload this pagehttps://github.com/python/mypy/pull/18897
sterliakovhttps://github.com/sterliakov
April 9, 2025 15:21https://github.com/python/mypy/pull/18897#commits-pushed-4e59a14
https://github.com/sterliakov
Merge remote-tracking branch 'upstream/master'https://github.com/python/mypy/pull/18897/commits/4e59a14d50740011e115c21bb0413d78fc1d1224
4e59a14https://github.com/python/mypy/pull/18897/commits/4e59a14d50740011e115c21bb0413d78fc1d1224
https://github.com/sterliakov
Remove error from the test again, fixed separatelyhttps://github.com/python/mypy/pull/18897/commits/ac0d9cb51ee01852beb9741d466d94080edec66a
ac0d9cbhttps://github.com/python/mypy/pull/18897/commits/ac0d9cb51ee01852beb9741d466d94080edec66a
https://github.com/sterliakov
Add an explicit test for changed behaviour of enum/union overlaphttps://github.com/python/mypy/pull/18897/commits/b3b5f922dcb673f59f853a6db701b1260aa5d286
b3b5f92https://github.com/python/mypy/pull/18897/commits/b3b5f922dcb673f59f853a6db701b1260aa5d286
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Apr 9, 2025 https://github.com/python/mypy/pull/18897#pullrequestreview-2753521811
View reviewed changes https://github.com/python/mypy/pull/18897/files/b3b5f922dcb673f59f853a6db701b1260aa5d286
test-data/unit/check-typeguard.testhttps://github.com/python/mypy/pull/18897/files/aa219cff7eea6ffb79d238fb419fb408bdcad5fb..b3b5f922dcb673f59f853a6db701b1260aa5d286#diff-ad4f23953abd6459e54da402b4ee3f0c62562fe8a606fb0f73fa57ebb196e3d1
Please reload this pagehttps://github.com/python/mypy/pull/18897
test-data/unit/check-typeis.testhttps://github.com/python/mypy/pull/18897/files/aa219cff7eea6ffb79d238fb419fb408bdcad5fb..b3b5f922dcb673f59f853a6db701b1260aa5d286#diff-b6daa571602110b066888622002caea3654556d248977faf0f2a5813ec53e630
Please reload this pagehttps://github.com/python/mypy/pull/18897
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18897
https://github.com/sterliakov
Address review commentshttps://github.com/python/mypy/pull/18897/commits/c8bd14800b255d13ef9fca2399cd3448fd7ef699
c8bd148https://github.com/python/mypy/pull/18897/commits/c8bd14800b255d13ef9fca2399cd3448fd7ef699
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 9, 2025https://github.com/python/mypy/pull/18897#issuecomment-2789903134
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/18897
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Apr 9, 2025 https://github.com/python/mypy/pull/18897#pullrequestreview-2753679365
View reviewed changes https://github.com/python/mypy/pull/18897/files/c8bd14800b255d13ef9fca2399cd3448fd7ef699
sobolevnhttps://github.com/sobolevn
https://github.com/python/mypy/pull/18897#pullrequestreview-2753679365
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/18897
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
b5c95d8https://github.com/python/mypy/commit/b5c95d84b4ac2940618251ed3ec48f46ba0662a0
Apr 11, 2025https://github.com/python/mypy/pull/18897#event-17219805102
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18897
https://github.com/sobolevn
sobolevn https://github.com/sobolevn
https://github.com/python/mypy/pull/18897/files/c8bd14800b255d13ef9fca2399cd3448fd7ef699
Please reload this pagehttps://github.com/python/mypy/pull/18897
Internal error with TypeGuard and Literal-based union narrowing using StrEnum https://github.com/python/mypy/issues/18895
Please reload this pagehttps://github.com/python/mypy/pull/18897
https://github.com/sterliakov
https://github.com/sobolevn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.