René's URL Explorer Experiment


Title: Fix crash on decorated getter in settable property by ilevkivskyi · Pull Request #18787 · python/mypy · GitHub

Open Graph Title: Fix crash on decorated getter in settable property by ilevkivskyi · Pull Request #18787 · python/mypy

X Title: Fix crash on decorated getter in settable property by ilevkivskyi · Pull Request #18787 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Follow up for #18774 Fix for crash is trivial, properly handle getter the same way as setter. Note I also consistently handle callable instances. cc @cdce8p could you please check this branch?

X Description: Follow up for #18774 Fix for crash is trivial, properly handle getter the same way as setter. Note I also consistently handle callable instances. cc @cdce8p could you please check this branch?

Opengraph URL: https://github.com/python/mypy/pull/18787

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3ed968bb-010e-0f1c-2c41-8181c09800fe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD64E:15B2A:70F6B:9935A:6B0018C7
html-safe-nonce6542fe7ca4a64da94b2c496ccb650085606a62db9d53e8605b602615e05c8acd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjRFOjE1QjJBOjcwRjZCOjk5MzVBOjZCMDAxOEM3IiwidmlzaXRvcl9pZCI6IjU4NTcwNjcyMzE0MzA1ODA0MjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc9a909a1762b1c79243fb49cd4f35634e95669a495d54f55871429f470febc5c
hovercard-subject-tagpull_request:2385325257
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/18787/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/94c94401d0af053677c514e8a9dd0947f99a6611d03524bf638663409bea6c2e/python/mypy/pull/18787
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/94c94401d0af053677c514e8a9dd0947f99a6611d03524bf638663409bea6c2e/python/mypy/pull/18787
og:image:altFollow up for #18774 Fix for crash is trivial, properly handle getter the same way as setter. Note I also consistently handle callable instances. cc @cdce8p could you please check this branch?
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
Nonea2dd2291b1b13cc9c06f27ec92fa3dbaf34116fc24c9347b8539db61884c59f4
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release70121d4e855ee0bb7b75cf15d061d91f8863c0f8
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/18787#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18787
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18787
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/18787
Reloadhttps://github.com/python/mypy/pull/18787
Reloadhttps://github.com/python/mypy/pull/18787
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:settable-property-type-getterhttps://github.com/ilevkivskyi/mypy/tree/settable-property-type-getter
Conversationhttps://github.com/python/mypy/pull/18787
Commits1 (1)https://github.com/python/mypy/pull/18787/commits
Checkshttps://github.com/python/mypy/pull/18787/checks
Files changedhttps://github.com/python/mypy/pull/18787/files
Fix crash on decorated getter in settable propertyhttps://github.com/python/mypy/pull/18787#top
JukkaLhttps://github.com/JukkaL
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:settable-property-type-getterhttps://github.com/ilevkivskyi/mypy/tree/settable-property-type-getter
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Mar 11, 2025https://github.com/python/mypy/pull/18787#issue-2910762637
#18774https://github.com/python/mypy/pull/18774
@cdce8phttps://github.com/cdce8p
Please reload this pagehttps://github.com/python/mypy/pull/18787
https://github.com/ilevkivskyi
Fix crash on decorated getter in settable propertyhttps://github.com/python/mypy/pull/18787/commits/a38f880f40e70649f976e80dacdb65d8a6d77c03
a38f880https://github.com/python/mypy/pull/18787/commits/a38f880f40e70649f976e80dacdb65d8a6d77c03
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
JukkaLhttps://github.com/JukkaL
hauntsaninjahttps://github.com/hauntsaninja
March 11, 2025 14:25https://github.com/python/mypy/pull/18787#event-16688306140
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Mar 11, 2025https://github.com/python/mypy/pull/18787#issuecomment-2714623955
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/18787
https://github.com/cdce8p
cdce8phttps://github.com/cdce8p
Mar 11, 2025https://github.com/python/mypy/pull/18787#issuecomment-2714807037
Please reload this pagehttps://github.com/python/mypy/pull/18787
@cdce8phttps://github.com/cdce8p
@ilevkivskyihttps://github.com/ilevkivskyi
Please reload this pagehttps://github.com/python/mypy/pull/18787
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
Mar 11, 2025 https://github.com/python/mypy/pull/18787#pullrequestreview-2675452451
View reviewed changes https://github.com/python/mypy/pull/18787/files/a38f880f40e70649f976e80dacdb65d8a6d77c03
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/18787#pullrequestreview-2675452451
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/18787
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
0f5ddd5https://github.com/python/mypy/commit/0f5ddd5e647d14afca93d3f41892b62af302e894
Mar 11, 2025https://github.com/python/mypy/pull/18787#event-16693573053
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
March 11, 2025 17:13https://github.com/python/mypy/pull/18787#event-16693674898
https://github.com/davidhalter
davidhalterhttps://github.com/davidhalter
Apr 20, 2025 https://github.com/python/mypy/pull/18787#pullrequestreview-2780350826
View reviewed changes https://github.com/python/mypy/pull/18787/files/a38f880f40e70649f976e80dacdb65d8a6d77c03
test-data/unit/check-classes.testhttps://github.com/python/mypy/pull/18787/files/a38f880f40e70649f976e80dacdb65d8a6d77c03#diff-1c26dc582ed5f36723414080dfb646bc71cf20736b73ae1ccff9b90a5d3befaf
davidhalterhttps://github.com/davidhalter
Apr 20, 2025https://github.com/python/mypy/pull/18787#discussion_r2051824223
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/18787
cdce8phttps://github.com/cdce8p
Apr 21, 2025https://github.com/python/mypy/pull/18787#discussion_r2052257983
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#18946https://github.com/python/mypy/pull/18946
Please reload this pagehttps://github.com/python/mypy/pull/18787
https://github.com/cdce8p
cdce8phttps://github.com/cdce8p
Apr 21, 2025 https://github.com/python/mypy/pull/18787#ref-pullrequest-3008155262
Fix typo in testPropertySetterDecorated #18946 https://github.com/python/mypy/pull/18946
ilevkivskyihttps://github.com/ilevkivskyi
Apr 26, 2025 https://github.com/python/mypy/pull/18787#ref-commit-6aec4b8
https://github.com/cdce8p
Fix typo in testPropertySetterDecorated (https://github.com/python/mypy/commit/6aec4b8617c6041649213152a32581e0f7812c0c
#18946https://github.com/python/mypy/pull/18946
)https://github.com/python/mypy/commit/6aec4b8617c6041649213152a32581e0f7812c0c
6aec4b8https://github.com/python/mypy/commit/6aec4b8617c6041649213152a32581e0f7812c0c
#18787 (comment)https://github.com/python/mypy/pull/18787#discussion_r2051824223
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18787
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/18787/files/a38f880f40e70649f976e80dacdb65d8a6d77c03
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/davidhalter
davidhalter https://github.com/davidhalter
https://github.com/python/mypy/pull/18787/files/a38f880f40e70649f976e80dacdb65d8a6d77c03
https://github.com/cdce8p
cdce8p https://github.com/cdce8p
https://github.com/python/mypy/pull/18787/files/a38f880f40e70649f976e80dacdb65d8a6d77c03
Please reload this pagehttps://github.com/python/mypy/pull/18787
Please reload this pagehttps://github.com/python/mypy/pull/18787
https://github.com/ilevkivskyi
https://github.com/cdce8p
https://github.com/davidhalter
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.