René's URL Explorer Experiment


Title: use is_same_type when determining if a cast is redundant by asottile · Pull Request #18588 · python/mypy · GitHub

Open Graph Title: use is_same_type when determining if a cast is redundant by asottile · Pull Request #18588 · python/mypy

X Title: use is_same_type when determining if a cast is redundant by asottile · Pull Request #18588 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: while working on #18540 (which my original prototype based the code on warn-redundant-casts) I noticed the suggestion here would probably make sense to apply to redundant-cast as well! I also made ...

X Description: while working on #18540 (which my original prototype based the code on warn-redundant-casts) I noticed the suggestion here would probably make sense to apply to redundant-cast as well! I also made ...

Opengraph URL: https://github.com/python/mypy/pull/18588

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d834ed0b-da04-63bd-4145-44ac8f62cf21
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF5A:47016:2955A0:372B14:6B009D18
html-safe-nonce49c5f3c5f7e9e4494eaafb41c9eda3009ef26783da5ac598693f90dae4c0cb5c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjVBOjQ3MDE2OjI5NTVBMDozNzJCMTQ6NkIwMDlEMTgiLCJ2aXNpdG9yX2lkIjoiODA3OTkzMDM0MjkwOTE4OTQwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac27084f9e6e41948d7845232af4d48f4d2221607e2894528ea2ae99541aac983e
hovercard-subject-tagpull_request:2311376217
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/18588/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/90227a25ea7867dd3e69530e6c32ee6b76736dadb903bbb1102922a7fb148939/python/mypy/pull/18588
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/90227a25ea7867dd3e69530e6c32ee6b76736dadb903bbb1102922a7fb148939/python/mypy/pull/18588
og:image:altwhile working on #18540 (which my original prototype based the code on warn-redundant-casts) I noticed the suggestion here would probably make sense to apply to redundant-cast as well! I also made ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameasottile
hostnamegithub.com
expected-hostnamegithub.com
None52c95ce7e48016ae14399656b4ee812462b6f1fa28c5008c8394da64794c00b8
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1c9ddec8215f9a94e295c8310c3579b9c54ba31a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/18588#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18588
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18588
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/18588
Reloadhttps://github.com/python/mypy/pull/18588
Reloadhttps://github.com/python/mypy/pull/18588
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests543 (543)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
asottile:redundant-casts-same-typehttps://github.com/asottile/mypy/tree/redundant-casts-same-type
Conversationhttps://github.com/python/mypy/pull/18588
Commits2 (2)https://github.com/python/mypy/pull/18588/commits
Checkshttps://github.com/python/mypy/pull/18588/checks
Files changedhttps://github.com/python/mypy/pull/18588/files
use is_same_type when determining if a cast is redundanthttps://github.com/python/mypy/pull/18588#top
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
asottile:redundant-casts-same-typehttps://github.com/asottile/mypy/tree/redundant-casts-same-type
https://github.com/asottile
asottilehttps://github.com/asottile
Feb 2, 2025https://github.com/python/mypy/pull/18588#issue-2825966593
#18540https://github.com/python/mypy/issues/18540
herehttps://github.com/python/mypy/issues/18540#issuecomment-2615574503
original implementationhttps://github.com/python/mypy/pull/1705#issue-159944226
Please reload this pagehttps://github.com/python/mypy/pull/18588
https://github.com/asottile
use is_same_type when determining if a cast is redundanthttps://github.com/python/mypy/pull/18588/commits/d87bac9ad96ab05333873de94a5da5e55a2b1c6f
d87bac9https://github.com/python/mypy/pull/18588/commits/d87bac9ad96ab05333873de94a5da5e55a2b1c6f
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18588
https://github.com/asottile
asottilehttps://github.com/asottile
Feb 2, 2025https://github.com/python/mypy/pull/18588#issuecomment-2629548689
Please reload this pagehttps://github.com/python/mypy/pull/18588
https://github.com/asottile
asottilehttps://github.com/asottile
February 2, 2025 20:53https://github.com/python/mypy/pull/18588#event-16153645145
https://github.com/asottile
don't report warn-redundant-cast to cast of Union of Anyhttps://github.com/python/mypy/pull/18588/commits/ffab4d41e73c93eb8dd3cb5e87fdc72842d910d6
ffab4d4https://github.com/python/mypy/pull/18588/commits/ffab4d41e73c93eb8dd3cb5e87fdc72842d910d6
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Feb 2, 2025https://github.com/python/mypy/pull/18588#issuecomment-2629557726
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/18588
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
Apr 20, 2025 https://github.com/python/mypy/pull/18588#pullrequestreview-2780320613
View reviewed changes https://github.com/python/mypy/pull/18588/files/ffab4d41e73c93eb8dd3cb5e87fdc72842d910d6
sterliakovhttps://github.com/sterliakov
https://github.com/python/mypy/pull/18588#pullrequestreview-2780320613
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#12328https://github.com/python/mypy/issues/12328
Please reload this pagehttps://github.com/python/mypy/pull/18588
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Apr 22, 2025 https://github.com/python/mypy/pull/18588#pullrequestreview-2782662687
View reviewed changes https://github.com/python/mypy/pull/18588/files/ffab4d41e73c93eb8dd3cb5e87fdc72842d910d6
hauntsaninjahttps://github.com/hauntsaninja
https://github.com/python/mypy/pull/18588#pullrequestreview-2782662687
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/18588
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
057f8adhttps://github.com/python/mypy/commit/057f8ad6b5298ae44e11c2e3592b1b14cd21b414
Apr 22, 2025https://github.com/python/mypy/pull/18588#event-17346143269
https://github.com/asottile
asottilehttps://github.com/asottile
April 22, 2025 10:33https://github.com/python/mypy/pull/18588#event-17351509001
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
May 8, 2025 https://github.com/python/mypy/pull/18588#ref-issue-3049602773
Regression: false positive avoid redundant cast with literal union #19055 https://github.com/python/mypy/issues/19055
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
May 30, 2025 https://github.com/python/mypy/pull/18588#ref-issue-3102204942
[1.16 regression] a cast is both needed and redundant at the same time #19170 https://github.com/python/mypy/issues/19170
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18588
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/python/mypy/pull/18588/files/ffab4d41e73c93eb8dd3cb5e87fdc72842d910d6
https://github.com/sterliakov
sterliakov https://github.com/sterliakov
https://github.com/python/mypy/pull/18588/files/ffab4d41e73c93eb8dd3cb5e87fdc72842d910d6
Please reload this pagehttps://github.com/python/mypy/pull/18588
Please reload this pagehttps://github.com/python/mypy/pull/18588
https://github.com/asottile
https://github.com/hauntsaninja
https://github.com/sterliakov
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.