| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d834ed0b-da04-63bd-4145-44ac8f62cf21 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DF5A:47016:2955A0:372B14:6B009D18 |
| html-safe-nonce | 49c5f3c5f7e9e4494eaafb41c9eda3009ef26783da5ac598693f90dae4c0cb5c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjVBOjQ3MDE2OjI5NTVBMDozNzJCMTQ6NkIwMDlEMTgiLCJ2aXNpdG9yX2lkIjoiODA3OTkzMDM0MjkwOTE4OTQwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 27084f9e6e41948d7845232af4d48f4d2221607e2894528ea2ae99541aac983e |
| hovercard-subject-tag | pull_request:2311376217 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/18588/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/90227a25ea7867dd3e69530e6c32ee6b76736dadb903bbb1102922a7fb148939/python/mypy/pull/18588 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/90227a25ea7867dd3e69530e6c32ee6b76736dadb903bbb1102922a7fb148939/python/mypy/pull/18588 |
| og:image:alt | while working on #18540 (which my original prototype based the code on warn-redundant-casts) I noticed the suggestion here would probably make sense to apply to redundant-cast as well!
I also made ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | asottile |
| hostname | github.com |
| expected-hostname | github.com |
| None | 52c95ce7e48016ae14399656b4ee812462b6f1fa28c5008c8394da64794c00b8 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1c9ddec8215f9a94e295c8310c3579b9c54ba31a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/mypy/pull/18588#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18588 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18588 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy |
| Reload | https://github.com/python/mypy/pull/18588 |
| Reload | https://github.com/python/mypy/pull/18588 |
| Reload | https://github.com/python/mypy/pull/18588 |
| python | https://github.com/python |
| mypy | https://github.com/python/mypy |
| Code | https://github.com/python/mypy |
| Issues2.7k (2.7k) | https://github.com/python/mypy/issues |
| Pull requests543 (543) | https://github.com/python/mypy/pulls |
| Actions | https://github.com/python/mypy/actions |
| Projects | https://github.com/python/mypy/projects |
| Wiki | https://github.com/python/mypy/wiki |
| Security and quality | https://github.com/python/mypy/security |
| Insights | https://github.com/python/mypy/insights |
| https://github.com/python/mypy |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| asottile:redundant-casts-same-type | https://github.com/asottile/mypy/tree/redundant-casts-same-type |
| Conversation | https://github.com/python/mypy/pull/18588 |
| Commits2 (2) | https://github.com/python/mypy/pull/18588/commits |
| Checks | https://github.com/python/mypy/pull/18588/checks |
| Files changed | https://github.com/python/mypy/pull/18588/files |
| use is_same_type when determining if a cast is redundant | https://github.com/python/mypy/pull/18588#top |
| hauntsaninja | https://github.com/hauntsaninja |
| python:master | https://github.com/python/mypy/tree/master |
| asottile:redundant-casts-same-type | https://github.com/asottile/mypy/tree/redundant-casts-same-type |
|
| https://github.com/asottile |
| asottile | https://github.com/asottile |
| Feb 2, 2025 | https://github.com/python/mypy/pull/18588#issue-2825966593 |
| #18540 | https://github.com/python/mypy/issues/18540 |
| here | https://github.com/python/mypy/issues/18540#issuecomment-2615574503 |
| original implementation | https://github.com/python/mypy/pull/1705#issue-159944226 |
| Please reload this page | https://github.com/python/mypy/pull/18588 |
|
| https://github.com/asottile |
| use is_same_type when determining if a cast is redundant | https://github.com/python/mypy/pull/18588/commits/d87bac9ad96ab05333873de94a5da5e55a2b1c6f |
| d87bac9 | https://github.com/python/mypy/pull/18588/commits/d87bac9ad96ab05333873de94a5da5e55a2b1c6f |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18588 |
| https://github.com/asottile |
| asottile | https://github.com/asottile |
| Feb 2, 2025 | https://github.com/python/mypy/pull/18588#issuecomment-2629548689 |
| Please reload this page | https://github.com/python/mypy/pull/18588 |
| https://github.com/asottile |
| asottile | https://github.com/asottile |
| February 2, 2025 20:53 | https://github.com/python/mypy/pull/18588#event-16153645145 |
|
| https://github.com/asottile |
| don't report warn-redundant-cast to cast of Union of Any | https://github.com/python/mypy/pull/18588/commits/ffab4d41e73c93eb8dd3cb5e87fdc72842d910d6 |
| ffab4d4 | https://github.com/python/mypy/pull/18588/commits/ffab4d41e73c93eb8dd3cb5e87fdc72842d910d6 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Feb 2, 2025 | https://github.com/python/mypy/pull/18588#issuecomment-2629557726 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/mypy/pull/18588 |
| https://github.com/sterliakov |
| sterliakov | https://github.com/sterliakov |
|
Apr 20, 2025
| https://github.com/python/mypy/pull/18588#pullrequestreview-2780320613 |
|
View reviewed changes
| https://github.com/python/mypy/pull/18588/files/ffab4d41e73c93eb8dd3cb5e87fdc72842d910d6 |
| sterliakov | https://github.com/sterliakov |
| https://github.com/python/mypy/pull/18588#pullrequestreview-2780320613 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #12328 | https://github.com/python/mypy/issues/12328 |
| Please reload this page | https://github.com/python/mypy/pull/18588 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Apr 22, 2025
| https://github.com/python/mypy/pull/18588#pullrequestreview-2782662687 |
|
View reviewed changes
| https://github.com/python/mypy/pull/18588/files/ffab4d41e73c93eb8dd3cb5e87fdc72842d910d6 |
| hauntsaninja | https://github.com/hauntsaninja |
| https://github.com/python/mypy/pull/18588#pullrequestreview-2782662687 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/mypy/pull/18588 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| 057f8ad | https://github.com/python/mypy/commit/057f8ad6b5298ae44e11c2e3592b1b14cd21b414 |
| Apr 22, 2025 | https://github.com/python/mypy/pull/18588#event-17346143269 |
| https://github.com/asottile |
| asottile | https://github.com/asottile |
| April 22, 2025 10:33 | https://github.com/python/mypy/pull/18588#event-17351509001 |
| https://github.com/JukkaL |
| JukkaL | https://github.com/JukkaL |
|
May 8, 2025
| https://github.com/python/mypy/pull/18588#ref-issue-3049602773 |
|
Regression: false positive avoid redundant cast with literal union
#19055
| https://github.com/python/mypy/issues/19055 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
May 30, 2025
| https://github.com/python/mypy/pull/18588#ref-issue-3102204942 |
|
[1.16 regression] a cast is both needed and redundant at the same time
#19170
| https://github.com/python/mypy/issues/19170 |
| https://github.co/hiddenchars |
| https://github.com/python/mypy/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18588 |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/mypy/pull/18588/files/ffab4d41e73c93eb8dd3cb5e87fdc72842d910d6 |
|
| https://github.com/sterliakov |
|
sterliakov
| https://github.com/sterliakov |
|
| https://github.com/python/mypy/pull/18588/files/ffab4d41e73c93eb8dd3cb5e87fdc72842d910d6 |
| Please reload this page | https://github.com/python/mypy/pull/18588 |
| Please reload this page | https://github.com/python/mypy/pull/18588 |
|
| https://github.com/asottile |
|
| https://github.com/hauntsaninja |
|
| https://github.com/sterliakov |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |