René's URL Explorer Experiment


Title: Fix literal context for ternary expressions (for real) by ilevkivskyi · Pull Request #18545 · python/mypy · GitHub

Open Graph Title: Fix literal context for ternary expressions (for real) by ilevkivskyi · Pull Request #18545 · python/mypy

X Title: Fix literal context for ternary expressions (for real) by ilevkivskyi · Pull Request #18545 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: I am not waiting for review as the fix is obvious. The only annoying thing is that we had an exact test as in the repro but it passed accidentally because we use builtins fixtures.

X Description: I am not waiting for review as the fix is obvious. The only annoying thing is that we had an exact test as in the repro but it passed accidentally because we use builtins fixtures.

Opengraph URL: https://github.com/python/mypy/pull/18545

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:89714b9d-fc1e-d869-f844-ff3ac29283ce
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A9E:B1603:1CD4898:252FE92:6AFFCA80
html-safe-nonce2f37afbe902e7cb597b831e5d249206be63f9471b14e41b8e14ea30a76f1beb9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTlFOkIxNjAzOjFDRDQ4OTg6MjUyRkU5Mjo2QUZGQ0E4MCIsInZpc2l0b3JfaWQiOiI4MjY5NDA4MzkxNDQ5NzkxMTA0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5534237ba2faf2884063b7c89572388dd5b6dae17712ef7707157f5e2b218222
hovercard-subject-tagpull_request:2299538177
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/18545/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/445aa58744a070c51484e3319742513acebf790d663a00d3675da3135fd7403d/python/mypy/pull/18545
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/445aa58744a070c51484e3319742513acebf790d663a00d3675da3135fd7403d/python/mypy/pull/18545
og:image:altI am not waiting for review as the fix is obvious. The only annoying thing is that we had an exact test as in the repro but it passed accidentally because we use builtins fixtures.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/18545#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18545
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18545
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/18545
Reloadhttps://github.com/python/mypy/pull/18545
Reloadhttps://github.com/python/mypy/pull/18545
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:fix-literal-ternary-for-realhttps://github.com/ilevkivskyi/mypy/tree/fix-literal-ternary-for-real
Conversationhttps://github.com/python/mypy/pull/18545
Commits1 (1)https://github.com/python/mypy/pull/18545/commits
Checkshttps://github.com/python/mypy/pull/18545/checks
Files changedhttps://github.com/python/mypy/pull/18545/files
Fix literal context for ternary expressions (for real)https://github.com/python/mypy/pull/18545#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
ilevkivskyi:fix-literal-ternary-for-realhttps://github.com/ilevkivskyi/mypy/tree/fix-literal-ternary-for-real
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Jan 27, 2025https://github.com/python/mypy/pull/18545#issue-2812613848
Please reload this pagehttps://github.com/python/mypy/pull/18545
https://github.com/ilevkivskyi
Fix literal context for ternary expressions (for real)https://github.com/python/mypy/pull/18545/commits/13916c85233c78eee5d4b3c224ac95ec60625f60
13916c8https://github.com/python/mypy/pull/18545/commits/13916c85233c78eee5d4b3c224ac95ec60625f60
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
JukkaLhttps://github.com/JukkaL
January 27, 2025 10:21https://github.com/python/mypy/pull/18545#event-16075581395
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Jan 27, 2025 https://github.com/python/mypy/pull/18545#ref-issue-2608228333
[1.12] Regression in is None narrowing #18021 https://github.com/python/mypy/issues/18021
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jan 27, 2025https://github.com/python/mypy/pull/18545#issuecomment-2615402921
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/18545
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
16e19f8https://github.com/python/mypy/commit/16e19f8fd435d0b87ad2ec11137964065410a43d
Jan 27, 2025https://github.com/python/mypy/pull/18545#event-16076058337
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
January 27, 2025 10:58https://github.com/python/mypy/pull/18545#event-16076058940
https://github.com/Dreamsorcerer
Dreamsorcererhttps://github.com/Dreamsorcerer
Jan 27, 2025 https://github.com/python/mypy/pull/18545#ref-issue-2797698178
1.15 Release Tracking Issue #18487 https://github.com/python/mypy/issues/18487
wesleywrighthttps://github.com/wesleywright
Jan 27, 2025 https://github.com/python/mypy/pull/18545#ref-commit-c30573e
https://github.com/ilevkivskyi
https://github.com/wesleywright
Fix literal context for ternary expressions (for real) (https://github.com/python/mypy/commit/c30573e7b95eef9d057ff42ebfd326438dac3c42
#18545https://github.com/python/mypy/pull/18545
)https://github.com/python/mypy/commit/c30573e7b95eef9d057ff42ebfd326438dac3c42
c30573ehttps://github.com/python/mypy/commit/c30573e7b95eef9d057ff42ebfd326438dac3c42
x612skmhttps://github.com/x612skm
Feb 24, 2025 https://github.com/python/mypy/pull/18545#ref-commit-8794cc0
https://github.com/ilevkivskyi
https://github.com/x612skm
Fix literal context for ternary expressions (for real) (https://github.com/x612skm/mypy-dev/commit/8794cc05311b3ea73175a9a8701bba16cd732a38
python#18545https://github.com/python/mypy/pull/18545
)https://github.com/x612skm/mypy-dev/commit/8794cc05311b3ea73175a9a8701bba16cd732a38
8794cc0https://github.com/x612skm/mypy-dev/commit/8794cc05311b3ea73175a9a8701bba16cd732a38
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18545
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
Please reload this pagehttps://github.com/python/mypy/pull/18545
Please reload this pagehttps://github.com/python/mypy/pull/18545
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.