René's URL Explorer Experiment


Title: Allow redefinitions in except/else/finally by sterliakov · Pull Request #18515 · python/mypy · GitHub

Open Graph Title: Allow redefinitions in except/else/finally by sterliakov · Pull Request #18515 · python/mypy

X Title: Allow redefinitions in except/else/finally by sterliakov · Pull Request #18515 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #18514. Only try clause should be treated as fallible, this should not prevent --allow-redefinition from working in other try clauses (except, else, finally).

X Description: Fixes #18514. Only try clause should be treated as fallible, this should not prevent --allow-redefinition from working in other try clauses (except, else, finally).

Opengraph URL: https://github.com/python/mypy/pull/18515

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1c10fa89-01d1-9033-d763-b304f915d72d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C80:302FC:F04A3A:141C993:6B0058AF
html-safe-nonce85d92f95cfc7e25b219228a50e563dd0aa262f16f6c3b9b9fbe958eb0143acb9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzgwOjMwMkZDOkYwNEEzQToxNDFDOTkzOjZCMDA1OEFGIiwidmlzaXRvcl9pZCI6IjQ3MTMzMjA1NjI5NDcwMjA5NzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9f2f08118ed68f821afd84c5d205e3ae668ac87e9761844d3528d7a88548a4db
hovercard-subject-tagpull_request:2294738369
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/18515/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6456e31e3731356513a8a460b1ba61f5420cf97f59da4d1adbd55cc09561d40d/python/mypy/pull/18515
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6456e31e3731356513a8a460b1ba61f5420cf97f59da4d1adbd55cc09561d40d/python/mypy/pull/18515
og:image:altFixes #18514. Only try clause should be treated as fallible, this should not prevent --allow-redefinition from working in other try clauses (except, else, finally).
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesterliakov
hostnamegithub.com
expected-hostnamegithub.com
None29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeacd927ba6112e3b01ba99c762bd699a4a4f5df7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/18515#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18515
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18515
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/18515
Reloadhttps://github.com/python/mypy/pull/18515
Reloadhttps://github.com/python/mypy/pull/18515
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
sobolevnhttps://github.com/sobolevn
python:masterhttps://github.com/python/mypy/tree/master
sterliakov:bugfix/st-allow-redefinition-try-clauseshttps://github.com/sterliakov/mypy/tree/bugfix/st-allow-redefinition-try-clauses
Conversationhttps://github.com/python/mypy/pull/18515
Commits3 (3)https://github.com/python/mypy/pull/18515/commits
Checkshttps://github.com/python/mypy/pull/18515/checks
Files changedhttps://github.com/python/mypy/pull/18515/files
Allow redefinitions in except/else/finallyhttps://github.com/python/mypy/pull/18515#top
sobolevnhttps://github.com/sobolevn
python:masterhttps://github.com/python/mypy/tree/master
sterliakov:bugfix/st-allow-redefinition-try-clauseshttps://github.com/sterliakov/mypy/tree/bugfix/st-allow-redefinition-try-clauses
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
Jan 23, 2025https://github.com/python/mypy/pull/18515#issue-2807179201
#18514https://github.com/python/mypy/issues/18514
Please reload this pagehttps://github.com/python/mypy/pull/18515
https://github.com/sterliakov
Allow renaming in except/else/finally clauseshttps://github.com/python/mypy/pull/18515/commits/6fafcdeb884e7c8103b3bac24b34f18f5c8242e9
6fafcdehttps://github.com/python/mypy/pull/18515/commits/6fafcdeb884e7c8103b3bac24b34f18f5c8242e9
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
Jan 23, 2025 https://github.com/python/mypy/pull/18515#pullrequestreview-2570173793
View reviewed changes https://github.com/python/mypy/pull/18515/files/6fafcdeb884e7c8103b3bac24b34f18f5c8242e9
test-data/unit/check-redefine.testhttps://github.com/python/mypy/pull/18515/files/6fafcdeb884e7c8103b3bac24b34f18f5c8242e9#diff-f258b3b77d5328cb1a2461e883be36ae095986f0bc4eb2d5d113daaf001cb86a
sterliakovhttps://github.com/sterliakov
Jan 23, 2025https://github.com/python/mypy/pull/18515#discussion_r1927158490
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#17384https://github.com/python/mypy/pull/17384
Please reload this pagehttps://github.com/python/mypy/pull/18515
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18515
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
January 23, 2025 15:35https://github.com/python/mypy/pull/18515#event-16045849084
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
Jan 23, 2025 https://github.com/python/mypy/pull/18515#pullrequestreview-2570594408
View reviewed changes https://github.com/python/mypy/pull/18515/files/6fafcdeb884e7c8103b3bac24b34f18f5c8242e9
test-data/unit/check-redefine.testhttps://github.com/python/mypy/pull/18515/files/6fafcdeb884e7c8103b3bac24b34f18f5c8242e9#diff-f258b3b77d5328cb1a2461e883be36ae095986f0bc4eb2d5d113daaf001cb86a
Please reload this pagehttps://github.com/python/mypy/pull/18515
https://github.com/sterliakov
Add a testcase with nested tryhttps://github.com/python/mypy/pull/18515/commits/a0ad1b9acfd09b0b8b8e51b0302a4142760a8401
a0ad1b9https://github.com/python/mypy/pull/18515/commits/a0ad1b9acfd09b0b8b8e51b0302a4142760a8401
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18515
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Jan 24, 2025 https://github.com/python/mypy/pull/18515#pullrequestreview-2572392783
View reviewed changes https://github.com/python/mypy/pull/18515/files/a0ad1b9acfd09b0b8b8e51b0302a4142760a8401
test-data/unit/check-redefine.testhttps://github.com/python/mypy/pull/18515/files/a0ad1b9acfd09b0b8b8e51b0302a4142760a8401#diff-f258b3b77d5328cb1a2461e883be36ae095986f0bc4eb2d5d113daaf001cb86a
sobolevnhttps://github.com/sobolevn
Jan 24, 2025https://github.com/python/mypy/pull/18515#discussion_r1928537060
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/18515
https://github.com/sterliakov
Add similar test with except*https://github.com/python/mypy/pull/18515/commits/00e226101589e47d368edc8b1e78741975baa749
00e2261https://github.com/python/mypy/pull/18515/commits/00e226101589e47d368edc8b1e78741975baa749
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jan 24, 2025https://github.com/python/mypy/pull/18515#issuecomment-2613073903
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/18515
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Jan 24, 2025 https://github.com/python/mypy/pull/18515#pullrequestreview-2573336176
View reviewed changes https://github.com/python/mypy/pull/18515/files/00e226101589e47d368edc8b1e78741975baa749
https://github.com/A5rocks
A5rockshttps://github.com/A5rocks
Jan 26, 2025 https://github.com/python/mypy/pull/18515#pullrequestreview-2574406399
View reviewed changes https://github.com/python/mypy/pull/18515/files/00e226101589e47d368edc8b1e78741975baa749
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
0451880https://github.com/python/mypy/commit/0451880759d926bc918eca02d0cfbc6233b0f120
Jan 26, 2025https://github.com/python/mypy/pull/18515#event-16071234007
x612skmhttps://github.com/x612skm
Feb 24, 2025 https://github.com/python/mypy/pull/18515#ref-commit-d1bd8e4
https://github.com/sterliakov
https://github.com/x612skm
Allow redefinitions in except/else/finally (https://github.com/x612skm/mypy-dev/commit/d1bd8e41a8a43d2fe60d3c5f777d8e56dd4d9819
python#18515https://github.com/python/mypy/pull/18515
)https://github.com/x612skm/mypy-dev/commit/d1bd8e41a8a43d2fe60d3c5f777d8e56dd4d9819
d1bd8e4https://github.com/x612skm/mypy-dev/commit/d1bd8e41a8a43d2fe60d3c5f777d8e56dd4d9819
python#18514https://github.com/python/mypy/issues/18514
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18515
https://github.com/sobolevn
sobolevn https://github.com/sobolevn
https://github.com/python/mypy/pull/18515/files/00e226101589e47d368edc8b1e78741975baa749
https://github.com/A5rocks
A5rocks https://github.com/A5rocks
https://github.com/python/mypy/pull/18515/files/00e226101589e47d368edc8b1e78741975baa749
Please reload this pagehttps://github.com/python/mypy/pull/18515
Redefinition doesn't work in else branch of try https://github.com/python/mypy/issues/18514
Please reload this pagehttps://github.com/python/mypy/pull/18515
https://github.com/sterliakov
https://github.com/sobolevn
https://github.com/A5rocks
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.