René's URL Explorer Experiment


Title: Fix parent generics mapping when overriding generic attribute with property by sterliakov · Pull Request #18441 · python/mypy · GitHub

Open Graph Title: Fix parent generics mapping when overriding generic attribute with property by sterliakov · Pull Request #18441 · python/mypy

X Title: Fix parent generics mapping when overriding generic attribute with property by sterliakov · Pull Request #18441 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #18189. Following #18415, this fixes one more place where parent class generics aren't mapped to attributes correctly.

X Description: Fixes #18189. Following #18415, this fixes one more place where parent class generics aren't mapped to attributes correctly.

Opengraph URL: https://github.com/python/mypy/pull/18441

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a8de0396-57c0-1e16-d34c-d9776c476643
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA7D2:396A8E:1F57BA4:29A408F:6B004B3D
html-safe-nonce02ea8aa03517d209903511663090fa8b8586c8cab7ef4a34109a793c5b1f5566
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0QyOjM5NkE4RToxRjU3QkE0OjI5QTQwOEY6NkIwMDRCM0QiLCJ2aXNpdG9yX2lkIjoiNTU3NDMzNTk0MjQyNjExODk3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccab51f2db28baff6d50162e55dbfe01064eeb685c2a5bfc7dc249496b5ac4394
hovercard-subject-tagpull_request:2271418686
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/18441/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/09b81b5ba03396b1ef9ca76ff6fed778388a03b64d990a68bbcc19a3eac3b9d5/python/mypy/pull/18441
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/09b81b5ba03396b1ef9ca76ff6fed778388a03b64d990a68bbcc19a3eac3b9d5/python/mypy/pull/18441
og:image:altFixes #18189. Following #18415, this fixes one more place where parent class generics aren't mapped to attributes correctly.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesterliakov
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/mypy/pull/18441#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18441
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18441
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/18441
Reloadhttps://github.com/python/mypy/pull/18441
Reloadhttps://github.com/python/mypy/pull/18441
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
sterliakov:bugfix/st-override-with-property-typevarhttps://github.com/sterliakov/mypy/tree/bugfix/st-override-with-property-typevar
Conversationhttps://github.com/python/mypy/pull/18441
Commits4 (4)https://github.com/python/mypy/pull/18441/commits
Checkshttps://github.com/python/mypy/pull/18441/checks
Files changedhttps://github.com/python/mypy/pull/18441/files
Fix parent generics mapping when overriding generic attribute with propertyhttps://github.com/python/mypy/pull/18441#top
ilevkivskyihttps://github.com/ilevkivskyi
python:masterhttps://github.com/python/mypy/tree/master
sterliakov:bugfix/st-override-with-property-typevarhttps://github.com/sterliakov/mypy/tree/bugfix/st-override-with-property-typevar
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
Jan 10, 2025https://github.com/python/mypy/pull/18441#issue-2781195285
#18189https://github.com/python/mypy/issues/18189
#18415https://github.com/python/mypy/pull/18415
Please reload this pagehttps://github.com/python/mypy/pull/18441
sterliakovhttps://github.com/sterliakov
January 10, 2025 22:06https://github.com/python/mypy/pull/18441#commits-pushed-97684e2
https://github.com/sterliakov
Add missing map_type_from_supertype when checking attr override wit…https://github.com/python/mypy/pull/18441/commits/97684e234fb62f5de36d66473564fb9e92054e83
97684e2https://github.com/python/mypy/pull/18441/commits/97684e234fb62f5de36d66473564fb9e92054e83
https://github.com/sterliakov
Add explicit testcase with Self in parenthttps://github.com/python/mypy/pull/18441/commits/66a51488adfd96d8bd30bd3d48d7e5b16ea3140b
66a5148https://github.com/python/mypy/pull/18441/commits/66a51488adfd96d8bd30bd3d48d7e5b16ea3140b
https://github.com/sterliakov
And property/property override with typevarhttps://github.com/python/mypy/pull/18441/commits/e77b8a54b069347bac462d110582f2b2241487d1
e77b8a5https://github.com/python/mypy/pull/18441/commits/e77b8a54b069347bac462d110582f2b2241487d1
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18441
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Jan 11, 2025 https://github.com/python/mypy/pull/18441#pullrequestreview-2545129851
View reviewed changes https://github.com/python/mypy/pull/18441/files/e77b8a54b069347bac462d110582f2b2241487d1
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Jan 11, 2025https://github.com/python/mypy/pull/18441#issuecomment-2585371347
Please reload this pagehttps://github.com/python/mypy/pull/18441
https://github.com/hauntsaninja
Merge branch 'master' into bugfix/st-override-with-property-typevarhttps://github.com/python/mypy/pull/18441/commits/4081fd903423c5b3cea845a52a88ff3c3c74a84d
4081fd9https://github.com/python/mypy/pull/18441/commits/4081fd903423c5b3cea845a52a88ff3c3c74a84d
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
upnext https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Aupnext
Jan 11, 2025https://github.com/python/mypy/pull/18441#event-15893519326
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jan 11, 2025https://github.com/python/mypy/pull/18441#issuecomment-2585396509
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/18441
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
9274a07https://github.com/python/mypy/commit/9274a07bfa3c92b38fe35cf9736beb068ae9196b
Jan 11, 2025https://github.com/python/mypy/pull/18441#event-15893694153
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18441
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/18441/files/e77b8a54b069347bac462d110582f2b2241487d1
Please reload this pagehttps://github.com/python/mypy/pull/18441
upnext https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Aupnext
Mypy disallows overriding a generic type attribute with a property https://github.com/python/mypy/issues/18189
Please reload this pagehttps://github.com/python/mypy/pull/18441
https://github.com/sterliakov
https://github.com/ilevkivskyi
https://github.com/hauntsaninja
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.