René's URL Explorer Experiment


Title: Fix nondeterministic type checking by making join with explicit Protocol and type promotion commute by hauntsaninja · Pull Request #18402 · python/mypy · GitHub

Open Graph Title: Fix nondeterministic type checking by making join with explicit Protocol and type promotion commute by hauntsaninja · Pull Request #18402 · python/mypy

X Title: Fix nondeterministic type checking by making join with explicit Protocol and type promotion commute by hauntsaninja · Pull Request #18402 · python/mypy

Description: Fixes #16979 (bzoracler case only, OP case fixed by #19147) See #16979 (comment)

Open Graph Description: Fixes #16979 (bzoracler case only, OP case fixed by #19147) See #16979 (comment)

X Description: Fixes #16979 (bzoracler case only, OP case fixed by #19147) See #16979 (comment)

Opengraph URL: https://github.com/python/mypy/pull/18402

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a76d599e-1f9f-3f2e-5c49-e49393bffa2b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCDC0:296588:49CECEE:660373D:6A5E285D
html-safe-nonce93ccf864e8f49793979f3b987cdcdf899ca7dcf249300e0a6491ebfb2eb44a79
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDREMwOjI5NjU4ODo0OUNFQ0VFOjY2MDM3M0Q6NkE1RTI4NUQiLCJ2aXNpdG9yX2lkIjoiNzk3NjQ1OTM0ODM0ODg2NzQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca2ec92dc38c87a30046c0c5df33a4d2f5ea0bd72e987cf43e4de447945eebb92
hovercard-subject-tagpull_request:2256960603
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/mypy/pull/18402/files
twitter:imagehttps://avatars.githubusercontent.com/u/12621235?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/12621235?s=400&v=4
og:image:altFixes #16979 (bzoracler case only, OP case fixed by #19147) See #16979 (comment)
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None493aee765c916e8e7acfb36b1e942dfd7746b31d84f7a04091db518541441852
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release14f1e1fce2dc2d662cbf7ef602c59756c2283f9e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/mypy/pull/18402/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18402%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18402%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/18402/files
Reloadhttps://github.com/python/mypy/pull/18402/files
Reloadhttps://github.com/python/mypy/pull/18402/files
Please reload this pagehttps://github.com/python/mypy/pull/18402/files
python https://github.com/python
mypyhttps://github.com/python/mypy
Please reload this pagehttps://github.com/python/mypy/pull/18402/files
Notifications https://github.com/login?return_to=%2Fpython%2Fmypy
Fork 3.3k https://github.com/login?return_to=%2Fpython%2Fmypy
Star 20.5k https://github.com/login?return_to=%2Fpython%2Fmypy
Code https://github.com/python/mypy
Issues 2.7k https://github.com/python/mypy/issues
Pull requests 472 https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality 0 https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
Code https://github.com/python/mypy
Issues https://github.com/python/mypy/issues
Pull requests https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fmypy%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fmypy%2Fissues%2Fnew%2Fchoose
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:nondethttps://github.com/hauntsaninja/mypy/tree/nondet
Conversation 9 https://github.com/python/mypy/pull/18402
Commits 8 https://github.com/python/mypy/pull/18402/commits
Checks 0 https://github.com/python/mypy/pull/18402/checks
Files changed https://github.com/python/mypy/pull/18402/files
Please reload this pagehttps://github.com/python/mypy/pull/18402/files
Fix nondeterministic type checking by making join with explicit Protocol and type promotion commute https://github.com/python/mypy/pull/18402/files#top
Show all changes 8 commits https://github.com/python/mypy/pull/18402/files
77679f8 Fix nondeterministic type checking involving noncommutative join hauntsaninja Jan 1, 2025 https://github.com/python/mypy/pull/18402/commits/77679f8cd31d79a08244ece52b72133460aec247
4cc6db9 Merge branch 'master' into nondet hauntsaninja May 25, 2025 https://github.com/python/mypy/pull/18402/commits/4cc6db9a0b920d2bfd31e08eb752aa322e0b4770
3ef78e8 fix hauntsaninja May 25, 2025 https://github.com/python/mypy/pull/18402/commits/3ef78e88b98263d2e2ac31ade358d7986b067ad7
0b18c18 efficiency hauntsaninja May 25, 2025 https://github.com/python/mypy/pull/18402/commits/0b18c18416a345d5fd473d0a05c1d8704a110318
69c1a65 fix false positive hauntsaninja May 25, 2025 https://github.com/python/mypy/pull/18402/commits/69c1a654ef8179b13b6536f22577b94d029e6de5
34e0a0c fix test hauntsaninja May 25, 2025 https://github.com/python/mypy/pull/18402/commits/34e0a0c71e2b709b85314e0b4cadf270845e5dae
c120f88 Merge branch 'master' into nondet hauntsaninja Jun 1, 2025 https://github.com/python/mypy/pull/18402/commits/c120f8807b34d5a13f9d7592600d38177c5ff1f5
4149882 test hauntsaninja Jun 1, 2025 https://github.com/python/mypy/pull/18402/commits/4149882cfb530129d2cae3c47714ad0bc7cb41a5
Clear filters https://github.com/python/mypy/pull/18402/files
Please reload this pagehttps://github.com/python/mypy/pull/18402/files
Please reload this pagehttps://github.com/python/mypy/pull/18402/files
join.py https://github.com/python/mypy/pull/18402/files#diff-dc731faa017a06257ba26e3eacaf17e68a6078aeaf9755d1c06d917fe13ce457
check-inference.test https://github.com/python/mypy/pull/18402/files#diff-c3eb296f041ab0dfaba0e8ea5cf200d63c2de36b8b57da835294af221ff0de5a
check-protocols.test https://github.com/python/mypy/pull/18402/files#diff-9197c899266eb7fc4382f2c2852c3f77ca6df8ec4bec97d985ab2f8c59aedaa2
mypy/join.pyhttps://github.com/python/mypy/pull/18402/files#diff-dc731faa017a06257ba26e3eacaf17e68a6078aeaf9755d1c06d917fe13ce457
View file https://github.com/hauntsaninja/mypy/blob/4149882cfb530129d2cae3c47714ad0bc7cb41a5/mypy/join.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/18402/{{ revealButtonHref }}
https://github.com/python/mypy/pull/18402/files#diff-dc731faa017a06257ba26e3eacaf17e68a6078aeaf9755d1c06d917fe13ce457
https://github.com/python/mypy/pull/18402/files#diff-dc731faa017a06257ba26e3eacaf17e68a6078aeaf9755d1c06d917fe13ce457
https://github.com/python/mypy/pull/18402/files#diff-dc731faa017a06257ba26e3eacaf17e68a6078aeaf9755d1c06d917fe13ce457
https://github.com/python/mypy/pull/18402/files#diff-dc731faa017a06257ba26e3eacaf17e68a6078aeaf9755d1c06d917fe13ce457
https://github.com/python/mypy/pull/18402/files#diff-dc731faa017a06257ba26e3eacaf17e68a6078aeaf9755d1c06d917fe13ce457
https://github.com/python/mypy/pull/18402/files#diff-dc731faa017a06257ba26e3eacaf17e68a6078aeaf9755d1c06d917fe13ce457
test-data/unit/check-inference.testhttps://github.com/python/mypy/pull/18402/files#diff-c3eb296f041ab0dfaba0e8ea5cf200d63c2de36b8b57da835294af221ff0de5a
View file https://github.com/hauntsaninja/mypy/blob/4149882cfb530129d2cae3c47714ad0bc7cb41a5/test-data/unit/check-inference.test
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/18402/{{ revealButtonHref }}
https://github.com/python/mypy/pull/18402/files#diff-c3eb296f041ab0dfaba0e8ea5cf200d63c2de36b8b57da835294af221ff0de5a
Please reload this pagehttps://github.com/python/mypy/pull/18402/files
Please reload this pagehttps://github.com/python/mypy/pull/18402/files
https://github.com/python/mypy/pull/18402/files#diff-c3eb296f041ab0dfaba0e8ea5cf200d63c2de36b8b57da835294af221ff0de5a
test-data/unit/check-protocols.testhttps://github.com/python/mypy/pull/18402/files#diff-9197c899266eb7fc4382f2c2852c3f77ca6df8ec4bec97d985ab2f8c59aedaa2
View file https://github.com/hauntsaninja/mypy/blob/4149882cfb530129d2cae3c47714ad0bc7cb41a5/test-data/unit/check-protocols.test
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/mypy/pull/18402/{{ revealButtonHref }}
https://github.com/python/mypy/pull/18402/files#diff-9197c899266eb7fc4382f2c2852c3f77ca6df8ec4bec97d985ab2f8c59aedaa2
Please reload this pagehttps://github.com/python/mypy/pull/18402/files
https://github.com/python/mypy/pull/18402/files#diff-9197c899266eb7fc4382f2c2852c3f77ca6df8ec4bec97d985ab2f8c59aedaa2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.