René's URL Explorer Experiment


Title: Fix nondeterministic type checking by making join with explicit Protocol and type promotion commute by hauntsaninja · Pull Request #18402 · python/mypy · GitHub

Open Graph Title: Fix nondeterministic type checking by making join with explicit Protocol and type promotion commute by hauntsaninja · Pull Request #18402 · python/mypy

X Title: Fix nondeterministic type checking by making join with explicit Protocol and type promotion commute by hauntsaninja · Pull Request #18402 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #16979 (bzoracler case only, OP case fixed by #19147) See #16979 (comment)

X Description: Fixes #16979 (bzoracler case only, OP case fixed by #19147) See #16979 (comment)

Opengraph URL: https://github.com/python/mypy/pull/18402

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:31d7f0db-d52c-a34a-925d-1dae57d3f1c4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDFB2:260014:2C5E02F:3A8D824:6A5CE8E2
html-safe-nonce89128e59a0ab3ed509de27a588a012bffd6cb3ecabc672ad15a4b1b48a528a80
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkIyOjI2MDAxNDoyQzVFMDJGOjNBOEQ4MjQ6NkE1Q0U4RTIiLCJ2aXNpdG9yX2lkIjoiNjUyMjI2ODIwNDU3Njg3MjY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1788fcb9bcf1c40e821483026ebe5efc4782e159ee879d36da9db9f0e6626c66
hovercard-subject-tagpull_request:2256960603
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/18402/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bef598be04e5f1885b06ebc6b1aa14eaf12d5b5d3172caf00138f0587dd0585f/python/mypy/pull/18402
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bef598be04e5f1885b06ebc6b1aa14eaf12d5b5d3172caf00138f0587dd0585f/python/mypy/pull/18402
og:image:altFixes #16979 (bzoracler case only, OP case fixed by #19147) See #16979 (comment)
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehauntsaninja
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/mypy/pull/18402#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18402
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18402
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/18402
Reloadhttps://github.com/python/mypy/pull/18402
Reloadhttps://github.com/python/mypy/pull/18402
Please reload this pagehttps://github.com/python/mypy/pull/18402
python https://github.com/python
mypyhttps://github.com/python/mypy
Please reload this pagehttps://github.com/python/mypy/pull/18402
Notifications https://github.com/login?return_to=%2Fpython%2Fmypy
Fork 3.2k https://github.com/login?return_to=%2Fpython%2Fmypy
Star 20.5k https://github.com/login?return_to=%2Fpython%2Fmypy
Code https://github.com/python/mypy
Issues 2.7k https://github.com/python/mypy/issues
Pull requests 471 https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality 0 https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
Code https://github.com/python/mypy
Issues https://github.com/python/mypy/issues
Pull requests https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:nondethttps://github.com/hauntsaninja/mypy/tree/nondet
Conversationhttps://github.com/python/mypy/pull/18402
Commits8 (8)https://github.com/python/mypy/pull/18402/commits
Checkshttps://github.com/python/mypy/pull/18402/checks
Files changedhttps://github.com/python/mypy/pull/18402/files
Fix nondeterministic type checking by making join with explicit Protocol and type promotion commutehttps://github.com/python/mypy/pull/18402#top
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/mypy/tree/master
hauntsaninja:nondethttps://github.com/hauntsaninja/mypy/tree/nondet
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Jan 1, 2025https://github.com/python/mypy/pull/18402#issue-2764962233
Please reload this pagehttps://github.com/python/mypy/pull/18402
#16979https://github.com/python/mypy/issues/16979
#19147https://github.com/python/mypy/pull/19147
#16979 (comment)https://github.com/python/mypy/issues/16979#issuecomment-1982283536
Please reload this pagehttps://github.com/python/mypy/pull/18402
https://github.com/hauntsaninja
Fix nondeterministic type checking involving noncommutative joinhttps://github.com/python/mypy/pull/18402/commits/77679f8cd31d79a08244ece52b72133460aec247
77679f8https://github.com/python/mypy/pull/18402/commits/77679f8cd31d79a08244ece52b72133460aec247
python#16979 (comment)https://github.com/python/mypy/issues/16979#issuecomment-1982283536
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
January 1, 2025 22:01https://github.com/python/mypy/pull/18402#event-15794676117
hauntsaninjahttps://github.com/hauntsaninja
May 25, 2025 14:26https://github.com/python/mypy/pull/18402#commits-pushed-4cc6db9
https://github.com/hauntsaninja
Merge branch 'master' into nondethttps://github.com/python/mypy/pull/18402/commits/4cc6db9a0b920d2bfd31e08eb752aa322e0b4770
4cc6db9https://github.com/python/mypy/pull/18402/commits/4cc6db9a0b920d2bfd31e08eb752aa322e0b4770
https://github.com/hauntsaninja
fixhttps://github.com/python/mypy/pull/18402/commits/3ef78e88b98263d2e2ac31ade358d7986b067ad7
3ef78e8https://github.com/python/mypy/pull/18402/commits/3ef78e88b98263d2e2ac31ade358d7986b067ad7
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
May 25, 2025 22:51https://github.com/python/mypy/pull/18402#event-17805760427
https://github.com/hauntsaninja
efficiencyhttps://github.com/python/mypy/pull/18402/commits/0b18c18416a345d5fd473d0a05c1d8704a110318
0b18c18https://github.com/python/mypy/pull/18402/commits/0b18c18416a345d5fd473d0a05c1d8704a110318
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18402
https://github.com/hauntsaninja
fix false positivehttps://github.com/python/mypy/pull/18402/commits/69c1a654ef8179b13b6536f22577b94d029e6de5
69c1a65https://github.com/python/mypy/pull/18402/commits/69c1a654ef8179b13b6536f22577b94d029e6de5
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
May 25, 2025https://github.com/python/mypy/pull/18402#issuecomment-2908169072
Please reload this pagehttps://github.com/python/mypy/pull/18402
https://github.com/hauntsaninja
fix testhttps://github.com/python/mypy/pull/18402/commits/34e0a0c71e2b709b85314e0b4cadf270845e5dae
34e0a0chttps://github.com/python/mypy/pull/18402/commits/34e0a0c71e2b709b85314e0b4cadf270845e5dae
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18402
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
May 26, 2025https://github.com/python/mypy/pull/18402#event-17806784094
Fix nondeterministic type checking caused by nonassociativity of joins #19147 https://github.com/python/mypy/pull/19147
MyPy is nondeterministic across runs #16979 https://github.com/python/mypy/issues/16979
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
May 27, 2025https://github.com/python/mypy/pull/18402#issuecomment-2913498508
@JukkaLhttps://github.com/JukkaL
Please reload this pagehttps://github.com/python/mypy/pull/18402
hauntsaninjahttps://github.com/hauntsaninja
May 28, 2025 https://github.com/python/mypy/pull/18402#ref-commit-f328ad6
https://github.com/hauntsaninja
Fix nondeterministic type checking caused by nonassociativity of joins (https://github.com/python/mypy/commit/f328ad6ab81fba3c8470e98f8e6795813a89f810
f328ad6https://github.com/python/mypy/commit/f328ad6ab81fba3c8470e98f8e6795813a89f810
#19147https://github.com/python/mypy/pull/19147
#19121https://github.com/python/mypy/issues/19121
#16979https://github.com/python/mypy/issues/16979
#18402https://github.com/python/mypy/pull/18402
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
May 28, 2025 https://github.com/python/mypy/pull/18402#pullrequestreview-2874370894
View reviewed changes https://github.com/python/mypy/pull/18402/files/34e0a0c71e2b709b85314e0b4cadf270845e5dae
JukkaLhttps://github.com/JukkaL
https://github.com/python/mypy/pull/18402#pullrequestreview-2874370894
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/18402
test-data/unit/check-inference.testhttps://github.com/python/mypy/pull/18402/files/34e0a0c71e2b709b85314e0b4cadf270845e5dae#diff-c3eb296f041ab0dfaba0e8ea5cf200d63c2de36b8b57da835294af221ff0de5a
Please reload this pagehttps://github.com/python/mypy/pull/18402
test-data/unit/check-inference.testhttps://github.com/python/mypy/pull/18402/files/34e0a0c71e2b709b85314e0b4cadf270845e5dae#diff-c3eb296f041ab0dfaba0e8ea5cf200d63c2de36b8b57da835294af221ff0de5a
Please reload this pagehttps://github.com/python/mypy/pull/18402
test-data/unit/check-protocols.testhttps://github.com/python/mypy/pull/18402/files/34e0a0c71e2b709b85314e0b4cadf270845e5dae#diff-9197c899266eb7fc4382f2c2852c3f77ca6df8ec4bec97d985ab2f8c59aedaa2
Please reload this pagehttps://github.com/python/mypy/pull/18402
hauntsaninjahttps://github.com/hauntsaninja
May 31, 2025 17:30https://github.com/python/mypy/pull/18402#commits-pushed-c120f88
https://github.com/hauntsaninja
Merge branch 'master' into nondethttps://github.com/python/mypy/pull/18402/commits/c120f8807b34d5a13f9d7592600d38177c5ff1f5
c120f88https://github.com/python/mypy/pull/18402/commits/c120f8807b34d5a13f9d7592600d38177c5ff1f5
https://github.com/hauntsaninja
testhttps://github.com/python/mypy/pull/18402/commits/4149882cfb530129d2cae3c47714ad0bc7cb41a5
4149882https://github.com/python/mypy/pull/18402/commits/4149882cfb530129d2cae3c47714ad0bc7cb41a5
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 1, 2025https://github.com/python/mypy/pull/18402#issuecomment-2926214758
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/18402
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
0ea8488https://github.com/python/mypy/commit/0ea84886e5a6decdb46b5bae93c4452a0a6ca6bb
Jun 1, 2025https://github.com/python/mypy/pull/18402#event-17907649282
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
June 1, 2025 01:08https://github.com/python/mypy/pull/18402#event-17907649414
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18402
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
https://github.com/python/mypy/pull/18402/files/34e0a0c71e2b709b85314e0b4cadf270845e5dae
MyPy is nondeterministic across runs https://github.com/python/mypy/issues/16979
Please reload this pagehttps://github.com/python/mypy/pull/18402
https://github.com/hauntsaninja
https://github.com/JukkaL
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.