René's URL Explorer Experiment


Title: Move the join-based narrowing logic towards a union-based narrowing logic. by tyralla · Pull Request #18212 · python/mypy · GitHub

Open Graph Title: Move the join-based narrowing logic towards a union-based narrowing logic. by tyralla · Pull Request #18212 · python/mypy

X Title: Move the join-based narrowing logic towards a union-based narrowing logic. by tyralla · Pull Request #18212 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Fixes #16379 Only a modest change. PR #18180 brought me to issue #18238. Trying to fix the latter revealed inconsistencies between join-style and union-style narrowing, so I decided to deal with ...

X Description: Fixes #16379 Only a modest change. PR #18180 brought me to issue #18238. Trying to fix the latter revealed inconsistencies between join-style and union-style narrowing, so I decided to deal with ...

Opengraph URL: https://github.com/python/mypy/pull/18212

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7118ee5d-7f4d-f166-b6e6-23733c748789
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBAD0:3F6E8D:DDDF4C:127BA89:6A5CF692
html-safe-nonce70001c356e03f3f37843ef17f573b5d446d8e0bdbdf31f53f97c7c64fa241e0f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUQwOjNGNkU4RDpERERGNEM6MTI3QkE4OTo2QTVDRjY5MiIsInZpc2l0b3JfaWQiOiIyODYxNDkzNTYwMTI1NzQ4ODgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac49db2d6bd422dc5b0aef075f80d5c549fc060bfe8bb81f9007d8a57c89bf9a44
hovercard-subject-tagpull_request:2207695532
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/mypy/18212/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f8520c7c9063327eb71c6d132de37a6edcb06b307f962656ddffdeea0c6b9f26/python/mypy/pull/18212
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f8520c7c9063327eb71c6d132de37a6edcb06b307f962656ddffdeea0c6b9f26/python/mypy/pull/18212
og:image:altFixes #16379 Only a modest change. PR #18180 brought me to issue #18238. Trying to fix the latter revealed inconsistencies between join-style and union-style narrowing, so I decided to deal with ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametyralla
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/mypy/pull/18212#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18212
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18212
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/pull/18212
Reloadhttps://github.com/python/mypy/pull/18212
Reloadhttps://github.com/python/mypy/pull/18212
Please reload this pagehttps://github.com/python/mypy/pull/18212
python https://github.com/python
mypyhttps://github.com/python/mypy
Please reload this pagehttps://github.com/python/mypy/pull/18212
Notifications https://github.com/login?return_to=%2Fpython%2Fmypy
Fork 3.2k https://github.com/login?return_to=%2Fpython%2Fmypy
Star 20.5k https://github.com/login?return_to=%2Fpython%2Fmypy
Code https://github.com/python/mypy
Issues 2.7k https://github.com/python/mypy/issues
Pull requests 471 https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality 0 https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
Code https://github.com/python/mypy
Issues https://github.com/python/mypy/issues
Pull requests https://github.com/python/mypy/pulls
Actions https://github.com/python/mypy/actions
Projects https://github.com/python/mypy/projects
Wiki https://github.com/python/mypy/wiki
Security and quality https://github.com/python/mypy/security
Insights https://github.com/python/mypy/pulse
tyrallahttps://github.com/tyralla
python:masterhttps://github.com/python/mypy/tree/master
tyralla:narrowing/move_join_based_narrowing_towards_union_based_narrowinghttps://github.com/tyralla/mypy/tree/narrowing/move_join_based_narrowing_towards_union_based_narrowing
Conversationhttps://github.com/python/mypy/pull/18212
Commits9 (9)https://github.com/python/mypy/pull/18212/commits
Checkshttps://github.com/python/mypy/pull/18212/checks
Files changedhttps://github.com/python/mypy/pull/18212/files
Move the join-based narrowing logic towards a union-based narrowing logic.https://github.com/python/mypy/pull/18212#top
tyrallahttps://github.com/tyralla
python:masterhttps://github.com/python/mypy/tree/master
tyralla:narrowing/move_join_based_narrowing_towards_union_based_narrowinghttps://github.com/tyralla/mypy/tree/narrowing/move_join_based_narrowing_towards_union_based_narrowing
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Nov 29, 2024https://github.com/python/mypy/pull/18212#issue-2705609353
Please reload this pagehttps://github.com/python/mypy/pull/18212
#16379https://github.com/python/mypy/issues/16379
#18180https://github.com/python/mypy/pull/18180
#18238https://github.com/python/mypy/issues/18238
Please reload this pagehttps://github.com/python/mypy/pull/18212
tyrallahttps://github.com/tyralla
November 29, 2024 17:41https://github.com/python/mypy/pull/18212#commits-pushed-5891413
https://github.com/tyralla
Move the join-based narrowing logic towards a union-based narrowing l…https://github.com/python/mypy/pull/18212/commits/5891413accb0b14c8209c3fe17ddaf492d945e3f
5891413https://github.com/python/mypy/pull/18212/commits/5891413accb0b14c8209c3fe17ddaf492d945e3f
https://github.com/marketplace/pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hookshttps://github.com/python/mypy/pull/18212/commits/0e9f99fdd0236f0001a8a4b45c9c0aceb4cd7954
0e9f99fhttps://github.com/python/mypy/pull/18212/commits/0e9f99fdd0236f0001a8a4b45c9c0aceb4cd7954
https://pre-commit.cihttps://pre-commit.ci
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Nov 29, 2024https://github.com/python/mypy/pull/18212#issuecomment-2508140294
Please reload this pagehttps://github.com/python/mypy/pull/18212
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18212
tyrallahttps://github.com/tyralla
December 1, 2024 11:24https://github.com/python/mypy/pull/18212#commits-pushed-d70a727
https://github.com/tyralla
much softer approachhttps://github.com/python/mypy/pull/18212/commits/d70a727203d7e509f5e194a362cbaf867d7df21f
d70a727https://github.com/python/mypy/pull/18212/commits/d70a727203d7e509f5e194a362cbaf867d7df21f
https://github.com/tyralla
Merge remote-tracking branch 'mypypy/narrowing/move_join_based_narrow…https://github.com/python/mypy/pull/18212/commits/c418ad38934aef0247ba78ca2a065f05a6feef34
c418ad3https://github.com/python/mypy/pull/18212/commits/c418ad38934aef0247ba78ca2a065f05a6feef34
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18212
https://github.com/tyralla
fixhttps://github.com/python/mypy/pull/18212/commits/bf8e8b1056e2b2b3f2cbf1309ad88ffd9624a35a
bf8e8b1https://github.com/python/mypy/pull/18212/commits/bf8e8b1056e2b2b3f2cbf1309ad88ffd9624a35a
https://github.com/tyralla
tyrallahttps://github.com/tyralla
December 1, 2024 11:54https://github.com/python/mypy/pull/18212#event-15484149036
https://github.com/tyralla
tyrallahttps://github.com/tyralla
topic-type-narrowing https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Atopic-type-narrowing
topic-join-v-union https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Atopic-join-v-union
Dec 1, 2024https://github.com/python/mypy/pull/18212#event-15484150048
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18212
tyrallahttps://github.com/tyralla
December 2, 2024 06:17https://github.com/python/mypy/pull/18212#commits-pushed-31a0401
https://github.com/tyralla
module importhttps://github.com/python/mypy/pull/18212/commits/31a04014fac592ad0056a74d9d04c74c9642ab9c
31a0401https://github.com/python/mypy/pull/18212/commits/31a04014fac592ad0056a74d9d04c74c9642ab9c
https://github.com/tyralla
add error message to asserthttps://github.com/python/mypy/pull/18212/commits/121d8e1e64676f1606e3f0f94273221d205dd61d
121d8e1https://github.com/python/mypy/pull/18212/commits/121d8e1e64676f1606e3f0f94273221d205dd61d
https://github.com/apps/github-actions
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18212
tyrallahttps://github.com/tyralla
December 2, 2024 22:30https://github.com/python/mypy/pull/18212#commits-pushed-2c1b1a1
https://github.com/tyralla
TupleType fallbacks as Instances, not Unionshttps://github.com/python/mypy/pull/18212/commits/2c1b1a10b0107b4ab2f566b0cfd0e91e148932d2
2c1b1a1https://github.com/python/mypy/pull/18212/commits/2c1b1a10b0107b4ab2f566b0cfd0e91e148932d2
https://github.com/tyralla
Add test case that would crash without the previous commithttps://github.com/python/mypy/pull/18212/commits/43ed94e692eb56bec169f0cec75e13b5fce466c8
43ed94ehttps://github.com/python/mypy/pull/18212/commits/43ed94e692eb56bec169f0cec75e13b5fce466c8
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Dec 2, 2024https://github.com/python/mypy/pull/18212#issuecomment-2513036530
mypy_primerhttps://github.com/hauntsaninja/mypy_primer
Please reload this pagehttps://github.com/python/mypy/pull/18212
https://github.com/tyralla
tyrallahttps://github.com/tyralla
JukkaLhttps://github.com/JukkaL
ilevkivskyihttps://github.com/ilevkivskyi
December 3, 2024 21:38https://github.com/python/mypy/pull/18212#event-15516375200
https://github.com/tyralla
tyrallahttps://github.com/tyralla
December 3, 2024 21:39https://github.com/python/mypy/pull/18212#event-15516387788
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Dec 3, 2024 https://github.com/python/mypy/pull/18212#pullrequestreview-2476985756
View reviewed changes https://github.com/python/mypy/pull/18212/files/43ed94e692eb56bec169f0cec75e13b5fce466c8
ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/python/mypy/pull/18212#pullrequestreview-2476985756
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/mypy/pull/18212
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Dec 4, 2024https://github.com/python/mypy/pull/18212#issuecomment-2515834688
Please reload this pagehttps://github.com/python/mypy/pull/18212
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Dec 4, 2024https://github.com/python/mypy/pull/18212#issuecomment-2518227692
Please reload this pagehttps://github.com/python/mypy/pull/18212
https://github.com/tyralla
tyrallahttps://github.com/tyralla
Dec 4, 2024https://github.com/python/mypy/pull/18212#event-15530843700
https://github.co/hiddenchars
https://github.com/python/mypy/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fpull%2F18212
https://github.com/ilevkivskyi
ilevkivskyi https://github.com/ilevkivskyi
https://github.com/python/mypy/pull/18212/files/43ed94e692eb56bec169f0cec75e13b5fce466c8
https://github.com/JukkaL
JukkaL https://github.com/JukkaL
topic-join-v-union https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Atopic-join-v-union
topic-type-narrowing https://github.com/python/mypy/issues?q=state%3Aopen%20label%3Atopic-type-narrowing
Incorrect type narrowing for select class hierarchies https://github.com/python/mypy/issues/16379
Please reload this pagehttps://github.com/python/mypy/pull/18212
https://github.com/tyralla
https://github.com/ilevkivskyi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.